)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"8c0d21a3645324b1eeb83b9f26850723e511cc06","unresolved":true,"context_lines":[{"line_number":15,"context_line":"vif_detach in the ConductorManager to ensure that any"},{"line_number":16,"context_line":"exceptions are captured and recorded as NodeHistory events"},{"line_number":17,"context_line":"before being raised."},{"line_number":18,"context_line":"Closes-Bug: #2131973"},{"line_number":19,"context_line":"Change-Id: I8d82bcda7b58d26e5d2a82d7c555d7de410ebaa4"},{"line_number":20,"context_line":"Signed-off-by: Victor Obiezue \u003cobiezuevictor@gmail.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"f28f5e7d_ee26f9c8","line":18,"updated":"2026-03-19 22:12:15.000000000","message":"Generally we would expect a little more spacing, but otherwise a clear commit message, thanks!","commit_id":"3469fc571cb3feefceb38b84b2573efba98ceb16"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"8c0d21a3645324b1eeb83b9f26850723e511cc06","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"db307e8a_3d64c4fd","updated":"2026-03-19 22:12:15.000000000","message":"The one major issue I see: We don\u0027t have a unit test. It woul be good to add a unit test. You would likely need to look at ironic/tests/unit/conductor/test_manager.py but it is quite a bit. Honestly, I\u0027d recommend letting claude do the lift for you.","commit_id":"3469fc571cb3feefceb38b84b2573efba98ceb16"},{"author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"change_message_id":"cd0ebda0c4edfa6146ff8f8f7295388286284df0","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"392cb8c8_5dae638d","updated":"2026-03-19 22:11:47.000000000","message":"While it is a bit of a feature. I think this is a quality of life thing that will help us long term and worth backporting.","commit_id":"3469fc571cb3feefceb38b84b2573efba98ceb16"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"eec44f8b7115b443bd0e778fef7ffaffcecd08b2","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"57a0efd4_9404552e","in_reply_to":"392cb8c8_5dae638d","updated":"2026-03-19 22:13:40.000000000","message":"I do concur!","commit_id":"3469fc571cb3feefceb38b84b2573efba98ceb16"}],"ironic/conductor/manager.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"8c0d21a3645324b1eeb83b9f26850723e511cc06","unresolved":true,"context_lines":[{"line_number":3581,"context_line":"            # in *its* context of execution."},{"line_number":3582,"context_line":"            try:"},{"line_number":3583,"context_line":"                task.driver.network.vif_attach(task, vif_info)"},{"line_number":3584,"context_line":"            except Exception as e:"},{"line_number":3585,"context_line":"                msg \u003d f\"Failed to attach VIF {vif_info[\u0027id\u0027]} to node {node_id}. Error {e}\""},{"line_number":3586,"context_line":"                utils.node_history_record(task.node, event\u003dmsg, event_type\u003d\u0027vif_attach\u0027, error\u003dTrue)"},{"line_number":3587,"context_line":"                raise"}],"source_content_type":"text/x-python","patch_set":1,"id":"c13aa3a6_9b7bc09f","line":3584,"updated":"2026-03-19 22:12:15.000000000","message":"I suspect some might not be happy with Exception, but the pattern you have here may be okay.","commit_id":"3469fc571cb3feefceb38b84b2573efba98ceb16"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"8c0d21a3645324b1eeb83b9f26850723e511cc06","unresolved":true,"context_lines":[{"line_number":3582,"context_line":"            try:"},{"line_number":3583,"context_line":"                task.driver.network.vif_attach(task, vif_info)"},{"line_number":3584,"context_line":"            except Exception as e:"},{"line_number":3585,"context_line":"                msg \u003d f\"Failed to attach VIF {vif_info[\u0027id\u0027]} to node {node_id}. Error {e}\""},{"line_number":3586,"context_line":"                utils.node_history_record(task.node, event\u003dmsg, event_type\u003d\u0027vif_attach\u0027, error\u003dTrue)"},{"line_number":3587,"context_line":"                raise"},{"line_number":3588,"context_line":"                "}],"source_content_type":"text/x-python","patch_set":1,"id":"27a05396_ae5857f2","line":3585,"range":{"start_line":3585,"start_character":81,"end_line":3585,"end_character":91},"updated":"2026-03-19 22:12:15.000000000","message":"I\u0027m not super sure about explicitly logging the exception in node history, reviewers can discuss.","commit_id":"3469fc571cb3feefceb38b84b2573efba98ceb16"},{"author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"change_message_id":"cd0ebda0c4edfa6146ff8f8f7295388286284df0","unresolved":true,"context_lines":[{"line_number":3585,"context_line":"                msg \u003d f\"Failed to attach VIF {vif_info[\u0027id\u0027]} to node {node_id}. Error {e}\""},{"line_number":3586,"context_line":"                utils.node_history_record(task.node, event\u003dmsg, event_type\u003d\u0027vif_attach\u0027, error\u003dTrue)"},{"line_number":3587,"context_line":"                raise"},{"line_number":3588,"context_line":"                "},{"line_number":3589,"context_line":"        LOG.info(\"VIF %(vif_id)s successfully attached to node %(node_id)s\","},{"line_number":3590,"context_line":"                 {\u0027vif_id\u0027: vif_info[\u0027id\u0027], \u0027node_id\u0027: node_id})"},{"line_number":3591,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"244c6ad5_0a0f18f5","line":3588,"updated":"2026-03-19 22:11:47.000000000","message":"This white space I bet will get flagged by the linter. Look at installing prek or pre-commit locally to catch this before you commit.","commit_id":"3469fc571cb3feefceb38b84b2573efba98ceb16"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"8c0d21a3645324b1eeb83b9f26850723e511cc06","unresolved":true,"context_lines":[{"line_number":3585,"context_line":"                msg \u003d f\"Failed to attach VIF {vif_info[\u0027id\u0027]} to node {node_id}. Error {e}\""},{"line_number":3586,"context_line":"                utils.node_history_record(task.node, event\u003dmsg, event_type\u003d\u0027vif_attach\u0027, error\u003dTrue)"},{"line_number":3587,"context_line":"                raise"},{"line_number":3588,"context_line":"                "},{"line_number":3589,"context_line":"        LOG.info(\"VIF %(vif_id)s successfully attached to node %(node_id)s\","},{"line_number":3590,"context_line":"                 {\u0027vif_id\u0027: vif_info[\u0027id\u0027], \u0027node_id\u0027: node_id})"},{"line_number":3591,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"c53b7475_ed74e32b","line":3588,"updated":"2026-03-19 22:12:15.000000000","message":"nit: excess whitespace. I believe this will actually fail the `tox -epep8` checks, so you should likely fix it.","commit_id":"3469fc571cb3feefceb38b84b2573efba98ceb16"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"8c0d21a3645324b1eeb83b9f26850723e511cc06","unresolved":true,"context_lines":[{"line_number":3614,"context_line":"            try:"},{"line_number":3615,"context_line":"                task.driver.network.vif_detach(task, vif_id)"},{"line_number":3616,"context_line":"            except Exception as e:"},{"line_number":3617,"context_line":"                msg \u003d f\"Failed to detach VIF {vif_id} from node {node_id}. Error {e}\""},{"line_number":3618,"context_line":"                utils.node_history_record(task.node, event\u003dmsg, event_type\u003d\u0027vif_detach\u0027, error\u003dTrue)"},{"line_number":3619,"context_line":"                raise"},{"line_number":3620,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"a7991284_ee06c85e","line":3617,"range":{"start_line":3617,"start_character":81,"end_line":3617,"end_character":84},"updated":"2026-03-19 22:12:15.000000000","message":"Reviewers, Discuss!","commit_id":"3469fc571cb3feefceb38b84b2573efba98ceb16"}]}