)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":36770,"name":"cid","display_name":"cid","email":"cid@gr-oss.io","username":"cidelight","status":"@gr-oss upstream: Doing good IRONIC things..."},"change_message_id":"fa21bc72fc5512140fa43621923204ffe4541514","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"8033c7d6_fcac7d9c","updated":"2026-04-07 17:20:33.000000000","message":"GR-OSS review jam","commit_id":"4569104fd4d085e64d8c5d01829a95d19f799495"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"0e840d2677f5b3542f803ae41e6c4f2a706f5cf5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"27eefd0b_90b79f28","updated":"2026-04-02 14:21:02.000000000","message":"Tagging with the hashtag to get discussion going, so we can decide if this is a valid approach.","commit_id":"4569104fd4d085e64d8c5d01829a95d19f799495"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"866c120283d96020160e28bed31ba5e8561e3389","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ea612e26_53f410be","updated":"2026-04-01 01:59:21.000000000","message":"recheck 4k job","commit_id":"4569104fd4d085e64d8c5d01829a95d19f799495"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"89cd5bebc9b59a3f4f7053e99262069019da3e54","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"f597ed24_0e3ec9fb","updated":"2026-03-29 22:28:52.000000000","message":"recheck post-failure","commit_id":"4569104fd4d085e64d8c5d01829a95d19f799495"}],"ironic/drivers/modules/redfish/firmware.py":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"e9392969611d25a8dde46060dc5797f360fd848c","unresolved":true,"context_lines":[{"line_number":597,"context_line":"                # Check if this looks like a NIC firmware entry"},{"line_number":598,"context_line":"                if any(keyword in fw_name for keyword in"},{"line_number":599,"context_line":"                       [\u0027ethernet\u0027, \u0027nic\u0027, \u0027network\u0027, \u0027e810\u0027,"},{"line_number":600,"context_line":"                        \u0027connectx\u0027, \u0027intel\u0027, \u0027mellanox\u0027, \u0027broadcom\u0027]):"},{"line_number":601,"context_line":""},{"line_number":602,"context_line":"                    updateable \u003d getattr(fw_member, \u0027updateable\u0027, None)"},{"line_number":603,"context_line":"                    if updateable is not True:"}],"source_content_type":"text/x-python","patch_set":2,"id":"26ab77ed_01987c80","line":600,"updated":"2026-04-07 17:18:46.000000000","message":"If we\u0027re going to have a magic list of NICs, there needs to be a way for an operator to trigger this behavior on hardware we have never seen or that identifies itself weirdly. I\u0027ll note it\u0027s not uncommon at all (hello mellanox/nvidia) to see NIC brands switch around even mid-cycle for a piece of hardware.\n\nPerhaps add something to driver info allowing someone to add names to this list? Make it configurable? IDK, but I don\u0027t love the idea that we\u0027ll have to backport if Intel NICs becoming PentiumNIC in 2027.","commit_id":"4569104fd4d085e64d8c5d01829a95d19f799495"},{"author":{"_account_id":36770,"name":"cid","display_name":"cid","email":"cid@gr-oss.io","username":"cidelight","status":"@gr-oss upstream: Doing good IRONIC things..."},"change_message_id":"fa21bc72fc5512140fa43621923204ffe4541514","unresolved":true,"context_lines":[{"line_number":597,"context_line":"                # Check if this looks like a NIC firmware entry"},{"line_number":598,"context_line":"                if any(keyword in fw_name for keyword in"},{"line_number":599,"context_line":"                       [\u0027ethernet\u0027, \u0027nic\u0027, \u0027network\u0027, \u0027e810\u0027,"},{"line_number":600,"context_line":"                        \u0027connectx\u0027, \u0027intel\u0027, \u0027mellanox\u0027, \u0027broadcom\u0027]):"},{"line_number":601,"context_line":""},{"line_number":602,"context_line":"                    updateable \u003d getattr(fw_member, \u0027updateable\u0027, None)"},{"line_number":603,"context_line":"                    if updateable is not True:"}],"source_content_type":"text/x-python","patch_set":2,"id":"66d88b93_c94f11f9","line":600,"in_reply_to":"26ab77ed_01987c80","updated":"2026-04-07 17:20:33.000000000","message":"Or at constants?","commit_id":"4569104fd4d085e64d8c5d01829a95d19f799495"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"191f5f60e14e1a50629220788000d68251e5c83f","unresolved":true,"context_lines":[{"line_number":597,"context_line":"                # Check if this looks like a NIC firmware entry"},{"line_number":598,"context_line":"                if any(keyword in fw_name for keyword in"},{"line_number":599,"context_line":"                       [\u0027ethernet\u0027, \u0027nic\u0027, \u0027network\u0027, \u0027e810\u0027,"},{"line_number":600,"context_line":"                        \u0027connectx\u0027, \u0027intel\u0027, \u0027mellanox\u0027, \u0027broadcom\u0027]):"},{"line_number":601,"context_line":""},{"line_number":602,"context_line":"                    updateable \u003d getattr(fw_member, \u0027updateable\u0027, None)"},{"line_number":603,"context_line":"                    if updateable is not True:"}],"source_content_type":"text/x-python","patch_set":2,"id":"282472a8_46ec8bff","line":600,"in_reply_to":"63411d9d_03298fe3","updated":"2026-04-08 15:48:40.000000000","message":"I like the retry-based approach.","commit_id":"4569104fd4d085e64d8c5d01829a95d19f799495"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"c55861a67af6e8b993efa7e671ba30cc6d54749a","unresolved":true,"context_lines":[{"line_number":597,"context_line":"                # Check if this looks like a NIC firmware entry"},{"line_number":598,"context_line":"                if any(keyword in fw_name for keyword in"},{"line_number":599,"context_line":"                       [\u0027ethernet\u0027, \u0027nic\u0027, \u0027network\u0027, \u0027e810\u0027,"},{"line_number":600,"context_line":"                        \u0027connectx\u0027, \u0027intel\u0027, \u0027mellanox\u0027, \u0027broadcom\u0027]):"},{"line_number":601,"context_line":""},{"line_number":602,"context_line":"                    updateable \u003d getattr(fw_member, \u0027updateable\u0027, None)"},{"line_number":603,"context_line":"                    if updateable is not True:"}],"source_content_type":"text/x-python","patch_set":2,"id":"63411d9d_03298fe3","line":600,"in_reply_to":"66d88b93_c94f11f9","updated":"2026-04-08 14:47:47.000000000","message":"Hey Jay, yeah I totally agree, this was more a POC people tested downstream...\nIn general I don\u0027t even think this is a good approach, mostly because we are trying to relay on the `Updateable`, I\u0027m wondering if you and CID are ok with using it as the source of true or we could go with a retry approach for example, since without this they faced some error that was `Base.1.18.OperationFailed`...\n\nWhat are your thoughts?","commit_id":"4569104fd4d085e64d8c5d01829a95d19f799495"}]}