)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"c3ed7f977f45a9522a59700e45ab10305bbe73cc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"4961ec55_5bd5d644","updated":"2026-04-08 04:03:40.000000000","message":"Thank you for your patch, Konstantinos. Overall LGTM, one comment in-line","commit_id":"5b6661ba84b17ff75cff3164067dd961cbec02d4"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"721bc8308594a18ae44a5ad9cef5a234de3e6341","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"7d73eaeb_6e472703","updated":"2026-04-10 05:34:07.000000000","message":"Thanks for the revision. I looked into the cause of CI failure and proposed a fix - have a look and see if my suggestion makes sense or perhaps you\u0027d like to fix it differently.","commit_id":"08e92aa86bbf16bd7d0d8581c573b7203fc25dcb"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"47b062f31f67a6e65e80c79980d40b0f67ff4e2f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"c75098d5_3d46552b","updated":"2026-04-10 12:26:17.000000000","message":"Thanks Konstantinos, LGTM now","commit_id":"4959f6e9abbbc0f336f81530b9393f585dd3d215"},{"author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"change_message_id":"ca05daf6078e14490eb0982abd502dd2623558a8","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"a5944c60_cf91ac53","updated":"2026-04-11 14:32:54.000000000","message":"This needs a release note so we can properly back port it.","commit_id":"4959f6e9abbbc0f336f81530b9393f585dd3d215"},{"author":{"_account_id":38806,"name":"Konstantinos Karampogias","email":"kkarampo@redhat.com","username":"karampok","status":"Red Hat"},"change_message_id":"0509fa3f99e84f8255f28c9733eb1b483653c420","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"cfb9015a_73568cd7","in_reply_to":"084899bb_32529588","updated":"2026-04-14 08:11:16.000000000","message":"Done","commit_id":"4959f6e9abbbc0f336f81530b9393f585dd3d215"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"a83e8bccb2d031266e384e51dbf35a280f8bb4fd","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"084899bb_32529588","in_reply_to":"a5944c60_cf91ac53","updated":"2026-04-13 10:56:00.000000000","message":"Good point, Doug, this is indeed reno worthy, removing my +1.","commit_id":"4959f6e9abbbc0f336f81530b9393f585dd3d215"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"2c3202c0677f128645a23fd861c705e178dcbb57","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"0558099e_bf05beb2","updated":"2026-04-15 04:22:24.000000000","message":"LGTM, thank you Konstantinos.","commit_id":"9f2c21be17887b523d5abee05f8393b6b4a87064"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"ce715c67c5abfdf0c209afe964ae08eaf8638a7d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"214c0587_7e8a64e2","updated":"2026-04-14 09:47:11.000000000","message":"only reno added, doesn\u0027t look like an actual CI problem","commit_id":"9f2c21be17887b523d5abee05f8393b6b4a87064"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"2471cd85c4732c3ab38292150b23ff63fb45645a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"eba84988_ac1d8b4d","updated":"2026-04-14 09:46:48.000000000","message":"recheck","commit_id":"9f2c21be17887b523d5abee05f8393b6b4a87064"},{"author":{"_account_id":38806,"name":"Konstantinos Karampogias","email":"kkarampo@redhat.com","username":"karampok","status":"Red Hat"},"change_message_id":"0509fa3f99e84f8255f28c9733eb1b483653c420","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"980941ab_d3219e28","updated":"2026-04-14 08:11:16.000000000","message":"thank you for your feedback","commit_id":"9f2c21be17887b523d5abee05f8393b6b4a87064"}],"ironic/conductor/servicing.py":[{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"c3ed7f977f45a9522a59700e45ab10305bbe73cc","unresolved":true,"context_lines":[{"line_number":106,"context_line":"    else:"},{"line_number":107,"context_line":"        LOG.debug(\u0027Will proceed with servicing node %(node)s \u0027"},{"line_number":108,"context_line":"                  \u0027without booting the ramdisk.\u0027, {\u0027node\u0027: node.uuid})"},{"line_number":109,"context_line":"        node.set_driver_internal_info(\u0027service_disable_ramdisk\u0027, True)"},{"line_number":110,"context_line":"        node.save()"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"    do_next_service_step(task, step_index, disable_ramdisk\u003ddisable_ramdisk)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bdf2ac58_bf017524","line":109,"range":{"start_line":109,"start_character":8,"end_line":109,"end_character":70},"updated":"2026-04-08 04:03:40.000000000","message":"Perhaps consider adding:\ndisable_ramdisk \u003d True\nhere so that the do_next_service_step() in L112 doesn\u0027t pass inconsistent/incorrect value\u003e","commit_id":"5b6661ba84b17ff75cff3164067dd961cbec02d4"},{"author":{"_account_id":38806,"name":"Konstantinos Karampogias","email":"kkarampo@redhat.com","username":"karampok","status":"Red Hat"},"change_message_id":"7c7cd683a9bbec6224b2142fb588af6b5c4ada17","unresolved":false,"context_lines":[{"line_number":106,"context_line":"    else:"},{"line_number":107,"context_line":"        LOG.debug(\u0027Will proceed with servicing node %(node)s \u0027"},{"line_number":108,"context_line":"                  \u0027without booting the ramdisk.\u0027, {\u0027node\u0027: node.uuid})"},{"line_number":109,"context_line":"        node.set_driver_internal_info(\u0027service_disable_ramdisk\u0027, True)"},{"line_number":110,"context_line":"        node.save()"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"    do_next_service_step(task, step_index, disable_ramdisk\u003ddisable_ramdisk)"}],"source_content_type":"text/x-python","patch_set":1,"id":"39cc4cc7_b5062039","line":109,"range":{"start_line":109,"start_character":8,"end_line":109,"end_character":70},"in_reply_to":"3af50f2b_b698d431","updated":"2026-04-09 07:53:10.000000000","message":"Done","commit_id":"5b6661ba84b17ff75cff3164067dd961cbec02d4"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"12e07504c292a9fe0dc95c8ce5f9afa4b8002228","unresolved":true,"context_lines":[{"line_number":106,"context_line":"    else:"},{"line_number":107,"context_line":"        LOG.debug(\u0027Will proceed with servicing node %(node)s \u0027"},{"line_number":108,"context_line":"                  \u0027without booting the ramdisk.\u0027, {\u0027node\u0027: node.uuid})"},{"line_number":109,"context_line":"        node.set_driver_internal_info(\u0027service_disable_ramdisk\u0027, True)"},{"line_number":110,"context_line":"        node.save()"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"    do_next_service_step(task, step_index, disable_ramdisk\u003ddisable_ramdisk)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3af50f2b_b698d431","line":109,"range":{"start_line":109,"start_character":8,"end_line":109,"end_character":70},"in_reply_to":"bdf2ac58_bf017524","updated":"2026-04-08 04:15:26.000000000","message":"so overall it reads\n\n    else:\n        LOG.debug(\u0027Will proceed with servicing node %(node)s \u0027\n                  \u0027without booting the ramdisk.\u0027, {\u0027node\u0027: node.uuid})\n        disable_ramdisk \u003d True\n        node.set_driver_internal_info(\u0027service_disable_ramdisk\u0027, True)\n        node.save()\n\nwe could reuse disable_ramdisk variable but your syntax precisely matches cleaning (https://github.com/openstack/ironic/blob/master/ironic/conductor/cleaning.py#L66-L72) so let\u0027s stick with that.","commit_id":"5b6661ba84b17ff75cff3164067dd961cbec02d4"}],"ironic/tests/unit/conductor/test_servicing.py":[{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"721bc8308594a18ae44a5ad9cef5a234de3e6341","unresolved":true,"context_lines":[{"line_number":364,"context_line":"            else:"},{"line_number":365,"context_line":"                mock_network_valid.assert_called_once_with(mock.ANY, task)"},{"line_number":366,"context_line":""},{"line_number":367,"context_line":"            mock_next_step.assert_called_once_with("},{"line_number":368,"context_line":"                task, 0, disable_ramdisk\u003ddisable_ramdisk)"},{"line_number":369,"context_line":"            mock_steps.assert_called_once_with("},{"line_number":370,"context_line":"                task, disable_ramdisk\u003ddisable_ramdisk)"},{"line_number":371,"context_line":"            if service_steps:"}],"source_content_type":"text/x-python","patch_set":2,"id":"d51fb5e8_67625fad","line":368,"range":{"start_line":367,"start_character":0,"end_line":368,"end_character":57},"updated":"2026-04-10 05:34:07.000000000","message":"This is failing CI - the old test needs to be adapted to the new behavior. Have a look at this patch (credit - Claude) - that\u0027s one way to fix this:\n\nhttps://paste.openstack.org/show/bhlPpCmmZzbJPoQgDS9f/","commit_id":"08e92aa86bbf16bd7d0d8581c573b7203fc25dcb"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"47b062f31f67a6e65e80c79980d40b0f67ff4e2f","unresolved":false,"context_lines":[{"line_number":364,"context_line":"            else:"},{"line_number":365,"context_line":"                mock_network_valid.assert_called_once_with(mock.ANY, task)"},{"line_number":366,"context_line":""},{"line_number":367,"context_line":"            mock_next_step.assert_called_once_with("},{"line_number":368,"context_line":"                task, 0, disable_ramdisk\u003ddisable_ramdisk)"},{"line_number":369,"context_line":"            mock_steps.assert_called_once_with("},{"line_number":370,"context_line":"                task, disable_ramdisk\u003ddisable_ramdisk)"},{"line_number":371,"context_line":"            if service_steps:"}],"source_content_type":"text/x-python","patch_set":2,"id":"f3e50144_88dfe576","line":368,"range":{"start_line":367,"start_character":0,"end_line":368,"end_character":57},"in_reply_to":"d51fb5e8_67625fad","updated":"2026-04-10 12:26:17.000000000","message":"Done","commit_id":"08e92aa86bbf16bd7d0d8581c573b7203fc25dcb"}]}