)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"2515b593a573db1a265d12a9b1166f375b4d3154","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"c08bd5db_e067ffbc","updated":"2026-04-16 03:53:13.000000000","message":"Thanks for the patch, also the change requires a release note","commit_id":"459a7eafb61b66f0a4d0fb3426a55aac988b329d"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"c5c0a1b303f35929e07997c3eaf9271e6819e948","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"fa3793ab_650f797f","updated":"2026-06-09 22:27:55.000000000","message":"Feel free to re-add hashtag:ironic-week-prio once Steve\u0027s feedback has been taken into account.","commit_id":"9799a6355fa88b9b28f2f48c12c8cdd3faded706"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"adae63663aca940cc7582388cd206ea633e19b4b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"ad84d40f_86539137","updated":"2026-06-07 22:45:51.000000000","message":"Graphical consoles have their own expiry cleanup periodic job\nhttps://opendev.org/openstack/ironic/src/branch/master/ironic/drivers/modules/graphical_console.py#L82\nhttps://opendev.org/openstack/ironic/src/branch/master/ironic/drivers/modules/redfish/graphical_console.py#L60\n\nThis change would need to consider:\n- not closing any graphical console since that is already managed\n- clarifying in config documentation strings which console drivers the setting applies to","commit_id":"9799a6355fa88b9b28f2f48c12c8cdd3faded706"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"cb566a27bfa1dd628220684a1f85263444ab674a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"cca68fae_0f50c384","updated":"2026-06-05 14:27:12.000000000","message":"I\u0027ve added the ironic-week-prio label to this change and I\u0027ve pinged Steve Baker to review as well as he has done some of our graphical console work as of recent.","commit_id":"9799a6355fa88b9b28f2f48c12c8cdd3faded706"}],"ironic/conductor/manager.py":[{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"2515b593a573db1a265d12a9b1166f375b4d3154","unresolved":true,"context_lines":[{"line_number":2152,"context_line":""},{"line_number":2153,"context_line":"            # Check if console has a start timestamp"},{"line_number":2154,"context_line":"            console_started_at \u003d node_obj.driver_internal_info.get("},{"line_number":2155,"context_line":"                \u0027console_started_at\u0027)"},{"line_number":2156,"context_line":"            if not console_started_at:"},{"line_number":2157,"context_line":"                continue"},{"line_number":2158,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"2d30e54d_0e5597b5","line":2155,"updated":"2026-04-16 03:53:13.000000000","message":"this may reach an edge case in the take over process by upgrading conductors in sequence, a node take over by other node will not have the field set up and effectively bypassed the timeout processing, i\u0027d suggest to put the logic into start/stop_console","commit_id":"459a7eafb61b66f0a4d0fb3426a55aac988b329d"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"2515b593a573db1a265d12a9b1166f375b4d3154","unresolved":true,"context_lines":[{"line_number":2642,"context_line":"        node.console_enabled \u003d enabled"},{"line_number":2643,"context_line":"        node.last_error \u003d None"},{"line_number":2644,"context_line":"        if enabled:"},{"line_number":2645,"context_line":"            node.driver_internal_info[\u0027console_started_at\u0027] \u003d \\"},{"line_number":2646,"context_line":"                timeutils.utcnow().isoformat()"},{"line_number":2647,"context_line":"        else:"},{"line_number":2648,"context_line":"            node.driver_internal_info.pop(\u0027console_started_at\u0027, None)"}],"source_content_type":"text/x-python","patch_set":2,"id":"83c9d960_585eaadb","line":2645,"updated":"2026-04-16 03:53:13.000000000","message":"if i remember correctly this doesn\u0027t work, you need to update driver_internal_info as a whole:\n```\ndii \u003d node.driver_internal_info\ndii[\u0027console_started_at\u0027] \u003d ..\nnode.driver_internal_info \u003d dii\n```","commit_id":"459a7eafb61b66f0a4d0fb3426a55aac988b329d"}]}