)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"c1e2c6d0ad90469f85423674d181794aedf81c3b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"da4acccf_e3585acb","updated":"2026-05-26 20:47:28.000000000","message":"Dependent patches inside a repo should be stacked and pushed together.\n\ne.g. you currently have 987887 that depends on 985880 and 985878 so your local branch, when you run git review, should look something like this (I assume 880 depends on 878 based on numbering):\n\n- [CURRENT MASTER HEAD COMMIT]\n- 985878\n- 985880\n- 987887\n\nThen when you run ``git review``, it\u0027ll push three linked changes together. As a bonus, if you keep the Change-Id already assigned, it\u0027ll update your existing patchsets just like for a minor code update.\n\nThe way I\u0027d personally go about this is:\n\n- git fetch origin\n- git checkout origin/master\n- git review -x 985878\n- git review -x 985880\n- git review -x 987887\n- git log origin/master # you should see your three commits aligned\n\nMake sure to remove Depends-On at this step.\n\nDepends-On, as you use it here: https://review.opendev.org/c/openstack/ironic-python-agent/+/988150 for cross-repo dependency declaration, still works great.","commit_id":"38789f7888b635a6e058283490a5035c1ad64842"}],"ironic/api/controllers/v1/ramdisk.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"d2becca21e5407566f9115493e80be2c8a4e5900","unresolved":true,"context_lines":[{"line_number":89,"context_line":"        \u0027disable_deep_image_inspection\u0027: CONF.conductor.disable_deep_image_inspection,  # noqa"},{"line_number":90,"context_line":"        \u0027permitted_image_formats\u0027: CONF.conductor.permitted_image_formats,"},{"line_number":91,"context_line":"        \u0027agent_skip_bmc_detect\u0027: skip_bmc_detect,"},{"line_number":92,"context_line":"        \u0027tls_min_version\u0027: CONF.api.tls_minimum_version,"},{"line_number":93,"context_line":"        \u0027tls_cipher_suites\u0027: CONF.api.tls_ciphers,"},{"line_number":94,"context_line":"    }"},{"line_number":95,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"47df5f31_99382cc4","line":92,"updated":"2026-05-18 14:10:51.000000000","message":"Hmm, this raises a good point, but the API TLS endpoint may not be configured by the service at all and it may be front-ended by a proxy which will render the configuration option unused. I\u0027d suggest revisiting based on https://review.opendev.org/c/openstack/ironic/+/985880/4/ironic/conf/agent.py which introduces [agent] section options.","commit_id":"0d41592d2983283b90b3624eb9388b11455bf3e9"},{"author":{"_account_id":37517,"name":"Mithun Krishnan Umesan","display_name":"mumesan","email":"mumesan@redhat.com","username":"mumesan"},"change_message_id":"915b193d6de3b1f2e9214ea41d30b6f1392f19d2","unresolved":false,"context_lines":[{"line_number":89,"context_line":"        \u0027disable_deep_image_inspection\u0027: CONF.conductor.disable_deep_image_inspection,  # noqa"},{"line_number":90,"context_line":"        \u0027permitted_image_formats\u0027: CONF.conductor.permitted_image_formats,"},{"line_number":91,"context_line":"        \u0027agent_skip_bmc_detect\u0027: skip_bmc_detect,"},{"line_number":92,"context_line":"        \u0027tls_min_version\u0027: CONF.api.tls_minimum_version,"},{"line_number":93,"context_line":"        \u0027tls_cipher_suites\u0027: CONF.api.tls_ciphers,"},{"line_number":94,"context_line":"    }"},{"line_number":95,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"8a97cc6e_749f4d58","line":92,"in_reply_to":"47df5f31_99382cc4","updated":"2026-05-18 16:51:03.000000000","message":"Done","commit_id":"0d41592d2983283b90b3624eb9388b11455bf3e9"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"c6657e99c8b4061a6bdc3978b20031b1a156799c","unresolved":true,"context_lines":[{"line_number":91,"context_line":"        \u0027agent_skip_bmc_detect\u0027: skip_bmc_detect,"},{"line_number":92,"context_line":"        \u0027enable_bios_bootloader_install\u0027: CONF.agent.enable_bios_bootloader_install, # noqa"},{"line_number":93,"context_line":"        \u0027tls_min_version\u0027: CONF.agent.tls_minimum_version,"},{"line_number":94,"context_line":"        \u0027tls_cipher_suites\u0027: CONF.agent.tls_ciphers,"},{"line_number":95,"context_line":"    }"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"c6007530_2043df64","line":94,"updated":"2026-06-05 14:09:40.000000000","message":"Okay, you h ave agent here.... Because https://review.opendev.org/c/openstack/ironic/+/985880/4/ironic/conf/agent.py","commit_id":"5906eca8084a73eb8be1fa99e21b4b394e9d7a06"},{"author":{"_account_id":37517,"name":"Mithun Krishnan Umesan","display_name":"mumesan","email":"mumesan@redhat.com","username":"mumesan"},"change_message_id":"5809321f1eff0662b7a78a266ae1bbfa1ea4069a","unresolved":false,"context_lines":[{"line_number":91,"context_line":"        \u0027agent_skip_bmc_detect\u0027: skip_bmc_detect,"},{"line_number":92,"context_line":"        \u0027enable_bios_bootloader_install\u0027: CONF.agent.enable_bios_bootloader_install, # noqa"},{"line_number":93,"context_line":"        \u0027tls_min_version\u0027: CONF.agent.tls_minimum_version,"},{"line_number":94,"context_line":"        \u0027tls_cipher_suites\u0027: CONF.agent.tls_ciphers,"},{"line_number":95,"context_line":"    }"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"044c8a2b_ce06f98c","line":94,"in_reply_to":"c6007530_2043df64","updated":"2026-06-05 15:13:02.000000000","message":"Done","commit_id":"5906eca8084a73eb8be1fa99e21b4b394e9d7a06"}],"releasenotes/notes/agent-lookup-tls-config-c056518d825f2f93.yaml":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"c6657e99c8b4061a6bdc3978b20031b1a156799c","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The ``/v1/lookup`` endpoint now includes TLS configuration in the"},{"line_number":5,"context_line":"    response to ironic-python-agent. The ``tls_min_version`` and"},{"line_number":6,"context_line":"    ``tls_cipher_suites`` keys are passed to IPA, sourced from the"},{"line_number":7,"context_line":"    ``[api] tls_minimum_version`` and ``[api] tls_ciphers`` config"},{"line_number":8,"context_line":"    options, allowing IPA to apply the same TLS security policy when"},{"line_number":9,"context_line":"    making callbacks to the Ironic API."}],"source_content_type":"text/x-yaml","patch_set":12,"id":"f7dd996c_b239c9ad","line":6,"range":{"start_line":6,"start_character":25,"end_line":6,"end_character":31},"updated":"2026-06-05 14:09:40.000000000","message":"nit: Instead of \"keys are\", I think \"configuration is\"","commit_id":"5906eca8084a73eb8be1fa99e21b4b394e9d7a06"},{"author":{"_account_id":37517,"name":"Mithun Krishnan Umesan","display_name":"mumesan","email":"mumesan@redhat.com","username":"mumesan"},"change_message_id":"5809321f1eff0662b7a78a266ae1bbfa1ea4069a","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The ``/v1/lookup`` endpoint now includes TLS configuration in the"},{"line_number":5,"context_line":"    response to ironic-python-agent. The ``tls_min_version`` and"},{"line_number":6,"context_line":"    ``tls_cipher_suites`` keys are passed to IPA, sourced from the"},{"line_number":7,"context_line":"    ``[api] tls_minimum_version`` and ``[api] tls_ciphers`` config"},{"line_number":8,"context_line":"    options, allowing IPA to apply the same TLS security policy when"},{"line_number":9,"context_line":"    making callbacks to the Ironic API."}],"source_content_type":"text/x-yaml","patch_set":12,"id":"99198e29_31e959bd","line":6,"range":{"start_line":6,"start_character":25,"end_line":6,"end_character":31},"in_reply_to":"f7dd996c_b239c9ad","updated":"2026-06-05 15:13:02.000000000","message":"Done","commit_id":"5906eca8084a73eb8be1fa99e21b4b394e9d7a06"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"c6657e99c8b4061a6bdc3978b20031b1a156799c","unresolved":true,"context_lines":[{"line_number":4,"context_line":"    The ``/v1/lookup`` endpoint now includes TLS configuration in the"},{"line_number":5,"context_line":"    response to ironic-python-agent. The ``tls_min_version`` and"},{"line_number":6,"context_line":"    ``tls_cipher_suites`` keys are passed to IPA, sourced from the"},{"line_number":7,"context_line":"    ``[api] tls_minimum_version`` and ``[api] tls_ciphers`` config"},{"line_number":8,"context_line":"    options, allowing IPA to apply the same TLS security policy when"},{"line_number":9,"context_line":"    making callbacks to the Ironic API."}],"source_content_type":"text/x-yaml","patch_set":12,"id":"fb34fff2_ed8b28f0","line":7,"range":{"start_line":7,"start_character":41,"end_line":7,"end_character":44},"updated":"2026-06-05 14:09:40.000000000","message":"ahh, but you have [api] twice on this line which doesn\u0027t match the configuration. This needs to be fixed 😉","commit_id":"5906eca8084a73eb8be1fa99e21b4b394e9d7a06"},{"author":{"_account_id":37517,"name":"Mithun Krishnan Umesan","display_name":"mumesan","email":"mumesan@redhat.com","username":"mumesan"},"change_message_id":"5809321f1eff0662b7a78a266ae1bbfa1ea4069a","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    The ``/v1/lookup`` endpoint now includes TLS configuration in the"},{"line_number":5,"context_line":"    response to ironic-python-agent. The ``tls_min_version`` and"},{"line_number":6,"context_line":"    ``tls_cipher_suites`` keys are passed to IPA, sourced from the"},{"line_number":7,"context_line":"    ``[api] tls_minimum_version`` and ``[api] tls_ciphers`` config"},{"line_number":8,"context_line":"    options, allowing IPA to apply the same TLS security policy when"},{"line_number":9,"context_line":"    making callbacks to the Ironic API."}],"source_content_type":"text/x-yaml","patch_set":12,"id":"baf2ea1c_de91ad25","line":7,"range":{"start_line":7,"start_character":41,"end_line":7,"end_character":44},"in_reply_to":"fb34fff2_ed8b28f0","updated":"2026-06-05 15:13:02.000000000","message":"Done","commit_id":"5906eca8084a73eb8be1fa99e21b4b394e9d7a06"}]}