)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"e237944f71b417aa6e68852de1d10e9af48b7991","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"b7013565_939fc666","updated":"2026-05-19 15:34:25.000000000","message":"Have we ensured this can\u0027t be bypassed via runbooks?","commit_id":"22c1896f1a83b6a6b19369990970bedd74ce7bf6"}],"ironic/api/controllers/v1/node.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"6f824208e01b64e7eefba400ccd172d68e70963e","unresolved":true,"context_lines":[{"line_number":1360,"context_line":"    _check_steps(clean_steps, \u0027clean\u0027, _STEPS_SCHEMA)"},{"line_number":1361,"context_line":""},{"line_number":1362,"context_line":"    disallowed_steps \u003d CONF.api.disallow_clean_steps"},{"line_number":1363,"context_line":"    if disallowed_steps:"},{"line_number":1364,"context_line":"        for step in clean_steps:"},{"line_number":1365,"context_line":"            step_id \u003d \u0027%s.%s\u0027 % (step[\u0027interface\u0027], step[\u0027step\u0027])"},{"line_number":1366,"context_line":"            if step_id in disallowed_steps:"}],"source_content_type":"text/x-python","patch_set":5,"id":"25de37e5_6634be48","line":1363,"updated":"2026-05-19 16:04:25.000000000","message":"So, I think the basic issue is this ignores runbook execution and which would then become an effective way to side-step this.  I think the way forward to address this is to standardize the conductor side evaluation of steps *before* the async task is launched (task.process_event) in ironic/conductor/manager.py instances where steps are interacted with. As I look at this, there is also an underlying problem, we sometiems get those steps after we\u0027ve launched the process event, so we may need to do some additional internal retooling of conductor/manager.py to frontload the collection and checking of steps.","commit_id":"22c1896f1a83b6a6b19369990970bedd74ce7bf6"}]}
