)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"change_message_id":"e757855767f45685889c5e29f11f19a826641d6c","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"95a170fe_0e7de890","updated":"2026-05-28 01:25:07.000000000","message":"I had forgotten about this. It was discussed that redfish shouldn\u0027t do this at all. This should be removed entirely and the ports inspection hook should be the behavior going forward. Now this might be the backportable / no behavior change but going forward this should absolutely not create these ports as they are slightly different than the inspected ones cause of different fix ups.\n\nThe problem is this same flag operates with the \u0027ports\u0027 hook so there\u0027s no way to disable it here and then use the \u0027ports\u0027 inspection hook.","commit_id":"b7f0c08a609d882275275da110f25fedcf165292"},{"author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"change_message_id":"1c6baf4363457248dd31dbac2748420e7001db51","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"0addc43a_8d19e6b5","updated":"2026-05-28 22:50:52.000000000","message":"Great change. Just fix up that comment.","commit_id":"e06d834f492af1a30d138f9895f9bf67bf20e4cc"},{"author":{"_account_id":36770,"name":"cid","display_name":"cid","email":"cid@gr-oss.io","username":"cidelight","status":"@gr-oss upstream: Doing good IRONIC things..."},"change_message_id":"2cc10fc3f0008218aead225e9f41d3467e5bf3e2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"6a35a808_1c89e94f","updated":"2026-05-29 14:45:38.000000000","message":"this patchset removes out-of-band port pre-creation from both redfish and idrac-redfish, leaving the ports hook as the sole port creator for them. I\u0027m confident from code, but want explicit confirmation before this merges, especially on idrac-redfish and most especially because of the comment: \"work around a bug in some versions of the firmware where the port state is not being reported correctly.\" which I believe  no longer applies but still need confirmation.","commit_id":"e06d834f492af1a30d138f9895f9bf67bf20e4cc"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"0b4a628d13ab1ea29200f9b6ca0b5814b3236b1c","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"e41c6906_278da1d5","updated":"2026-06-01 20:14:57.000000000","message":"The change itself is good, but I think the config descriptions are going to be extremely hard for an out-of-context operator to understand.","commit_id":"eb6a3b7c23750c28ee26fd3743d01e0ba8b9f5d9"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"b3a9533e61c134660780d9fad7a9c51ee62bbf86","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"b86de924_dd2123a3","updated":"2026-06-09 22:35:19.000000000","message":"Excellent.","commit_id":"f8b0b49e9fd6fe517e64a0f87f9ddeae0b4b0db2"}],"doc/source/admin/inspection/hooks.rst":[{"author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"change_message_id":"6edb1f2f81a850d569c7d467d235da41be8f320d","unresolved":true,"context_lines":[{"line_number":86,"context_line":"    :oslo.config:option:`inspector.keep_ports` setting."},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    .. note::"},{"line_number":89,"context_line":"       The ``agent`` and ``idrac-redfish`` inspect interfaces also pre-create"},{"line_number":90,"context_line":"       ports from the MAC addresses reported by the BMC before inspection,"},{"line_number":91,"context_line":"       independently of this hook. For the ``agent`` interface this is"},{"line_number":92,"context_line":"       controlled by the"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9275eaae_1b84463f","line":89,"updated":"2026-05-28 19:23:05.000000000","message":"you removed redfish here so we should get rid of this comment.","commit_id":"e06d834f492af1a30d138f9895f9bf67bf20e4cc"},{"author":{"_account_id":36770,"name":"cid","display_name":"cid","email":"cid@gr-oss.io","username":"cidelight","status":"@gr-oss upstream: Doing good IRONIC things..."},"change_message_id":"2cd6e6ff1e7b238ccf0d284b06961132db11d81a","unresolved":true,"context_lines":[{"line_number":86,"context_line":"    :oslo.config:option:`inspector.keep_ports` setting."},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    .. note::"},{"line_number":89,"context_line":"       The ``agent`` and ``idrac-redfish`` inspect interfaces also pre-create"},{"line_number":90,"context_line":"       ports from the MAC addresses reported by the BMC before inspection,"},{"line_number":91,"context_line":"       independently of this hook. For the ``agent`` interface this is"},{"line_number":92,"context_line":"       controlled by the"}],"source_content_type":"text/x-rst","patch_set":3,"id":"22d22c88_81aa0fb6","line":89,"in_reply_to":"9275eaae_1b84463f","updated":"2026-05-29 14:41:31.000000000","message":"That did not include idrac_redfish. I will update the patch.","commit_id":"e06d834f492af1a30d138f9895f9bf67bf20e4cc"}],"ironic/conf/inspector.py":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"0b4a628d13ab1ea29200f9b6ca0b5814b3236b1c","unresolved":true,"context_lines":[{"line_number":79,"context_line":"               help\u003d_(\u0027Which MAC addresses from the inspected inventory to \u0027"},{"line_number":80,"context_line":"                      \u0027add as ports, applied by the \"ports\" inspection hook. \u0027"},{"line_number":81,"context_line":"                      \u0027This does not control the port pre-creation step; \u0027"},{"line_number":82,"context_line":"                      \u0027see [inspector]pre_create_ports.\u0027),"},{"line_number":83,"context_line":"               choices\u003dlist(VALID_ADD_PORTS_VALUES.items())),"},{"line_number":84,"context_line":"    cfg.StrOpt(\u0027keep_ports\u0027,"},{"line_number":85,"context_line":"               default\u003d\u0027all\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a272ade_32adc860","line":82,"updated":"2026-06-01 20:14:57.000000000","message":"I know the difference between this and pxe_create_ports, and it\u0027s still confusing. Is there anything we can do to this description to make it more clear?\n\nPerhaps (check this for correctness! I am confused and this may be a reflection of my confusion about the behavior):\n\n\"There are two ways to create ports, which can conflict if both methods attempt to add the same ports:\n- [inspector]add_ports will add ports discovered, regardless of method via the ports inspection hook.\n- [inspector]pre_create_ports will add ports found in the redfish controller before beginning any in-band inspection.\"\n\nI don\u0027t think we\u0027re going to be able to clearly describe what one does without also mentioning what the other does.","commit_id":"eb6a3b7c23750c28ee26fd3743d01e0ba8b9f5d9"},{"author":{"_account_id":36770,"name":"cid","display_name":"cid","email":"cid@gr-oss.io","username":"cidelight","status":"@gr-oss upstream: Doing good IRONIC things..."},"change_message_id":"65f1526ea5d9668f3cedb9183678530ab798b09f","unresolved":false,"context_lines":[{"line_number":79,"context_line":"               help\u003d_(\u0027Which MAC addresses from the inspected inventory to \u0027"},{"line_number":80,"context_line":"                      \u0027add as ports, applied by the \"ports\" inspection hook. \u0027"},{"line_number":81,"context_line":"                      \u0027This does not control the port pre-creation step; \u0027"},{"line_number":82,"context_line":"                      \u0027see [inspector]pre_create_ports.\u0027),"},{"line_number":83,"context_line":"               choices\u003dlist(VALID_ADD_PORTS_VALUES.items())),"},{"line_number":84,"context_line":"    cfg.StrOpt(\u0027keep_ports\u0027,"},{"line_number":85,"context_line":"               default\u003d\u0027all\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"7c711000_feda89f8","line":82,"in_reply_to":"3a272ade_32adc860","updated":"2026-06-09 17:47:15.000000000","message":"Acknowledged","commit_id":"eb6a3b7c23750c28ee26fd3743d01e0ba8b9f5d9"}]}