)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"change_message_id":"e757855767f45685889c5e29f11f19a826641d6c","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"95a170fe_0e7de890","updated":"2026-05-28 01:25:07.000000000","message":"I had forgotten about this. It was discussed that redfish shouldn\u0027t do this at all. This should be removed entirely and the ports inspection hook should be the behavior going forward. Now this might be the backportable / no behavior change but going forward this should absolutely not create these ports as they are slightly different than the inspected ones cause of different fix ups.\n\nThe problem is this same flag operates with the \u0027ports\u0027 hook so there\u0027s no way to disable it here and then use the \u0027ports\u0027 inspection hook.","commit_id":"b7f0c08a609d882275275da110f25fedcf165292"},{"author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"change_message_id":"1c6baf4363457248dd31dbac2748420e7001db51","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"0addc43a_8d19e6b5","updated":"2026-05-28 22:50:52.000000000","message":"Great change. Just fix up that comment.","commit_id":"e06d834f492af1a30d138f9895f9bf67bf20e4cc"},{"author":{"_account_id":36770,"name":"cid","display_name":"cid","email":"cid@gr-oss.io","username":"cidelight","status":"@gr-oss upstream: Doing good IRONIC things..."},"change_message_id":"2cc10fc3f0008218aead225e9f41d3467e5bf3e2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"6a35a808_1c89e94f","updated":"2026-05-29 14:45:38.000000000","message":"this patchset removes out-of-band port pre-creation from both redfish and idrac-redfish, leaving the ports hook as the sole port creator for them. I\u0027m confident from code, but want explicit confirmation before this merges, especially on idrac-redfish and most especially because of the comment: \"work around a bug in some versions of the firmware where the port state is not being reported correctly.\" which I believe  no longer applies but still need confirmation.","commit_id":"e06d834f492af1a30d138f9895f9bf67bf20e4cc"}],"doc/source/admin/inspection/hooks.rst":[{"author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"change_message_id":"6edb1f2f81a850d569c7d467d235da41be8f320d","unresolved":true,"context_lines":[{"line_number":86,"context_line":"    :oslo.config:option:`inspector.keep_ports` setting."},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    .. note::"},{"line_number":89,"context_line":"       The ``agent`` and ``idrac-redfish`` inspect interfaces also pre-create"},{"line_number":90,"context_line":"       ports from the MAC addresses reported by the BMC before inspection,"},{"line_number":91,"context_line":"       independently of this hook. For the ``agent`` interface this is"},{"line_number":92,"context_line":"       controlled by the"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9275eaae_1b84463f","line":89,"updated":"2026-05-28 19:23:05.000000000","message":"you removed redfish here so we should get rid of this comment.","commit_id":"e06d834f492af1a30d138f9895f9bf67bf20e4cc"},{"author":{"_account_id":36770,"name":"cid","display_name":"cid","email":"cid@gr-oss.io","username":"cidelight","status":"@gr-oss upstream: Doing good IRONIC things..."},"change_message_id":"2cd6e6ff1e7b238ccf0d284b06961132db11d81a","unresolved":true,"context_lines":[{"line_number":86,"context_line":"    :oslo.config:option:`inspector.keep_ports` setting."},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    .. note::"},{"line_number":89,"context_line":"       The ``agent`` and ``idrac-redfish`` inspect interfaces also pre-create"},{"line_number":90,"context_line":"       ports from the MAC addresses reported by the BMC before inspection,"},{"line_number":91,"context_line":"       independently of this hook. For the ``agent`` interface this is"},{"line_number":92,"context_line":"       controlled by the"}],"source_content_type":"text/x-rst","patch_set":3,"id":"22d22c88_81aa0fb6","line":89,"in_reply_to":"9275eaae_1b84463f","updated":"2026-05-29 14:41:31.000000000","message":"That did not include idrac_redfish. I will update the patch.","commit_id":"e06d834f492af1a30d138f9895f9bf67bf20e4cc"}]}