)]}'
{"ironic/api/controllers/v1/volume_target.py":[{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"7fad459333cd9c2ab4422437fe1436a34bdd5588","unresolved":true,"context_lines":[{"line_number":318,"context_line":"        if not policy.check_policy(\u0027baremetal:volume:view_target_properties\u0027,"},{"line_number":319,"context_line":"                                   cdict, cdict):"},{"line_number":320,"context_line":"            self._redact_target_properties(new_target)"},{"line_number":321,"context_line":""},{"line_number":322,"context_line":"        return convert_with_links(new_target)"},{"line_number":323,"context_line":""},{"line_number":324,"context_line":"    @METRICS.timer(\u0027VolumeTargetsController.patch\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"da43512a_af5da3ef","line":321,"updated":"2026-05-28 21:32:01.000000000","message":"They have literally just provided the properties attribute to create with this object. There is a risk this will break client code which consumes the response from this call and expects the properties to be there.\n\nHaving said that, creating a custom policy which allows creating volume targets but not viewing them would be extremely unlikely.","commit_id":"b9722137df9760aee93de9e664f2a876fcc6e67a"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"7fad459333cd9c2ab4422437fe1436a34bdd5588","unresolved":true,"context_lines":[{"line_number":409,"context_line":"        cdict \u003d api.request.context.to_policy_values()"},{"line_number":410,"context_line":"        if not policy.check_policy(\u0027baremetal:volume:view_target_properties\u0027,"},{"line_number":411,"context_line":"                                   cdict, cdict):"},{"line_number":412,"context_line":"            self._redact_target_properties(new_target)"},{"line_number":413,"context_line":""},{"line_number":414,"context_line":"        api_target \u003d convert_with_links(new_target)"},{"line_number":415,"context_line":"        notify.emit_end_notification(context, new_target, \u0027update\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"91ef0f02_5eab6b90","line":412,"updated":"2026-05-28 21:32:01.000000000","message":"Basically the same comment as above, but they may not have patched the properties","commit_id":"b9722137df9760aee93de9e664f2a876fcc6e67a"}]}