)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"0d38e78813228c4ef397d6067a72bbf18133bc9b","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Fix TARGET_SCHEMA bounds to prevent storage exhaustion (F-85)"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add explicit size limits to unbounded volume target fields in"},{"line_number":10,"context_line":"volume_target.py to mitigate Medium F-85."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Set extra and properties to maxProperties: 64"},{"line_number":13,"context_line":"Set node_uuid and volume_id to maxLength: 36"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"83464537_c6ad8817","line":10,"updated":"2026-05-28 22:36:33.000000000","message":"This reads like you are working off a security vulnerability list.\n\nPlease stop pushing security fixes publically and responsibly disclose them to the OpenStack VMT!\n\nFor actual code review feedback: \"medium F-38\" is not useful information for upstream.","commit_id":"ef9fd2a43ad21bcc6d35e5b86a5c412fd296d023"},{"author":{"_account_id":38267,"name":"Nuutti Hakala","display_name":"nuhakala","email":"nuutti.hakala@est.tech","username":"nuhakala"},"change_message_id":"30010fc645b2bd8e2bd089b5411536cb5b8d3111","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix TARGET_SCHEMA bounds to prevent storage exhaustion (F-85)"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add explicit size limits to unbounded volume target fields in"},{"line_number":10,"context_line":"volume_target.py to mitigate Medium F-85."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Set extra and properties to maxProperties: 64"},{"line_number":13,"context_line":"Set node_uuid and volume_id to maxLength: 36"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"e17cccd5_1257717b","line":10,"in_reply_to":"83464537_c6ad8817","updated":"2026-06-22 10:36:42.000000000","message":"Done","commit_id":"ef9fd2a43ad21bcc6d35e5b86a5c412fd296d023"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"9db82afd22d3320cfdfc955dea55c6abd1ae8e7f","unresolved":true,"context_lines":[{"line_number":13,"context_line":"attacks."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Closes-Bug: 2155050"},{"line_number":16,"context_line":"Change-Id: Iec0a7e783c6828a6abe31a2f721702b888ff1487"},{"line_number":17,"context_line":"Co-Authored-By: Nuutti Hakala \u003cnuutti.hakala@est.tech\u003e"},{"line_number":18,"context_line":"Signed-off-by: Saad Zia \u003csaad.zia@est.tech\u003e"},{"line_number":19,"context_line":"Signed-off-by: Nuutti Hakala \u003cnuutti.hakala@est.tech\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9043fc2e_a93ce91d","line":16,"updated":"2026-08-13 21:36:45.000000000","message":"Just double checking: this sorta change would be the kind many folks would wanna use an LLM to assist with. If you did it by hand, impressive and awesome. If you got some LLM help, please tag with assisted-by or generated-by.","commit_id":"664a029e570b658e67ef9f9f842ba60e0012a3fb"},{"author":{"_account_id":38267,"name":"Nuutti Hakala","display_name":"nuhakala","email":"nuutti.hakala@est.tech","username":"nuhakala"},"change_message_id":"827a5081f15979f1bbd3eeb06fa8699136f68ac1","unresolved":false,"context_lines":[{"line_number":13,"context_line":"attacks."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Closes-Bug: 2155050"},{"line_number":16,"context_line":"Change-Id: Iec0a7e783c6828a6abe31a2f721702b888ff1487"},{"line_number":17,"context_line":"Co-Authored-By: Nuutti Hakala \u003cnuutti.hakala@est.tech\u003e"},{"line_number":18,"context_line":"Signed-off-by: Saad Zia \u003csaad.zia@est.tech\u003e"},{"line_number":19,"context_line":"Signed-off-by: Nuutti Hakala \u003cnuutti.hakala@est.tech\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"fa79cc2b_b3ba509f","line":16,"in_reply_to":"9043fc2e_a93ce91d","updated":"2026-09-01 06:29:34.000000000","message":"Acknowledged","commit_id":"664a029e570b658e67ef9f9f842ba60e0012a3fb"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"15f6a130a48d86b52c02688a4678f32aaa9bb911","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"0bf4b5cd_b6311903","updated":"2026-05-28 22:35:17.000000000","message":"Please file security-impacting bugs responsibly, following the process here: https://security.openstack.org/reporting.html -- for Ironic this would be a launchpad bug, marked \"private security\" from the creation.","commit_id":"ef9fd2a43ad21bcc6d35e5b86a5c412fd296d023"},{"author":{"_account_id":38267,"name":"Nuutti Hakala","display_name":"nuhakala","email":"nuutti.hakala@est.tech","username":"nuhakala"},"change_message_id":"30010fc645b2bd8e2bd089b5411536cb5b8d3111","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7e966b87_0be572e9","in_reply_to":"0bf4b5cd_b6311903","updated":"2026-06-22 10:36:42.000000000","message":"Done","commit_id":"ef9fd2a43ad21bcc6d35e5b86a5c412fd296d023"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"ee5adaf3113162852e6c4c21ac12ba6ff9653feb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"84a4e486_53666033","updated":"2026-07-28 21:24:02.000000000","message":"Greetings Saad, could you please rebase this change? Thanks in advance!","commit_id":"fc9875ad5a1259a08b3aed71a069e82da62c9a0f"},{"author":{"_account_id":38267,"name":"Nuutti Hakala","display_name":"nuhakala","email":"nuutti.hakala@est.tech","username":"nuhakala"},"change_message_id":"30010fc645b2bd8e2bd089b5411536cb5b8d3111","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"73eca6e3_5e14aebd","updated":"2026-06-22 10:36:42.000000000","message":"I added a huge amount of validation to different fields as discussed in launchpad. Some of the new validation are most likely unnecessary and some might have too strict validation. I used the existing values as much as I could and also used the built-in format keyword where suitable.","commit_id":"fc9875ad5a1259a08b3aed71a069e82da62c9a0f"},{"author":{"_account_id":38267,"name":"Nuutti Hakala","display_name":"nuhakala","email":"nuutti.hakala@est.tech","username":"nuhakala"},"change_message_id":"cbe6e108eaa3a706188c7192aaafba28c470eb1f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"dc68086b_a8101267","in_reply_to":"84a4e486_53666033","updated":"2026-07-30 06:14:20.000000000","message":"We agreed with Saad that I take this over. It is now rebased.","commit_id":"fc9875ad5a1259a08b3aed71a069e82da62c9a0f"},{"author":{"_account_id":36770,"name":"cid","display_name":"cid","email":"cid@gr-oss.io","username":"cidelight","status":"@gr-oss upstream: Doing good IRONIC things..."},"change_message_id":"bf3a12fce47e736553d81a7a29e5920c1e258e90","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"28812c26_2c93e88a","updated":"2026-08-25 17:47:53.000000000","message":"GR-OSS group review session. Please re-add the tag once review feedback is addressed. Thanks","commit_id":"664a029e570b658e67ef9f9f842ba60e0012a3fb"},{"author":{"_account_id":36102,"name":"Adam McArthur","display_name":"Adam McArthur","email":"adam@mcaq.me","username":"adamcarthur","status":"PhD Candidate in Computational Imaging. Open Source Software Engineer at G-Research."},"change_message_id":"3c104ed62b2853231efa47e831e24f07169537b9","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"cae74483_2ad5f221","updated":"2026-08-15 04:17:18.000000000","message":"Hey folks,\n\nI am one of the developers working on migrating from the current API setup to https://opendev.org/openstack/ironic/src/branch/master/ironic/api/schemas\n\nThis is in an attempt to support OpenAPI specs: https://opendev.org/openstack/codegenerator\n\nYou can see the initial code here: https://review.opendev.org/c/openstack/ironic/+/928920, and the full work here: https://review.opendev.org/q/topic:%22openapi%22+project:openstack/ironic\n\nThis is mixing two separate efforts.\n\nSome of this hardening work may be useful, but it is not the schema migration needed for OpenAPI/codegenerator support. It mostly extends legacy args.schema validation and does not add the complete ironic.api.schemas.v1 request/response/path/query schemas, including microversion handling.\n\nIt does not complete the planned work for chassis, deploy templates, drivers, nodes, ports, ramdisk, or runbooks. Drivers are not covered at all.\n\nThe new limits are API behavior changes and need focused tests and review, especially for arbitrary driver/plugin data.\n\nI do not think this should merge in it\u0027s current form. Please split out any hardening work and continue the established schema migration pattern, rather than the legacy ones.","commit_id":"664a029e570b658e67ef9f9f842ba60e0012a3fb"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"9db82afd22d3320cfdfc955dea55c6abd1ae8e7f","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"36de9409_f930d5e5","updated":"2026-08-13 21:36:45.000000000","message":"This is a lot to review in a single change. I will have to dedicate a significant amount of time to validating it.\n\nTo make smaller amounts of progress more quickly, please break this up.","commit_id":"664a029e570b658e67ef9f9f842ba60e0012a3fb"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"afc1dc2fe62dba865d414ff7c20d6f8e8b38ca31","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"0cde2472_72406481","updated":"2026-08-13 22:19:00.000000000","message":"We are in the middle of a schema migration, using a method endorsed by the SDKs team to implement request and response body validation. I do not think this change should be merged in it\u0027s current form, instead, we need to complete that migration in order to have validation everywhere.","commit_id":"664a029e570b658e67ef9f9f842ba60e0012a3fb"},{"author":{"_account_id":38267,"name":"Nuutti Hakala","display_name":"nuhakala","email":"nuutti.hakala@est.tech","username":"nuhakala"},"change_message_id":"827a5081f15979f1bbd3eeb06fa8699136f68ac1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"4e39377c_662e123e","in_reply_to":"0cde2472_72406481","updated":"2026-09-01 06:29:34.000000000","message":"Acknowledged","commit_id":"664a029e570b658e67ef9f9f842ba60e0012a3fb"},{"author":{"_account_id":38267,"name":"Nuutti Hakala","display_name":"nuhakala","email":"nuutti.hakala@est.tech","username":"nuhakala"},"change_message_id":"827a5081f15979f1bbd3eeb06fa8699136f68ac1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"7d475704_0c0fca22","in_reply_to":"36de9409_f930d5e5","updated":"2026-09-01 06:29:34.000000000","message":"I will split this at some point.","commit_id":"664a029e570b658e67ef9f9f842ba60e0012a3fb"},{"author":{"_account_id":36102,"name":"Adam McArthur","display_name":"Adam McArthur","email":"adam@mcaq.me","username":"adamcarthur","status":"PhD Candidate in Computational Imaging. Open Source Software Engineer at G-Research."},"change_message_id":"2070d21fb4ea0515da53ddceab7f41049778d194","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"1ec339b0_bc8a2b01","in_reply_to":"70b0a341_9ae3be99","updated":"2026-09-02 04:08:58.000000000","message":"I personally would vote its done through the schemas? @jay@jvf.cc?","commit_id":"664a029e570b658e67ef9f9f842ba60e0012a3fb"},{"author":{"_account_id":38267,"name":"Nuutti Hakala","display_name":"nuhakala","email":"nuutti.hakala@est.tech","username":"nuhakala"},"change_message_id":"827a5081f15979f1bbd3eeb06fa8699136f68ac1","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"70b0a341_9ae3be99","in_reply_to":"cae74483_2ad5f221","updated":"2026-09-01 06:29:34.000000000","message":"Thanks for the feedback. When I started this, the schema migration was not so advanced yet and I ended up mixing the validation into API and schemas. However, now it is clearer and looks like we could do the validation either in schemas (schemas dir) or in the API level (controllers dir), but which is preferred?\n\nOnce this is sorted, I will split this changeset.","commit_id":"664a029e570b658e67ef9f9f842ba60e0012a3fb"}]}