)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"af09251ea0923d61faff34cefc71d3a8f32a5ca7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d711fbb4_90650761","updated":"2026-05-28 21:12:20.000000000","message":"Could there be unit tests on each of these 3 limits with assertions that the warning is being logged?","commit_id":"43b6ccc819e59d8ac7ded36c66962eb2e287b924"},{"author":{"_account_id":38267,"name":"Nuutti Hakala","display_name":"nuhakala","email":"nuutti.hakala@est.tech","username":"nuhakala"},"change_message_id":"b71ec8b04f11fe9cb4a7675e16faea5addaa3dd8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ba6e9588_c06585b1","in_reply_to":"9e8ae5db_d16c1f9d","updated":"2026-07-06 13:42:05.000000000","message":"Done","commit_id":"43b6ccc819e59d8ac7ded36c66962eb2e287b924"},{"author":{"_account_id":38267,"name":"Nuutti Hakala","display_name":"nuhakala","email":"nuutti.hakala@est.tech","username":"nuhakala"},"change_message_id":"5b1ac4fe32962630facabb53e89de3ec1b50ec89","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"9e8ae5db_d16c1f9d","in_reply_to":"d711fbb4_90650761","updated":"2026-07-06 13:41:42.000000000","message":"Added unit tests also.","commit_id":"43b6ccc819e59d8ac7ded36c66962eb2e287b924"}],"ironic/drivers/modules/inspector/hooks/parse_lldp.py":[{"author":{"_account_id":38267,"name":"Nuutti Hakala","display_name":"nuhakala","email":"nuutti.hakala@est.tech","username":"nuhakala"},"change_message_id":"05cf3019dec3e9af810377cb971c52f66e43173d","unresolved":true,"context_lines":[{"line_number":76,"context_line":""},{"line_number":77,"context_line":"        lldp_raw \u003d plugin_data.get(\u0027lldp_raw\u0027) or {}"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"        # Limit the possible interfaces. Each LLDPDU is associated with"},{"line_number":80,"context_line":"        # physical interface, so that creates a natural limit for the"},{"line_number":81,"context_line":"        # interfaces."},{"line_number":82,"context_line":"        _MAX_INTERFACES \u003d 64"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"        interfaces \u003d inventory[\u0027interfaces\u0027]"},{"line_number":85,"context_line":"        if len(interfaces) \u003e _MAX_INTERFACES:"}],"source_content_type":"text/x-python","patch_set":2,"id":"96ed1acf_957af048","line":82,"range":{"start_line":79,"start_character":0,"end_line":82,"end_character":28},"updated":"2026-07-06 13:40:51.000000000","message":"Correct limit for this depends on the hardware, and hence also depends where Ironic is deployed. I don\u0027t really know which kind of devices Ironic and IPA can manage, so 64 sounds like a reasonable limit to me. I know that there are devices with way more than 64 physical network ports, but can those devices run regular OS, and hence be managed by Ironic?","commit_id":"6285b6a36949eafab7ecf2e396abb13594a8cc2d"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"cfc69bba9648d368751f9c7c4ba48a1bba609957","unresolved":true,"context_lines":[{"line_number":76,"context_line":""},{"line_number":77,"context_line":"        lldp_raw \u003d plugin_data.get(\u0027lldp_raw\u0027) or {}"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"        # Limit the possible interfaces. Each LLDPDU is associated with"},{"line_number":80,"context_line":"        # physical interface, so that creates a natural limit for the"},{"line_number":81,"context_line":"        # interfaces."},{"line_number":82,"context_line":"        _MAX_INTERFACES \u003d 64"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"        interfaces \u003d inventory[\u0027interfaces\u0027]"},{"line_number":85,"context_line":"        if len(interfaces) \u003e _MAX_INTERFACES:"}],"source_content_type":"text/x-python","patch_set":2,"id":"1b45db71_3df316a4","line":82,"range":{"start_line":79,"start_character":0,"end_line":82,"end_character":28},"in_reply_to":"96ed1acf_957af048","updated":"2026-07-28 21:23:16.000000000","message":"I\u0027ve seen some hardware with far more interfaces, but typically that is just overcommittment or hardware which doesn\u0027t matter as much to the core use cases, i.e. switch like devices. I think the right thing here is to roll with it and if someone has issues, we can fix it.\n\nFWIW, If I had an average per node, its 6-12 interfaces.","commit_id":"6285b6a36949eafab7ecf2e396abb13594a8cc2d"}]}