)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"change_message_id":"c9ff32b03ded6bd9190b4ea84a348f78ba0b6d0e","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":7,"id":"4bddff20_aca19140","updated":"2026-08-04 05:08:17.000000000","message":"I would personally feel more comfortable with one more revision addressing the review comments and then we can merge.","commit_id":"a62522eaf78903e19fbdc3020ff14fddb638d360"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"4a32703a52fb5833c045506d21cc8b7c243a3670","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"72d547e6_a45e0594","updated":"2026-07-31 13:30:05.000000000","message":"LGTM. Some nits inline, if the patch merges as it is, please follow-up.","commit_id":"a62522eaf78903e19fbdc3020ff14fddb638d360"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"140175e1891b3a4c157232b572637d284fea4791","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"81c7622e_230120fa","updated":"2026-08-10 10:36:54.000000000","message":"Let\u0027s follow-up. We have 3+ patch series competing for the next API versions, and this is closest one.","commit_id":"a62522eaf78903e19fbdc3020ff14fddb638d360"},{"author":{"_account_id":38806,"name":"Konstantinos Karampogias","email":"kkarampo@redhat.com","username":"karampok","status":"Red Hat"},"change_message_id":"b1ec81dc3c96814ba98ba7cfa0b4e9cd80be01a3","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":7,"id":"c72a0612_6da632ed","updated":"2026-08-10 11:18:39.000000000","message":"Thank you for the feedback, just from PTO will take a look","commit_id":"a62522eaf78903e19fbdc3020ff14fddb638d360"}],"api-ref/source/baremetal-api-v1-nodes-firmware.inc":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"4a32703a52fb5833c045506d21cc8b7c243a3670","unresolved":true,"context_lines":[{"line_number":46,"context_line":"    - serial_number: firmware_component_serial_number"},{"line_number":47,"context_line":"    - vendor: firmware_component_vendor"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":".. note::"},{"line_number":50,"context_line":"   The ``vendor``, ``model``, and ``serial_number`` fields are included in"},{"line_number":51,"context_line":"   the response at API microversion 1.114 or higher.  For NIC components the"},{"line_number":52,"context_line":"   values are sourced from the Redfish ``NetworkAdapter`` resource; for BMC"}],"source_content_type":"text/x-c++src","patch_set":7,"id":"63eed5bb_feef3ecc","line":49,"updated":"2026-07-31 13:30:05.000000000","message":"We have a special tag `.. versionadded::` for these cases","commit_id":"a62522eaf78903e19fbdc3020ff14fddb638d360"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"91119fa94909bc1c4cf9dd921d6753a878de1102","unresolved":true,"context_lines":[{"line_number":46,"context_line":"    - serial_number: firmware_component_serial_number"},{"line_number":47,"context_line":"    - vendor: firmware_component_vendor"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":".. note::"},{"line_number":50,"context_line":"   The ``vendor``, ``model``, and ``serial_number`` fields are included in"},{"line_number":51,"context_line":"   the response at API microversion 1.114 or higher.  For NIC components the"},{"line_number":52,"context_line":"   values are sourced from the Redfish ``NetworkAdapter`` resource; for BMC"}],"source_content_type":"text/x-c++src","patch_set":7,"id":"eaac1afe_ded98404","line":49,"in_reply_to":"63eed5bb_feef3ecc","updated":"2026-08-03 21:32:05.000000000","message":"Yeah, Ideally we use that for consistency.","commit_id":"a62522eaf78903e19fbdc3020ff14fddb638d360"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"4a32703a52fb5833c045506d21cc8b7c243a3670","unresolved":true,"context_lines":[{"line_number":51,"context_line":"   the response at API microversion 1.114 or higher.  For NIC components the"},{"line_number":52,"context_line":"   values are sourced from the Redfish ``NetworkAdapter`` resource; for BMC"},{"line_number":53,"context_line":"   components only ``model`` is populated from ``Manager.Model``; all three"},{"line_number":54,"context_line":"   fields are ``null`` for BIOS components."},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"**Example list of a Node\u0027s Firmware Components (starting with API microversion 1.114):**"},{"line_number":57,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":7,"id":"f004e266_78e8e9bf","line":54,"updated":"2026-07-31 13:30:05.000000000","message":"Let\u0027s not have Redfish-specific comments in the generic API. Instead, let\u0027s explicitly say that these values are specific to both the node driver and the hardware model and vendor.","commit_id":"a62522eaf78903e19fbdc3020ff14fddb638d360"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"91119fa94909bc1c4cf9dd921d6753a878de1102","unresolved":true,"context_lines":[{"line_number":51,"context_line":"   the response at API microversion 1.114 or higher.  For NIC components the"},{"line_number":52,"context_line":"   values are sourced from the Redfish ``NetworkAdapter`` resource; for BMC"},{"line_number":53,"context_line":"   components only ``model`` is populated from ``Manager.Model``; all three"},{"line_number":54,"context_line":"   fields are ``null`` for BIOS components."},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"**Example list of a Node\u0027s Firmware Components (starting with API microversion 1.114):**"},{"line_number":57,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":7,"id":"fface385_422fa5d3","line":54,"in_reply_to":"f004e266_78e8e9bf","updated":"2026-08-03 21:32:05.000000000","message":"++","commit_id":"a62522eaf78903e19fbdc3020ff14fddb638d360"}],"api-ref/source/parameters.yaml":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"4a32703a52fb5833c045506d21cc8b7c243a3670","unresolved":true,"context_lines":[{"line_number":1093,"context_line":"  type: string"},{"line_number":1094,"context_line":"firmware_component_model:"},{"line_number":1095,"context_line":"  description: |"},{"line_number":1096,"context_line":"    The hardware model of a Firmware Component, sourced from the Redfish"},{"line_number":1097,"context_line":"    ``NetworkAdapter.Model`` (NICs) or ``Manager.Model`` (BMC) resource."},{"line_number":1098,"context_line":"    ``null`` when not available (BIOS)."},{"line_number":1099,"context_line":"    Available starting with API microversion 1.114."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"5e48d9fe_d3f99632","line":1096,"updated":"2026-07-31 13:30:05.000000000","message":"Since it\u0027s generic API, replace \"sourced from\" with \"for example\" (same below)","commit_id":"a62522eaf78903e19fbdc3020ff14fddb638d360"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"91119fa94909bc1c4cf9dd921d6753a878de1102","unresolved":true,"context_lines":[{"line_number":1093,"context_line":"  type: string"},{"line_number":1094,"context_line":"firmware_component_model:"},{"line_number":1095,"context_line":"  description: |"},{"line_number":1096,"context_line":"    The hardware model of a Firmware Component, sourced from the Redfish"},{"line_number":1097,"context_line":"    ``NetworkAdapter.Model`` (NICs) or ``Manager.Model`` (BMC) resource."},{"line_number":1098,"context_line":"    ``null`` when not available (BIOS)."},{"line_number":1099,"context_line":"    Available starting with API microversion 1.114."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"1bb421e5_66c32412","line":1096,"in_reply_to":"5e48d9fe_d3f99632","updated":"2026-08-03 21:32:05.000000000","message":"++","commit_id":"a62522eaf78903e19fbdc3020ff14fddb638d360"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"91119fa94909bc1c4cf9dd921d6753a878de1102","unresolved":true,"context_lines":[{"line_number":1102,"context_line":"  type: string"},{"line_number":1103,"context_line":"firmware_component_serial_number:"},{"line_number":1104,"context_line":"  description: |"},{"line_number":1105,"context_line":"    The serial number of a Firmware Component, sourced from the Redfish"},{"line_number":1106,"context_line":"    ``NetworkAdapter.SerialNumber`` resource. ``null`` for BMC and BIOS"},{"line_number":1107,"context_line":"    components, and for NICs that do not expose a serial number."},{"line_number":1108,"context_line":"    Available starting with API microversion 1.114."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"60b1d0bf_db11f97d","line":1105,"updated":"2026-08-03 21:32:05.000000000","message":"Same for here.","commit_id":"a62522eaf78903e19fbdc3020ff14fddb638d360"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"91119fa94909bc1c4cf9dd921d6753a878de1102","unresolved":true,"context_lines":[{"line_number":1111,"context_line":"  type: string"},{"line_number":1112,"context_line":"firmware_component_vendor:"},{"line_number":1113,"context_line":"  description: |"},{"line_number":1114,"context_line":"    The hardware vendor of a Firmware Component, sourced from the Redfish"},{"line_number":1115,"context_line":"    ``NetworkAdapter.Manufacturer`` (NICs) or ``Manager`` (BMC) resource."},{"line_number":1116,"context_line":"    ``null`` when not available (BIOS, BMC without manufacturer data)."},{"line_number":1117,"context_line":"    Available starting with API microversion 1.114."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"5a245a63_18ac3cc1","line":1114,"range":{"start_line":1114,"start_character":66,"end_line":1114,"end_character":73},"updated":"2026-08-03 21:32:05.000000000","message":"and here.","commit_id":"a62522eaf78903e19fbdc3020ff14fddb638d360"}],"ironic/drivers/modules/redfish/firmware.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"afec27ff1fbff5a00b3d97706163ba3286cec59b","unresolved":false,"context_lines":[{"line_number":235,"context_line":""},{"line_number":236,"context_line":"                net_adp_fw \u003d {"},{"line_number":237,"context_line":"                    \u0027component\u0027: redfish_utils.NIC_COMPONENT_PREFIX"},{"line_number":238,"context_line":"                                 + net_adp_id,"},{"line_number":239,"context_line":"                    \u0027current_version\u0027: fw_pkg_v,"},{"line_number":240,"context_line":"                    \u0027vendor\u0027: net_adp.manufacturer,"},{"line_number":241,"context_line":"                    \u0027model\u0027: net_adp.model,"}],"source_content_type":"text/x-python","patch_set":2,"id":"e330fe57_95dd9539","line":238,"updated":"2026-06-08 12:01:47.000000000","message":"pep8: E131 continuation line unaligned for hanging indent","commit_id":"d8ecfd7113eeaedf4d2c9bc808b5934388dc24f5"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"838abe07ca35035d69f789f88cfdafab100e211d","unresolved":false,"context_lines":[{"line_number":235,"context_line":""},{"line_number":236,"context_line":"                net_adp_fw \u003d {"},{"line_number":237,"context_line":"                    \u0027component\u0027: (redfish_utils.NIC_COMPONENT_PREFIX"},{"line_number":238,"context_line":"                                 + net_adp_id),"},{"line_number":239,"context_line":"                    \u0027current_version\u0027: fw_pkg_v,"},{"line_number":240,"context_line":"                    \u0027vendor\u0027: net_adp.manufacturer,"},{"line_number":241,"context_line":"                    \u0027model\u0027: net_adp.model,"}],"source_content_type":"text/x-python","patch_set":3,"id":"2c31e092_b29b8f35","line":238,"updated":"2026-06-08 15:08:12.000000000","message":"pep8: E128 continuation line under-indented for visual indent","commit_id":"ab3fea34ef4564eb588de0cd79f90afb61fe756e"}]}