)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"1720a86ce0fe74cc94d410f8024c7fa6d0ab8e35","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Add kernel parameter parsing to create_boot_iso"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"create_boot_iso will now raise InvalidParameterValue if the kernel"},{"line_number":10,"context_line":"parameters arguments contains invalid input. Downstream functions have"},{"line_number":11,"context_line":"been updated to accept parsed parameters as arguments instead of lists"},{"line_number":12,"context_line":"of strings."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"12b176c1_84ab4e1b","line":10,"range":{"start_line":10,"start_character":45,"end_line":10,"end_character":65},"updated":"2026-06-13 03:20:57.000000000","message":"I`m a bit lost with this part \"Downstream functions..\" 😅","commit_id":"a333ddd64d45a42eb000f60708095dcef73c2086"},{"author":{"_account_id":14228,"name":"Clif Houck","email":"me@clifhouck.com","username":"clif_h"},"change_message_id":"13053ff3d7d025ef95ddd13d0697bd0ba5ba5e26","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add kernel parameter parsing to create_boot_iso"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"create_boot_iso will now raise InvalidParameterValue if the kernel"},{"line_number":10,"context_line":"parameters arguments contains invalid input. Downstream functions have"},{"line_number":11,"context_line":"been updated to accept parsed parameters as arguments instead of lists"},{"line_number":12,"context_line":"of strings."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"a0332464_053ed79a","line":10,"range":{"start_line":10,"start_character":45,"end_line":10,"end_character":65},"in_reply_to":"12b176c1_84ab4e1b","updated":"2026-06-29 22:19:27.000000000","message":"Reworked the commit message to be more explicit about what changed.","commit_id":"a333ddd64d45a42eb000f60708095dcef73c2086"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"8a03bdacd2e079a332e20b01152a17e1265db0bf","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"ec0b14f5_7ecffee7","updated":"2026-07-07 18:14:07.000000000","message":"Ideally for a change that touches this many deployment toggles, we would ensure CI passes at least once for all non-voting jobs as well. Right now two are failing.","commit_id":"3cefa6277b68432e8a9a2cd715e343f838d803a3"},{"author":{"_account_id":14228,"name":"Clif Houck","email":"me@clifhouck.com","username":"clif_h"},"change_message_id":"ff330e4f8148721f3682f660486057111ec536ea","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"fc7ed413_d7f802ae","updated":"2026-07-27 16:45:17.000000000","message":"recheck","commit_id":"3cefa6277b68432e8a9a2cd715e343f838d803a3"}],"ironic/common/images.py":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"303a1b936d69d7728eb42ba8f66e124da06fc926","unresolved":true,"context_lines":[{"line_number":664,"context_line":"        for each hardware architecture to boot. This image will be written"},{"line_number":665,"context_line":"        onto the ISO image. If not specified, the `deploy_iso_href` option"},{"line_number":666,"context_line":"        is only required for building UEFI-bootable ISO."},{"line_number":667,"context_line":"    :param kernel_params: a string containing whitespace separated values"},{"line_number":668,"context_line":"        kernel cmdline arguments of the form K\u003dV or K (optional)."},{"line_number":669,"context_line":"    :boot_mode: the boot mode in which the deploy is to happen."},{"line_number":670,"context_line":"    :param inject_files: Mapping of local source file paths to their location"}],"source_content_type":"text/x-python","patch_set":2,"id":"ece3f5d6_519a0716","line":667,"updated":"2026-06-10 17:39:40.000000000","message":"I was kinda surprised there\u0027s nothing in this chain that ensures all method inputs of kernel params are passed as KernelCommandLine objects","commit_id":"a333ddd64d45a42eb000f60708095dcef73c2086"},{"author":{"_account_id":14228,"name":"Clif Houck","email":"me@clifhouck.com","username":"clif_h"},"change_message_id":"13053ff3d7d025ef95ddd13d0697bd0ba5ba5e26","unresolved":false,"context_lines":[{"line_number":664,"context_line":"        for each hardware architecture to boot. This image will be written"},{"line_number":665,"context_line":"        onto the ISO image. If not specified, the `deploy_iso_href` option"},{"line_number":666,"context_line":"        is only required for building UEFI-bootable ISO."},{"line_number":667,"context_line":"    :param kernel_params: a string containing whitespace separated values"},{"line_number":668,"context_line":"        kernel cmdline arguments of the form K\u003dV or K (optional)."},{"line_number":669,"context_line":"    :boot_mode: the boot mode in which the deploy is to happen."},{"line_number":670,"context_line":"    :param inject_files: Mapping of local source file paths to their location"}],"source_content_type":"text/x-python","patch_set":2,"id":"9c5451bd_06799210","line":667,"in_reply_to":"ece3f5d6_519a0716","updated":"2026-06-29 22:19:27.000000000","message":"That\u0027s fair. I\u0027ll re-work this commit to do parameter parsing higher in the chain.","commit_id":"a333ddd64d45a42eb000f60708095dcef73c2086"}],"ironic/drivers/modules/image_utils.py":[{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"3e951825753ea4ee30ae2b882140b30332278595","unresolved":true,"context_lines":[{"line_number":494,"context_line":"                    for kv in params.items())))"},{"line_number":495,"context_line":""},{"line_number":496,"context_line":"        # NOTE(clif): Raises InvalidParameterValue if params fail to parse."},{"line_number":497,"context_line":"        kernel_cmd_line \u003d kp.KernelCommandLine.parse(kernel_params)"},{"line_number":498,"context_line":""},{"line_number":499,"context_line":"        LOG.debug("},{"line_number":500,"context_line":"            \"Trying to create %(boot_mode)s ISO image for node %(node)s \""}],"source_content_type":"text/x-python","patch_set":3,"id":"43e6984b_f99ce08f","line":497,"updated":"2026-06-30 01:02:43.000000000","message":"My comment in the previous change in this series about only parsing when CONF.conductor.disable_kernel_parameter_parsing \u003d\u003d True would apply here too and for the following changes in this series.","commit_id":"c1967728dd93e701fd1f3c3269f9e3fded3cce90"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"0cf56d05bc4c0b242483e74eb86cc120572dac14","unresolved":true,"context_lines":[{"line_number":494,"context_line":"                    for kv in params.items())))"},{"line_number":495,"context_line":""},{"line_number":496,"context_line":"        # NOTE(clif): Raises InvalidParameterValue if params fail to parse."},{"line_number":497,"context_line":"        kernel_cmd_line \u003d kp.KernelCommandLine.parse(kernel_params)"},{"line_number":498,"context_line":""},{"line_number":499,"context_line":"        LOG.debug("},{"line_number":500,"context_line":"            \"Trying to create %(boot_mode)s ISO image for node %(node)s \""}],"source_content_type":"text/x-python","patch_set":3,"id":"53f01943_edaee250","line":497,"in_reply_to":"43e6984b_f99ce08f","updated":"2026-06-30 02:16:56.000000000","message":"A suggestion: maybe put a deprecation date on that toggle, as part of this series, with a request for folks with need for it to file bugs?","commit_id":"c1967728dd93e701fd1f3c3269f9e3fded3cce90"},{"author":{"_account_id":14228,"name":"Clif Houck","email":"me@clifhouck.com","username":"clif_h"},"change_message_id":"7c6525c1bfa56bd61aa283b40ef2a49dbecd2ec8","unresolved":false,"context_lines":[{"line_number":494,"context_line":"                    for kv in params.items())))"},{"line_number":495,"context_line":""},{"line_number":496,"context_line":"        # NOTE(clif): Raises InvalidParameterValue if params fail to parse."},{"line_number":497,"context_line":"        kernel_cmd_line \u003d kp.KernelCommandLine.parse(kernel_params)"},{"line_number":498,"context_line":""},{"line_number":499,"context_line":"        LOG.debug("},{"line_number":500,"context_line":"            \"Trying to create %(boot_mode)s ISO image for node %(node)s \""}],"source_content_type":"text/x-python","patch_set":3,"id":"621e3269_760c397c","line":497,"in_reply_to":"53f01943_edaee250","updated":"2026-07-06 15:33:14.000000000","message":"Done","commit_id":"c1967728dd93e701fd1f3c3269f9e3fded3cce90"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"8a03bdacd2e079a332e20b01152a17e1265db0bf","unresolved":true,"context_lines":[{"line_number":559,"context_line":"                               kp.ParameterValue(\u0027\u0027)))"},{"line_number":560,"context_line":""},{"line_number":561,"context_line":"        unstructured_params.append("},{"line_number":562,"context_line":"                kp.UnstructuredParameters("},{"line_number":563,"context_line":"                    node.instance_info.get(\"ramdisk_kernel_arguments\", \"\")))"},{"line_number":564,"context_line":"    else:"},{"line_number":565,"context_line":"        unstructured_params.append("}],"source_content_type":"text/x-python","patch_set":5,"id":"e843f2ae_fde45719","line":562,"updated":"2026-07-07 18:14:07.000000000","message":"nit: the indentation is weird here versus code above and below","commit_id":"3cefa6277b68432e8a9a2cd715e343f838d803a3"}]}