)]}'
{"ironic/drivers/modules/deploy_utils.py":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"9dd5aaf1b14c25a8bc01f8f4c57acf3a112010fe","unresolved":false,"context_lines":[{"line_number":356,"context_line":"    discovery(address, port)"},{"line_number":357,"context_line":"    login_iscsi(address, port, iqn)"},{"line_number":358,"context_line":""},{"line_number":359,"context_line":"    LOG.info(_(\u0027Logged in to disk %(dev)s$\u0027) % {\u0027dev\u0027: dev})"},{"line_number":360,"context_line":""},{"line_number":361,"context_line":"    try:"},{"line_number":362,"context_line":"        root_uuid \u003d work_on_disk(dev, root_mb, swap_mb, ephemeral_mb,"}],"source_content_type":"text/x-python","patch_set":4,"id":"1ae5cdf2_1f1e1abb","line":359,"updated":"2014-06-13 21:29:45.000000000","message":"Probably want to mention something about this being iscsi? Logged into disk just sounds strange IMO.","commit_id":"d4128f3a8a63455bd75d21732378cce2250b9aa4"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"338de0b3ecdd2faedd5ff74f7d339fc025000b1f","unresolved":false,"context_lines":[{"line_number":357,"context_line":"    discovery(address, port)"},{"line_number":358,"context_line":"    login_iscsi(address, port, iqn)"},{"line_number":359,"context_line":""},{"line_number":360,"context_line":"    LOG.info(_(\u0027Logged in to iSCSI target %(dev)s$\u0027) % {\u0027dev\u0027: dev})"},{"line_number":361,"context_line":""},{"line_number":362,"context_line":"    try:"},{"line_number":363,"context_line":"        root_uuid \u003d work_on_disk(dev, root_mb, swap_mb, ephemeral_mb,"}],"source_content_type":"text/x-python","patch_set":5,"id":"1ae5cdf2_1970cc72","line":360,"updated":"2014-06-16 13:20:22.000000000","message":"I vote for this to be debug","commit_id":"6dc5bb31675dacd3ac92e615612db97aaf06d8d6"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"67002410788a89429d87e47b00ce01a53905b712","unresolved":false,"context_lines":[{"line_number":125,"context_line":"    if commit:"},{"line_number":126,"context_line":"        # write to the disk"},{"line_number":127,"context_line":"        dp.commit()"},{"line_number":128,"context_line":"        LOG.info(_LI(\u0027Created and wrote partitions to device %(dev)s. \u0027"},{"line_number":129,"context_line":"                     \u0027root: %(root)d MiB, swap: %(swap)d MiB, ephemeral: \u0027"},{"line_number":130,"context_line":"                   \u0027%(eph)d MiB.\u0027), {\u0027dev\u0027: dev,"},{"line_number":131,"context_line":"                                     \u0027root\u0027: root_mb,"}],"source_content_type":"text/x-python","patch_set":6,"id":"1ae5cdf2_e8b20c05","line":128,"updated":"2014-06-25 19:12:22.000000000","message":"This is too granular for INFO level. It\u0027s not a \"unit of work\" -- we should log once when the deploy completes, not multiple times for each step of the deploy","commit_id":"37424334237b9fcb9ffa8b7958288663193e3476"}],"ironic/drivers/modules/ipminative.py":[{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"67002410788a89429d87e47b00ce01a53905b712","unresolved":false,"context_lines":[{"line_number":255,"context_line":"                \"set_power_state called with an invalid power state: %s.\""},{"line_number":256,"context_line":"                ) % pstate)"},{"line_number":257,"context_line":""},{"line_number":258,"context_line":"        LOG.info(_LI(\"Node %(node)s successfully set to state %(state)s.\"),"},{"line_number":259,"context_line":"                 {\u0027node\u0027: driver_info[\u0027uuid\u0027], \u0027state\u0027: pstate})"},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"    @task_manager.require_exclusive_lock"}],"source_content_type":"text/x-python","patch_set":6,"id":"1ae5cdf2_c8d47021","line":258,"updated":"2014-06-25 19:12:22.000000000","message":"These should be logged in a common place, not within each driver. See ironic/conductor/utils.py","commit_id":"37424334237b9fcb9ffa8b7958288663193e3476"}]}