)]}'
{"id":"openstack%2Fjs-openstack-lib~342282","triplet_id":"openstack%2Fjs-openstack-lib~master~I159d93b37388e3c6884f81a8e6026a514351b71d","project":"openstack/js-openstack-lib","branch":"master","topic":"neverland","hashtags":[],"change_id":"I159d93b37388e3c6884f81a8e6026a514351b71d","subject":"Added node-fetch","status":"MERGED","created":"2016-07-14 16:55:28.000000000","updated":"2016-07-21 14:22:28.000000000","submitted":"2016-07-21 14:22:28.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"86981b8a5b3edf08ac5323fe127782837df31da9","_number":342282,"virtual_id_number":342282,"owner":{"_account_id":8735,"name":"Vitaly Kramskikh","email":"vkramskikh@mirantis.com","username":"vkramskikh"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2016-07-21 14:22:27.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":9717,"name":"Michael Krotscheck","email":"krotscheck@gmail.com","username":"krotscheck"},{"value":0,"_account_id":8614,"name":"Corentin Ardeois","email":"corentin.ardeois@gmail.com","username":"cardeois"},{"value":0,"_account_id":8735,"name":"Vitaly Kramskikh","email":"vkramskikh@mirantis.com","username":"vkramskikh"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":9717,"name":"Michael Krotscheck","email":"krotscheck@gmail.com","username":"krotscheck"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2016-07-20 13:51:05.000000000","_account_id":9717,"name":"Michael Krotscheck","email":"krotscheck@gmail.com","username":"krotscheck"},{"value":-1,"date":"2016-07-21 14:19:24.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":8614,"name":"Corentin Ardeois","email":"corentin.ardeois@gmail.com","username":"cardeois"},{"value":0,"_account_id":8735,"name":"Vitaly Kramskikh","email":"vkramskikh@mirantis.com","username":"vkramskikh"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":8735,"name":"Vitaly Kramskikh","email":"vkramskikh@mirantis.com","username":"vkramskikh"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":9717,"name":"Michael Krotscheck","email":"krotscheck@gmail.com","username":"krotscheck"},{"value":0,"_account_id":8614,"name":"Corentin Ardeois","email":"corentin.ardeois@gmail.com","username":"cardeois"},{"value":1,"date":"2016-07-20 14:16:30.000000000","_account_id":8735,"name":"Vitaly Kramskikh","email":"vkramskikh@mirantis.com","username":"vkramskikh"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":8614,"name":"Corentin Ardeois","email":"corentin.ardeois@gmail.com","username":"cardeois"},{"_account_id":8735,"name":"Vitaly Kramskikh","email":"vkramskikh@mirantis.com","username":"vkramskikh"},{"_account_id":9717,"name":"Michael Krotscheck","email":"krotscheck@gmail.com","username":"krotscheck"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-07-19 19:06:27.000000000","updated_by":{"_account_id":9717,"name":"Michael Krotscheck","email":"krotscheck@gmail.com","username":"krotscheck"},"reviewer":{"_account_id":9717,"name":"Michael Krotscheck","email":"krotscheck@gmail.com","username":"krotscheck"},"state":"REVIEWER"},{"updated":"2016-07-21 14:19:24.000000000","updated_by":{"_account_id":8614,"name":"Corentin Ardeois","email":"corentin.ardeois@gmail.com","username":"cardeois"},"reviewer":{"_account_id":8614,"name":"Corentin Ardeois","email":"corentin.ardeois@gmail.com","username":"cardeois"},"state":"REVIEWER"},{"updated":"2016-07-21 14:22:27.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"ce9ead49ec20c99592cad3fdd5a88c4b1d6305cd","author":{"_account_id":8735,"name":"Vitaly Kramskikh","email":"vkramskikh@mirantis.com","username":"vkramskikh"},"date":"2016-07-14 16:55:28.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"ddd5adb3daed9792129c70179f502a92e1503cc0","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-07-14 17:33:19.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-js-openstack-lib-npm-run-lint http://logs.openstack.org/82/342282/1/check/gate-js-openstack-lib-npm-run-lint/9436323/ : SUCCESS in 6m 32s\n- gate-js-openstack-lib-npm-run-test http://logs.openstack.org/82/342282/1/check/gate-js-openstack-lib-npm-run-test/9d9006d/ : SUCCESS in 6m 20s","accounts_in_message":[],"_revision_number":1},{"id":"e58bda95cc725e8ad90e32e1f5dca86afe453732","author":{"_account_id":8614,"name":"Corentin Ardeois","email":"corentin.ardeois@gmail.com","username":"cardeois"},"date":"2016-07-18 17:12:47.000000000","message":"Patch Set 1:\n\nWhat about the test? Can you add one that mocks node-fetch?\nIt would be nice to introduce the proper way to mock fetch calls with this review.","accounts_in_message":[],"_revision_number":1},{"id":"0ff7abdc92192770dc221b8b557878cd59184ecd","author":{"_account_id":9717,"name":"Michael Krotscheck","email":"krotscheck@gmail.com","username":"krotscheck"},"date":"2016-07-19 19:06:27.000000000","message":"Patch Set 1: Code-Review+2\n\n@Corentin: Sounds like you just volunteered ;)","accounts_in_message":[],"_revision_number":1},{"id":"98ba837517a99f6e75d1e2fb2b8fd15d50cc3011","author":{"_account_id":9717,"name":"Michael Krotscheck","email":"krotscheck@gmail.com","username":"krotscheck"},"date":"2016-07-20 13:21:05.000000000","message":"Patch Set 1: Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"f451f938f10b13713a849c3da797c398bf1af8ce","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-07-20 13:39:26.000000000","message":"Patch Set 1: Verified-1\n\nMerge Failed.\n\nThis change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.","accounts_in_message":[],"_revision_number":1},{"id":"590859583f4001ae30f8764f03fe083fd36ab1a9","author":{"_account_id":8735,"name":"Vitaly Kramskikh","email":"vkramskikh@mirantis.com","username":"vkramskikh"},"date":"2016-07-20 13:51:05.000000000","message":"Patch Set 2: Patch Set 1 was rebased","accounts_in_message":[],"_revision_number":1},{"id":"dce5c4174b239b09f64d2a6c724a28d4d690215d","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-07-20 14:16:06.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-js-openstack-lib-npm-run-lint http://logs.openstack.org/82/342282/2/check/gate-js-openstack-lib-npm-run-lint/e0db243/ : SUCCESS in 4m 42s\n- gate-js-openstack-lib-npm-run-test http://logs.openstack.org/82/342282/2/check/gate-js-openstack-lib-npm-run-test/e2d9f81/ : SUCCESS in 6m 16s","accounts_in_message":[],"_revision_number":2},{"id":"0ee42e8a3a8cb3dccfe235f96bf5cd3316d2d694","author":{"_account_id":8735,"name":"Vitaly Kramskikh","email":"vkramskikh@mirantis.com","username":"vkramskikh"},"date":"2016-07-20 14:16:30.000000000","message":"Patch Set 2: Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"39e9903ab2eb6f172931b419075983b215e9fa44","author":{"_account_id":8614,"name":"Corentin Ardeois","email":"corentin.ardeois@gmail.com","username":"cardeois"},"date":"2016-07-20 20:43:54.000000000","message":"Patch Set 2:\n\nI tried to run `npm run test:browser` but I have a warning similar to this:\nhttps://github.com/bitinn/node-fetch/issues/24\n\nnode-fetch is not compatible with webpack, so we need to use the polyfill instead. However it looks like isomorphic-fetch does that already, so maybe we should go back on our decision and use isomorphic-fetch?","accounts_in_message":[],"_revision_number":2},{"id":"c4546abcb4f6dfdbf6831c3f7f4551d6a0f91773","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-07-21 14:08:24.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"5e175525082ac7a5c3a5881a8514b7d5c563899a","author":{"_account_id":8614,"name":"Corentin Ardeois","email":"corentin.ardeois@gmail.com","username":"cardeois"},"date":"2016-07-21 14:19:24.000000000","message":"Patch Set 2: Code-Review-1\n\nWebpack version is not working properly with node-fetch, tests are not breaking because we don\u0027t actually call \"fetch\", in them, but there webpack errors in the console when running them","accounts_in_message":[],"_revision_number":2},{"id":"2380118dbcedbcf4de1d8ef8d72a27c015f2a5c6","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-07-21 14:22:27.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-js-openstack-lib-nodejs4-npm-run-lint http://logs.openstack.org/82/342282/2/gate/gate-js-openstack-lib-nodejs4-npm-run-lint/a2a9720/ : SUCCESS in 6m 28s\n- gate-js-openstack-lib-nodejs4-npm-run-test http://logs.openstack.org/82/342282/2/gate/gate-js-openstack-lib-nodejs4-npm-run-test/9bc8a10/ : SUCCESS in 8m 52s","accounts_in_message":[],"_revision_number":2},{"id":"66d571fdeb64da6a17929ecead1d09603e3f7fe5","date":"2016-07-21 14:22:28.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"fd53f563e25464cf8e231384a258c068adc419d2","revisions":{"a24637ecbf790a10c05ea5f0af071a6bb544199e":{"kind":"REWORK","_number":1,"created":"2016-07-14 16:55:28.000000000","uploader":{"_account_id":8735,"name":"Vitaly Kramskikh","email":"vkramskikh@mirantis.com","username":"vkramskikh"},"ref":"refs/changes/82/342282/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/js-openstack-lib","ref":"refs/changes/82/342282/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/js-openstack-lib refs/changes/82/342282/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/js-openstack-lib refs/changes/82/342282/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/js-openstack-lib refs/changes/82/342282/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/js-openstack-lib refs/changes/82/342282/1"}}},"commit":{"parents":[{"commit":"096eebdcad8bc24d4902deff1ff8102c8cc443da","subject":"Added Istanbul integration","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/js-openstack-lib/commit/096eebdcad8bc24d4902deff1ff8102c8cc443da"}]}],"author":{"name":"Vitaly Kramskikh","email":"vkramskikh@mirantis.com","date":"2016-07-14 16:53:38.000000000","tz":180},"committer":{"name":"Vitaly Kramskikh","email":"vkramskikh@mirantis.com","date":"2016-07-14 16:53:38.000000000","tz":180},"subject":"Added node-fetch","message":"Added node-fetch\n\nThis commit adds a node-fetch library to dependencies and adds\na simple method to the Test class which calls it with provided\narguments.\n\nChange-Id: I159d93b37388e3c6884f81a8e6026a514351b71d\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/js-openstack-lib/commit/a24637ecbf790a10c05ea5f0af071a6bb544199e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/js-openstack-lib/commit/a24637ecbf790a10c05ea5f0af071a6bb544199e"}]},"branch":"refs/heads/master"},"fd53f563e25464cf8e231384a258c068adc419d2":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2016-07-20 13:51:05.000000000","uploader":{"_account_id":8735,"name":"Vitaly Kramskikh","email":"vkramskikh@mirantis.com","username":"vkramskikh"},"ref":"refs/changes/82/342282/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/js-openstack-lib","ref":"refs/changes/82/342282/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/js-openstack-lib refs/changes/82/342282/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/js-openstack-lib refs/changes/82/342282/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/js-openstack-lib refs/changes/82/342282/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/js-openstack-lib refs/changes/82/342282/2"}}},"commit":{"parents":[{"commit":"e8d39a47475a6452bda81f6559ad5a26de45d03f","subject":"Added Istanbul integration","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/js-openstack-lib/commit/e8d39a47475a6452bda81f6559ad5a26de45d03f"}]}],"author":{"name":"Vitaly Kramskikh","email":"vkramskikh@mirantis.com","date":"2016-07-14 16:53:38.000000000","tz":180},"committer":{"name":"Vitaly Kramskikh","email":"vkramskikh@mirantis.com","date":"2016-07-20 13:51:05.000000000","tz":0},"subject":"Added node-fetch","message":"Added node-fetch\n\nThis commit adds a node-fetch library to dependencies and adds\na simple method to the Test class which calls it with provided\narguments.\n\nChange-Id: I159d93b37388e3c6884f81a8e6026a514351b71d\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/js-openstack-lib/commit/fd53f563e25464cf8e231384a258c068adc419d2"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/js-openstack-lib/commit/fd53f563e25464cf8e231384a258c068adc419d2"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}