)]}'
{"src/util/version.js":[{"author":{"_account_id":8614,"name":"Corentin Ardeois","email":"corentin.ardeois@gmail.com","username":"cardeois"},"change_message_id":"a62c4b1ecdfe29fc1dc5f8d87339a1e5211afbe9","unresolved":false,"context_lines":[{"line_number":13,"context_line":" *"},{"line_number":14,"context_line":" * See the License for the specific language governing permissions and"},{"line_number":15,"context_line":" * limitations under the License."},{"line_number":16,"context_line":" */"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"/**"},{"line_number":19,"context_line":" * A simple version parser, able to parse various version strings used in OpenStack into a"}],"source_content_type":"text/javascript","patch_set":2,"id":"3ac371cc_8fadfa33","line":16,"updated":"2016-08-15 15:59:44.000000000","message":"Not sure if it\u0027s important, but we should actually have this licensing according to OpenStack Style Guide http://docs.openstack.org/developer/hacking/#openstack-licensing","commit_id":"620536d146316fd1734328151b00cf162b7795d7"},{"author":{"_account_id":9717,"name":"Michael Krotscheck","email":"krotscheck@gmail.com","username":"krotscheck"},"change_message_id":"651f21c4cced17484019aba2dc9864c42f6552e7","unresolved":false,"context_lines":[{"line_number":13,"context_line":" *"},{"line_number":14,"context_line":" * See the License for the specific language governing permissions and"},{"line_number":15,"context_line":" * limitations under the License."},{"line_number":16,"context_line":" */"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"/**"},{"line_number":19,"context_line":" * A simple version parser, able to parse various version strings used in OpenStack into a"}],"source_content_type":"text/javascript","patch_set":2,"id":"3ac371cc_7a31480b","line":16,"in_reply_to":"3ac371cc_8fadfa33","updated":"2016-08-15 20:25:24.000000000","message":"Copyright !\u003d License, so the header\u0027s fine. As for the license, I don\u0027 tthink the difference in whitespace matters, but I\u0027ll update it.","commit_id":"620536d146316fd1734328151b00cf162b7795d7"}],"test/unit/util/versionTest.js":[{"author":{"_account_id":8614,"name":"Corentin Ardeois","email":"corentin.ardeois@gmail.com","username":"cardeois"},"change_message_id":"a62c4b1ecdfe29fc1dc5f8d87339a1e5211afbe9","unresolved":false,"context_lines":[{"line_number":75,"context_line":"    // Version tests"},{"line_number":76,"context_line":"    expect(v1.equals(new Version(\"compute 1.0.0\"))).toBe(true);"},{"line_number":77,"context_line":"    expect(v1.equals(new Version(\"compute 1.0.1\"))).toBe(false);"},{"line_number":78,"context_line":"    expect(v1.equals(new Version(\"identity 1.0.0\"))).toBe(false);"},{"line_number":79,"context_line":"    expect(v1.equals(new Version(\"1.0.0\"))).toBe(false);"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    // Other tests..."}],"source_content_type":"text/javascript","patch_set":2,"id":"3ac371cc_f490b997","line":78,"updated":"2016-08-15 15:59:44.000000000","message":"What\u0027s the difference between those 3 tests and the ones line 71-73","commit_id":"620536d146316fd1734328151b00cf162b7795d7"},{"author":{"_account_id":9717,"name":"Michael Krotscheck","email":"krotscheck@gmail.com","username":"krotscheck"},"change_message_id":"651f21c4cced17484019aba2dc9864c42f6552e7","unresolved":false,"context_lines":[{"line_number":75,"context_line":"    // Version tests"},{"line_number":76,"context_line":"    expect(v1.equals(new Version(\"compute 1.0.0\"))).toBe(true);"},{"line_number":77,"context_line":"    expect(v1.equals(new Version(\"compute 1.0.1\"))).toBe(false);"},{"line_number":78,"context_line":"    expect(v1.equals(new Version(\"identity 1.0.0\"))).toBe(false);"},{"line_number":79,"context_line":"    expect(v1.equals(new Version(\"1.0.0\"))).toBe(false);"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    // Other tests..."}],"source_content_type":"text/javascript","patch_set":2,"id":"3ac371cc_d5c12d82","line":78,"in_reply_to":"3ac371cc_f490b997","updated":"2016-08-15 20:25:24.000000000","message":"These test that we can feed in an instance of this class for comparison. The ones above test whether we can pass in a string.","commit_id":"620536d146316fd1734328151b00cf162b7795d7"},{"author":{"_account_id":8614,"name":"Corentin Ardeois","email":"corentin.ardeois@gmail.com","username":"cardeois"},"change_message_id":"a62c4b1ecdfe29fc1dc5f8d87339a1e5211afbe9","unresolved":false,"context_lines":[{"line_number":81,"context_line":"    // Other tests..."},{"line_number":82,"context_line":"    expect(v1.equals({})).toBe(false);"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    const v2 \u003d new Version(\"1.0.0\");"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    // String tests..."},{"line_number":87,"context_line":"    expect(v2.equals(\"compute 1.0.0\")).toBe(false);"}],"source_content_type":"text/javascript","patch_set":2,"id":"3ac371cc_74f3290b","line":84,"updated":"2016-08-15 15:59:44.000000000","message":"Shouldn\u0027t this be 2.0.0 ?","commit_id":"620536d146316fd1734328151b00cf162b7795d7"},{"author":{"_account_id":9717,"name":"Michael Krotscheck","email":"krotscheck@gmail.com","username":"krotscheck"},"change_message_id":"651f21c4cced17484019aba2dc9864c42f6552e7","unresolved":false,"context_lines":[{"line_number":81,"context_line":"    // Other tests..."},{"line_number":82,"context_line":"    expect(v1.equals({})).toBe(false);"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    const v2 \u003d new Version(\"1.0.0\");"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    // String tests..."},{"line_number":87,"context_line":"    expect(v2.equals(\"compute 1.0.0\")).toBe(false);"}],"source_content_type":"text/javascript","patch_set":2,"id":"3ac371cc_b541110e","line":84,"in_reply_to":"3ac371cc_74f3290b","updated":"2016-08-15 20:25:24.000000000","message":"Meh. It refers to \"The second instance of a version class under test\", not \"instance of version that contains V2.","commit_id":"620536d146316fd1734328151b00cf162b7795d7"}]}