)]}'
{"id":"openstack%2Fjs-openstack-lib~357448","triplet_id":"openstack%2Fjs-openstack-lib~master~I736bcaccf6324a3d66191692e5f2ce922a727dea","project":"openstack/js-openstack-lib","branch":"master","topic":"keystone","hashtags":[],"change_id":"I736bcaccf6324a3d66191692e5f2ce922a727dea","subject":"Http class now rejects 4xx and 5xx responses","status":"MERGED","created":"2016-08-18 20:21:25.000000000","updated":"2016-08-19 15:55:15.000000000","submitted":"2016-08-19 15:55:15.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"10f04b1c7662603727260bcec4b4ad9de8a998d6","_number":357448,"virtual_id_number":357448,"owner":{"_account_id":9717,"name":"Michael Krotscheck","email":"krotscheck@gmail.com","username":"krotscheck"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2016-08-19 15:55:15.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":8735,"name":"Vitaly Kramskikh","email":"vkramskikh@mirantis.com","username":"vkramskikh"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":8735,"name":"Vitaly Kramskikh","email":"vkramskikh@mirantis.com","username":"vkramskikh"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2016-08-19 15:38:46.000000000","_account_id":8735,"name":"Vitaly Kramskikh","email":"vkramskikh@mirantis.com","username":"vkramskikh"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":8735,"name":"Vitaly Kramskikh","email":"vkramskikh@mirantis.com","username":"vkramskikh"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2016-08-19 15:38:46.000000000","_account_id":8735,"name":"Vitaly Kramskikh","email":"vkramskikh@mirantis.com","username":"vkramskikh"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":8735,"name":"Vitaly Kramskikh","email":"vkramskikh@mirantis.com","username":"vkramskikh"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-08-19 15:38:46.000000000","updated_by":{"_account_id":8735,"name":"Vitaly Kramskikh","email":"vkramskikh@mirantis.com","username":"vkramskikh"},"reviewer":{"_account_id":8735,"name":"Vitaly Kramskikh","email":"vkramskikh@mirantis.com","username":"vkramskikh"},"state":"REVIEWER"},{"updated":"2016-08-19 15:55:15.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"4a540c00d3eb469f1cd92c14548283f8c86e7434","author":{"_account_id":9717,"name":"Michael Krotscheck","email":"krotscheck@gmail.com","username":"krotscheck"},"date":"2016-08-18 20:21:25.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"0329407e0d21af4aa024c05c37a2d331ba41d6ec","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-08-18 22:56:17.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-js-openstack-lib-nodejs4-npm-run-lint http://logs.openstack.org/48/357448/1/check/gate-js-openstack-lib-nodejs4-npm-run-lint/7795a31/ : SUCCESS in 9m 32s\n- gate-js-openstack-lib-nodejs4-npm-run-test http://logs.openstack.org/48/357448/1/check/gate-js-openstack-lib-nodejs4-npm-run-test/41a5301/ : SUCCESS in 10m 22s\n- gate-js-openstack-lib-nodejs6-npm-run-lint http://logs.openstack.org/48/357448/1/check/gate-js-openstack-lib-nodejs6-npm-run-lint/6afd3b7/ : SUCCESS in 3m 16s (non-voting)\n- gate-js-openstack-lib-nodejs6-npm-run-test http://logs.openstack.org/48/357448/1/check/gate-js-openstack-lib-nodejs6-npm-run-test/3cf62ec/ : SUCCESS in 3m 31s (non-voting)\n- gate-js-openstack-lib-nodejs6-npm-docs http://docs-draft.openstack.org/48/357448/1/check/gate-js-openstack-lib-nodejs6-npm-docs/26adffc//doc/build/html/ : SUCCESS in 2m 43s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"555a909a18798ae62f4ae60029b09ee8c4862208","author":{"_account_id":8735,"name":"Vitaly Kramskikh","email":"vkramskikh@mirantis.com","username":"vkramskikh"},"date":"2016-08-19 09:27:04.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"ff9559ccea127ac8a28542f2111eb2610b853080","author":{"_account_id":9717,"name":"Michael Krotscheck","email":"krotscheck@gmail.com","username":"krotscheck"},"date":"2016-08-19 15:37:27.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"216d6d243662e396802255f4615c6c0cf27ed8a1","author":{"_account_id":8735,"name":"Vitaly Kramskikh","email":"vkramskikh@mirantis.com","username":"vkramskikh"},"date":"2016-08-19 15:38:46.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"51253188fa91c929908cf806548df00398984e09","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-08-19 15:39:02.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"1873a95130ef798ae0cebf110c8a27354c041f59","date":"2016-08-19 15:55:15.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":1},{"id":"770eba0baa2b6438dff1234521fe6d32e5d0f68d","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-08-19 15:55:15.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-js-openstack-lib-nodejs4-npm-run-lint http://logs.openstack.org/48/357448/1/gate/gate-js-openstack-lib-nodejs4-npm-run-lint/d4628af/ : SUCCESS in 5m 54s\n- gate-js-openstack-lib-nodejs4-npm-run-test http://logs.openstack.org/48/357448/1/gate/gate-js-openstack-lib-nodejs4-npm-run-test/3e48472/ : SUCCESS in 6m 54s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"528bccbf81308e6095a3675130b41a881d02d7f3","revisions":{"528bccbf81308e6095a3675130b41a881d02d7f3":{"kind":"REWORK","_number":1,"created":"2016-08-18 20:21:25.000000000","uploader":{"_account_id":9717,"name":"Michael Krotscheck","email":"krotscheck@gmail.com","username":"krotscheck"},"ref":"refs/changes/48/357448/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/js-openstack-lib","ref":"refs/changes/48/357448/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/js-openstack-lib refs/changes/48/357448/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/js-openstack-lib refs/changes/48/357448/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/js-openstack-lib refs/changes/48/357448/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/js-openstack-lib refs/changes/48/357448/1"}}},"commit":{"parents":[{"commit":"abd0508c30a91a9f119045d9ca20c5bdac06768d","subject":"Created HTTP wrapper","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/js-openstack-lib/commit/abd0508c30a91a9f119045d9ca20c5bdac06768d"}]}],"author":{"name":"Michael Krotscheck","email":"krotscheck@gmail.com","date":"2016-08-18 19:51:27.000000000","tz":-420},"committer":{"name":"Michael Krotscheck","email":"krotscheck@gmail.com","date":"2016-08-18 20:08:18.000000000","tz":-420},"subject":"Http class now rejects 4xx and 5xx responses","message":"Http class now rejects 4xx and 5xx responses\n\nThis patch makes sure that successful HTTP requests, which result\nin an error code, are passed to the catch() or reject handler, rather\nthan the success handler.\n\nThis results in two different cases in the claim() handler, that of\nan internally thrown exception (like a TypeError), and that of a\nResponse() instance. In most cases, developers should not write\ncode that throws exceptions - and even in those, the ES6 Promise\nAPI silently swallows most uncaught throws.\n\nChange-Id: I736bcaccf6324a3d66191692e5f2ce922a727dea\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/js-openstack-lib/commit/528bccbf81308e6095a3675130b41a881d02d7f3"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/js-openstack-lib/commit/528bccbf81308e6095a3675130b41a881d02d7f3"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}