)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8735,"name":"Vitaly Kramskikh","email":"vkramskikh@mirantis.com","username":"vkramskikh"},"change_message_id":"f3bfd4ddef55eea8e92d907cabe2ba500601262b","unresolved":false,"context_lines":[{"line_number":11,"context_line":"time it only supports the password authorization plugin. Additional"},{"line_number":12,"context_line":"use cases should be provided by third-party developers."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"It is the long term intent that this method will deprecate the"},{"line_number":15,"context_line":"authorize() method, in order to provide a consistently idempotent"},{"line_number":16,"context_line":"implementation."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: If1368bcdae251606d2e03043345cd4fc6f0b8b80"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1ac06dbe_b58bb11d","line":15,"range":{"start_line":14,"start_character":32,"end_line":15,"end_character":18},"updated":"2016-08-22 09:26:14.000000000","message":"What\u0027s wrong with authorize()?","commit_id":"a4fa3b88fce1258ee81bf857e5642643a15389ff"},{"author":{"_account_id":9717,"name":"Michael Krotscheck","email":"krotscheck@gmail.com","username":"krotscheck"},"change_message_id":"7c350ef7c1574d97a76ab1b7e846f90d58e9f5b6","unresolved":false,"context_lines":[{"line_number":11,"context_line":"time it only supports the password authorization plugin. Additional"},{"line_number":12,"context_line":"use cases should be provided by third-party developers."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"It is the long term intent that this method will deprecate the"},{"line_number":15,"context_line":"authorize() method, in order to provide a consistently idempotent"},{"line_number":16,"context_line":"implementation."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: If1368bcdae251606d2e03043345cd4fc6f0b8b80"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1ac06dbe_96393ada","line":15,"range":{"start_line":14,"start_character":32,"end_line":15,"end_character":18},"in_reply_to":"1ac06dbe_b58bb11d","updated":"2016-08-22 19:43:49.000000000","message":"It doesn\u0027t adhere to the \u003cresourcename\u003e\u003caction\u003e pattern we agreed on. Also, it stores its data internally, so it\u0027s not really idempotent. I end up deprecating it in https://review.openstack.org/#/c/358091/1","commit_id":"a4fa3b88fce1258ee81bf857e5642643a15389ff"}],"src/keystone.js":[{"author":{"_account_id":8735,"name":"Vitaly Kramskikh","email":"vkramskikh@mirantis.com","username":"vkramskikh"},"change_message_id":"f3bfd4ddef55eea8e92d907cabe2ba500601262b","unresolved":false,"context_lines":[{"line_number":33,"context_line":"   * @private"},{"line_number":34,"context_line":"   * @returns {String} The value found in the config, or null."},{"line_number":35,"context_line":"   */"},{"line_number":36,"context_line":"  _safeConfigGet (path) {"},{"line_number":37,"context_line":"    let segments \u003d path.split(\u0027.\u0027);"},{"line_number":38,"context_line":"    let pointer \u003d this.cloudConfig;"},{"line_number":39,"context_line":"    while (segments.length \u003e 0) {"}],"source_content_type":"text/javascript","patch_set":1,"id":"1ac06dbe_f544091c","line":36,"updated":"2016-08-22 09:26:14.000000000","message":"Probably it\u0027s the time to start using lodash.get","commit_id":"a4fa3b88fce1258ee81bf857e5642643a15389ff"},{"author":{"_account_id":9717,"name":"Michael Krotscheck","email":"krotscheck@gmail.com","username":"krotscheck"},"change_message_id":"7c350ef7c1574d97a76ab1b7e846f90d58e9f5b6","unresolved":false,"context_lines":[{"line_number":33,"context_line":"   * @private"},{"line_number":34,"context_line":"   * @returns {String} The value found in the config, or null."},{"line_number":35,"context_line":"   */"},{"line_number":36,"context_line":"  _safeConfigGet (path) {"},{"line_number":37,"context_line":"    let segments \u003d path.split(\u0027.\u0027);"},{"line_number":38,"context_line":"    let pointer \u003d this.cloudConfig;"},{"line_number":39,"context_line":"    while (segments.length \u003e 0) {"}],"source_content_type":"text/javascript","patch_set":1,"id":"1ac06dbe_96677ae8","line":36,"in_reply_to":"1ac06dbe_f544091c","updated":"2016-08-22 19:43:49.000000000","message":"Eeeehhnnn... I\u0027m not convinced.","commit_id":"a4fa3b88fce1258ee81bf857e5642643a15389ff"}],"test/unit/keystoneTest.js":[{"author":{"_account_id":8735,"name":"Vitaly Kramskikh","email":"vkramskikh@mirantis.com","username":"vkramskikh"},"change_message_id":"f3bfd4ddef55eea8e92d907cabe2ba500601262b","unresolved":false,"context_lines":[{"line_number":250,"context_line":"        })"},{"line_number":251,"context_line":"        .catch((error) \u003d\u003e {"},{"line_number":252,"context_line":"          // Fail this test."},{"line_number":253,"context_line":"          expect(error).toBeNull();"},{"line_number":254,"context_line":"          done();"},{"line_number":255,"context_line":"        });"},{"line_number":256,"context_line":"    });"}],"source_content_type":"text/javascript","patch_set":1,"id":"1ac06dbe_35f501cb","line":253,"updated":"2016-08-22 09:26:14.000000000","message":"I suggest to use done.fail() to explicitly fail the tests. Such assertions are not very obvious","commit_id":"a4fa3b88fce1258ee81bf857e5642643a15389ff"},{"author":{"_account_id":9717,"name":"Michael Krotscheck","email":"krotscheck@gmail.com","username":"krotscheck"},"change_message_id":"7c350ef7c1574d97a76ab1b7e846f90d58e9f5b6","unresolved":false,"context_lines":[{"line_number":250,"context_line":"        })"},{"line_number":251,"context_line":"        .catch((error) \u003d\u003e {"},{"line_number":252,"context_line":"          // Fail this test."},{"line_number":253,"context_line":"          expect(error).toBeNull();"},{"line_number":254,"context_line":"          done();"},{"line_number":255,"context_line":"        });"},{"line_number":256,"context_line":"    });"}],"source_content_type":"text/javascript","patch_set":1,"id":"1ac06dbe_76a3de00","line":253,"in_reply_to":"1ac06dbe_35f501cb","updated":"2016-08-22 19:43:49.000000000","message":"Works for me.","commit_id":"a4fa3b88fce1258ee81bf857e5642643a15389ff"}]}