)]}'
{"id":"openstack%2Fjs-openstack-lib~363213","triplet_id":"openstack%2Fjs-openstack-lib~master~I4cdf7b7106c771f0562de47e8835076d48d03a31","project":"openstack/js-openstack-lib","branch":"master","topic":"fix_dsvm","hashtags":[],"change_id":"I4cdf7b7106c771f0562de47e8835076d48d03a31","subject":"Removed request and response interception.","status":"MERGED","created":"2016-08-30 21:24:50.000000000","updated":"2016-08-31 09:15:00.000000000","submitted":"2016-08-31 09:15:00.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"c624b2586c1a542ff68f83cfa9381cad287244c1","_number":363213,"virtual_id_number":363213,"owner":{"_account_id":9717,"name":"Michael Krotscheck","email":"krotscheck@gmail.com","username":"krotscheck"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2016-08-31 09:15:00.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":8614,"name":"Corentin Ardeois","email":"corentin.ardeois@gmail.com","username":"cardeois"},{"value":0,"_account_id":8735,"name":"Vitaly Kramskikh","email":"vkramskikh@mirantis.com","username":"vkramskikh"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":8735,"name":"Vitaly Kramskikh","email":"vkramskikh@mirantis.com","username":"vkramskikh"},"recommended":{"_account_id":8614,"name":"Corentin Ardeois","email":"corentin.ardeois@gmail.com","username":"cardeois"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2016-08-30 21:42:04.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":8614,"name":"Corentin Ardeois","email":"corentin.ardeois@gmail.com","username":"cardeois"},{"value":2,"date":"2016-08-31 09:06:00.000000000","_account_id":8735,"name":"Vitaly Kramskikh","email":"vkramskikh@mirantis.com","username":"vkramskikh"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":8735,"name":"Vitaly Kramskikh","email":"vkramskikh@mirantis.com","username":"vkramskikh"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":8614,"name":"Corentin Ardeois","email":"corentin.ardeois@gmail.com","username":"cardeois"},{"value":1,"date":"2016-08-31 09:06:00.000000000","_account_id":8735,"name":"Vitaly Kramskikh","email":"vkramskikh@mirantis.com","username":"vkramskikh"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":8614,"name":"Corentin Ardeois","email":"corentin.ardeois@gmail.com","username":"cardeois"},{"_account_id":8735,"name":"Vitaly Kramskikh","email":"vkramskikh@mirantis.com","username":"vkramskikh"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-08-30 21:42:04.000000000","updated_by":{"_account_id":8614,"name":"Corentin Ardeois","email":"corentin.ardeois@gmail.com","username":"cardeois"},"reviewer":{"_account_id":8614,"name":"Corentin Ardeois","email":"corentin.ardeois@gmail.com","username":"cardeois"},"state":"REVIEWER"},{"updated":"2016-08-31 09:06:00.000000000","updated_by":{"_account_id":8735,"name":"Vitaly Kramskikh","email":"vkramskikh@mirantis.com","username":"vkramskikh"},"reviewer":{"_account_id":8735,"name":"Vitaly Kramskikh","email":"vkramskikh@mirantis.com","username":"vkramskikh"},"state":"REVIEWER"},{"updated":"2016-08-31 09:15:00.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"4b58d8c17721d234c4ece03273ee19ab06dcc576","author":{"_account_id":9717,"name":"Michael Krotscheck","email":"krotscheck@gmail.com","username":"krotscheck"},"date":"2016-08-30 21:24:50.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"2b7c77623164a941ee0978b160554380ec75927d","author":{"_account_id":8614,"name":"Corentin Ardeois","email":"corentin.ardeois@gmail.com","username":"cardeois"},"date":"2016-08-30 21:42:04.000000000","message":"Patch Set 1: Code-Review+1\n\nSo much cleaner now !","accounts_in_message":[],"_revision_number":1},{"id":"e27ed2322fda65744476e1b639cbb9559ec34c5c","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-08-30 21:46:12.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-js-openstack-lib-nodejs4-npm-run-lint http://logs.openstack.org/13/363213/1/check/gate-js-openstack-lib-nodejs4-npm-run-lint/4893ad4/ : SUCCESS in 4m 03s\n- gate-js-openstack-lib-nodejs4-npm-run-test http://logs.openstack.org/13/363213/1/check/gate-js-openstack-lib-nodejs4-npm-run-test/3c61276/ : SUCCESS in 4m 50s\n- gate-js-openstack-lib-nodejs6-npm-run-lint http://logs.openstack.org/13/363213/1/check/gate-js-openstack-lib-nodejs6-npm-run-lint/76cd8f6/ : SUCCESS in 4m 27s\n- gate-js-openstack-lib-nodejs6-npm-run-test http://logs.openstack.org/13/363213/1/check/gate-js-openstack-lib-nodejs6-npm-run-test/42aaaf5/ : SUCCESS in 6m 26s\n- gate-js-openstack-lib-nodejs6-npm-docs http://docs-draft.openstack.org/13/363213/1/check/gate-js-openstack-lib-nodejs6-npm-docs/951ec6a//doc/build/html/ : SUCCESS in 4m 16s (non-voting)\n- js-openstack-lib-dsvm-nodejs6-npm-run-functional-test http://logs.openstack.org/13/363213/1/check/js-openstack-lib-dsvm-nodejs6-npm-run-functional-test/370dedb/ : FAILURE in 16m 54s (non-voting)\n- js-openstack-lib-dsvm-nodejs4-npm-run-functional-test http://logs.openstack.org/13/363213/1/check/js-openstack-lib-dsvm-nodejs4-npm-run-functional-test/e89ec0b/ : FAILURE in 18m 17s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"89be9ffe58add1f3cc229e3b3947e547e081fb46","author":{"_account_id":8735,"name":"Vitaly Kramskikh","email":"vkramskikh@mirantis.com","username":"vkramskikh"},"date":"2016-08-31 09:06:00.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"0d0021043bdc38a6fc06a649ecdc5e3cdcd69067","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-08-31 09:06:13.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"e0c2ef8f8d1834f9b058996f94ff8ebdad14221a","date":"2016-08-31 09:15:00.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":1},{"id":"19b738c52473f2ec8f35a1232a1648e5e1e1b63e","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-08-31 09:15:00.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-js-openstack-lib-nodejs4-npm-run-lint http://logs.openstack.org/13/363213/1/gate/gate-js-openstack-lib-nodejs4-npm-run-lint/572324b/ : SUCCESS in 8m 37s\n- gate-js-openstack-lib-nodejs4-npm-run-test http://logs.openstack.org/13/363213/1/gate/gate-js-openstack-lib-nodejs4-npm-run-test/c23d41b/ : SUCCESS in 5m 11s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"7767d0183cec873c74e601104450060f8ecd98b0","revisions":{"7767d0183cec873c74e601104450060f8ecd98b0":{"kind":"REWORK","_number":1,"created":"2016-08-30 21:24:50.000000000","uploader":{"_account_id":9717,"name":"Michael Krotscheck","email":"krotscheck@gmail.com","username":"krotscheck"},"ref":"refs/changes/13/363213/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/js-openstack-lib","ref":"refs/changes/13/363213/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/js-openstack-lib refs/changes/13/363213/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/js-openstack-lib refs/changes/13/363213/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/js-openstack-lib refs/changes/13/363213/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/js-openstack-lib refs/changes/13/363213/1"}}},"commit":{"parents":[{"commit":"a3bfae89762c861d19a2b1ce89a02181b64895b8","subject":"Removed authenticate() method","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/js-openstack-lib/commit/a3bfae89762c861d19a2b1ce89a02181b64895b8"}]}],"author":{"name":"Michael Krotscheck","email":"krotscheck@gmail.com","date":"2016-08-30 21:22:52.000000000","tz":-420},"committer":{"name":"Michael Krotscheck","email":"krotscheck@gmail.com","date":"2016-08-30 21:22:52.000000000","tz":-420},"subject":"Removed request and response interception.","message":"Removed request and response interception.\n\nThe request/response interception has not yet been used, and\nintroduced quite a bit of complexity, especially surrounding fetchMock.\nFurthermore, they made our DSVM tests fail, as the browser\u0027s implementation\nof Request requires that a request body be accessed using the regular\njson(), text(), etc. promise generators. Since this would have\nsimply added more complexity to an already complex, unused feature,\nwe\u0027ve simply removed the feature.\n\nChange-Id: I4cdf7b7106c771f0562de47e8835076d48d03a31\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/js-openstack-lib/commit/7767d0183cec873c74e601104450060f8ecd98b0"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/js-openstack-lib/commit/7767d0183cec873c74e601104450060f8ecd98b0"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}