)]}'
{"src/index.js":[{"author":{"_account_id":9717,"name":"Michael Krotscheck","email":"krotscheck@gmail.com","username":"krotscheck"},"change_message_id":"443be7b46a395e45d9a47abe680c7f0e973200ca","unresolved":false,"context_lines":[{"line_number":1,"context_line":"import \u0027isomorphic-fetch\u0027;"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"export default class OpenStack {"},{"line_number":4,"context_line":"  construtor (cloudConfig) {"},{"line_number":5,"context_line":"    // Sanity checks."},{"line_number":6,"context_line":"    if (!cloudConfig) {"},{"line_number":7,"context_line":"      throw new Error(\u0027A configuration is required.\u0027);"}],"source_content_type":"text/javascript","patch_set":2,"id":"7a8ec9b2_75a31c9f","line":4,"updated":"2016-09-14 02:26:20.000000000","message":"\u0027constructor\u0027 is misspelled.","commit_id":"c51e2a0fb2c181b304745a7d64a30c7abeaac24f"},{"author":{"_account_id":9725,"name":"Dong Ma","email":"winterma.dong@gmail.com","username":"larainema"},"change_message_id":"4f33b8d969d51c8dfb994251202aa8da6854b76f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"import \u0027isomorphic-fetch\u0027;"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"export default class OpenStack {"},{"line_number":4,"context_line":"  construtor (cloudConfig) {"},{"line_number":5,"context_line":"    // Sanity checks."},{"line_number":6,"context_line":"    if (!cloudConfig) {"},{"line_number":7,"context_line":"      throw new Error(\u0027A configuration is required.\u0027);"}],"source_content_type":"text/javascript","patch_set":2,"id":"7a8ec9b2_0af2836f","line":4,"in_reply_to":"7a8ec9b2_75a31c9f","updated":"2016-09-14 16:52:12.000000000","message":"Done","commit_id":"c51e2a0fb2c181b304745a7d64a30c7abeaac24f"},{"author":{"_account_id":9717,"name":"Michael Krotscheck","email":"krotscheck@gmail.com","username":"krotscheck"},"change_message_id":"443be7b46a395e45d9a47abe680c7f0e973200ca","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"    this.cloudConfig \u003d cloudConfig;"},{"line_number":14,"context_line":"  }"},{"line_number":15,"context_line":"  getConfig () {"},{"line_number":16,"context_line":"    return this.cloudConfig;"},{"line_number":17,"context_line":"  }"},{"line_number":18,"context_line":"}"}],"source_content_type":"text/javascript","patch_set":2,"id":"7a8ec9b2_b5ada48a","line":15,"updated":"2016-09-14 02:26:20.000000000","message":"A bit of jsdoc would be nice.","commit_id":"c51e2a0fb2c181b304745a7d64a30c7abeaac24f"},{"author":{"_account_id":9725,"name":"Dong Ma","email":"winterma.dong@gmail.com","username":"larainema"},"change_message_id":"4f33b8d969d51c8dfb994251202aa8da6854b76f","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"    this.cloudConfig \u003d cloudConfig;"},{"line_number":14,"context_line":"  }"},{"line_number":15,"context_line":"  getConfig () {"},{"line_number":16,"context_line":"    return this.cloudConfig;"},{"line_number":17,"context_line":"  }"},{"line_number":18,"context_line":"}"}],"source_content_type":"text/javascript","patch_set":2,"id":"7a8ec9b2_6a030743","line":15,"in_reply_to":"7a8ec9b2_b5ada48a","updated":"2016-09-14 16:52:12.000000000","message":"Done","commit_id":"c51e2a0fb2c181b304745a7d64a30c7abeaac24f"},{"author":{"_account_id":8614,"name":"Corentin Ardeois","email":"corentin.ardeois@gmail.com","username":"cardeois"},"change_message_id":"2e885567e6e5888f8c98a24fcccbc97c2adf01c5","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    // Returns the config instance"},{"line_number":22,"context_line":"    return this.cloudConfig;"},{"line_number":23,"context_line":"  }"},{"line_number":24,"context_line":"  getUrl (url) {"},{"line_number":25,"context_line":"    return fetch(url)"},{"line_number":26,"context_line":"      .then((response) \u003d\u003e {"},{"line_number":27,"context_line":"        return response;"}],"source_content_type":"text/javascript","patch_set":8,"id":"7a8ec9b2_1cd9a722","line":24,"updated":"2016-09-21 13:43:11.000000000","message":"What\u0027s the goal of this method? Is it just for tests or do you see any purpose later?","commit_id":"532bf635c28e7a88328c610a4ba8984fae37846e"},{"author":{"_account_id":8735,"name":"Vitaly Kramskikh","email":"vkramskikh@mirantis.com","username":"vkramskikh"},"change_message_id":"64256628b8a04e93e8cba5441ece312525ed5d2f","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    // Returns the config instance"},{"line_number":22,"context_line":"    return this.cloudConfig;"},{"line_number":23,"context_line":"  }"},{"line_number":24,"context_line":"  getUrl (url) {"},{"line_number":25,"context_line":"    return fetch(url)"},{"line_number":26,"context_line":"      .then((response) \u003d\u003e {"},{"line_number":27,"context_line":"        return response;"}],"source_content_type":"text/javascript","patch_set":8,"id":"5a8bc5a2_aaf618d5","line":24,"in_reply_to":"7a8ec9b2_05c3068a","updated":"2016-09-22 13:30:24.000000000","message":"I\u0027d remove it - it was needed for dummy tests and now makes no sense","commit_id":"532bf635c28e7a88328c610a4ba8984fae37846e"},{"author":{"_account_id":9725,"name":"Dong Ma","email":"winterma.dong@gmail.com","username":"larainema"},"change_message_id":"a82e376e26dadfc20ff5cad09f569fc93620257b","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    // Returns the config instance"},{"line_number":22,"context_line":"    return this.cloudConfig;"},{"line_number":23,"context_line":"  }"},{"line_number":24,"context_line":"  getUrl (url) {"},{"line_number":25,"context_line":"    return fetch(url)"},{"line_number":26,"context_line":"      .then((response) \u003d\u003e {"},{"line_number":27,"context_line":"        return response;"}],"source_content_type":"text/javascript","patch_set":8,"id":"7a8ec9b2_05c3068a","line":24,"in_reply_to":"7a8ec9b2_1cd9a722","updated":"2016-09-21 14:15:53.000000000","message":"It\u0027s just for trying to test the function test.","commit_id":"532bf635c28e7a88328c610a4ba8984fae37846e"}],"test/unit/indexTest.js":[{"author":{"_account_id":9717,"name":"Michael Krotscheck","email":"krotscheck@gmail.com","username":"krotscheck"},"change_message_id":"443be7b46a395e45d9a47abe680c7f0e973200ca","unresolved":false,"context_lines":[{"line_number":9,"context_line":"    FetchMock.reset();"},{"line_number":10,"context_line":"  });"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"  it(\"should export a class\", () \u003d\u003e {"},{"line_number":13,"context_line":"    let t \u003d new OpenStack(mockData.config);"},{"line_number":14,"context_line":"    expect(t).toBeDefined();"},{"line_number":15,"context_line":"  });"}],"source_content_type":"text/javascript","patch_set":2,"id":"7a8ec9b2_d5aa3070","line":12,"updated":"2016-09-14 02:26:20.000000000","message":"A test to make sure that getConfig returns the config, and that the config instances are not the same.","commit_id":"c51e2a0fb2c181b304745a7d64a30c7abeaac24f"},{"author":{"_account_id":9725,"name":"Dong Ma","email":"winterma.dong@gmail.com","username":"larainema"},"change_message_id":"4f33b8d969d51c8dfb994251202aa8da6854b76f","unresolved":false,"context_lines":[{"line_number":9,"context_line":"    FetchMock.reset();"},{"line_number":10,"context_line":"  });"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"  it(\"should export a class\", () \u003d\u003e {"},{"line_number":13,"context_line":"    let t \u003d new OpenStack(mockData.config);"},{"line_number":14,"context_line":"    expect(t).toBeDefined();"},{"line_number":15,"context_line":"  });"}],"source_content_type":"text/javascript","patch_set":2,"id":"7a8ec9b2_8a5a134f","line":12,"in_reply_to":"7a8ec9b2_d5aa3070","updated":"2016-09-14 16:52:12.000000000","message":"Can you explain more about the test make sure the config instances are not the same?","commit_id":"c51e2a0fb2c181b304745a7d64a30c7abeaac24f"},{"author":{"_account_id":8614,"name":"Corentin Ardeois","email":"corentin.ardeois@gmail.com","username":"cardeois"},"change_message_id":"2c791b089fad7229c1f72d4340866fc4f5a1df47","unresolved":false,"context_lines":[{"line_number":1,"context_line":"import OpenStack from \"../../src/index\";"},{"line_number":2,"context_line":"import * as mockData from \u0027./helpers/data/keystone\u0027;"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"const FetchMock \u003d require(\u0027fetch-mock\u0027);"},{"line_number":5,"context_line":""}],"source_content_type":"text/javascript","patch_set":4,"id":"7a8ec9b2_d0168cf0","line":2,"updated":"2016-09-14 17:12:57.000000000","message":"I think it\u0027s better to create your own mockData for `Openstack`, as keystone will later use a different config object based on a catalog entry. Krotscheck is that right?","commit_id":"851b2eb76d0a6fb9e476a03c8a96a5c8ff587a51"}]}