)]}'
{"test/unit/novaTest.js":[{"author":{"_account_id":8614,"name":"Corentin Ardeois","email":"corentin.ardeois@gmail.com","username":"cardeois"},"change_message_id":"573e60179ed2db4c06c66cecfaedf13404ce1e36","unresolved":false,"context_lines":[{"line_number":30,"context_line":"  it(\u0027should throw an error for an empty config\u0027, () \u003d\u003e {"},{"line_number":31,"context_line":"    try {"},{"line_number":32,"context_line":"      const nova \u003d new Nova();"},{"line_number":33,"context_line":"      nova.versions();"},{"line_number":34,"context_line":"    } catch (e) {"},{"line_number":35,"context_line":"      expect(e.message).toEqual(\u0027An endpoint configuration is required.\u0027);"},{"line_number":36,"context_line":"    }"}],"source_content_type":"text/javascript","patch_set":2,"id":"7a8ec9b2_4a855dab","line":33,"updated":"2016-09-14 21:15:44.000000000","message":"If this doesn\u0027t raise anything this test won\u0027t fail.\nYou should I think use `expect(func).toThrow(\"message\")`\nhttp://jasmine.github.io/2.0/introduction.html#section-Included_Matchers","commit_id":"8495510fef28b1f631747f3da26d6bf7a8a7b361"},{"author":{"_account_id":8614,"name":"Corentin Ardeois","email":"corentin.ardeois@gmail.com","username":"cardeois"},"change_message_id":"573e60179ed2db4c06c66cecfaedf13404ce1e36","unresolved":false,"context_lines":[{"line_number":69,"context_line":"          expect(fetchMock.calls(mockOptions.name).length).toEqual(2);"},{"line_number":70,"context_line":"          done();"},{"line_number":71,"context_line":"        })"},{"line_number":72,"context_line":"        .catch((error) \u003d\u003e done.fail(error));"},{"line_number":73,"context_line":"    });"},{"line_number":74,"context_line":"  });"},{"line_number":75,"context_line":""}],"source_content_type":"text/javascript","patch_set":2,"id":"7a8ec9b2_8a54c521","line":72,"updated":"2016-09-14 21:15:44.000000000","message":"I was thinking, now this is tested in AbstractService, should we still unit test the version caching thing in all AbstractService implementations?\nIf the test is here, let\u0027s keep it but should we still add new tests on that?\n\nMaybe another way could be to run some AbstractService tests for all classes implementing it? not sure if that\u0027s possible (and nice) to do so.","commit_id":"8495510fef28b1f631747f3da26d6bf7a8a7b361"},{"author":{"_account_id":9717,"name":"Michael Krotscheck","email":"krotscheck@gmail.com","username":"krotscheck"},"change_message_id":"c66ce58d42d5be709d96d5090049d0762e00f283","unresolved":false,"context_lines":[{"line_number":69,"context_line":"          expect(fetchMock.calls(mockOptions.name).length).toEqual(2);"},{"line_number":70,"context_line":"          done();"},{"line_number":71,"context_line":"        })"},{"line_number":72,"context_line":"        .catch((error) \u003d\u003e done.fail(error));"},{"line_number":73,"context_line":"    });"},{"line_number":74,"context_line":"  });"},{"line_number":75,"context_line":""}],"source_content_type":"text/javascript","patch_set":2,"id":"7a8ec9b2_5485a204","line":72,"in_reply_to":"7a8ec9b2_8a54c521","updated":"2016-09-16 13:49:05.000000000","message":"We probably don\u0027t need to keep these tests here, you\u0027re right. I\u0027ll keep the specific version selection in the tests though.","commit_id":"8495510fef28b1f631747f3da26d6bf7a8a7b361"}]}