)]}'
{"smaug_dashboard/protectionplans/forms.py":[{"author":{"_account_id":16983,"name":"Eshed Gal-Or","email":"eshed.galor@huawei.com","username":"eshedg"},"change_message_id":"d58047c1ff6ce2b0ca6c644a21df14018c8c3ea2","unresolved":false,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    def handle(self, request, data):"},{"line_number":58,"context_line":"        try:"},{"line_number":59,"context_line":"            new_plan \u003d smaugclient.plan_create(request,"},{"line_number":60,"context_line":"                                               data[\"name\"],"},{"line_number":61,"context_line":"                                               data[\"provider_id\"],"},{"line_number":62,"context_line":"                                               json.loads(data[\"resources\"]),"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a9d85d2_33e1a3ff","line":59,"updated":"2016-06-21 09:08:39.000000000","message":"I would also add a validation on new_plan, in case a malformed response was received (e.g. reached a no-op microservice that replies with blank JSONs)","commit_id":"dfa9d8561cd879eb23b1b9bca636c77d5c448655"}],"smaug_dashboard/protectionplans/views.py":[{"author":{"_account_id":16983,"name":"Eshed Gal-Or","email":"eshed.galor@huawei.com","username":"eshedg"},"change_message_id":"d58047c1ff6ce2b0ca6c644a21df14018c8c3ea2","unresolved":false,"context_lines":[{"line_number":119,"context_line":"                            self.request,"},{"line_number":120,"context_line":"                            dependent_resource[\"type\"],"},{"line_number":121,"context_line":"                            dependent_resource[\"id\"])"},{"line_number":122,"context_line":"                        self.get_results([dependent], result.showid, results)"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"class ScheduleProtectView(horizon_forms.ModalFormView):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a9d85d2_98e70612","line":122,"updated":"2016-06-21 09:08:39.000000000","message":"I think this could lead to memory problem and a very long execution time with a mid-to-large topology, because this is an unbounded nested-loop recursive call.\nI would recommend to change this to only do one level of the tree, with \u0027+\u0027 buttons to expand specific items.","commit_id":"dfa9d8561cd879eb23b1b9bca636c77d5c448655"},{"author":{"_account_id":21648,"name":"zhangshuai","email":"446077695@qq.com","username":"zhangshuai"},"change_message_id":"7e2cb3150d921b1df87c3fb4202c1bdb737163c9","unresolved":false,"context_lines":[{"line_number":119,"context_line":"                            self.request,"},{"line_number":120,"context_line":"                            dependent_resource[\"type\"],"},{"line_number":121,"context_line":"                            dependent_resource[\"id\"])"},{"line_number":122,"context_line":"                        self.get_results([dependent], result.showid, results)"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"class ScheduleProtectView(horizon_forms.ModalFormView):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a9d85d2_872e4cf8","line":122,"in_reply_to":"5a9d85d2_98e70612","updated":"2016-06-22 01:23:38.000000000","message":"If we don\u0027t retrieve all the dependents,it will be wrong in protecting. we will consider it in another pacth.","commit_id":"dfa9d8561cd879eb23b1b9bca636c77d5c448655"}]}
