)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":17151,"name":"chenying","email":"chenyingko@gmail.com","username":"chenying"},"change_message_id":"bae009ea73d9a311a48b1827babcae79aa51eb20","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"authentication fails by keystonemiddleware"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In order to pass througth the authentication of keystonemiddleware, I add a function \"create_smaug_accounts\" to create an account in Keystone in the plugin.sh."},{"line_number":10,"context_line":"There are 4 steps in \"create_smaug_accounts\" :"},{"line_number":11,"context_line":"1. create a user \"smaug\"."},{"line_number":12,"context_line":"2. bind the user with the project \"service\" and grant the role \"service\" to the user."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3a7e1126_f2d719eb","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":113},"updated":"2015-12-18 02:09:08.000000000","message":"be good to meet the OpenStack commit message guidelines\nsummary no more the 50 characters, description no more than 72\nhttps://wiki.openstack.org/wiki/GitCommitMessages#Summary_of_Git_commit_message_structure","commit_id":"b4146b664085d806eda6241f14fb1ac5f92ab1b0"}],"devstack/plugin.sh":[{"author":{"_account_id":17151,"name":"chenying","email":"chenyingko@gmail.com","username":"chenying"},"change_message_id":"bae009ea73d9a311a48b1827babcae79aa51eb20","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"        if [[ \"$KEYSTONE_CATALOG_BACKEND\" \u003d \u0027sql\u0027 ]]; then"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"            get_or_create_service \"smaug\" \"protect\" \"Disaster Recovery Service\""},{"line_number":34,"context_line":"            get_or_create_endpoint \"protect\" \"$REGION_NAME\" \\"},{"line_number":35,"context_line":"                \"$SMAUG_API_PROTOCOL://$SMAUG_API_HOST:$SMAUG_API_PORT/v1/\\$(tenant_id)s\" \\"},{"line_number":36,"context_line":"                \"$SMAUG_API_PROTOCOL://$SMAUG_API_HOST:$SMAUG_API_PORT/v1/\\$(tenant_id)s\" \\"}],"source_content_type":"text/x-sh","patch_set":2,"id":"3a7e1126_f2a9597c","line":33,"range":{"start_line":33,"start_character":53,"end_line":33,"end_character":78},"updated":"2015-12-18 02:09:08.000000000","message":"I think that the description of smaug service should be same as the the description of smaug launchpad.\nApplication Data Protection Service","commit_id":"b4146b664085d806eda6241f14fb1ac5f92ab1b0"},{"author":{"_account_id":13070,"name":"Eran Gampel","email":"eran@gampel.net","username":"Gampel"},"change_message_id":"09e849085601e223fe300166ad9cdd9800344d73","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"        if [[ \"$KEYSTONE_CATALOG_BACKEND\" \u003d \u0027sql\u0027 ]]; then"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"            get_or_create_service \"smaug\" \"protect\" \"Application Data Protection Service\""},{"line_number":32,"context_line":"            get_or_create_endpoint \"protect\" \"$REGION_NAME\" \\"},{"line_number":33,"context_line":"                \"$SMAUG_API_PROTOCOL://$SMAUG_API_HOST:$SMAUG_API_PORT/v1/\\$(tenant_id)s\" \\"},{"line_number":34,"context_line":"                \"$SMAUG_API_PROTOCOL://$SMAUG_API_HOST:$SMAUG_API_PORT/v1/\\$(tenant_id)s\" \\"}],"source_content_type":"text/x-sh","patch_set":3,"id":"3a7e1126_67a56da0","line":31,"range":{"start_line":31,"start_character":43,"end_line":31,"end_character":50},"updated":"2015-12-19 18:43:33.000000000","message":"I am not sure protect is the best value for the \"type\"\n\nI think that \"data-protect\" or data-protection are better","commit_id":"8b8dabc6aaabe8ccf08cdbbf773168e395ae15a7"},{"author":{"_account_id":18266,"name":"zengchen","email":"chenzeng2@huawei.com","username":"zengchen"},"change_message_id":"0695a9057a8eba14aa261d132a2f8ce3b0aa2131","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"        if [[ \"$KEYSTONE_CATALOG_BACKEND\" \u003d \u0027sql\u0027 ]]; then"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"            get_or_create_service \"smaug\" \"protect\" \"Application Data Protection Service\""},{"line_number":32,"context_line":"            get_or_create_endpoint \"protect\" \"$REGION_NAME\" \\"},{"line_number":33,"context_line":"                \"$SMAUG_API_PROTOCOL://$SMAUG_API_HOST:$SMAUG_API_PORT/v1/\\$(tenant_id)s\" \\"},{"line_number":34,"context_line":"                \"$SMAUG_API_PROTOCOL://$SMAUG_API_HOST:$SMAUG_API_PORT/v1/\\$(tenant_id)s\" \\"}],"source_content_type":"text/x-sh","patch_set":3,"id":"3a7e1126_832f1787","line":31,"range":{"start_line":31,"start_character":43,"end_line":31,"end_character":50},"in_reply_to":"3a7e1126_67a56da0","updated":"2015-12-21 08:50:48.000000000","message":"Done","commit_id":"8b8dabc6aaabe8ccf08cdbbf773168e395ae15a7"},{"author":{"_account_id":13070,"name":"Eran Gampel","email":"eran@gampel.net","username":"Gampel"},"change_message_id":"09e849085601e223fe300166ad9cdd9800344d73","unresolved":false,"context_lines":[{"line_number":32,"context_line":"            get_or_create_endpoint \"protect\" \"$REGION_NAME\" \\"},{"line_number":33,"context_line":"                \"$SMAUG_API_PROTOCOL://$SMAUG_API_HOST:$SMAUG_API_PORT/v1/\\$(tenant_id)s\" \\"},{"line_number":34,"context_line":"                \"$SMAUG_API_PROTOCOL://$SMAUG_API_HOST:$SMAUG_API_PORT/v1/\\$(tenant_id)s\" \\"},{"line_number":35,"context_line":"                \"$SMAUG_API_PROTOCOL://$SMAUG_API_HOST:$SMAUG_API_PORT/v1\""},{"line_number":36,"context_line":"        fi"},{"line_number":37,"context_line":"    fi"},{"line_number":38,"context_line":"}"}],"source_content_type":"text/x-sh","patch_set":3,"id":"3a7e1126_87cdf986","line":35,"range":{"start_line":35,"start_character":73,"end_line":35,"end_character":74},"updated":"2015-12-19 18:43:33.000000000","message":"Why is the internal URL different-- without the $(tenant_id)s\n\nI think that Public admin and internal should all be the same at the moment","commit_id":"8b8dabc6aaabe8ccf08cdbbf773168e395ae15a7"},{"author":{"_account_id":18266,"name":"zengchen","email":"chenzeng2@huawei.com","username":"zengchen"},"change_message_id":"0695a9057a8eba14aa261d132a2f8ce3b0aa2131","unresolved":false,"context_lines":[{"line_number":32,"context_line":"            get_or_create_endpoint \"protect\" \"$REGION_NAME\" \\"},{"line_number":33,"context_line":"                \"$SMAUG_API_PROTOCOL://$SMAUG_API_HOST:$SMAUG_API_PORT/v1/\\$(tenant_id)s\" \\"},{"line_number":34,"context_line":"                \"$SMAUG_API_PROTOCOL://$SMAUG_API_HOST:$SMAUG_API_PORT/v1/\\$(tenant_id)s\" \\"},{"line_number":35,"context_line":"                \"$SMAUG_API_PROTOCOL://$SMAUG_API_HOST:$SMAUG_API_PORT/v1\""},{"line_number":36,"context_line":"        fi"},{"line_number":37,"context_line":"    fi"},{"line_number":38,"context_line":"}"}],"source_content_type":"text/x-sh","patch_set":3,"id":"3a7e1126_63b78b3a","line":35,"range":{"start_line":35,"start_character":73,"end_line":35,"end_character":74},"in_reply_to":"3a7e1126_87cdf986","updated":"2015-12-21 08:50:48.000000000","message":"Done","commit_id":"8b8dabc6aaabe8ccf08cdbbf773168e395ae15a7"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"d560f609c1fe4a2d6fb6ca07654a538e494f9c48","unresolved":false,"context_lines":[{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    elif [[ \"$1\" \u003d\u003d \"stack\" \u0026\u0026 \"$2\" \u003d\u003d \"extra\" ]]; then"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"        create_smaug_accounts"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"        echo_summary \"Initializing Smaug Service\""},{"line_number":103,"context_line":"        SMAUG_BIN_DIR\u003d$(get_python_exec_prefix)"}],"source_content_type":"text/x-sh","patch_set":3,"id":"3a7e1126_4c2f3088","line":100,"updated":"2015-12-20 14:08:33.000000000","message":"Moving this to post-config would be better.\nAnd check \"is_service_enabled key\" first.","commit_id":"8b8dabc6aaabe8ccf08cdbbf773168e395ae15a7"},{"author":{"_account_id":17151,"name":"chenying","email":"chenyingko@gmail.com","username":"chenying"},"change_message_id":"0cfa71f91f75a51b147cb74ead6c1699619fff9e","unresolved":false,"context_lines":[{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    elif [[ \"$1\" \u003d\u003d \"stack\" \u0026\u0026 \"$2\" \u003d\u003d \"extra\" ]]; then"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"        create_smaug_accounts"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"        echo_summary \"Initializing Smaug Service\""},{"line_number":103,"context_line":"        SMAUG_BIN_DIR\u003d$(get_python_exec_prefix)"}],"source_content_type":"text/x-sh","patch_set":3,"id":"3a7e1126_cf254809","line":100,"range":{"start_line":100,"start_character":7,"end_line":100,"end_character":28},"updated":"2015-12-21 06:46:33.000000000","message":"To take Manila for an example, I think this method adding here is OK. I think the description of this method should be added.\necho_summary \"Creating Smaug entities for auth service\"","commit_id":"8b8dabc6aaabe8ccf08cdbbf773168e395ae15a7"},{"author":{"_account_id":18266,"name":"zengchen","email":"chenzeng2@huawei.com","username":"zengchen"},"change_message_id":"0695a9057a8eba14aa261d132a2f8ce3b0aa2131","unresolved":false,"context_lines":[{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    elif [[ \"$1\" \u003d\u003d \"stack\" \u0026\u0026 \"$2\" \u003d\u003d \"extra\" ]]; then"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"        create_smaug_accounts"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"        echo_summary \"Initializing Smaug Service\""},{"line_number":103,"context_line":"        SMAUG_BIN_DIR\u003d$(get_python_exec_prefix)"}],"source_content_type":"text/x-sh","patch_set":3,"id":"3a7e1126_63ef8be9","line":100,"in_reply_to":"3a7e1126_4c2f3088","updated":"2015-12-21 08:50:48.000000000","message":"Creating Smaug accounts must be done after the Keystone has been started, so this step should be invoked here.","commit_id":"8b8dabc6aaabe8ccf08cdbbf773168e395ae15a7"},{"author":{"_account_id":18266,"name":"zengchen","email":"chenzeng2@huawei.com","username":"zengchen"},"change_message_id":"0695a9057a8eba14aa261d132a2f8ce3b0aa2131","unresolved":false,"context_lines":[{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    elif [[ \"$1\" \u003d\u003d \"stack\" \u0026\u0026 \"$2\" \u003d\u003d \"extra\" ]]; then"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"        create_smaug_accounts"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"        echo_summary \"Initializing Smaug Service\""},{"line_number":103,"context_line":"        SMAUG_BIN_DIR\u003d$(get_python_exec_prefix)"}],"source_content_type":"text/x-sh","patch_set":3,"id":"3a7e1126_6349cb5f","line":100,"range":{"start_line":100,"start_character":7,"end_line":100,"end_character":28},"in_reply_to":"3a7e1126_cf254809","updated":"2015-12-21 08:50:48.000000000","message":"Done","commit_id":"8b8dabc6aaabe8ccf08cdbbf773168e395ae15a7"}]}
