)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"cb0f6a3e0f889c0bffa7b5b496625b57396bc867","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Create the base data abstraction layer into the DB in basic"},{"line_number":10,"context_line":"API service.I create a database table services as a example."},{"line_number":11,"context_line":"This table is used to save therunning status of deployed"},{"line_number":12,"context_line":"services."},{"line_number":13,"context_line":"The command smaug-manage is used to manage the database."},{"line_number":14,"context_line":"we can use this command \u0027smaug-manage db sync\u0027 to sync"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a7e1126_2cfae443","line":11,"range":{"start_line":11,"start_character":27,"end_line":11,"end_character":37},"updated":"2015-12-20 16:10:22.000000000","message":"the running","commit_id":"eed43280d9df1744986aaf3efc665507bdcac3f6"},{"author":{"_account_id":17151,"name":"chenying","email":"chenyingko@gmail.com","username":"chenying"},"change_message_id":"b22f11f7f869fcca9f206411b726b06bcf2d300e","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Create the base data abstraction layer into the DB in basic"},{"line_number":10,"context_line":"API service.I create a database table services as a example."},{"line_number":11,"context_line":"This table is used to save therunning status of deployed"},{"line_number":12,"context_line":"services."},{"line_number":13,"context_line":"The command smaug-manage is used to manage the database."},{"line_number":14,"context_line":"we can use this command \u0027smaug-manage db sync\u0027 to sync"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a7e1126_3c62083f","line":11,"range":{"start_line":11,"start_character":27,"end_line":11,"end_character":37},"in_reply_to":"3a7e1126_2cfae443","updated":"2015-12-21 06:16:36.000000000","message":"Done","commit_id":"eed43280d9df1744986aaf3efc665507bdcac3f6"},{"author":{"_account_id":15069,"name":"zhonghuali","email":"lizhonghua.li@huawei.com","username":"sloblee"},"change_message_id":"067516a8f55a5212782e940682198dabf9126b41","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"basic API service: Create the base DAL into the DB"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Create the base data abstraction layer into the DB in basic"},{"line_number":10,"context_line":"API service.I create a database table services as a example."},{"line_number":11,"context_line":"This table is used to save the running status of deployed"},{"line_number":12,"context_line":"services."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"1a7b0d38_613c79c8","line":9,"range":{"start_line":9,"start_character":11,"end_line":9,"end_character":15},"updated":"2015-12-29 09:08:27.000000000","message":"s/base/basic","commit_id":"92d04185bcd707aa39739fbb480286d2c6bcbccd"},{"author":{"_account_id":17151,"name":"chenying","email":"chenyingko@gmail.com","username":"chenying"},"change_message_id":"cc383a8eb310acbc601d7d81224b8223255310f8","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"basic API service: Create the base DAL into the DB"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Create the base data abstraction layer into the DB in basic"},{"line_number":10,"context_line":"API service.I create a database table services as a example."},{"line_number":11,"context_line":"This table is used to save the running status of deployed"},{"line_number":12,"context_line":"services."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"1a7b0d38_f72d8746","line":9,"range":{"start_line":9,"start_character":11,"end_line":9,"end_character":15},"in_reply_to":"1a7b0d38_613c79c8","updated":"2015-12-29 09:10:36.000000000","message":"Done","commit_id":"92d04185bcd707aa39739fbb480286d2c6bcbccd"},{"author":{"_account_id":15069,"name":"zhonghuali","email":"lizhonghua.li@huawei.com","username":"sloblee"},"change_message_id":"067516a8f55a5212782e940682198dabf9126b41","unresolved":false,"context_lines":[{"line_number":7,"context_line":"basic API service: Create the base DAL into the DB"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Create the base data abstraction layer into the DB in basic"},{"line_number":10,"context_line":"API service.I create a database table services as a example."},{"line_number":11,"context_line":"This table is used to save the running status of deployed"},{"line_number":12,"context_line":"services."},{"line_number":13,"context_line":"The command smaug-manage is used to manage the database."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"1a7b0d38_813965d9","line":10,"updated":"2015-12-29 09:08:27.000000000","message":"s/a/an","commit_id":"92d04185bcd707aa39739fbb480286d2c6bcbccd"},{"author":{"_account_id":17151,"name":"chenying","email":"chenyingko@gmail.com","username":"chenying"},"change_message_id":"cc383a8eb310acbc601d7d81224b8223255310f8","unresolved":false,"context_lines":[{"line_number":7,"context_line":"basic API service: Create the base DAL into the DB"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Create the base data abstraction layer into the DB in basic"},{"line_number":10,"context_line":"API service.I create a database table services as a example."},{"line_number":11,"context_line":"This table is used to save the running status of deployed"},{"line_number":12,"context_line":"services."},{"line_number":13,"context_line":"The command smaug-manage is used to manage the database."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"1a7b0d38_b7237f57","line":10,"in_reply_to":"1a7b0d38_813965d9","updated":"2015-12-29 09:10:36.000000000","message":"Done","commit_id":"92d04185bcd707aa39739fbb480286d2c6bcbccd"}],"MANIFEST.in":[{"author":{"_account_id":13070,"name":"Eran Gampel","email":"eran@gampel.net","username":"Gampel"},"change_message_id":"32fbf7910818212aa10da58e50ced8dcfefc1341","unresolved":false,"context_lines":[{"line_number":1,"context_line":"include AUTHORS"},{"line_number":2,"context_line":"include ChangeLog"},{"line_number":3,"context_line":"recursive-include smaug *.cfg"},{"line_number":4,"context_line":"exclude .gitignore"},{"line_number":5,"context_line":"exclude .gitreview"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"global-exclude *.pyc"}],"source_content_type":"text/x-properties","patch_set":7,"id":"1a7b0d38_42f2ff70","line":4,"range":{"start_line":4,"start_character":0,"end_line":4,"end_character":7},"updated":"2015-12-25 07:06:04.000000000","message":"Usually there a empty line  between the include and exclude","commit_id":"cc6508c656856234179e882b6ade5a8866733c80"},{"author":{"_account_id":17151,"name":"chenying","email":"chenyingko@gmail.com","username":"chenying"},"change_message_id":"2b834c73565662f8d2fe8f2dc91dbed77b0fdec0","unresolved":false,"context_lines":[{"line_number":1,"context_line":"include AUTHORS"},{"line_number":2,"context_line":"include ChangeLog"},{"line_number":3,"context_line":"recursive-include smaug *.cfg"},{"line_number":4,"context_line":"exclude .gitignore"},{"line_number":5,"context_line":"exclude .gitreview"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"global-exclude *.pyc"}],"source_content_type":"text/x-properties","patch_set":7,"id":"1a7b0d38_f6f3929c","line":4,"range":{"start_line":4,"start_character":0,"end_line":4,"end_character":7},"in_reply_to":"1a7b0d38_42f2ff70","updated":"2015-12-25 08:24:54.000000000","message":"Done","commit_id":"cc6508c656856234179e882b6ade5a8866733c80"}],"smaug/api/openstack/wsgi.py":[{"author":{"_account_id":2023,"name":"Saggi Mizrahi","email":"ficoos+osreview@gmail.com","username":"ficoos"},"change_message_id":"26b7f91305db7bbc72c0a2cfd84500d70a41a877","unresolved":false,"context_lines":[{"line_number":620,"context_line":"        action_args.update(contents)"},{"line_number":621,"context_line":""},{"line_number":622,"context_line":"        project_id \u003d action_args.pop(\"project_id\", None)"},{"line_number":623,"context_line":"        context \u003d request.environ.get(\u0027smaug.context\u0027)"},{"line_number":624,"context_line":"        if (context and project_id and (project_id !\u003d context.project_id)):"},{"line_number":625,"context_line":"            msg \u003d _(\"Malformed request url\")"},{"line_number":626,"context_line":"            return Fault(webob.exc.HTTPBadRequest(explanation\u003dmsg))"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a7e1126_7b05d90e","line":623,"range":{"start_line":623,"start_character":8,"end_line":623,"end_character":15},"updated":"2015-12-21 16:57:58.000000000","message":"Unrelated. Please move to different patch.","commit_id":"7b1d481f3d0827cbab7e0117214e06d93ba6f732"},{"author":{"_account_id":17151,"name":"chenying","email":"chenyingko@gmail.com","username":"chenying"},"change_message_id":"10a1856c2e6902e5bf605ce6781b99d46a98c9c4","unresolved":false,"context_lines":[{"line_number":620,"context_line":"        action_args.update(contents)"},{"line_number":621,"context_line":""},{"line_number":622,"context_line":"        project_id \u003d action_args.pop(\"project_id\", None)"},{"line_number":623,"context_line":"        context \u003d request.environ.get(\u0027smaug.context\u0027)"},{"line_number":624,"context_line":"        if (context and project_id and (project_id !\u003d context.project_id)):"},{"line_number":625,"context_line":"            msg \u003d _(\"Malformed request url\")"},{"line_number":626,"context_line":"            return Fault(webob.exc.HTTPBadRequest(explanation\u003dmsg))"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a7e1126_62ac3b8c","line":623,"range":{"start_line":623,"start_character":8,"end_line":623,"end_character":15},"in_reply_to":"3a7e1126_7b05d90e","updated":"2015-12-22 04:44:58.000000000","message":"Ok I will move it to another patch. Thanks.","commit_id":"7b1d481f3d0827cbab7e0117214e06d93ba6f732"},{"author":{"_account_id":13070,"name":"Eran Gampel","email":"eran@gampel.net","username":"Gampel"},"change_message_id":"9543739e12b319819661ed26c269879f27ee1c7e","unresolved":false,"context_lines":[{"line_number":620,"context_line":"        action_args.update(contents)"},{"line_number":621,"context_line":""},{"line_number":622,"context_line":"        project_id \u003d action_args.pop(\"project_id\", None)"},{"line_number":623,"context_line":"        context \u003d request.environ.get(\u0027smaug.context\u0027)"},{"line_number":624,"context_line":"        if (context and project_id and (project_id !\u003d context.project_id)):"},{"line_number":625,"context_line":"            msg \u003d _(\"Malformed request url\")"},{"line_number":626,"context_line":"            return Fault(webob.exc.HTTPBadRequest(explanation\u003dmsg))"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a7e1126_32b50831","line":623,"range":{"start_line":623,"start_character":34,"end_line":623,"end_character":37},"updated":"2015-12-23 07:17:40.000000000","message":"this fix was introduce in another patch, please remove","commit_id":"9684713fa28b445ddce0a1742f70444e818e8140"},{"author":{"_account_id":17151,"name":"chenying","email":"chenyingko@gmail.com","username":"chenying"},"change_message_id":"8fe1119656e74f723a721525e202dc7f5081699b","unresolved":false,"context_lines":[{"line_number":620,"context_line":"        action_args.update(contents)"},{"line_number":621,"context_line":""},{"line_number":622,"context_line":"        project_id \u003d action_args.pop(\"project_id\", None)"},{"line_number":623,"context_line":"        context \u003d request.environ.get(\u0027smaug.context\u0027)"},{"line_number":624,"context_line":"        if (context and project_id and (project_id !\u003d context.project_id)):"},{"line_number":625,"context_line":"            msg \u003d _(\"Malformed request url\")"},{"line_number":626,"context_line":"            return Fault(webob.exc.HTTPBadRequest(explanation\u003dmsg))"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a7b0d38_2fd105ce","line":623,"range":{"start_line":623,"start_character":34,"end_line":623,"end_character":37},"in_reply_to":"3a7e1126_32b50831","updated":"2015-12-23 08:08:08.000000000","message":"Done","commit_id":"9684713fa28b445ddce0a1742f70444e818e8140"}],"smaug/cmd/manage.py":[{"author":{"_account_id":13070,"name":"Eran Gampel","email":"eran@gampel.net","username":"Gampel"},"change_message_id":"8a55773527cb96b8793adeb6dc0ac2d8a6d2cd24","unresolved":false,"context_lines":[{"line_number":212,"context_line":"        print(_(\"\\nOpenStack Smaug version: %(version)s\\n\") %"},{"line_number":213,"context_line":"              {\u0027version\u0027: version.version_string()})"},{"line_number":214,"context_line":"        print(script_name + \" category action [\u003cargs\u003e]\")"},{"line_number":215,"context_line":"        print(_(\"Available categories:\"))"},{"line_number":216,"context_line":"        for category in CATEGORIES:"},{"line_number":217,"context_line":"            print(_(\"\\t%s\") % category)"},{"line_number":218,"context_line":"        sys.exit(2)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a7e1126_d505bc45","line":215,"range":{"start_line":215,"start_character":15,"end_line":215,"end_character":17},"updated":"2015-12-21 16:19:04.000000000","message":"please add usage function and -help\nI think We need to print the usage on any error","commit_id":"7b1d481f3d0827cbab7e0117214e06d93ba6f732"},{"author":{"_account_id":17151,"name":"chenying","email":"chenyingko@gmail.com","username":"chenying"},"change_message_id":"2e453aa09fc24a5307eaa82c31e70084c295ff0d","unresolved":false,"context_lines":[{"line_number":212,"context_line":"        print(_(\"\\nOpenStack Smaug version: %(version)s\\n\") %"},{"line_number":213,"context_line":"              {\u0027version\u0027: version.version_string()})"},{"line_number":214,"context_line":"        print(script_name + \" category action [\u003cargs\u003e]\")"},{"line_number":215,"context_line":"        print(_(\"Available categories:\"))"},{"line_number":216,"context_line":"        for category in CATEGORIES:"},{"line_number":217,"context_line":"            print(_(\"\\t%s\") % category)"},{"line_number":218,"context_line":"        sys.exit(2)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a7e1126_29ca961b","line":215,"range":{"start_line":215,"start_character":15,"end_line":215,"end_character":17},"in_reply_to":"3a7e1126_d505bc45","updated":"2015-12-22 06:28:38.000000000","message":"Have implemented printing the usage.\n\nroot@SZX1000042013:/opt/stack/smaug# smaug-manage db\nNo handlers could be found for logger \"oslo_config.cfg\"\nusage: smaug-manage db [-h] {sync,version} ...\nsmaug-manage db: error: too few arguments\n\n\nroot@SZX1000042013:/opt/stack/smaug# smaug-manage db --help\nNo handlers could be found for logger \"oslo_config.cfg\"\nusage: smaug-manage db [-h] {sync,version} ...\n\npositional arguments:\n  {sync,version}\n\noptional arguments:\n  -h, --help      show this help message and exit","commit_id":"7b1d481f3d0827cbab7e0117214e06d93ba6f732"},{"author":{"_account_id":13070,"name":"Eran Gampel","email":"eran@gampel.net","username":"Gampel"},"change_message_id":"9543739e12b319819661ed26c269879f27ee1c7e","unresolved":false,"context_lines":[{"line_number":227,"context_line":"        cfgfile \u003d CONF.config_file[-1] if CONF.config_file else None"},{"line_number":228,"context_line":"        if cfgfile and not os.access(cfgfile, os.R_OK):"},{"line_number":229,"context_line":"            st \u003d os.stat(cfgfile)"},{"line_number":230,"context_line":"            print(_(\"Could not read %s. Re-running with sudo\") % cfgfile)"},{"line_number":231,"context_line":"            try:"},{"line_number":232,"context_line":"                os.execvp(\u0027sudo\u0027, [\u0027sudo\u0027, \u0027-u\u0027, \u0027#%s\u0027 % st.st_uid] + sys.argv)"},{"line_number":233,"context_line":"            except Exception:"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a7e1126_92c87caa","line":230,"range":{"start_line":230,"start_character":38,"end_line":230,"end_character":39},"updated":"2015-12-23 07:17:40.000000000","message":"Could not read %s,Please try running this command again as root/Administrator privilege using sudo","commit_id":"9684713fa28b445ddce0a1742f70444e818e8140"},{"author":{"_account_id":17151,"name":"chenying","email":"chenyingko@gmail.com","username":"chenying"},"change_message_id":"8fe1119656e74f723a721525e202dc7f5081699b","unresolved":false,"context_lines":[{"line_number":227,"context_line":"        cfgfile \u003d CONF.config_file[-1] if CONF.config_file else None"},{"line_number":228,"context_line":"        if cfgfile and not os.access(cfgfile, os.R_OK):"},{"line_number":229,"context_line":"            st \u003d os.stat(cfgfile)"},{"line_number":230,"context_line":"            print(_(\"Could not read %s. Re-running with sudo\") % cfgfile)"},{"line_number":231,"context_line":"            try:"},{"line_number":232,"context_line":"                os.execvp(\u0027sudo\u0027, [\u0027sudo\u0027, \u0027-u\u0027, \u0027#%s\u0027 % st.st_uid] + sys.argv)"},{"line_number":233,"context_line":"            except Exception:"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a7b0d38_af06551e","line":230,"range":{"start_line":230,"start_character":38,"end_line":230,"end_character":39},"in_reply_to":"3a7e1126_92c87caa","updated":"2015-12-23 08:08:08.000000000","message":"Done","commit_id":"9684713fa28b445ddce0a1742f70444e818e8140"}],"smaug/common/config.py":[{"author":{"_account_id":13070,"name":"Eran Gampel","email":"eran@gampel.net","username":"Gampel"},"change_message_id":"32fbf7910818212aa10da58e50ced8dcfefc1341","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    cfg.StrOpt(\u0027api_paste_config\u0027,"},{"line_number":33,"context_line":"               default\u003d\"api-paste.ini\","},{"line_number":34,"context_line":"               help\u003d\u0027File name for the paste.deploy config for smaug-api\u0027),"},{"line_number":35,"context_line":"    cfg.StrOpt(\u0027state_path\u0027,"},{"line_number":36,"context_line":"               default\u003d\u0027/var/lib/smaug\u0027,"},{"line_number":37,"context_line":"               deprecated_name\u003d\u0027pybasedir\u0027,"},{"line_number":38,"context_line":"               help\u003d\"Top-level directory for maintaining smaug\u0027s state\"),"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a7b0d38_f0071a1a","line":35,"range":{"start_line":35,"start_character":16,"end_line":35,"end_character":26},"updated":"2015-12-25 07:06:04.000000000","message":"are we using this option ? Where ? \n\ndo we need to keep track about the deprecated_name ?","commit_id":"cc6508c656856234179e882b6ade5a8866733c80"},{"author":{"_account_id":17151,"name":"chenying","email":"chenyingko@gmail.com","username":"chenying"},"change_message_id":"2b834c73565662f8d2fe8f2dc91dbed77b0fdec0","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    cfg.StrOpt(\u0027api_paste_config\u0027,"},{"line_number":33,"context_line":"               default\u003d\"api-paste.ini\","},{"line_number":34,"context_line":"               help\u003d\u0027File name for the paste.deploy config for smaug-api\u0027),"},{"line_number":35,"context_line":"    cfg.StrOpt(\u0027state_path\u0027,"},{"line_number":36,"context_line":"               default\u003d\u0027/var/lib/smaug\u0027,"},{"line_number":37,"context_line":"               deprecated_name\u003d\u0027pybasedir\u0027,"},{"line_number":38,"context_line":"               help\u003d\"Top-level directory for maintaining smaug\u0027s state\"),"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a7b0d38_36fa7a76","line":35,"range":{"start_line":35,"start_character":16,"end_line":35,"end_character":26},"in_reply_to":"1a7b0d38_f0071a1a","updated":"2015-12-25 08:24:54.000000000","message":"\u0027state_path\u0027 This option is used for db unit test.\n\nWe could use comments to keep track the deprecated option name.","commit_id":"cc6508c656856234179e882b6ade5a8866733c80"}],"smaug/db/api.py":[{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"cb0f6a3e0f889c0bffa7b5b496625b57396bc867","unresolved":false,"context_lines":[{"line_number":101,"context_line":"    return IMPL.service_get_all_by_topic(context, topic, disabled\u003ddisabled)"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"def service_get_by_args(context, host, binary):"},{"line_number":105,"context_line":"    \"\"\"Get the state of an service by node name and binary.\"\"\""},{"line_number":106,"context_line":"    return IMPL.service_get_by_args(context, host, binary)"},{"line_number":107,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3a7e1126_921bee72","line":104,"updated":"2015-12-20 16:10:22.000000000","message":"Could the service_get, service_get_by_host_and_topic, service_get_all, service_get_all_by_topic and service_get_by_args be merged to one?","commit_id":"eed43280d9df1744986aaf3efc665507bdcac3f6"},{"author":{"_account_id":17151,"name":"chenying","email":"chenyingko@gmail.com","username":"chenying"},"change_message_id":"b22f11f7f869fcca9f206411b726b06bcf2d300e","unresolved":false,"context_lines":[{"line_number":101,"context_line":"    return IMPL.service_get_all_by_topic(context, topic, disabled\u003ddisabled)"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"def service_get_by_args(context, host, binary):"},{"line_number":105,"context_line":"    \"\"\"Get the state of an service by node name and binary.\"\"\""},{"line_number":106,"context_line":"    return IMPL.service_get_by_args(context, host, binary)"},{"line_number":107,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3a7e1126_bc04b849","line":104,"in_reply_to":"3a7e1126_921bee72","updated":"2015-12-21 06:16:36.000000000","message":"I don\u0027t think these methods need be merged to one. They are used in different scene. I have checked the cene of this method. I find that it is not necessary in smaug.","commit_id":"eed43280d9df1744986aaf3efc665507bdcac3f6"},{"author":{"_account_id":13070,"name":"Eran Gampel","email":"eran@gampel.net","username":"Gampel"},"change_message_id":"8a55773527cb96b8793adeb6dc0ac2d8a6d2cd24","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"db_opts \u003d ["},{"line_number":40,"context_line":"    cfg.BoolOpt(\u0027enable_new_services\u0027,"},{"line_number":41,"context_line":"                default\u003dTrue,"},{"line_number":42,"context_line":"                help\u003d\u0027Services to be added to the available pool on create\u0027),"},{"line_number":43,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a7e1126_75508832","line":40,"range":{"start_line":40,"start_character":17,"end_line":40,"end_character":36},"updated":"2015-12-21 16:19:04.000000000","message":"I am not sure I understand this variable can you please explain","commit_id":"7b1d481f3d0827cbab7e0117214e06d93ba6f732"},{"author":{"_account_id":17151,"name":"chenying","email":"chenyingko@gmail.com","username":"chenying"},"change_message_id":"5034e14c94ac9e18ffddc4789a077ad142049818","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"db_opts \u003d ["},{"line_number":40,"context_line":"    cfg.BoolOpt(\u0027enable_new_services\u0027,"},{"line_number":41,"context_line":"                default\u003dTrue,"},{"line_number":42,"context_line":"                help\u003d\u0027Services to be added to the available pool on create\u0027),"},{"line_number":43,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a7e1126_b33d8c2c","line":40,"range":{"start_line":40,"start_character":17,"end_line":40,"end_character":36},"in_reply_to":"3a7e1126_75508832","updated":"2015-12-22 08:43:01.000000000","message":"The \u0027disable\u0027 filed of service means the active status of a service.\nenable_new_services:when adding a new service to the database, is \nthe status of this service in db  enable?(Default: True)","commit_id":"7b1d481f3d0827cbab7e0117214e06d93ba6f732"},{"author":{"_account_id":17151,"name":"chenying","email":"chenyingko@gmail.com","username":"chenying"},"change_message_id":"0d3c431c3f9540eaf21bcaaeac9fccd462a0380d","unresolved":false,"context_lines":[{"line_number":101,"context_line":"    return IMPL.service_get_all_by_topic(context, topic, disabled\u003ddisabled)"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"def service_get_by_args(context, host, binary):"},{"line_number":105,"context_line":"    \"\"\"Get the state of an service by node name and binary.\"\"\""},{"line_number":106,"context_line":"    return IMPL.service_get_by_args(context, host, binary)"},{"line_number":107,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3a7e1126_52f57b54","line":104,"range":{"start_line":104,"start_character":4,"end_line":104,"end_character":23},"updated":"2015-12-21 07:26:30.000000000","message":"when I check the start methld of Service class. I find that service_get_by_args is necessary.","commit_id":"7b1d481f3d0827cbab7e0117214e06d93ba6f732"}],"smaug/db/sqlalchemy/migrate_repo/migrate.cfg":[{"author":{"_account_id":13070,"name":"Eran Gampel","email":"eran@gampel.net","username":"Gampel"},"change_message_id":"8a55773527cb96b8793adeb6dc0ac2d8a6d2cd24","unresolved":false,"context_lines":[{"line_number":5,"context_line":""},{"line_number":6,"context_line":"# The name of the database table used to track the schema version."},{"line_number":7,"context_line":"# This name shouldn\u0027t already be used by your project."},{"line_number":8,"context_line":"# If this is changed once a database is under version control, you\u0027ll need to "},{"line_number":9,"context_line":"# change the table name in each database too. "},{"line_number":10,"context_line":"version_table\u003dmigrate_version"},{"line_number":11,"context_line":""}],"source_content_type":"text/x-ttcn-cfg","patch_set":3,"id":"3a7e1126_e97a6bbc","line":8,"range":{"start_line":8,"start_character":77,"end_line":8,"end_character":78},"updated":"2015-12-21 16:19:04.000000000","message":"Please remove the white spaces","commit_id":"7b1d481f3d0827cbab7e0117214e06d93ba6f732"},{"author":{"_account_id":17151,"name":"chenying","email":"chenyingko@gmail.com","username":"chenying"},"change_message_id":"10a1856c2e6902e5bf605ce6781b99d46a98c9c4","unresolved":false,"context_lines":[{"line_number":5,"context_line":""},{"line_number":6,"context_line":"# The name of the database table used to track the schema version."},{"line_number":7,"context_line":"# This name shouldn\u0027t already be used by your project."},{"line_number":8,"context_line":"# If this is changed once a database is under version control, you\u0027ll need to "},{"line_number":9,"context_line":"# change the table name in each database too. "},{"line_number":10,"context_line":"version_table\u003dmigrate_version"},{"line_number":11,"context_line":""}],"source_content_type":"text/x-ttcn-cfg","patch_set":3,"id":"3a7e1126_02b217e5","line":8,"range":{"start_line":8,"start_character":77,"end_line":8,"end_character":78},"in_reply_to":"3a7e1126_e97a6bbc","updated":"2015-12-22 04:44:58.000000000","message":"OK","commit_id":"7b1d481f3d0827cbab7e0117214e06d93ba6f732"}],"smaug/db/sqlalchemy/migrate_repo/versions/001_smaug_init.py":[{"author":{"_account_id":2023,"name":"Saggi Mizrahi","email":"ficoos+osreview@gmail.com","username":"ficoos"},"change_message_id":"26b7f91305db7bbc72c0a2cfd84500d70a41a877","unresolved":false,"context_lines":[{"line_number":28,"context_line":"        Column(\u0027topic\u0027, String(length\u003d255)),"},{"line_number":29,"context_line":"        Column(\u0027report_count\u0027, Integer, nullable\u003dFalse),"},{"line_number":30,"context_line":"        Column(\u0027disabled\u0027, Boolean),"},{"line_number":31,"context_line":"        Column(\u0027availability_zone\u0027, String(length\u003d255)),"},{"line_number":32,"context_line":"        Column(\u0027disabled_reason\u0027, String(length\u003d255)),"},{"line_number":33,"context_line":"        Column(\u0027modified_at\u0027, DateTime),"},{"line_number":34,"context_line":"        mysql_engine\u003d\u0027InnoDB\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a7e1126_5b981d1c","line":31,"range":{"start_line":31,"start_character":7,"end_line":31,"end_character":56},"updated":"2015-12-21 16:57:58.000000000","message":"I don\u0027t really know how AZ translates to Smaug. We will need to think about it before including it.","commit_id":"7b1d481f3d0827cbab7e0117214e06d93ba6f732"},{"author":{"_account_id":17151,"name":"chenying","email":"chenyingko@gmail.com","username":"chenying"},"change_message_id":"57a09202465f6ef80fe604dc30933a0be24bbbd8","unresolved":false,"context_lines":[{"line_number":28,"context_line":"        Column(\u0027topic\u0027, String(length\u003d255)),"},{"line_number":29,"context_line":"        Column(\u0027report_count\u0027, Integer, nullable\u003dFalse),"},{"line_number":30,"context_line":"        Column(\u0027disabled\u0027, Boolean),"},{"line_number":31,"context_line":"        Column(\u0027availability_zone\u0027, String(length\u003d255)),"},{"line_number":32,"context_line":"        Column(\u0027disabled_reason\u0027, String(length\u003d255)),"},{"line_number":33,"context_line":"        Column(\u0027modified_at\u0027, DateTime),"},{"line_number":34,"context_line":"        mysql_engine\u003d\u0027InnoDB\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a7e1126_f39d5b0a","line":31,"range":{"start_line":31,"start_character":7,"end_line":31,"end_character":56},"in_reply_to":"3a7e1126_35374b00","updated":"2015-12-22 04:46:43.000000000","message":"I an not sure that availability zone is necessary. So I add this to get some comments. IMO, I also think that wo do not need availability zone. I will remove it.","commit_id":"7b1d481f3d0827cbab7e0117214e06d93ba6f732"},{"author":{"_account_id":17151,"name":"chenying","email":"chenyingko@gmail.com","username":"chenying"},"change_message_id":"10a1856c2e6902e5bf605ce6781b99d46a98c9c4","unresolved":false,"context_lines":[{"line_number":28,"context_line":"        Column(\u0027topic\u0027, String(length\u003d255)),"},{"line_number":29,"context_line":"        Column(\u0027report_count\u0027, Integer, nullable\u003dFalse),"},{"line_number":30,"context_line":"        Column(\u0027disabled\u0027, Boolean),"},{"line_number":31,"context_line":"        Column(\u0027availability_zone\u0027, String(length\u003d255)),"},{"line_number":32,"context_line":"        Column(\u0027disabled_reason\u0027, String(length\u003d255)),"},{"line_number":33,"context_line":"        Column(\u0027modified_at\u0027, DateTime),"},{"line_number":34,"context_line":"        mysql_engine\u003d\u0027InnoDB\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a7e1126_35374b00","line":31,"range":{"start_line":31,"start_character":7,"end_line":31,"end_character":56},"in_reply_to":"3a7e1126_5b981d1c","updated":"2015-12-22 04:44:58.000000000","message":"I also not sure that","commit_id":"7b1d481f3d0827cbab7e0117214e06d93ba6f732"}],"smaug/db/sqlalchemy/models.py":[{"author":{"_account_id":13070,"name":"Eran Gampel","email":"eran@gampel.net","username":"Gampel"},"change_message_id":"8a55773527cb96b8793adeb6dc0ac2d8a6d2cd24","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    topic \u003d Column(String(255))"},{"line_number":53,"context_line":"    report_count \u003d Column(Integer, nullable\u003dFalse, default\u003d0)"},{"line_number":54,"context_line":"    disabled \u003d Column(Boolean, default\u003dFalse)"},{"line_number":55,"context_line":"    availability_zone \u003d Column(String(255), default\u003d\u0027smaug\u0027)"},{"line_number":56,"context_line":"    disabled_reason \u003d Column(String(255))"},{"line_number":57,"context_line":"    # adding column modified_at to contain timestamp"},{"line_number":58,"context_line":"    # for manual enable/disable of smaug services"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a7e1126_15b3440b","line":55,"range":{"start_line":55,"start_character":4,"end_line":55,"end_character":21},"updated":"2015-12-21 16:19:04.000000000","message":"why do we need availability zone ?","commit_id":"7b1d481f3d0827cbab7e0117214e06d93ba6f732"},{"author":{"_account_id":17151,"name":"chenying","email":"chenyingko@gmail.com","username":"chenying"},"change_message_id":"10a1856c2e6902e5bf605ce6781b99d46a98c9c4","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    topic \u003d Column(String(255))"},{"line_number":53,"context_line":"    report_count \u003d Column(Integer, nullable\u003dFalse, default\u003d0)"},{"line_number":54,"context_line":"    disabled \u003d Column(Boolean, default\u003dFalse)"},{"line_number":55,"context_line":"    availability_zone \u003d Column(String(255), default\u003d\u0027smaug\u0027)"},{"line_number":56,"context_line":"    disabled_reason \u003d Column(String(255))"},{"line_number":57,"context_line":"    # adding column modified_at to contain timestamp"},{"line_number":58,"context_line":"    # for manual enable/disable of smaug services"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a7e1126_a2a6a3ab","line":55,"range":{"start_line":55,"start_character":4,"end_line":55,"end_character":21},"in_reply_to":"3a7e1126_15b3440b","updated":"2015-12-22 04:44:58.000000000","message":"I an not sure that availability zone is necessary. So I add this to get some comments. IMO, I also think that wo do not need availability zone. I will remove it.","commit_id":"7b1d481f3d0827cbab7e0117214e06d93ba6f732"},{"author":{"_account_id":13070,"name":"Eran Gampel","email":"eran@gampel.net","username":"Gampel"},"change_message_id":"8a55773527cb96b8793adeb6dc0ac2d8a6d2cd24","unresolved":false,"context_lines":[{"line_number":53,"context_line":"    report_count \u003d Column(Integer, nullable\u003dFalse, default\u003d0)"},{"line_number":54,"context_line":"    disabled \u003d Column(Boolean, default\u003dFalse)"},{"line_number":55,"context_line":"    availability_zone \u003d Column(String(255), default\u003d\u0027smaug\u0027)"},{"line_number":56,"context_line":"    disabled_reason \u003d Column(String(255))"},{"line_number":57,"context_line":"    # adding column modified_at to contain timestamp"},{"line_number":58,"context_line":"    # for manual enable/disable of smaug services"},{"line_number":59,"context_line":"    # updated_at column will now contain timestamps for"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a7e1126_55922c4d","line":56,"range":{"start_line":56,"start_character":21,"end_line":56,"end_character":22},"updated":"2015-12-21 16:19:04.000000000","message":"Maybe we need to add RPC version support","commit_id":"7b1d481f3d0827cbab7e0117214e06d93ba6f732"},{"author":{"_account_id":17151,"name":"chenying","email":"chenyingko@gmail.com","username":"chenying"},"change_message_id":"10a1856c2e6902e5bf605ce6781b99d46a98c9c4","unresolved":false,"context_lines":[{"line_number":53,"context_line":"    report_count \u003d Column(Integer, nullable\u003dFalse, default\u003d0)"},{"line_number":54,"context_line":"    disabled \u003d Column(Boolean, default\u003dFalse)"},{"line_number":55,"context_line":"    availability_zone \u003d Column(String(255), default\u003d\u0027smaug\u0027)"},{"line_number":56,"context_line":"    disabled_reason \u003d Column(String(255))"},{"line_number":57,"context_line":"    # adding column modified_at to contain timestamp"},{"line_number":58,"context_line":"    # for manual enable/disable of smaug services"},{"line_number":59,"context_line":"    # updated_at column will now contain timestamps for"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a7e1126_986bd6b6","line":56,"range":{"start_line":56,"start_character":21,"end_line":56,"end_character":22},"in_reply_to":"3a7e1126_55922c4d","updated":"2015-12-22 04:44:58.000000000","message":"OK I will add it in next patch.","commit_id":"7b1d481f3d0827cbab7e0117214e06d93ba6f732"}],"smaug/utils.py":[{"author":{"_account_id":13070,"name":"Eran Gampel","email":"eran@gampel.net","username":"Gampel"},"change_message_id":"32fbf7910818212aa10da58e50ced8dcfefc1341","unresolved":false,"context_lines":[{"line_number":75,"context_line":"    \"\"\"Check whether a service is up based on last heartbeat.\"\"\""},{"line_number":76,"context_line":"    last_heartbeat \u003d service[\u0027updated_at\u0027] or service[\u0027created_at\u0027]"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    elapsed \u003d (timeutils.utcnow(with_timezone\u003dFalse) -"},{"line_number":79,"context_line":"               last_heartbeat).total_seconds()"},{"line_number":80,"context_line":"    return abs(elapsed) \u003c\u003d CONF.service_down_time"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a7b0d38_bb0653cc","line":78,"range":{"start_line":78,"start_character":32,"end_line":78,"end_character":45},"updated":"2015-12-25 07:06:04.000000000","message":"I think that all of our time calculation should be done with TZ-aware datetime \n\nWhy did you set the the with_timezone to False I think it should be True","commit_id":"cc6508c656856234179e882b6ade5a8866733c80"},{"author":{"_account_id":17151,"name":"chenying","email":"chenyingko@gmail.com","username":"chenying"},"change_message_id":"2b834c73565662f8d2fe8f2dc91dbed77b0fdec0","unresolved":false,"context_lines":[{"line_number":75,"context_line":"    \"\"\"Check whether a service is up based on last heartbeat.\"\"\""},{"line_number":76,"context_line":"    last_heartbeat \u003d service[\u0027updated_at\u0027] or service[\u0027created_at\u0027]"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    elapsed \u003d (timeutils.utcnow(with_timezone\u003dFalse) -"},{"line_number":79,"context_line":"               last_heartbeat).total_seconds()"},{"line_number":80,"context_line":"    return abs(elapsed) \u003c\u003d CONF.service_down_time"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a7b0d38_56c1467f","line":78,"range":{"start_line":78,"start_character":32,"end_line":78,"end_character":45},"in_reply_to":"1a7b0d38_bb0653cc","updated":"2015-12-25 08:24:54.000000000","message":"Yes The with_timezone should be set True. \nThere is a  problem with my linux environment. I set with_timezone\u003dFalse for a test. I will fix it.","commit_id":"cc6508c656856234179e882b6ade5a8866733c80"}]}
