)]}'
{"devstack/plugin.sh":[{"author":{"_account_id":13070,"name":"Eran Gampel","email":"eran@gampel.net","username":"Gampel"},"change_message_id":"0cb108efbf2f6b86154b7786d485b890d9d4a293","unresolved":false,"context_lines":[{"line_number":19,"context_line":"function configure_smaug_api {"},{"line_number":20,"context_line":"    if is_service_enabled smaug-api ; then"},{"line_number":21,"context_line":"        echo \"Configuring Smaug API\""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"        cp $SMAUG_DIR/etc/smaug.conf $SMAUG_API_CONF"},{"line_number":24,"context_line":"        cp $SMAUG_DIR/etc/api-paste.ini $SMAUG_CONF_DIR"},{"line_number":25,"context_line":"        cp $SMAUG_DIR/etc/policy.json $SMAUG_CONF_DIR"}],"source_content_type":"text/x-sh","patch_set":1,"id":"1a7b0d38_a106e119","side":"PARENT","line":22,"updated":"2015-12-29 07:43:07.000000000","message":"What about running the service in devstack will you do it in different patch ?","commit_id":"c2c2dfbb28ee78134b6d554ca9e107b40a9651b5"},{"author":{"_account_id":17151,"name":"chenying","email":"chenyingko@gmail.com","username":"chenying"},"change_message_id":"9182893fa6cd7434b1ec25f7946a976264d70079","unresolved":false,"context_lines":[{"line_number":19,"context_line":"function configure_smaug_api {"},{"line_number":20,"context_line":"    if is_service_enabled smaug-api ; then"},{"line_number":21,"context_line":"        echo \"Configuring Smaug API\""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"        cp $SMAUG_DIR/etc/smaug.conf $SMAUG_API_CONF"},{"line_number":24,"context_line":"        cp $SMAUG_DIR/etc/api-paste.ini $SMAUG_CONF_DIR"},{"line_number":25,"context_line":"        cp $SMAUG_DIR/etc/policy.json $SMAUG_CONF_DIR"}],"source_content_type":"text/x-sh","patch_set":1,"id":"1a7b0d38_61e9d9e5","side":"PARENT","line":22,"in_reply_to":"1a7b0d38_a106e119","updated":"2015-12-29 08:00:49.000000000","message":"This service will run in devstack. I will add it.","commit_id":"c2c2dfbb28ee78134b6d554ca9e107b40a9651b5"},{"author":{"_account_id":13070,"name":"Eran Gampel","email":"eran@gampel.net","username":"Gampel"},"change_message_id":"957b213e87094aab969b134820e2caa41d8624ae","unresolved":false,"context_lines":[{"line_number":114,"context_line":"        if is_service_enabled smaug-api; then"},{"line_number":115,"context_line":"            run_process smaug-api \"$SMAUG_BIN_DIR/smaug-api --config-file $SMAUG_API_CONF\""},{"line_number":116,"context_line":"        fi"},{"line_number":117,"context_line":"        run_process smaug-operationengine \"$SMAUG_BIN_DIR/smaug-operationengine --config-file $SMAUG_API_CONF\""},{"line_number":118,"context_line":"    fi"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"    if [[ \"$1\" \u003d\u003d \"unstack\" ]]; then"}],"source_content_type":"text/x-sh","patch_set":4,"id":"fa69d971_fdbe41fe","line":117,"range":{"start_line":117,"start_character":8,"end_line":117,"end_character":18},"updated":"2015-12-31 08:23:31.000000000","message":"please add \nif is_service_enabled smaug-operationengine; then","commit_id":"ccd2ad29a69a29d1ccc802b73848ab9de345d746"}],"smaug/operationengine/api.py":[{"author":{"_account_id":13070,"name":"Eran Gampel","email":"eran@gampel.net","username":"Gampel"},"change_message_id":"6f4de0832f3151b80c99512e21de70534e977b12","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        super(API, self).__init__(db_driver)"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    def create_scheduled_operation(self, context, request_spec):"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"        self.operationengine_rpcapi.create_scheduled_operation(context,"},{"line_number":39,"context_line":"                                                               request_spec)"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa69d971_389f2bb6","line":37,"range":{"start_line":37,"start_character":0,"end_line":37,"end_character":0},"updated":"2016-01-07 15:55:44.000000000","message":"Usually there is not an empty space in the start of a method \nplease add comment or remove the space","commit_id":"2ad1bc46ea10370b81aba1fc09761ecd5b3da3ae"}],"smaug/scheduler/api.py":[{"author":{"_account_id":13070,"name":"Eran Gampel","email":"eran@gampel.net","username":"Gampel"},"change_message_id":"0cb108efbf2f6b86154b7786d485b890d9d4a293","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        self.scheduler_rpcapi \u003d scheduler_rpcapi.SchedulerAPI()"},{"line_number":33,"context_line":"        super(API, self).__init__(db_driver)"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    def create_test_scheduler(self, context, request_spec):"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"        self.scheduler_rpcapi.create_test_scheduler(context, request_spec)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a7b0d38_41185d75","line":35,"range":{"start_line":35,"start_character":8,"end_line":35,"end_character":29},"updated":"2015-12-29 07:43:07.000000000","message":"same move the test to the test folder","commit_id":"033064e93c64f2c9fea4436e92259896e1a22615"},{"author":{"_account_id":17151,"name":"chenying","email":"chenyingko@gmail.com","username":"chenying"},"change_message_id":"9182893fa6cd7434b1ec25f7946a976264d70079","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        self.scheduler_rpcapi \u003d scheduler_rpcapi.SchedulerAPI()"},{"line_number":33,"context_line":"        super(API, self).__init__(db_driver)"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    def create_test_scheduler(self, context, request_spec):"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"        self.scheduler_rpcapi.create_test_scheduler(context, request_spec)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a7b0d38_61979948","line":35,"range":{"start_line":35,"start_character":8,"end_line":35,"end_character":29},"in_reply_to":"1a7b0d38_41185d75","updated":"2015-12-29 08:00:49.000000000","message":"Done","commit_id":"033064e93c64f2c9fea4436e92259896e1a22615"}],"smaug/scheduler/manager.py":[{"author":{"_account_id":13070,"name":"Eran Gampel","email":"eran@gampel.net","username":"Gampel"},"change_message_id":"0cb108efbf2f6b86154b7786d485b890d9d4a293","unresolved":false,"context_lines":[{"line_number":37,"context_line":"                 *args, **kwargs):"},{"line_number":38,"context_line":"        super(SchedulerManager, self).__init__(*args, **kwargs)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    def create_test_scheduler(self, context, request_spec\u003dNone):"},{"line_number":41,"context_line":"        LOG.debug(\"Received a rpc call from a api service.\""},{"line_number":42,"context_line":"                  \"request_spec:%s\", request_spec)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a7b0d38_de9668ef","line":40,"range":{"start_line":40,"start_character":8,"end_line":40,"end_character":29},"updated":"2015-12-29 07:43:07.000000000","message":"Please move the test to the test folder","commit_id":"033064e93c64f2c9fea4436e92259896e1a22615"},{"author":{"_account_id":17151,"name":"chenying","email":"chenyingko@gmail.com","username":"chenying"},"change_message_id":"9182893fa6cd7434b1ec25f7946a976264d70079","unresolved":false,"context_lines":[{"line_number":37,"context_line":"                 *args, **kwargs):"},{"line_number":38,"context_line":"        super(SchedulerManager, self).__init__(*args, **kwargs)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    def create_test_scheduler(self, context, request_spec\u003dNone):"},{"line_number":41,"context_line":"        LOG.debug(\"Received a rpc call from a api service.\""},{"line_number":42,"context_line":"                  \"request_spec:%s\", request_spec)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a7b0d38_81940543","line":40,"range":{"start_line":40,"start_character":8,"end_line":40,"end_character":29},"in_reply_to":"1a7b0d38_de9668ef","updated":"2015-12-29 08:00:49.000000000","message":"Done","commit_id":"033064e93c64f2c9fea4436e92259896e1a22615"}],"smaug/scheduler/rpcapi.py":[{"author":{"_account_id":13070,"name":"Eran Gampel","email":"eran@gampel.net","username":"Gampel"},"change_message_id":"0cb108efbf2f6b86154b7786d485b890d9d4a293","unresolved":false,"context_lines":[{"line_number":42,"context_line":"                                  version\u003dself.RPC_API_VERSION)"},{"line_number":43,"context_line":"        self.client \u003d rpc.get_client(target, version_cap\u003dNone)"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    def create_test_scheduler(self, ctxt, request_spec\u003dNone):"},{"line_number":46,"context_line":"        request_spec_p \u003d jsonutils.to_primitive(request_spec)"},{"line_number":47,"context_line":"        cctxt \u003d self.client.prepare(version\u003d\u00271.0\u0027)"},{"line_number":48,"context_line":"        return cctxt.cast("}],"source_content_type":"text/x-python","patch_set":1,"id":"1a7b0d38_3ef76c5a","line":45,"range":{"start_line":45,"start_character":8,"end_line":45,"end_character":29},"updated":"2015-12-29 07:43:07.000000000","message":"Please move the test to the test folder.\n\nUntil we finished the RPC definition  You can add a method\n\nadd_scheduled_operation(...)","commit_id":"033064e93c64f2c9fea4436e92259896e1a22615"},{"author":{"_account_id":17151,"name":"chenying","email":"chenyingko@gmail.com","username":"chenying"},"change_message_id":"9182893fa6cd7434b1ec25f7946a976264d70079","unresolved":false,"context_lines":[{"line_number":42,"context_line":"                                  version\u003dself.RPC_API_VERSION)"},{"line_number":43,"context_line":"        self.client \u003d rpc.get_client(target, version_cap\u003dNone)"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    def create_test_scheduler(self, ctxt, request_spec\u003dNone):"},{"line_number":46,"context_line":"        request_spec_p \u003d jsonutils.to_primitive(request_spec)"},{"line_number":47,"context_line":"        cctxt \u003d self.client.prepare(version\u003d\u00271.0\u0027)"},{"line_number":48,"context_line":"        return cctxt.cast("}],"source_content_type":"text/x-python","patch_set":1,"id":"1a7b0d38_c1ad2d9c","line":45,"range":{"start_line":45,"start_character":8,"end_line":45,"end_character":29},"in_reply_to":"1a7b0d38_3ef76c5a","updated":"2015-12-29 08:00:49.000000000","message":"Done","commit_id":"033064e93c64f2c9fea4436e92259896e1a22615"}]}