)]}'
{"smaug/services/protection/clients/cinder.py":[{"author":{"_account_id":20883,"name":"Yuval Brik","email":"yuval@brik.org.il","username":"yuvalbr"},"change_message_id":"d89a274acd6d4b7426fbd049ae0d1a10ceecbec4","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"class CinderClient(client.Client):"},{"line_number":22,"context_line":"    _SERVICE_TYPES \u003d (_VOLUME, _VOLUME_V2) \u003d (\u0027volume\u0027, \u0027volumev2\u0027)"},{"line_number":23,"context_line":"    _CLIENT_VERSIONS \u003d (_CLIENT_VERSION_1, _CLIENT_VERSION_2) \u003d (\u00271\u0027, \u00272\u0027)"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    def _create(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3afc51ec_cf20989e","line":22,"range":{"start_line":22,"start_character":0,"end_line":22,"end_character":67},"updated":"2016-03-13 15:01:19.000000000","message":"I believe \u0027volume\u0027 and \u0027volumev2\u0027 need to be added to service_catalog filtering in context.py, if they are to be found in the catalog by _get_url()","commit_id":"c61990e60b0a8aeb1392698cf35fb626e21debbf"},{"author":{"_account_id":20883,"name":"Yuval Brik","email":"yuval@brik.org.il","username":"yuvalbr"},"change_message_id":"5f3450e7ff63c2138c52e9bce920f384ea14a073","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"SERVICE \u003d \"cinder\""},{"line_number":22,"context_line":"cinder_client_opts \u003d ["},{"line_number":23,"context_line":"    cfg.StrOpt(SERVICE + \u0027_endpoint\u0027,"},{"line_number":24,"context_line":"               help\u003d\u0027The info of the cinder endpoint. \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"1af94dfe_775d8b78","line":21,"range":{"start_line":21,"start_character":0,"end_line":21,"end_character":18},"updated":"2016-03-17 14:04:03.000000000","message":"I think cinder v2 is named cinderv2 in the catalog, and we won\u0027t find it using SERVICE \u003d \"cinder\".\nPlease add two clients, one for \"cinder\" (v1) and one for \"cinderv2\" (v2) (in case we even need v1, I\u0027m not sure)","commit_id":"806aa9ad31417663364a3d7dec5b93b86673ad9d"},{"author":{"_account_id":20883,"name":"Yuval Brik","email":"yuval@brik.org.il","username":"yuvalbr"},"change_message_id":"5f3450e7ff63c2138c52e9bce920f384ea14a073","unresolved":false,"context_lines":[{"line_number":23,"context_line":"    cfg.StrOpt(SERVICE + \u0027_endpoint\u0027,"},{"line_number":24,"context_line":"               help\u003d\u0027The info of the cinder endpoint. \u0027"},{"line_number":25,"context_line":"                    \u0027Format is: separated values of the form: \u0027"},{"line_number":26,"context_line":"                    \u0027\u003cservice_type\u003e;\u003cendpoint_url\u003e;\u003cendpoint_type\u003e\u0027),"},{"line_number":27,"context_line":"    cfg.StrOpt(SERVICE + \u0027_catalog_info\u0027,"},{"line_number":28,"context_line":"               default\u003d\u0027volumev2;cinder;publicURL\u0027,"},{"line_number":29,"context_line":"               help\u003d\u0027Info to match when looking for cinder in the service \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"1af94dfe_9710175b","line":26,"range":{"start_line":26,"start_character":0,"end_line":26,"end_character":69},"updated":"2016-03-17 14:04:03.000000000","message":"See client factory config - no need to specify the service_type and endpoint_type.","commit_id":"806aa9ad31417663364a3d7dec5b93b86673ad9d"}]}