)]}'
{"smaug/operationengine/engine/executors/base.py":[{"author":{"_account_id":20883,"name":"Yuval Brik","email":"yuval@brik.org.il","username":"yuvalbr"},"change_message_id":"7288f07e88999610644f6ebf53551212c87fe560","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        pass"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    @abstractmethod"},{"line_number":50,"context_line":"    def restore_operation(self, operation_id):"},{"line_number":51,"context_line":"        \"\"\"Restore an operation."},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"        Get operations which are not finished from DB by operation_id,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a18252c_f262c115","line":50,"range":{"start_line":50,"start_character":0,"end_line":50,"end_character":46},"updated":"2016-04-12 07:24:47.000000000","message":"I\u0027m afraid this name can cause confusion with the \u0027protect\u0027 operation. Do you think we can find a similar name? Maybe resume_operation?","commit_id":"cbc5faf24f82b2c70bccb67f4a72546491df2a93"},{"author":{"_account_id":18266,"name":"zengchen","email":"chenzeng2@huawei.com","username":"zengchen"},"change_message_id":"6243914cf95fbf828eea7dbc522e9ebe41a402e6","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        pass"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    @abstractmethod"},{"line_number":50,"context_line":"    def restore_operation(self, operation_id):"},{"line_number":51,"context_line":"        \"\"\"Restore an operation."},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"        Get operations which are not finished from DB by operation_id,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a18252c_e092b44a","line":50,"range":{"start_line":50,"start_character":0,"end_line":50,"end_character":46},"in_reply_to":"5a18252c_f262c115","updated":"2016-04-13 02:36:34.000000000","message":"got it. i will update. thanks.","commit_id":"cbc5faf24f82b2c70bccb67f4a72546491df2a93"}],"smaug/operationengine/manager.py":[{"author":{"_account_id":20883,"name":"Yuval Brik","email":"yuval@brik.org.il","username":"yuvalbr"},"change_message_id":"7288f07e88999610644f6ebf53551212c87fe560","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        self._restore_operations()"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    def _restore_triggers(self):"},{"line_number":60,"context_line":"        num \u003d 100"},{"line_number":61,"context_line":"        marker \u003d None"},{"line_number":62,"context_line":"        filters \u003d {}"},{"line_number":63,"context_line":"        ctxt \u003d context.get_admin_context()"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a18252c_320f19e3","line":60,"range":{"start_line":60,"start_character":0,"end_line":60,"end_character":17},"updated":"2016-04-12 07:24:47.000000000","message":"please refactor the variable name to a more verbose name (limit?)","commit_id":"cbc5faf24f82b2c70bccb67f4a72546491df2a93"},{"author":{"_account_id":18266,"name":"zengchen","email":"chenzeng2@huawei.com","username":"zengchen"},"change_message_id":"6243914cf95fbf828eea7dbc522e9ebe41a402e6","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        self._restore_operations()"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    def _restore_triggers(self):"},{"line_number":60,"context_line":"        num \u003d 100"},{"line_number":61,"context_line":"        marker \u003d None"},{"line_number":62,"context_line":"        filters \u003d {}"},{"line_number":63,"context_line":"        ctxt \u003d context.get_admin_context()"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a18252c_609fc450","line":60,"range":{"start_line":60,"start_character":0,"end_line":60,"end_character":17},"in_reply_to":"5a18252c_320f19e3","updated":"2016-04-13 02:36:34.000000000","message":"got it. i will update it. thanks.","commit_id":"cbc5faf24f82b2c70bccb67f4a72546491df2a93"},{"author":{"_account_id":20883,"name":"Yuval Brik","email":"yuval@brik.org.il","username":"yuvalbr"},"change_message_id":"7288f07e88999610644f6ebf53551212c87fe560","unresolved":false,"context_lines":[{"line_number":75,"context_line":"            marker \u003d triggers[-1].id"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    def _restore_operations(self):"},{"line_number":78,"context_line":"        num \u003d 100"},{"line_number":79,"context_line":"        marker \u003d None"},{"line_number":80,"context_line":"        filters \u003d {\"service_id\": self._service_id,"},{"line_number":81,"context_line":"                   \"state\": scheduled_operation_state.REGISTERED}"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a18252c_12149df3","line":78,"range":{"start_line":78,"start_character":0,"end_line":78,"end_character":17},"updated":"2016-04-12 07:24:47.000000000","message":"ditto","commit_id":"cbc5faf24f82b2c70bccb67f4a72546491df2a93"},{"author":{"_account_id":18266,"name":"zengchen","email":"chenzeng2@huawei.com","username":"zengchen"},"change_message_id":"6243914cf95fbf828eea7dbc522e9ebe41a402e6","unresolved":false,"context_lines":[{"line_number":75,"context_line":"            marker \u003d triggers[-1].id"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    def _restore_operations(self):"},{"line_number":78,"context_line":"        num \u003d 100"},{"line_number":79,"context_line":"        marker \u003d None"},{"line_number":80,"context_line":"        filters \u003d {\"service_id\": self._service_id,"},{"line_number":81,"context_line":"                   \"state\": scheduled_operation_state.REGISTERED}"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a18252c_a0a9dc7d","line":78,"range":{"start_line":78,"start_character":0,"end_line":78,"end_character":17},"in_reply_to":"5a18252c_12149df3","updated":"2016-04-13 02:36:34.000000000","message":"Done","commit_id":"cbc5faf24f82b2c70bccb67f4a72546491df2a93"},{"author":{"_account_id":13070,"name":"Eran Gampel","email":"eran@gampel.net","username":"Gampel"},"change_message_id":"0225639fb273669ef99c28d60c6ec5dea819fba9","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        filters \u003d {}"},{"line_number":63,"context_line":"        ctxt \u003d context.get_admin_context()"},{"line_number":64,"context_line":"        while True:"},{"line_number":65,"context_line":"            triggers \u003d objects.TriggerList.get_by_filters("},{"line_number":66,"context_line":"                ctxt, filters, limit, marker)"},{"line_number":67,"context_line":"            if not triggers:"},{"line_number":68,"context_line":"                break"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a18252c_a3354bdb","line":65,"range":{"start_line":65,"start_character":23,"end_line":65,"end_character":58},"updated":"2016-04-13 13:07:49.000000000","message":"This is using direct DB assess best will be to get the data over the RPC","commit_id":"922a186373de8637a1e42b1e0a21915fae6a1836"},{"author":{"_account_id":18266,"name":"zengchen","email":"chenzeng2@huawei.com","username":"zengchen"},"change_message_id":"259738174a5d257b75b65efd5cf8916ba46829f1","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        filters \u003d {}"},{"line_number":63,"context_line":"        ctxt \u003d context.get_admin_context()"},{"line_number":64,"context_line":"        while True:"},{"line_number":65,"context_line":"            triggers \u003d objects.TriggerList.get_by_filters("},{"line_number":66,"context_line":"                ctxt, filters, limit, marker)"},{"line_number":67,"context_line":"            if not triggers:"},{"line_number":68,"context_line":"                break"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a18252c_08396ed7","line":65,"range":{"start_line":65,"start_character":23,"end_line":65,"end_character":58},"in_reply_to":"5a18252c_a3354bdb","updated":"2016-04-14 15:13:33.000000000","message":"Sorry, gampel. According to the discussion with yuval, we are best to change the way of accessing db later. because we don\u0027t have a service offering the api of db at present.","commit_id":"922a186373de8637a1e42b1e0a21915fae6a1836"},{"author":{"_account_id":20883,"name":"Yuval Brik","email":"yuval@brik.org.il","username":"yuvalbr"},"change_message_id":"0a1f489942d84ed668529be531b04bba7740c865","unresolved":false,"context_lines":[{"line_number":78,"context_line":"        limit \u003d 100"},{"line_number":79,"context_line":"        marker \u003d None"},{"line_number":80,"context_line":"        filters \u003d {\"service_id\": self._service_id,"},{"line_number":81,"context_line":"                   \"state\": scheduled_operation_state.REGISTERED}"},{"line_number":82,"context_line":"        columns_to_join \u003d [\u0027operation\u0027]"},{"line_number":83,"context_line":"        ctxt \u003d context.get_admin_context()"},{"line_number":84,"context_line":"        while True:"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a122d0e_8ddf4768","line":81,"range":{"start_line":81,"start_character":0,"end_line":81,"end_character":65},"updated":"2016-04-20 08:19:09.000000000","message":"filter also \u0027running\u0027 and \u0027triggered\u0027 states also","commit_id":"922a186373de8637a1e42b1e0a21915fae6a1836"},{"author":{"_account_id":20883,"name":"Yuval Brik","email":"yuval@brik.org.il","username":"yuvalbr"},"change_message_id":"0a1f489942d84ed668529be531b04bba7740c865","unresolved":false,"context_lines":[{"line_number":90,"context_line":"            for state in states:"},{"line_number":91,"context_line":"                self._trigger_manager.register_operation("},{"line_number":92,"context_line":"                    state.operation.trigger_id, state.operation.id,"},{"line_number":93,"context_line":"                    resume\u003dTrue)"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"            if len(states) \u003c limit:"},{"line_number":96,"context_line":"                break"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a122d0e_0d3977a4","line":93,"range":{"start_line":93,"start_character":0,"end_line":93,"end_character":32},"updated":"2016-04-20 08:19:09.000000000","message":"resume only if state was \u0027running\u0027 or \u0027triggered\u0027.","commit_id":"922a186373de8637a1e42b1e0a21915fae6a1836"}]}