)]}'
{"smaug/api/v1/operation_logs.py":[{"author":{"_account_id":16206,"name":"chenhuayi","email":"chenhuayi@huawei.com","username":"chenhuayi2"},"change_message_id":"a25e7868ab544534aa311390cf1aa29ff7b44d31","unresolved":false,"context_lines":[{"line_number":36,"context_line":"query_operation_log_filters_opt \u003d cfg.ListOpt("},{"line_number":37,"context_line":"    \u0027query_operation_log_filters\u0027,"},{"line_number":38,"context_line":"    default\u003d[\u0027state\u0027, \u0027scheduled_operation_id\u0027],"},{"line_number":39,"context_line":"    help\u003d\"OperationLog filter options which \""},{"line_number":40,"context_line":"    \"non-admin user could use to \""},{"line_number":41,"context_line":"    \"query restores. Default values \""},{"line_number":42,"context_line":"    \"are: [\u0027state\u0027, \u0027scheduled_operation_id\u0027]\")"},{"line_number":43,"context_line":"CONF \u003d cfg.CONF"},{"line_number":44,"context_line":"CONF.register_opt(query_operation_log_filters_opt)"},{"line_number":45,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9abb7d3a_d2f8e74b","line":42,"range":{"start_line":39,"start_character":9,"end_line":42,"end_character":45},"updated":"2016-05-31 08:27:41.000000000","message":"help info should more longer in one line, or else display in the terminal will make not easy to read.","commit_id":"fb9abb4d8b846beda270a65ccb2492d71bcd5475"},{"author":{"_account_id":20883,"name":"Yuval Brik","email":"yuval@brik.org.il","username":"yuvalbr"},"change_message_id":"57d537b94231aef4bdcdb3cb376078b33e070356","unresolved":false,"context_lines":[{"line_number":140,"context_line":""},{"line_number":141,"context_line":"        LOG.info(_LI(\"Show operation_log with id: %s\"), id, context\u003dcontext)"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"        if not uuidutils.is_uuid_like(id):"},{"line_number":144,"context_line":"            msg \u003d _(\"Invalid restore id provided.\")"},{"line_number":145,"context_line":"            raise exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"        try:"},{"line_number":148,"context_line":"            operation_log \u003d self._operation_log_get(context, id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"bab6814e_8d071981","line":145,"range":{"start_line":143,"start_character":0,"end_line":145,"end_character":53},"updated":"2016-05-22 05:10:36.000000000","message":"validation already in _operation_log_get","commit_id":"fb9abb4d8b846beda270a65ccb2492d71bcd5475"}],"smaug/tests/unit/api/v1/test_operation_logs.py":[{"author":{"_account_id":20883,"name":"Yuval Brik","email":"yuval@brik.org.il","username":"yuvalbr"},"change_message_id":"57d537b94231aef4bdcdb3cb376078b33e070356","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    @mock.patch("},{"line_number":33,"context_line":"        \u0027smaug.api.v1.operation_logs.OperationLogsController._get_all\u0027)"},{"line_number":34,"context_line":"    def test_operation_log_list_detail(self, moak_get_all):"},{"line_number":35,"context_line":"        req \u003d fakes.HTTPRequest.blank(\u0027/v1/operation_logs\u0027)"},{"line_number":36,"context_line":"        self.controller.index(req)"},{"line_number":37,"context_line":"        self.assertTrue(moak_get_all.called)"}],"source_content_type":"text/x-python","patch_set":3,"id":"bab6814e_edcfc553","line":34,"range":{"start_line":34,"start_character":0,"end_line":34,"end_character":59},"updated":"2016-05-22 05:10:36.000000000","message":"moak -\u003e mock (in all the file)","commit_id":"fb9abb4d8b846beda270a65ccb2492d71bcd5475"},{"author":{"_account_id":20883,"name":"Yuval Brik","email":"yuval@brik.org.il","username":"yuvalbr"},"change_message_id":"57d537b94231aef4bdcdb3cb376078b33e070356","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    @mock.patch("},{"line_number":33,"context_line":"        \u0027smaug.api.v1.operation_logs.OperationLogsController._get_all\u0027)"},{"line_number":34,"context_line":"    def test_operation_log_list_detail(self, moak_get_all):"},{"line_number":35,"context_line":"        req \u003d fakes.HTTPRequest.blank(\u0027/v1/operation_logs\u0027)"},{"line_number":36,"context_line":"        self.controller.index(req)"},{"line_number":37,"context_line":"        self.assertTrue(moak_get_all.called)"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    @mock.patch("},{"line_number":40,"context_line":"        \u0027smaug.api.v1.operation_logs.OperationLogsController.\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"bab6814e_6d18f5d3","line":37,"range":{"start_line":35,"start_character":0,"end_line":37,"end_character":44},"updated":"2016-05-22 05:10:36.000000000","message":"Tests only check that get_all is called? That doesn\u0027t test anything about the actual \u0027show\u0027 or \u0027get_all\u0027 result.\nConsider mocking `objects.OperationLog.get_by_id` and testing the result. Same goes for all other operations below.","commit_id":"fb9abb4d8b846beda270a65ccb2492d71bcd5475"},{"author":{"_account_id":20883,"name":"Yuval Brik","email":"yuval@brik.org.il","username":"yuvalbr"},"change_message_id":"57d537b94231aef4bdcdb3cb376078b33e070356","unresolved":false,"context_lines":[{"line_number":45,"context_line":"            show(req, \u00272a9ce1f3-cc1a-4516-9435-0ebb13caa398\u0027)"},{"line_number":46,"context_line":"        self.assertTrue(moak_operation_log_get.called)"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    def test_operation_log_show_Invalid(self):"},{"line_number":49,"context_line":"        req \u003d fakes.HTTPRequest.blank(\u0027/v1/operation_logs/1\u0027)"},{"line_number":50,"context_line":"        self.assertRaises("},{"line_number":51,"context_line":"            exc.HTTPBadRequest, self.controller.show,"}],"source_content_type":"text/x-python","patch_set":3,"id":"bab6814e_4ddb711b","line":48,"range":{"start_line":48,"start_character":0,"end_line":48,"end_character":46},"updated":"2016-05-22 05:10:36.000000000","message":"Invalid -\u003e invalid (also below)","commit_id":"fb9abb4d8b846beda270a65ccb2492d71bcd5475"}]}