)]}'
{"smaug/services/protection/bank_plugin.py":[{"author":{"_account_id":2023,"name":"Saggi Mizrahi","email":"ficoos+osreview@gmail.com","username":"ficoos"},"change_message_id":"5f2f7cec1aa45c7379fec00551a29c373ff9e15f","unresolved":false,"context_lines":[{"line_number":111,"context_line":"        return self._plugin.delete_object(self._normalize_key(key))"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    def get_sub_section(self, prefix, is_writable\u003dTrue):"},{"line_number":114,"context_line":"        return BankSection(self, self._prefix + \u0027/\u0027 + prefix, is_writable)"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"class BankSection(object):"}],"source_content_type":"text/x-python","patch_set":4,"id":"dab17558_95a4bfa6","line":114,"range":{"start_line":114,"start_character":33,"end_line":114,"end_character":60},"updated":"2016-05-08 14:02:28.000000000","message":"I think this should just be prefix since this._prefix isn\u0027t defined in the class.","commit_id":"9544668fa75487fa2fb8e8939b9c8bfd939469b4"},{"author":{"_account_id":20883,"name":"Yuval Brik","email":"yuval@brik.org.il","username":"yuvalbr"},"change_message_id":"c9a2d5b66c26b95ba71dd34901004f2cd0385af5","unresolved":false,"context_lines":[{"line_number":111,"context_line":"        return self._plugin.delete_object(self._normalize_key(key))"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    def get_sub_section(self, prefix, is_writable\u003dTrue):"},{"line_number":114,"context_line":"        return BankSection(self, self._prefix + \u0027/\u0027 + prefix, is_writable)"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"class BankSection(object):"}],"source_content_type":"text/x-python","patch_set":4,"id":"dab17558_351073a8","line":114,"range":{"start_line":114,"start_character":33,"end_line":114,"end_character":60},"in_reply_to":"dab17558_95a4bfa6","updated":"2016-05-08 14:17:42.000000000","message":"My bad.","commit_id":"9544668fa75487fa2fb8e8939b9c8bfd939469b4"},{"author":{"_account_id":2023,"name":"Saggi Mizrahi","email":"ficoos+osreview@gmail.com","username":"ficoos"},"change_message_id":"5f2f7cec1aa45c7379fec00551a29c373ff9e15f","unresolved":false,"context_lines":[{"line_number":131,"context_line":""},{"line_number":132,"context_line":"        self._is_writable \u003d is_writable"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"    def get_sub_section(self, prefix):"},{"line_number":135,"context_line":"        return BankSection(self._bank, self._prefix + \u0027/\u0027 + prefix,"},{"line_number":136,"context_line":"                           self._is_writable)"},{"line_number":137,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"dab17558_15b72fd9","line":134,"range":{"start_line":134,"start_character":36,"end_line":134,"end_character":37},"updated":"2016-05-08 14:02:28.000000000","message":"We should allow for a writable section to return a read only section. It also helps keep the interface consistent with the bank version.\n\n , is_writable):\n    if not self._is_writable and is_writable:\n       raise ...","commit_id":"9544668fa75487fa2fb8e8939b9c8bfd939469b4"},{"author":{"_account_id":20883,"name":"Yuval Brik","email":"yuval@brik.org.il","username":"yuvalbr"},"change_message_id":"c9a2d5b66c26b95ba71dd34901004f2cd0385af5","unresolved":false,"context_lines":[{"line_number":131,"context_line":""},{"line_number":132,"context_line":"        self._is_writable \u003d is_writable"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"    def get_sub_section(self, prefix):"},{"line_number":135,"context_line":"        return BankSection(self._bank, self._prefix + \u0027/\u0027 + prefix,"},{"line_number":136,"context_line":"                           self._is_writable)"},{"line_number":137,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"dab17558_157a8ff1","line":134,"range":{"start_line":134,"start_character":36,"end_line":134,"end_character":37},"in_reply_to":"dab17558_15b72fd9","updated":"2016-05-08 14:17:42.000000000","message":"Adding that","commit_id":"9544668fa75487fa2fb8e8939b9c8bfd939469b4"},{"author":{"_account_id":2023,"name":"Saggi Mizrahi","email":"ficoos+osreview@gmail.com","username":"ficoos"},"change_message_id":"5f2f7cec1aa45c7379fec00551a29c373ff9e15f","unresolved":false,"context_lines":[{"line_number":132,"context_line":"        self._is_writable \u003d is_writable"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"    def get_sub_section(self, prefix):"},{"line_number":135,"context_line":"        return BankSection(self._bank, self._prefix + \u0027/\u0027 + prefix,"},{"line_number":136,"context_line":"                           self._is_writable)"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"    @property"},{"line_number":139,"context_line":"    def is_writable(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"dab17558_b5a9037e","line":136,"range":{"start_line":135,"start_character":8,"end_line":136,"end_character":45},"updated":"2016-05-08 14:02:28.000000000","message":"Reuse the bank method.\n\n return self._bank.get_sub_section(self._prefix + \u0027/\u0027 + prefix, is_writable);","commit_id":"9544668fa75487fa2fb8e8939b9c8bfd939469b4"},{"author":{"_account_id":20883,"name":"Yuval Brik","email":"yuval@brik.org.il","username":"yuvalbr"},"change_message_id":"c9a2d5b66c26b95ba71dd34901004f2cd0385af5","unresolved":false,"context_lines":[{"line_number":132,"context_line":"        self._is_writable \u003d is_writable"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"    def get_sub_section(self, prefix):"},{"line_number":135,"context_line":"        return BankSection(self._bank, self._prefix + \u0027/\u0027 + prefix,"},{"line_number":136,"context_line":"                           self._is_writable)"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"    @property"},{"line_number":139,"context_line":"    def is_writable(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"dab17558_550d378f","line":136,"range":{"start_line":135,"start_character":8,"end_line":136,"end_character":45},"in_reply_to":"dab17558_b5a9037e","updated":"2016-05-08 14:17:42.000000000","message":"this is on purpose. If sub_sections are nested, no need to have each sub_section call its parent up to the real bank.","commit_id":"9544668fa75487fa2fb8e8939b9c8bfd939469b4"},{"author":{"_account_id":2023,"name":"Saggi Mizrahi","email":"ficoos+osreview@gmail.com","username":"ficoos"},"change_message_id":"5f2f7cec1aa45c7379fec00551a29c373ff9e15f","unresolved":false,"context_lines":[{"line_number":139,"context_line":"    def is_writable(self):"},{"line_number":140,"context_line":"        return self._is_writable"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"    @property"},{"line_number":143,"context_line":"    def prefix(self):"},{"line_number":144,"context_line":"        return self._prefix"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"    @staticmethod"},{"line_number":147,"context_line":"    def _validate_key(key):"}],"source_content_type":"text/x-python","patch_set":4,"id":"dab17558_d5c5a73c","line":144,"range":{"start_line":142,"start_character":4,"end_line":144,"end_character":27},"updated":"2016-05-08 14:02:28.000000000","message":"Do we really want to expose this? If someone assumes anything about this value (unless during testing) they are making a mistake since the prefixes are not guaranteed to be stable.","commit_id":"9544668fa75487fa2fb8e8939b9c8bfd939469b4"},{"author":{"_account_id":20883,"name":"Yuval Brik","email":"yuval@brik.org.il","username":"yuvalbr"},"change_message_id":"c9a2d5b66c26b95ba71dd34901004f2cd0385af5","unresolved":false,"context_lines":[{"line_number":139,"context_line":"    def is_writable(self):"},{"line_number":140,"context_line":"        return self._is_writable"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"    @property"},{"line_number":143,"context_line":"    def prefix(self):"},{"line_number":144,"context_line":"        return self._prefix"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"    @staticmethod"},{"line_number":147,"context_line":"    def _validate_key(key):"}],"source_content_type":"text/x-python","patch_set":4,"id":"dab17558_95279f11","line":144,"range":{"start_line":142,"start_character":4,"end_line":144,"end_character":27},"in_reply_to":"dab17558_d5c5a73c","updated":"2016-05-08 14:17:42.000000000","message":"Removing","commit_id":"9544668fa75487fa2fb8e8939b9c8bfd939469b4"}]}