)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":2023,"name":"Saggi Mizrahi","email":"ficoos+osreview@gmail.com","username":"ficoos"},"change_message_id":"8cffd62aba52189a21b20ca5afcaf60b2ec3a6b2","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     zhangshuai \u003c446077695@qq.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-05-30 05:47:49 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix create checkpoint API errors in protection service"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch fix the errors when I test \u0027protect\u0027 action with"},{"line_number":10,"context_line":"volume protection plugins."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"9abb7d3a_4ebab90b","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":54},"updated":"2016-05-30 12:10:50.000000000","message":"Please specify what errors and try and have different patches for each fix if possible.","commit_id":"36defa9563ced60a6bca985130467674b848a6a0"}],"etc/providers.d/openstack-infra.conf":[{"author":{"_account_id":20883,"name":"Yuval Brik","email":"yuval@brik.org.il","username":"yuvalbr"},"change_message_id":"1d8ae4d51a3ddae51f4840276211f79861d77c85","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#swift_key\u003dpassword"},{"line_number":14,"context_line":"#swift_tenant_name\u003dadmin"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"#[DEFAULT]"},{"line_number":17,"context_line":"#lease_expire_window\u003d100"},{"line_number":18,"context_line":"#lease_renew_window\u003d100"},{"line_number":19,"context_line":"#lease_validity_window\u003d100"}],"source_content_type":"text/plain","patch_set":3,"id":"bab6814e_ee7bb179","line":16,"range":{"start_line":16,"start_character":0,"end_line":16,"end_character":10},"updated":"2016-05-25 07:25:32.000000000","message":"incorrect section","commit_id":"35b6297af22835e383a0d19a1b9ecac65a8cfc45"},{"author":{"_account_id":17151,"name":"chenying","email":"chenyingko@gmail.com","username":"chenying"},"change_message_id":"1f0a77ecbb49f15afb727cbd9041704b2abd44d2","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#swift_key\u003dpassword"},{"line_number":14,"context_line":"#swift_tenant_name\u003dadmin"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"#[DEFAULT]"},{"line_number":17,"context_line":"#lease_expire_window\u003d100"},{"line_number":18,"context_line":"#lease_renew_window\u003d100"},{"line_number":19,"context_line":"#lease_validity_window\u003d100"}],"source_content_type":"text/plain","patch_set":3,"id":"bab6814e_86756c99","line":16,"range":{"start_line":16,"start_character":0,"end_line":16,"end_character":10},"in_reply_to":"bab6814e_9b2ca503","updated":"2016-05-26 07:17:17.000000000","message":"I see. I will update this patch.","commit_id":"35b6297af22835e383a0d19a1b9ecac65a8cfc45"},{"author":{"_account_id":20883,"name":"Yuval Brik","email":"yuval@brik.org.il","username":"yuvalbr"},"change_message_id":"7bd4fbed48cf8ed6f4eb92d2b29489a8e94bf4d8","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#swift_key\u003dpassword"},{"line_number":14,"context_line":"#swift_tenant_name\u003dadmin"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"#[DEFAULT]"},{"line_number":17,"context_line":"#lease_expire_window\u003d100"},{"line_number":18,"context_line":"#lease_renew_window\u003d100"},{"line_number":19,"context_line":"#lease_validity_window\u003d100"}],"source_content_type":"text/plain","patch_set":3,"id":"bab6814e_9b2ca503","line":16,"range":{"start_line":16,"start_character":0,"end_line":16,"end_character":10},"in_reply_to":"bab6814e_e943ab6a","updated":"2016-05-26 07:01:45.000000000","message":"I mean that it is registered as \u0027swift_bank_plugin\u0027 group in swift_bank_plugin.py","commit_id":"35b6297af22835e383a0d19a1b9ecac65a8cfc45"},{"author":{"_account_id":17151,"name":"chenying","email":"chenyingko@gmail.com","username":"chenying"},"change_message_id":"f54cfbf8f4b155944a3d61368d125b25916cc266","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#swift_key\u003dpassword"},{"line_number":14,"context_line":"#swift_tenant_name\u003dadmin"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"#[DEFAULT]"},{"line_number":17,"context_line":"#lease_expire_window\u003d100"},{"line_number":18,"context_line":"#lease_renew_window\u003d100"},{"line_number":19,"context_line":"#lease_validity_window\u003d100"}],"source_content_type":"text/plain","patch_set":3,"id":"bab6814e_e943ab6a","line":16,"range":{"start_line":16,"start_character":0,"end_line":16,"end_character":10},"in_reply_to":"bab6814e_ee7bb179","updated":"2016-05-25 07:57:24.000000000","message":"Do you mean that the section is not needed here?","commit_id":"35b6297af22835e383a0d19a1b9ecac65a8cfc45"}],"smaug/services/protection/bank_plugins/swift_bank_plugin.py":[{"author":{"_account_id":20883,"name":"Yuval Brik","email":"yuval@brik.org.il","username":"yuvalbr"},"change_message_id":"1d8ae4d51a3ddae51f4840276211f79861d77c85","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"lease_opt \u003d [cfg.IntOpt(\u0027lease_expire_window\u0027,"},{"line_number":37,"context_line":"                        default\u003d600,"},{"line_number":38,"context_line":"                        help\u003d\u0027expired_window for bank lease, in seconds\u0027),"},{"line_number":39,"context_line":"             cfg.IntOpt(\u0027lease_renew_window\u0027,"},{"line_number":40,"context_line":"                        default\u003d120,"},{"line_number":41,"context_line":"                        help\u003d\u0027period for bank lease, in seconds, \u0027"},{"line_number":42,"context_line":"                             \u0027between bank lease client renew the lease\u0027),"},{"line_number":43,"context_line":"             cfg.IntOpt(\u0027lease_validity_window\u0027,"},{"line_number":44,"context_line":"                        default\u003d100,"},{"line_number":45,"context_line":"                        help\u003d\u0027validity_window for bank lease, in seconds\u0027), ]"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"class SwiftConnectionFailed(exception.SmaugException):"}],"source_content_type":"text/x-python","patch_set":3,"id":"bab6814e_036d2e04","line":45,"range":{"start_line":36,"start_character":0,"end_line":45,"end_character":77},"updated":"2016-05-25 07:25:32.000000000","message":"are these swift_bank_plugin specific? they also exist in common/config.py\nhow about registering these options in LeasePlugin constructor?","commit_id":"35b6297af22835e383a0d19a1b9ecac65a8cfc45"},{"author":{"_account_id":17151,"name":"chenying","email":"chenyingko@gmail.com","username":"chenying"},"change_message_id":"f54cfbf8f4b155944a3d61368d125b25916cc266","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"lease_opt \u003d [cfg.IntOpt(\u0027lease_expire_window\u0027,"},{"line_number":37,"context_line":"                        default\u003d600,"},{"line_number":38,"context_line":"                        help\u003d\u0027expired_window for bank lease, in seconds\u0027),"},{"line_number":39,"context_line":"             cfg.IntOpt(\u0027lease_renew_window\u0027,"},{"line_number":40,"context_line":"                        default\u003d120,"},{"line_number":41,"context_line":"                        help\u003d\u0027period for bank lease, in seconds, \u0027"},{"line_number":42,"context_line":"                             \u0027between bank lease client renew the lease\u0027),"},{"line_number":43,"context_line":"             cfg.IntOpt(\u0027lease_validity_window\u0027,"},{"line_number":44,"context_line":"                        default\u003d100,"},{"line_number":45,"context_line":"                        help\u003d\u0027validity_window for bank lease, in seconds\u0027), ]"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"class SwiftConnectionFailed(exception.SmaugException):"}],"source_content_type":"text/x-python","patch_set":3,"id":"bab6814e_c9a18748","line":45,"range":{"start_line":36,"start_character":0,"end_line":45,"end_character":77},"in_reply_to":"bab6814e_036d2e04","updated":"2016-05-25 07:57:24.000000000","message":"Yes, these config are swift_bank_plugin specific. I will delete the config in common/config.py.","commit_id":"35b6297af22835e383a0d19a1b9ecac65a8cfc45"},{"author":{"_account_id":17151,"name":"chenying","email":"chenyingko@gmail.com","username":"chenying"},"change_message_id":"1f0a77ecbb49f15afb727cbd9041704b2abd44d2","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"lease_opt \u003d [cfg.IntOpt(\u0027lease_expire_window\u0027,"},{"line_number":37,"context_line":"                        default\u003d600,"},{"line_number":38,"context_line":"                        help\u003d\u0027expired_window for bank lease, in seconds\u0027),"},{"line_number":39,"context_line":"             cfg.IntOpt(\u0027lease_renew_window\u0027,"},{"line_number":40,"context_line":"                        default\u003d120,"},{"line_number":41,"context_line":"                        help\u003d\u0027period for bank lease, in seconds, \u0027"},{"line_number":42,"context_line":"                             \u0027between bank lease client renew the lease\u0027),"},{"line_number":43,"context_line":"             cfg.IntOpt(\u0027lease_validity_window\u0027,"},{"line_number":44,"context_line":"                        default\u003d100,"},{"line_number":45,"context_line":"                        help\u003d\u0027validity_window for bank lease, in seconds\u0027), ]"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"class SwiftConnectionFailed(exception.SmaugException):"}],"source_content_type":"text/x-python","patch_set":3,"id":"bab6814e_3b2ad990","line":45,"range":{"start_line":36,"start_character":0,"end_line":45,"end_character":77},"in_reply_to":"bab6814e_bbb249e3","updated":"2016-05-26 07:17:17.000000000","message":"Yes, It depends on its own implementation of BankPlugin. If this BankPlugin need additional config, it need register in his own module.","commit_id":"35b6297af22835e383a0d19a1b9ecac65a8cfc45"},{"author":{"_account_id":20883,"name":"Yuval Brik","email":"yuval@brik.org.il","username":"yuvalbr"},"change_message_id":"2036b5b5204e8734d341ca8c19dc5b1e1b68911b","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"lease_opt \u003d [cfg.IntOpt(\u0027lease_expire_window\u0027,"},{"line_number":37,"context_line":"                        default\u003d600,"},{"line_number":38,"context_line":"                        help\u003d\u0027expired_window for bank lease, in seconds\u0027),"},{"line_number":39,"context_line":"             cfg.IntOpt(\u0027lease_renew_window\u0027,"},{"line_number":40,"context_line":"                        default\u003d120,"},{"line_number":41,"context_line":"                        help\u003d\u0027period for bank lease, in seconds, \u0027"},{"line_number":42,"context_line":"                             \u0027between bank lease client renew the lease\u0027),"},{"line_number":43,"context_line":"             cfg.IntOpt(\u0027lease_validity_window\u0027,"},{"line_number":44,"context_line":"                        default\u003d100,"},{"line_number":45,"context_line":"                        help\u003d\u0027validity_window for bank lease, in seconds\u0027), ]"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"class SwiftConnectionFailed(exception.SmaugException):"}],"source_content_type":"text/x-python","patch_set":3,"id":"bab6814e_bbb249e3","line":45,"range":{"start_line":36,"start_character":0,"end_line":45,"end_character":77},"in_reply_to":"bab6814e_c9a18748","updated":"2016-05-26 06:59:31.000000000","message":"So, if I write another BankPlugin (i.e S3BankPlugin), I might register different options?","commit_id":"35b6297af22835e383a0d19a1b9ecac65a8cfc45"},{"author":{"_account_id":20883,"name":"Yuval Brik","email":"yuval@brik.org.il","username":"yuvalbr"},"change_message_id":"1d8ae4d51a3ddae51f4840276211f79861d77c85","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        super(SwiftBankPlugin, self).__init__(config)"},{"line_number":55,"context_line":"        self._config.register_opts(swift_bank_plugin_opts,"},{"line_number":56,"context_line":"                                   \"swift_bank_plugin\")"},{"line_number":57,"context_line":"        self._config.register_opts(lease_opt)"},{"line_number":58,"context_line":"        self.bank_object_container \u003d \\"},{"line_number":59,"context_line":"            self._config.swift_bank_plugin.bank_swift_object_container"},{"line_number":60,"context_line":"        self.lease_expire_window \u003d self._config.lease_expire_window"}],"source_content_type":"text/x-python","patch_set":3,"id":"bab6814e_e36f4afa","line":57,"range":{"start_line":57,"start_character":0,"end_line":57,"end_character":45},"updated":"2016-05-25 07:25:32.000000000","message":"ditto","commit_id":"35b6297af22835e383a0d19a1b9ecac65a8cfc45"}],"smaug/services/protection/checkpoint.py":[{"author":{"_account_id":16206,"name":"chenhuayi","email":"chenhuayi@huawei.com","username":"chenhuayi2"},"change_message_id":"eba4af30791603095b00638cfb6d1820f8dbf841","unresolved":false,"context_lines":[{"line_number":130,"context_line":"                          checkpoint_id)"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"    def commit(self):"},{"line_number":133,"context_line":"        # TODO(luobin) luobin will submit a patch to fix this bank_lease error"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"        # if self._bank_lease is not None:"},{"line_number":136,"context_line":"        #     if self._bank_lease.check_lease_validity():"},{"line_number":137,"context_line":"        #        self._bank_section.create_object("},{"line_number":138,"context_line":"        #            key\u003dself._index_file_path,"},{"line_number":139,"context_line":"        #            value\u003dself._md_cache,"},{"line_number":140,"context_line":"        #        )"},{"line_number":141,"context_line":"        #    else:"},{"line_number":142,"context_line":"        #        raise RuntimeError(\"Could not commit: lease isn\u0027t valid \""},{"line_number":143,"context_line":"        #                           \"for enough commit time\")"},{"line_number":144,"context_line":"        # else:"},{"line_number":145,"context_line":"        self._bank_section.create_object("},{"line_number":146,"context_line":"            key\u003dself._index_file_path,"},{"line_number":147,"context_line":"            value\u003dself._md_cache,"}],"source_content_type":"text/x-python","patch_set":5,"id":"9abb7d3a_0fce455a","line":144,"range":{"start_line":133,"start_character":0,"end_line":144,"end_character":15},"updated":"2016-05-27 03:47:19.000000000","message":"If no need, pls delete it.","commit_id":"72f624ff5552462650136091e2187f28c076bc25"},{"author":{"_account_id":2023,"name":"Saggi Mizrahi","email":"ficoos+osreview@gmail.com","username":"ficoos"},"change_message_id":"8cffd62aba52189a21b20ca5afcaf60b2ec3a6b2","unresolved":false,"context_lines":[{"line_number":132,"context_line":"    def commit(self):"},{"line_number":133,"context_line":"        # TODO(luobin) luobin will submit a patch to fix this bank_lease error"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"        # if self._bank_lease is not None:"},{"line_number":136,"context_line":"        #     if self._bank_lease.check_lease_validity():"},{"line_number":137,"context_line":"        #        self._bank_section.create_object("},{"line_number":138,"context_line":"        #            key\u003dself._index_file_path,"},{"line_number":139,"context_line":"        #            value\u003dself._md_cache,"},{"line_number":140,"context_line":"        #        )"},{"line_number":141,"context_line":"        #    else:"},{"line_number":142,"context_line":"        #        raise RuntimeError(\"Could not commit: lease isn\u0027t valid \""},{"line_number":143,"context_line":"        #                           \"for enough commit time\")"},{"line_number":144,"context_line":"        # else:"},{"line_number":145,"context_line":"        self._bank_section.create_object("},{"line_number":146,"context_line":"            key\u003dself._index_file_path,"},{"line_number":147,"context_line":"            value\u003dself._md_cache,"}],"source_content_type":"text/x-python","patch_set":6,"id":"9abb7d3a_ee58cdfc","line":144,"range":{"start_line":135,"start_character":8,"end_line":144,"end_character":15},"updated":"2016-05-30 12:10:50.000000000","message":"Then I\u0027ll just commit his fix. No need for commented code in the codebase.","commit_id":"36defa9563ced60a6bca985130467674b848a6a0"},{"author":{"_account_id":13070,"name":"Eran Gampel","email":"eran@gampel.net","username":"Gampel"},"change_message_id":"e6af2aa211b4374237f410ff553fafe80f3ca310","unresolved":false,"context_lines":[{"line_number":132,"context_line":"    def commit(self):"},{"line_number":133,"context_line":"        # TODO(luobin) luobin will submit a patch to fix this bank_lease error"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"        # if self._bank_lease is not None:"},{"line_number":136,"context_line":"        #     if self._bank_lease.check_lease_validity():"},{"line_number":137,"context_line":"        #        self._bank_section.create_object("},{"line_number":138,"context_line":"        #            key\u003dself._index_file_path,"},{"line_number":139,"context_line":"        #            value\u003dself._md_cache,"},{"line_number":140,"context_line":"        #        )"},{"line_number":141,"context_line":"        #    else:"},{"line_number":142,"context_line":"        #        raise RuntimeError(\"Could not commit: lease isn\u0027t valid \""},{"line_number":143,"context_line":"        #                           \"for enough commit time\")"},{"line_number":144,"context_line":"        # else:"},{"line_number":145,"context_line":"        self._bank_section.create_object("},{"line_number":146,"context_line":"            key\u003dself._index_file_path,"},{"line_number":147,"context_line":"            value\u003dself._md_cache,"}],"source_content_type":"text/x-python","patch_set":6,"id":"9abb7d3a_0216c554","line":144,"range":{"start_line":135,"start_character":8,"end_line":144,"end_character":15},"in_reply_to":"9abb7d3a_ee58cdfc","updated":"2016-05-30 12:49:52.000000000","message":"I agree","commit_id":"36defa9563ced60a6bca985130467674b848a6a0"},{"author":{"_account_id":13070,"name":"Eran Gampel","email":"eran@gampel.net","username":"Gampel"},"change_message_id":"5dbf9d428fc49b56a70d7897ee3993f85e443a5d","unresolved":false,"context_lines":[{"line_number":130,"context_line":"                          checkpoint_id)"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"    def commit(self):"},{"line_number":133,"context_line":"        # TODO(luobin) luobin will submit a patch to fix this bank_lease error"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"        # if self._bank_lease is not None:"},{"line_number":136,"context_line":"        #     if self._bank_lease.check_lease_validity():"},{"line_number":137,"context_line":"        #        self._bank_section.create_object("},{"line_number":138,"context_line":"        #            key\u003dself._index_file_path,"},{"line_number":139,"context_line":"        #            value\u003dself._md_cache,"},{"line_number":140,"context_line":"        #        )"},{"line_number":141,"context_line":"        #    else:"},{"line_number":142,"context_line":"        #        raise RuntimeError(\"Could not commit: lease isn\u0027t valid \""},{"line_number":143,"context_line":"        #                           \"for enough commit time\")"},{"line_number":144,"context_line":"        # else:"},{"line_number":145,"context_line":"        self._bank_section.create_object("},{"line_number":146,"context_line":"            key\u003dself._index_file_path,"},{"line_number":147,"context_line":"            value\u003dself._md_cache,"}],"source_content_type":"text/x-python","patch_set":7,"id":"9abb7d3a_1499bf1f","line":144,"range":{"start_line":133,"start_character":8,"end_line":144,"end_character":15},"updated":"2016-05-31 07:54:17.000000000","message":"When is this patch going to be submitted \nIn general i agree with saggi that it does not make sense to comment code in one patch and have another patch fix it.\nMaybe just remove those line and submit a BUG","commit_id":"0b9a1ef1933a89238c499a8dc2c3123549bbf421"},{"author":{"_account_id":19346,"name":"yinwei","email":"yinweiishere@icloud.com","username":"yinwei"},"change_message_id":"54fa8f199c509058ae0144c4596767ffa4e1d1db","unresolved":false,"context_lines":[{"line_number":130,"context_line":"                          checkpoint_id)"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"    def commit(self):"},{"line_number":133,"context_line":"        self._bank_section.create_object("},{"line_number":134,"context_line":"            key\u003dself._index_file_path,"},{"line_number":135,"context_line":"            value\u003dself._md_cache,"},{"line_number":136,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":9,"id":"9abb7d3a_53016669","line":133,"updated":"2016-06-01 00:52:13.000000000","message":"sorry, what\u0027s the solution of lease check at last? We will remove lease checking for now?","commit_id":"1064401f94e600d8f63438b0e0c444ecb3591cf9"},{"author":{"_account_id":17151,"name":"chenying","email":"chenyingko@gmail.com","username":"chenying"},"change_message_id":"5729fdec1cccca72ab3feca88cbe2381d5cf78c5","unresolved":false,"context_lines":[{"line_number":130,"context_line":"                          checkpoint_id)"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"    def commit(self):"},{"line_number":133,"context_line":"        self._bank_section.create_object("},{"line_number":134,"context_line":"            key\u003dself._index_file_path,"},{"line_number":135,"context_line":"            value\u003dself._md_cache,"},{"line_number":136,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":9,"id":"9abb7d3a_76dbb84f","line":133,"in_reply_to":"9abb7d3a_53016669","updated":"2016-06-01 01:37:04.000000000","message":"Luobin will submit a patch to add the check, and make sure that it work.","commit_id":"1064401f94e600d8f63438b0e0c444ecb3591cf9"}],"smaug/services/protection/manager.py":[{"author":{"_account_id":20883,"name":"Yuval Brik","email":"yuval@brik.org.il","username":"yuvalbr"},"change_message_id":"1d8ae4d51a3ddae51f4840276211f79861d77c85","unresolved":false,"context_lines":[{"line_number":257,"context_line":"            \"dependent_types\": dependents"},{"line_number":258,"context_line":"        }"},{"line_number":259,"context_line":""},{"line_number":260,"context_line":"    def list_protectable_instances(self, context,"},{"line_number":261,"context_line":"                                   protectable_type\u003dNone,"},{"line_number":262,"context_line":"                                   marker\u003dNone,"},{"line_number":263,"context_line":"                                   limit\u003dNone,"},{"line_number":264,"context_line":"                                   sort_keys\u003dNone,"},{"line_number":265,"context_line":"                                   sort_dirs\u003dNone,"},{"line_number":266,"context_line":"                                   filters\u003dNone):"},{"line_number":267,"context_line":"        LOG.info(_LI(\"Start to list protectable instances of type: %s\"),"},{"line_number":268,"context_line":"                 protectable_type)"},{"line_number":269,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"bab6814e_aefec902","line":266,"range":{"start_line":260,"start_character":0,"end_line":266,"end_character":49},"updated":"2016-05-25 07:25:32.000000000","message":"How does this relate to fixing the checkpoint api? (if it doesn\u0027t, submit in another patch)\nDoesn\u0027t this mean these params need to be added to ProtectableController too?","commit_id":"35b6297af22835e383a0d19a1b9ecac65a8cfc45"},{"author":{"_account_id":17151,"name":"chenying","email":"chenyingko@gmail.com","username":"chenying"},"change_message_id":"f54cfbf8f4b155944a3d61368d125b25916cc266","unresolved":false,"context_lines":[{"line_number":257,"context_line":"            \"dependent_types\": dependents"},{"line_number":258,"context_line":"        }"},{"line_number":259,"context_line":""},{"line_number":260,"context_line":"    def list_protectable_instances(self, context,"},{"line_number":261,"context_line":"                                   protectable_type\u003dNone,"},{"line_number":262,"context_line":"                                   marker\u003dNone,"},{"line_number":263,"context_line":"                                   limit\u003dNone,"},{"line_number":264,"context_line":"                                   sort_keys\u003dNone,"},{"line_number":265,"context_line":"                                   sort_dirs\u003dNone,"},{"line_number":266,"context_line":"                                   filters\u003dNone):"},{"line_number":267,"context_line":"        LOG.info(_LI(\"Start to list protectable instances of type: %s\"),"},{"line_number":268,"context_line":"                 protectable_type)"},{"line_number":269,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"bab6814e_494477b6","line":266,"range":{"start_line":260,"start_character":0,"end_line":266,"end_character":49},"in_reply_to":"bab6814e_aefec902","updated":"2016-05-25 07:57:24.000000000","message":"It is better to submit a new patch. It is not relate to this one. These params have been added to ProtectableController.","commit_id":"35b6297af22835e383a0d19a1b9ecac65a8cfc45"}]}