)]}'
{"smaug/tests/fullstack/smaug_base.py":[{"author":{"_account_id":20883,"name":"Yuval Brik","email":"yuval@brik.org.il","username":"yuvalbr"},"change_message_id":"465ed612d94fe93124bebc34d21bbf74f105c3a7","unresolved":false,"context_lines":[{"line_number":149,"context_line":""},{"line_number":150,"context_line":"    def create_volume(self, size, name\u003dNone):"},{"line_number":151,"context_line":"        volume \u003d self.cinder_client.volumes.create(size, name\u003dname)"},{"line_number":152,"context_line":"        sleep(10)"},{"line_number":153,"context_line":"        return volume"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"    def delete_volume(self, volume_id):"}],"source_content_type":"text/x-python","patch_set":10,"id":"7aa08908_b3729eab","line":152,"range":{"start_line":152,"start_character":0,"end_line":152,"end_character":17},"updated":"2016-06-07 08:29:07.000000000","message":"poll until it is ready instead of sleeping a constant amount of time?","commit_id":"edfb8e23b40d3653485b1da9c3980e85ebb2b999"},{"author":{"_account_id":21648,"name":"zhangshuai","email":"446077695@qq.com","username":"zhangshuai"},"change_message_id":"f762762c623e7f73e558679916d86997acfd9ea5","unresolved":false,"context_lines":[{"line_number":149,"context_line":""},{"line_number":150,"context_line":"    def create_volume(self, size, name\u003dNone):"},{"line_number":151,"context_line":"        volume \u003d self.cinder_client.volumes.create(size, name\u003dname)"},{"line_number":152,"context_line":"        sleep(10)"},{"line_number":153,"context_line":"        return volume"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"    def delete_volume(self, volume_id):"}],"source_content_type":"text/x-python","patch_set":10,"id":"7aa08908_53509a5d","line":152,"range":{"start_line":152,"start_character":0,"end_line":152,"end_character":17},"in_reply_to":"7aa08908_b3729eab","updated":"2016-06-07 08:37:37.000000000","message":"it\u0027s probably temporary,I will fix it next patch.","commit_id":"edfb8e23b40d3653485b1da9c3980e85ebb2b999"},{"author":{"_account_id":20883,"name":"Yuval Brik","email":"yuval@brik.org.il","username":"yuvalbr"},"change_message_id":"465ed612d94fe93124bebc34d21bbf74f105c3a7","unresolved":false,"context_lines":[{"line_number":154,"context_line":""},{"line_number":155,"context_line":"    def delete_volume(self, volume_id):"},{"line_number":156,"context_line":"        self.cinder_client.volumes.delete(volume_id)"},{"line_number":157,"context_line":"        sleep(30)"}],"source_content_type":"text/x-python","patch_set":10,"id":"7aa08908_136a92b3","line":157,"range":{"start_line":157,"start_character":0,"end_line":157,"end_character":17},"updated":"2016-06-07 08:29:07.000000000","message":"ditto","commit_id":"edfb8e23b40d3653485b1da9c3980e85ebb2b999"},{"author":{"_account_id":13070,"name":"Eran Gampel","email":"eran@gampel.net","username":"Gampel"},"change_message_id":"274edfefdb3ef6a3330d1f9e3559044e2256d4c1","unresolved":false,"context_lines":[{"line_number":138,"context_line":""},{"line_number":139,"context_line":"    def create_volume(self, size, name\u003dNone):"},{"line_number":140,"context_line":"        volume \u003d self.cinder_client.volumes.create(size, name\u003dname)"},{"line_number":141,"context_line":"        sleep(10)"},{"line_number":142,"context_line":"        return volume"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"    def delete_volume(self, volume_id):"}],"source_content_type":"text/x-python","patch_set":11,"id":"7aa08908_92a3fcff","line":141,"range":{"start_line":141,"start_character":8,"end_line":141,"end_character":13},"updated":"2016-06-07 15:39:58.000000000","message":"I think that we should use wait for condition \nBut we could do it in another patch","commit_id":"bcebc28c50c09b3666be11710426e618c7031032"},{"author":{"_account_id":21648,"name":"zhangshuai","email":"446077695@qq.com","username":"zhangshuai"},"change_message_id":"96a7d737173e21fced0df07066d641edcf089a16","unresolved":false,"context_lines":[{"line_number":138,"context_line":""},{"line_number":139,"context_line":"    def create_volume(self, size, name\u003dNone):"},{"line_number":140,"context_line":"        volume \u003d self.cinder_client.volumes.create(size, name\u003dname)"},{"line_number":141,"context_line":"        sleep(10)"},{"line_number":142,"context_line":"        return volume"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"    def delete_volume(self, volume_id):"}],"source_content_type":"text/x-python","patch_set":11,"id":"7aa08908_f8f848c5","line":141,"range":{"start_line":141,"start_character":8,"end_line":141,"end_character":13},"in_reply_to":"7aa08908_92a3fcff","updated":"2016-06-08 01:36:13.000000000","message":"Yes,i agree with you, and i really intended to do like that.","commit_id":"bcebc28c50c09b3666be11710426e618c7031032"}],"smaug/tests/fullstack/test_plans.py":[{"author":{"_account_id":17151,"name":"chenying","email":"chenyingko@gmail.com","username":"chenying"},"change_message_id":"5cd9fc599e705ebc93402571a040c26215bb50e4","unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    def test_plans_create(self):"},{"line_number":53,"context_line":"        volume_id \u003d self.create_volume(1).id"},{"line_number":54,"context_line":"        providers \u003d self.provider_list()"},{"line_number":55,"context_line":"        plan1, plan2 \u003d self.create_plan(providers[0].id, volume_id)"},{"line_number":56,"context_line":"        plan_item \u003d utils.wait_until_is_and_return("},{"line_number":57,"context_line":"            lambda: self.smaug_client.plans.get(plan1.get(\"id\")),"}],"source_content_type":"text/x-python","patch_set":6,"id":"7aa08908_e8c10830","line":54,"range":{"start_line":54,"start_character":8,"end_line":54,"end_character":40},"updated":"2016-06-06 12:06:38.000000000","message":"Does a assert to check providers not none here?","commit_id":"2c0c483bc7b5e54ec1c3dee1491da25b776c75bb"},{"author":{"_account_id":17151,"name":"chenying","email":"chenyingko@gmail.com","username":"chenying"},"change_message_id":"5cd9fc599e705ebc93402571a040c26215bb50e4","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    def test_plans_list(self):"},{"line_number":67,"context_line":"        volume_id \u003d self.create_volume(1).id"},{"line_number":68,"context_line":"        providers \u003d self.provider_list()"},{"line_number":69,"context_line":"        plans \u003d self.smaug_client.plans.list()"},{"line_number":70,"context_line":"        before_num \u003d len(plans)"},{"line_number":71,"context_line":"        plan1, plan2 \u003d self.create_plan(providers[0].id, volume_id)"}],"source_content_type":"text/x-python","patch_set":6,"id":"7aa08908_e84628be","line":68,"range":{"start_line":68,"start_character":20,"end_line":68,"end_character":24},"updated":"2016-06-06 12:06:38.000000000","message":"ditto","commit_id":"2c0c483bc7b5e54ec1c3dee1491da25b776c75bb"},{"author":{"_account_id":17151,"name":"chenying","email":"chenyingko@gmail.com","username":"chenying"},"change_message_id":"5cd9fc599e705ebc93402571a040c26215bb50e4","unresolved":false,"context_lines":[{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    def test_plans_get(self):"},{"line_number":83,"context_line":"        volume_id \u003d self.create_volume(1).id"},{"line_number":84,"context_line":"        providers \u003d self.provider_list()"},{"line_number":85,"context_line":"        plan1, plan2 \u003d self.create_plan(providers[0].id, volume_id)"},{"line_number":86,"context_line":"        plan_item \u003d utils.wait_until_is_and_return("},{"line_number":87,"context_line":"            lambda: self.smaug_client.plans.get(plan1.get(\"id\")),"}],"source_content_type":"text/x-python","patch_set":6,"id":"7aa08908_e81d88be","line":84,"range":{"start_line":84,"start_character":8,"end_line":84,"end_character":40},"updated":"2016-06-06 12:06:38.000000000","message":"ditto","commit_id":"2c0c483bc7b5e54ec1c3dee1491da25b776c75bb"},{"author":{"_account_id":17151,"name":"chenying","email":"chenyingko@gmail.com","username":"chenying"},"change_message_id":"5cd9fc599e705ebc93402571a040c26215bb50e4","unresolved":false,"context_lines":[{"line_number":87,"context_line":"            lambda: self.smaug_client.plans.get(plan1.get(\"id\")),"},{"line_number":88,"context_line":"            exception\u003dException(\u0027No plan data in db\u0027)"},{"line_number":89,"context_line":"        )"},{"line_number":90,"context_line":"        self.assertEqual(\"My plan app1\", plan_item.name)"},{"line_number":91,"context_line":"        self.smaug_client.plans.delete(plan1.get(\"id\"))"},{"line_number":92,"context_line":"        self.smaug_client.plans.delete(plan2.get(\"id\"))"},{"line_number":93,"context_line":"        self.delete_volume(volume_id)"}],"source_content_type":"text/x-python","patch_set":6,"id":"7aa08908_48181c85","line":90,"range":{"start_line":90,"start_character":8,"end_line":90,"end_character":56},"updated":"2016-06-06 12:06:38.000000000","message":"Since two plans have been created, you could add a assert for plan2.","commit_id":"2c0c483bc7b5e54ec1c3dee1491da25b776c75bb"},{"author":{"_account_id":17151,"name":"chenying","email":"chenyingko@gmail.com","username":"chenying"},"change_message_id":"5cd9fc599e705ebc93402571a040c26215bb50e4","unresolved":false,"context_lines":[{"line_number":92,"context_line":"        self.smaug_client.plans.delete(plan2.get(\"id\"))"},{"line_number":93,"context_line":"        self.delete_volume(volume_id)"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    def test_plans_update(self):"},{"line_number":96,"context_line":"        volume_id \u003d self.create_volume(1).id"},{"line_number":97,"context_line":"        providers \u003d self.provider_list()"},{"line_number":98,"context_line":"        plan1, plan2 \u003d self.create_plan(providers[0].id, volume_id)"}],"source_content_type":"text/x-python","patch_set":6,"id":"7aa08908_43263dbb","line":95,"range":{"start_line":95,"start_character":8,"end_line":95,"end_character":25},"updated":"2016-06-06 12:06:38.000000000","message":"I think you could add more test to update another parameter.","commit_id":"2c0c483bc7b5e54ec1c3dee1491da25b776c75bb"}],"smaug/tests/fullstack/test_providers.py":[{"author":{"_account_id":17151,"name":"chenying","email":"chenyingko@gmail.com","username":"chenying"},"change_message_id":"150e67ca5a7986fd7eb5622a70e502faa2dcca14","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    def test_providers_list(self):"},{"line_number":25,"context_line":"        provider_res \u003d self.smaug_client.providers.list()"},{"line_number":26,"context_line":"        self.assertEqual(1, len(provider_res))"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    def test_provider_get(self):"},{"line_number":29,"context_line":"        providers \u003d self.provider_list()"}],"source_content_type":"text/x-python","patch_set":6,"id":"7aa08908_23a051f4","line":26,"range":{"start_line":26,"start_character":8,"end_line":26,"end_character":46},"updated":"2016-06-06 12:14:44.000000000","message":"I don\u0027t think the length of providers is only 1.","commit_id":"2c0c483bc7b5e54ec1c3dee1491da25b776c75bb"},{"author":{"_account_id":17151,"name":"chenying","email":"chenyingko@gmail.com","username":"chenying"},"change_message_id":"150e67ca5a7986fd7eb5622a70e502faa2dcca14","unresolved":false,"context_lines":[{"line_number":26,"context_line":"        self.assertEqual(1, len(provider_res))"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    def test_provider_get(self):"},{"line_number":29,"context_line":"        providers \u003d self.provider_list()"},{"line_number":30,"context_line":"        provider_res \u003d self.smaug_client.providers.get(providers[0].id)"},{"line_number":31,"context_line":"        self.assertEqual(providers[0].name, provider_res.name)"}],"source_content_type":"text/x-python","patch_set":6,"id":"7aa08908_6387f90f","line":31,"range":{"start_line":29,"start_character":0,"end_line":31,"end_character":62},"updated":"2016-06-06 12:14:44.000000000","message":"If we configure more then one provider in conf, this assert may fail.","commit_id":"2c0c483bc7b5e54ec1c3dee1491da25b776c75bb"}]}