)]}'
{"smaug/services/protection/checkpoint.py":[{"author":{"_account_id":17151,"name":"chenying","email":"chenyingko@gmail.com","username":"chenying"},"change_message_id":"d9f0fad3a51be8747c430ed68c0278f2e1fea294","unresolved":false,"context_lines":[{"line_number":40,"context_line":"            \"id\": self.id,"},{"line_number":41,"context_line":"            \"status\": self.status,"},{"line_number":42,"context_line":"            \"protection_plan\": self.protection_plan,"},{"line_number":43,"context_line":"            \"project_id\": self.project_id,"},{"line_number":44,"context_line":"        }"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    @property"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a9d85d2_c898771e","line":43,"range":{"start_line":43,"start_character":13,"end_line":43,"end_character":23},"updated":"2016-06-21 02:33:02.000000000","message":"need add field resource_graph here. The response of checkpoint API have a parameter resource_graph.","commit_id":"8cab05b38c593ae1672a85346d9a9c58ebe8bb1d"}],"smaug/services/protection/manager.py":[{"author":{"_account_id":17151,"name":"chenying","email":"chenyingko@gmail.com","username":"chenying"},"change_message_id":"08b10a0c79b95442ab873e1171ca23f6ab8ebd49","unresolved":false,"context_lines":[{"line_number":248,"context_line":"        if provider is None:"},{"line_number":249,"context_line":"            raise exception.ProviderNotFound(provider_id\u003dprovider_id)"},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"        checkpoint \u003d provider.get_checkpoint(checkpoint_id)"},{"line_number":252,"context_line":"        return checkpoint.to_dict()"},{"line_number":253,"context_line":""},{"line_number":254,"context_line":"    def list_protectable_types(self, context):"},{"line_number":255,"context_line":"        LOG.info(_LI(\"Start to list protectable types.\"))"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a9d85d2_b82c82ac","line":252,"range":{"start_line":251,"start_character":0,"end_line":252,"end_character":35},"updated":"2016-06-20 12:09:21.000000000","message":"Find this problem just now when I test checkpoint-show. I also think that a try-except statement is needed here to catch get_checkpoint exception.","commit_id":"3eb3b3e925c4e86ee47cc1e53e146aec88981631"},{"author":{"_account_id":20883,"name":"Yuval Brik","email":"yuval@brik.org.il","username":"yuvalbr"},"change_message_id":"9732df60aff091aaef4b4897c390c1f6884eaf9f","unresolved":false,"context_lines":[{"line_number":248,"context_line":"        if provider is None:"},{"line_number":249,"context_line":"            raise exception.ProviderNotFound(provider_id\u003dprovider_id)"},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"        checkpoint \u003d provider.get_checkpoint(checkpoint_id)"},{"line_number":252,"context_line":"        return checkpoint.to_dict()"},{"line_number":253,"context_line":""},{"line_number":254,"context_line":"    def list_protectable_types(self, context):"},{"line_number":255,"context_line":"        LOG.info(_LI(\"Start to list protectable types.\"))"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a9d85d2_f3162da6","line":252,"range":{"start_line":251,"start_character":0,"end_line":252,"end_character":35},"in_reply_to":"5a9d85d2_b82c82ac","updated":"2016-06-20 12:18:50.000000000","message":"Updated with a fix.\nget_checkpoint can throw a CheckpointNotFound, which is expected (see decorator)","commit_id":"3eb3b3e925c4e86ee47cc1e53e146aec88981631"},{"author":{"_account_id":17151,"name":"chenying","email":"chenyingko@gmail.com","username":"chenying"},"change_message_id":"d9f0fad3a51be8747c430ed68c0278f2e1fea294","unresolved":false,"context_lines":[{"line_number":249,"context_line":"            raise exception.ProviderNotFound(provider_id\u003dprovider_id)"},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"        checkpoint \u003d provider.get_checkpoint(checkpoint_id)"},{"line_number":252,"context_line":"        return checkpoint.to_dict()"},{"line_number":253,"context_line":""},{"line_number":254,"context_line":"    def list_protectable_types(self, context):"},{"line_number":255,"context_line":"        LOG.info(_LI(\"Start to list protectable types.\"))"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a9d85d2_8b3029ea","line":252,"range":{"start_line":252,"start_character":15,"end_line":252,"end_character":25},"updated":"2016-06-21 02:33:02.000000000","message":"also consider adding field provider_id to this dict here. The checkpoint API model need this parameter.","commit_id":"8cab05b38c593ae1672a85346d9a9c58ebe8bb1d"}]}