)]}'
{"doc/source/specs/checkpoint-scheduled-clean.rst":[{"author":{"_account_id":2023,"name":"Saggi Mizrahi","email":"ficoos+osreview@gmail.com","username":"ficoos"},"change_message_id":"0ab37c33b0278f3e5439c26f0b4d3735e186895e","unresolved":false,"context_lines":[{"line_number":113,"context_line":"Security impact"},{"line_number":114,"context_line":"---------------"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"We need to make sure the two values are withing bounds to prevent any attacks."},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"Notifications impact"},{"line_number":119,"context_line":"--------------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9ad45d7e_62b0a9de","line":116,"range":{"start_line":116,"start_character":0,"end_line":116,"end_character":78},"updated":"2016-08-09 11:42:56.000000000","message":"Where are bounds defined? Local config?","commit_id":"c9e2783dbadbea2cb4d36616cd3ac48fe6079ba0"},{"author":{"_account_id":17192,"name":"xiangxinyong","email":"xiangxinyong@huawei.com","username":"xianxinyong"},"change_message_id":"41c64dc2a3c7bc1dff650ec45d78820cf5e51a38","unresolved":false,"context_lines":[{"line_number":113,"context_line":"Security impact"},{"line_number":114,"context_line":"---------------"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"We need to make sure the two values are withing bounds to prevent any attacks."},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"Notifications impact"},{"line_number":119,"context_line":"--------------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9ad45d7e_871e5461","line":116,"range":{"start_line":116,"start_character":0,"end_line":116,"end_character":78},"in_reply_to":"9ad45d7e_62b0a9de","updated":"2016-08-09 14:42:08.000000000","message":"Done","commit_id":"c9e2783dbadbea2cb4d36616cd3ac48fe6079ba0"},{"author":{"_account_id":18266,"name":"zengchen","email":"chenzeng2@huawei.com","username":"zengchen"},"change_message_id":"c56723fababb7cf84002824be4ddba5f1a4f749c","unresolved":false,"context_lines":[{"line_number":23,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"With more and more checkpoints created in the Bank, the end users need more"},{"line_number":26,"context_line":"and more storage capacity, and some checkpoints are not meaningful and"},{"line_number":27,"context_line":"necessary for the end users. The checkpoint scheduled clean feature is"},{"line_number":28,"context_line":"necessary to satisfy the end user\u0027s requirement."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"Proposed change"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9ad45d7e_7e058c78","line":27,"range":{"start_line":26,"start_character":30,"end_line":27,"end_character":28},"updated":"2016-08-10 02:19:08.000000000","message":"think about changing it to \u0027some checkpoints are \nmeaningless and not necessary for the end users\u0027","commit_id":"94de0d57472e81ca2e119d6021c12994499807dc"},{"author":{"_account_id":17192,"name":"xiangxinyong","email":"xiangxinyong@huawei.com","username":"xianxinyong"},"change_message_id":"14617de4f5e55c10a6334effab2a471e7f22bcac","unresolved":false,"context_lines":[{"line_number":23,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"With more and more checkpoints created in the Bank, the end users need more"},{"line_number":26,"context_line":"and more storage capacity, and some checkpoints are not meaningful and"},{"line_number":27,"context_line":"necessary for the end users. The checkpoint scheduled clean feature is"},{"line_number":28,"context_line":"necessary to satisfy the end user\u0027s requirement."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"Proposed change"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9ad45d7e_bd8549ae","line":27,"range":{"start_line":26,"start_character":30,"end_line":27,"end_character":28},"in_reply_to":"9ad45d7e_7e058c78","updated":"2016-08-10 02:54:42.000000000","message":"I feel it is better to use \"not\" in front.","commit_id":"94de0d57472e81ca2e119d6021c12994499807dc"},{"author":{"_account_id":18266,"name":"zengchen","email":"chenzeng2@huawei.com","username":"zengchen"},"change_message_id":"c56723fababb7cf84002824be4ddba5f1a4f749c","unresolved":false,"context_lines":[{"line_number":41,"context_line":"   by the scheduled operation. e.g. 20 weeks."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"Smaug provides the default values for these two settings. The default value is"},{"line_number":44,"context_line":"-1, and it means Smaug will not clean the checkpoints by default. When the end"},{"line_number":45,"context_line":"users launch a scheduled operation, they can input the values of these two"},{"line_number":46,"context_line":"settings and invoke the scheduled operation RESTful API."},{"line_number":47,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"9ad45d7e_3e4b14cb","line":44,"range":{"start_line":44,"start_character":4,"end_line":44,"end_character":11},"updated":"2016-08-10 02:19:08.000000000","message":"s/and it/which","commit_id":"94de0d57472e81ca2e119d6021c12994499807dc"},{"author":{"_account_id":17192,"name":"xiangxinyong","email":"xiangxinyong@huawei.com","username":"xianxinyong"},"change_message_id":"14617de4f5e55c10a6334effab2a471e7f22bcac","unresolved":false,"context_lines":[{"line_number":41,"context_line":"   by the scheduled operation. e.g. 20 weeks."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"Smaug provides the default values for these two settings. The default value is"},{"line_number":44,"context_line":"-1, and it means Smaug will not clean the checkpoints by default. When the end"},{"line_number":45,"context_line":"users launch a scheduled operation, they can input the values of these two"},{"line_number":46,"context_line":"settings and invoke the scheduled operation RESTful API."},{"line_number":47,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"9ad45d7e_7dbab16f","line":44,"range":{"start_line":44,"start_character":4,"end_line":44,"end_character":11},"in_reply_to":"9ad45d7e_3e4b14cb","updated":"2016-08-10 02:54:42.000000000","message":"I will modify it.","commit_id":"94de0d57472e81ca2e119d6021c12994499807dc"},{"author":{"_account_id":18266,"name":"zengchen","email":"chenzeng2@huawei.com","username":"zengchen"},"change_message_id":"c56723fababb7cf84002824be4ddba5f1a4f749c","unresolved":false,"context_lines":[{"line_number":43,"context_line":"Smaug provides the default values for these two settings. The default value is"},{"line_number":44,"context_line":"-1, and it means Smaug will not clean the checkpoints by default. When the end"},{"line_number":45,"context_line":"users launch a scheduled operation, they can input the values of these two"},{"line_number":46,"context_line":"settings and invoke the scheduled operation RESTful API."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"Meanwhile a database table called **CheckpointRecords** will be created to"},{"line_number":49,"context_line":"store the checkpoints which are created by the scheduled operation."}],"source_content_type":"text/x-rst","patch_set":2,"id":"9ad45d7e_9ea3204f","line":46,"range":{"start_line":46,"start_character":8,"end_line":46,"end_character":55},"updated":"2016-08-10 02:19:08.000000000","message":"Maybe it is the same meaning to \u0027When the end\nusers launch a scheduled operation\u0027","commit_id":"94de0d57472e81ca2e119d6021c12994499807dc"},{"author":{"_account_id":17192,"name":"xiangxinyong","email":"xiangxinyong@huawei.com","username":"xianxinyong"},"change_message_id":"14617de4f5e55c10a6334effab2a471e7f22bcac","unresolved":false,"context_lines":[{"line_number":43,"context_line":"Smaug provides the default values for these two settings. The default value is"},{"line_number":44,"context_line":"-1, and it means Smaug will not clean the checkpoints by default. When the end"},{"line_number":45,"context_line":"users launch a scheduled operation, they can input the values of these two"},{"line_number":46,"context_line":"settings and invoke the scheduled operation RESTful API."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"Meanwhile a database table called **CheckpointRecords** will be created to"},{"line_number":49,"context_line":"store the checkpoints which are created by the scheduled operation."}],"source_content_type":"text/x-rst","patch_set":2,"id":"9ad45d7e_7d7111e0","line":46,"range":{"start_line":46,"start_character":8,"end_line":46,"end_character":55},"in_reply_to":"9ad45d7e_9ea3204f","updated":"2016-08-10 02:54:42.000000000","message":"\"When the end users launch a scheduled operation\"\nIt means the UI operation like that.","commit_id":"94de0d57472e81ca2e119d6021c12994499807dc"},{"author":{"_account_id":18266,"name":"zengchen","email":"chenzeng2@huawei.com","username":"zengchen"},"change_message_id":"c56723fababb7cf84002824be4ddba5f1a4f749c","unresolved":false,"context_lines":[{"line_number":45,"context_line":"users launch a scheduled operation, they can input the values of these two"},{"line_number":46,"context_line":"settings and invoke the scheduled operation RESTful API."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"Meanwhile a database table called **CheckpointRecords** will be created to"},{"line_number":49,"context_line":"store the checkpoints which are created by the scheduled operation."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"+--------------------+--------------+------+-----+---------+----------------+"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9ad45d7e_79d12657","line":48,"range":{"start_line":48,"start_character":36,"end_line":48,"end_character":53},"updated":"2016-08-10 02:19:08.000000000","message":"The table name should keep consistent to others. s/CheckpointRecords/checkpoint_records/.\nBTW, I thinks \u0027checkpoints\u0027 is better.","commit_id":"94de0d57472e81ca2e119d6021c12994499807dc"},{"author":{"_account_id":17192,"name":"xiangxinyong","email":"xiangxinyong@huawei.com","username":"xianxinyong"},"change_message_id":"14617de4f5e55c10a6334effab2a471e7f22bcac","unresolved":false,"context_lines":[{"line_number":45,"context_line":"users launch a scheduled operation, they can input the values of these two"},{"line_number":46,"context_line":"settings and invoke the scheduled operation RESTful API."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"Meanwhile a database table called **CheckpointRecords** will be created to"},{"line_number":49,"context_line":"store the checkpoints which are created by the scheduled operation."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"+--------------------+--------------+------+-----+---------+----------------+"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9ad45d7e_5d324d11","line":48,"range":{"start_line":48,"start_character":36,"end_line":48,"end_character":53},"in_reply_to":"9ad45d7e_79d12657","updated":"2016-08-10 02:54:42.000000000","message":"Thanks. It is very useful.\nI guess \u0027checkpoints\u0027 is confused with the users.\nBecause \u0027checkpoints\u0027 resource has already existed in the API service.","commit_id":"94de0d57472e81ca2e119d6021c12994499807dc"},{"author":{"_account_id":18266,"name":"zengchen","email":"chenzeng2@huawei.com","username":"zengchen"},"change_message_id":"c56723fababb7cf84002824be4ddba5f1a4f749c","unresolved":false,"context_lines":[{"line_number":80,"context_line":"When the operation is triggered in the Operation Engine Service, the operation"},{"line_number":81,"context_line":"could get the values of ``max_backups`` and ``retention_duration`` from the"},{"line_number":82,"context_line":"scheduled operation, and then the operation will judge these two values to"},{"line_number":83,"context_line":"confirm if it will invoke the REST API to clean the deprecated checkpoints."},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"Alternatives"},{"line_number":86,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9ad45d7e_19bbca0f","line":83,"range":{"start_line":83,"start_character":8,"end_line":83,"end_character":10},"updated":"2016-08-10 02:19:08.000000000","message":"s/if/whether","commit_id":"94de0d57472e81ca2e119d6021c12994499807dc"},{"author":{"_account_id":17192,"name":"xiangxinyong","email":"xiangxinyong@huawei.com","username":"xianxinyong"},"change_message_id":"14617de4f5e55c10a6334effab2a471e7f22bcac","unresolved":false,"context_lines":[{"line_number":80,"context_line":"When the operation is triggered in the Operation Engine Service, the operation"},{"line_number":81,"context_line":"could get the values of ``max_backups`` and ``retention_duration`` from the"},{"line_number":82,"context_line":"scheduled operation, and then the operation will judge these two values to"},{"line_number":83,"context_line":"confirm if it will invoke the REST API to clean the deprecated checkpoints."},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"Alternatives"},{"line_number":86,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9ad45d7e_9d3cc5e3","line":83,"range":{"start_line":83,"start_character":8,"end_line":83,"end_character":10},"in_reply_to":"9ad45d7e_19bbca0f","updated":"2016-08-10 02:54:42.000000000","message":"I will modify it.","commit_id":"94de0d57472e81ca2e119d6021c12994499807dc"},{"author":{"_account_id":18266,"name":"zengchen","email":"chenzeng2@huawei.com","username":"zengchen"},"change_message_id":"c56723fababb7cf84002824be4ddba5f1a4f749c","unresolved":false,"context_lines":[{"line_number":90,"context_line":"Data model impact"},{"line_number":91,"context_line":"-----------------"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"Add two key-values in the operation_definition of scheduled operation. These"},{"line_number":94,"context_line":"two optional key-values are called ``max_backups`` and ``retention_duration``."},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"REST API impact"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9ad45d7e_59642248","line":93,"range":{"start_line":93,"start_character":0,"end_line":93,"end_character":69},"updated":"2016-08-10 02:19:08.000000000","message":"I think just the \u0027protect\u0027 operation have these two optional parameters. Different operations have different \u0027operation_definition\u0027. so s/scheduled operation/protect scheduled operation.","commit_id":"94de0d57472e81ca2e119d6021c12994499807dc"},{"author":{"_account_id":17192,"name":"xiangxinyong","email":"xiangxinyong@huawei.com","username":"xianxinyong"},"change_message_id":"14617de4f5e55c10a6334effab2a471e7f22bcac","unresolved":false,"context_lines":[{"line_number":90,"context_line":"Data model impact"},{"line_number":91,"context_line":"-----------------"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"Add two key-values in the operation_definition of scheduled operation. These"},{"line_number":94,"context_line":"two optional key-values are called ``max_backups`` and ``retention_duration``."},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"REST API impact"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9ad45d7e_dd263dcd","line":93,"range":{"start_line":93,"start_character":0,"end_line":93,"end_character":69},"in_reply_to":"9ad45d7e_59642248","updated":"2016-08-10 02:54:42.000000000","message":"I will modify it.","commit_id":"94de0d57472e81ca2e119d6021c12994499807dc"},{"author":{"_account_id":17151,"name":"chenying","email":"chenyingko@gmail.com","username":"chenying"},"change_message_id":"0a91c7f36da8e0808ca5b760a9b076f1dccdf085","unresolved":false,"context_lines":[{"line_number":45,"context_line":"users launch a scheduled operation, they can input the values of these two"},{"line_number":46,"context_line":"settings and invoke the scheduled operation RESTful API."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"Meanwhile a database table called **checkpoint_records** will be created to"},{"line_number":49,"context_line":"store the checkpoints which are created by the scheduled operation."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"+--------------------+--------------+------+-----+---------+----------------+"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9ad45d7e_77864a14","line":48,"range":{"start_line":48,"start_character":36,"end_line":48,"end_character":54},"updated":"2016-08-10 06:29:55.000000000","message":"What\u0027s different beteeen checkpoint_records table and operation_logs? You know saggi design a new API about operation_log?","commit_id":"e69eea7ede1b99b6b25cabdd3c6606f71a60bf89"},{"author":{"_account_id":17192,"name":"xiangxinyong","email":"xiangxinyong@huawei.com","username":"xianxinyong"},"change_message_id":"546938bc100fdaf5704714d158090f6e0bbc3959","unresolved":false,"context_lines":[{"line_number":45,"context_line":"users launch a scheduled operation, they can input the values of these two"},{"line_number":46,"context_line":"settings and invoke the scheduled operation RESTful API."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"Meanwhile a database table called **checkpoint_records** will be created to"},{"line_number":49,"context_line":"store the checkpoints which are created by the scheduled operation."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"+--------------------+--------------+------+-----+---------+----------------+"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9ad45d7e_b3b85a2b","line":48,"range":{"start_line":48,"start_character":36,"end_line":48,"end_character":54},"in_reply_to":"9ad45d7e_77864a14","updated":"2016-08-12 01:09:44.000000000","message":"It is different.\nOperation logs will record the logs of Schedule Operations.\nCheckpoint Records will record the checkpoint information.","commit_id":"e69eea7ede1b99b6b25cabdd3c6606f71a60bf89"}]}