)]}'
{"karbor/services/operationengine/engine/triggers/timetrigger/time_trigger.py":[{"author":{"_account_id":23068,"name":"Wang Hui","email":"wanghui71@huawei.com","username":"krejwang"},"change_message_id":"d1fc22ac3da701ff21d00d1634f3ae7a93b3209d","unresolved":false,"context_lines":[{"line_number":345,"context_line":"        return None"},{"line_number":346,"context_line":""},{"line_number":347,"context_line":"    @classmethod"},{"line_number":348,"context_line":"    def _get_time_format_class(cls):"},{"line_number":349,"context_line":"        return import_driver.DriverManager("},{"line_number":350,"context_line":"            \u0027karbor.operationengine.engine.timetrigger.time_format\u0027,"},{"line_number":351,"context_line":"            \u0027time_format\u0027).driver"}],"source_content_type":"text/x-python","patch_set":9,"id":"7a8ec9b2_85941d8b","line":348,"range":{"start_line":348,"start_character":31,"end_line":348,"end_character":34},"updated":"2016-09-19 06:31:14.000000000","message":"What is \u0027cls\u0027 used for?","commit_id":"915080d329218832d7e9fb1995b01b8a885a9a01"},{"author":{"_account_id":18266,"name":"zengchen","email":"chenzeng2@huawei.com","username":"zengchen"},"change_message_id":"c777ad4bd1c9832d9c16f914582ece5433d2770c","unresolved":false,"context_lines":[{"line_number":345,"context_line":"        return None"},{"line_number":346,"context_line":""},{"line_number":347,"context_line":"    @classmethod"},{"line_number":348,"context_line":"    def _get_time_format_class(cls):"},{"line_number":349,"context_line":"        return import_driver.DriverManager("},{"line_number":350,"context_line":"            \u0027karbor.operationengine.engine.timetrigger.time_format\u0027,"},{"line_number":351,"context_line":"            \u0027time_format\u0027).driver"}],"source_content_type":"text/x-python","patch_set":9,"id":"7a8ec9b2_96c37537","line":348,"range":{"start_line":348,"start_character":31,"end_line":348,"end_character":34},"in_reply_to":"7a8ec9b2_85941d8b","updated":"2016-09-19 08:12:53.000000000","message":"this method is class method which has a fixed parameter named \u0027cls\u0027 no matter use it or not.","commit_id":"915080d329218832d7e9fb1995b01b8a885a9a01"},{"author":{"_account_id":21648,"name":"zhangshuai","email":"446077695@qq.com","username":"zhangshuai"},"change_message_id":"13a133ededcdb00f1dd2a54ddbb7b2e0749bf64e","unresolved":false,"context_lines":[{"line_number":271,"context_line":"            sended_ops.add(operation_id)"},{"line_number":272,"context_line":""},{"line_number":273,"context_line":"        return self._compute_next_run_time("},{"line_number":274,"context_line":"            datetime.utcnow(), trigger_property[\u0027end_time\u0027], timer)"},{"line_number":275,"context_line":""},{"line_number":276,"context_line":"    @classmethod"},{"line_number":277,"context_line":"    def check_trigger_definition(cls, trigger_definition):"}],"source_content_type":"text/x-python","patch_set":16,"id":"ba5da102_304e55c1","line":274,"range":{"start_line":274,"start_character":12,"end_line":274,"end_character":29},"updated":"2016-11-03 02:07:31.000000000","message":"This time may be less than expect_run_time.","commit_id":"a6b3a5c445f3bed57a42050f58a80925a4a1c65a"},{"author":{"_account_id":18266,"name":"zengchen","email":"chenzeng2@huawei.com","username":"zengchen"},"change_message_id":"0ece489a5ebd2070c4d17418774ea8b0ddafbed9","unresolved":false,"context_lines":[{"line_number":271,"context_line":"            sended_ops.add(operation_id)"},{"line_number":272,"context_line":""},{"line_number":273,"context_line":"        return self._compute_next_run_time("},{"line_number":274,"context_line":"            datetime.utcnow(), trigger_property[\u0027end_time\u0027], timer)"},{"line_number":275,"context_line":""},{"line_number":276,"context_line":"    @classmethod"},{"line_number":277,"context_line":"    def check_trigger_definition(cls, trigger_definition):"}],"source_content_type":"text/x-python","patch_set":16,"id":"ba5da102_c659e38f","line":274,"range":{"start_line":274,"start_character":12,"end_line":274,"end_character":29},"in_reply_to":"ba5da102_304e55c1","updated":"2016-11-03 03:58:42.000000000","message":"good comment! thank you. I update it on another patch, please take a look at it.\nhttps://review.openstack.org/#/c/372191/","commit_id":"a6b3a5c445f3bed57a42050f58a80925a4a1c65a"}],"setup.cfg":[{"author":{"_account_id":21648,"name":"zhangshuai","email":"446077695@qq.com","username":"zhangshuai"},"change_message_id":"d2027e1327739d83c05a9b76e00c53347d6c37d0","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    volume \u003d karbor.services.protection.protectable_plugins.volume:VolumeProtectablePlugin"},{"line_number":53,"context_line":"    image \u003d karbor.services.protection.protectable_plugins.image:ImageProtectablePlugin"},{"line_number":54,"context_line":"karbor.operationengine.engine.timetrigger.time_format \u003d"},{"line_number":55,"context_line":"    time_format \u003d karbor.services.operationengine.engine.triggers.timetrigger.timeformats.crontab_time.Crontab"},{"line_number":56,"context_line":"karbor.operationengine.engine.executor \u003d"},{"line_number":57,"context_line":"    thread_pool \u003d karbor.services.operationengine.engine.executors.thread_pool_executor:ThreadPoolExecutor"},{"line_number":58,"context_line":""}],"source_content_type":"text/x-ttcn-cfg","patch_set":14,"id":"fa6399be_df1becc8","line":55,"range":{"start_line":55,"start_character":102,"end_line":55,"end_character":103},"updated":"2016-10-19 03:29:18.000000000","message":"maybe \u0027:\u0027 instead of \u0027,\u0027","commit_id":"fe0d83a2b368fe9fc88faab033d2c754f2d224a6"}],"smaug/api/v1/triggers.py":[{"author":{"_account_id":2023,"name":"Saggi Mizrahi","email":"ficoos+osreview@gmail.com","username":"ficoos"},"change_message_id":"198ea528ee839cfbec4216d8430ccd3822d942d1","unresolved":false,"context_lines":[{"line_number":103,"context_line":""},{"line_number":104,"context_line":"        self.validate_name_and_description(trigger_info)"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"        start_time \u003d trigger_property.get(\u0027start_time\u0027, None)"},{"line_number":107,"context_line":"        if not start_time:"},{"line_number":108,"context_line":"            trigger_property[\u0027start_time\u0027] \u003d ("},{"line_number":109,"context_line":"                datetime.utcnow().replace(microsecond\u003d0))"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"        trigger_definition \u003d {"},{"line_number":112,"context_line":"            \u0027id\u0027: str(uuid.uuid4()),"}],"source_content_type":"text/x-python","patch_set":3,"id":"1ac06dbe_70393041","line":109,"range":{"start_line":106,"start_character":0,"end_line":109,"end_character":57},"updated":"2016-08-22 15:44:58.000000000","message":"Don\u0027t introduce a local variable you are mot going to user.\n\neither:\n\ntrigger_property.setdefault(\u0027start_time\u0027, atetime.utcnow().replace(microsecond\u003d0))\n\nor\n\nif not \u0027start_time\u0027 in trigger_property:\n...","commit_id":"1e31696bf370eedf2d96f8e71fe570bbb151fea8"}]}