)]}'
{"doc/source/specs/instances-extra-info.rst":[{"author":{"_account_id":18266,"name":"zengchen","email":"chenzeng2@huawei.com","username":"zengchen"},"change_message_id":"df4eee9b79e2f1ec0ec117e6b2ab57912e4cd9c2","unresolved":false,"context_lines":[{"line_number":37,"context_line":"Proposed change"},{"line_number":38,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"Add a new field extra_info to the response for Protectable Instances API."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"          examples:"},{"line_number":43,"context_line":"            application/json: {"}],"source_content_type":"text/x-rst","patch_set":1,"id":"fa6399be_62ca11a3","line":40,"range":{"start_line":40,"start_character":47,"end_line":40,"end_character":72},"updated":"2016-10-20 02:21:34.000000000","message":"IMO, it is better to list the apis which will be updated.","commit_id":"2aab6190f5f09297a98d531cade1010b191cbe8c"},{"author":{"_account_id":17151,"name":"chenying","email":"chenyingko@gmail.com","username":"chenying"},"change_message_id":"4c235a818467a5278943a7314ce27337120dd2f7","unresolved":false,"context_lines":[{"line_number":37,"context_line":"Proposed change"},{"line_number":38,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"Add a new field extra_info to the response for Protectable Instances API."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"          examples:"},{"line_number":43,"context_line":"            application/json: {"}],"source_content_type":"text/x-rst","patch_set":1,"id":"fa6399be_c2903d51","line":40,"range":{"start_line":40,"start_character":47,"end_line":40,"end_character":72},"in_reply_to":"fa6399be_62ca11a3","updated":"2016-10-20 02:33:04.000000000","message":"Done","commit_id":"2aab6190f5f09297a98d531cade1010b191cbe8c"},{"author":{"_account_id":18266,"name":"zengchen","email":"chenzeng2@huawei.com","username":"zengchen"},"change_message_id":"df4eee9b79e2f1ec0ec117e6b2ab57912e4cd9c2","unresolved":false,"context_lines":[{"line_number":55,"context_line":"                    {"},{"line_number":56,"context_line":"                      \"id\": \"99777fdd-8a5b-45ab-ba2c-52420008103f\","},{"line_number":57,"context_line":"                      \"type\": \"OS::Glance::Image\","},{"line_number":58,"context_line":"                      \"name\": \"cirros-0.3.4-x86_64-uec\""},{"line_number":59,"context_line":"                    }"},{"line_number":60,"context_line":"                  ]"},{"line_number":61,"context_line":"                }"}],"source_content_type":"text/x-rst","patch_set":1,"id":"fa6399be_e25541c6","line":58,"updated":"2016-10-20 02:21:34.000000000","message":"do dependent resources also have \u0027extra_info\u0027 filed?","commit_id":"2aab6190f5f09297a98d531cade1010b191cbe8c"},{"author":{"_account_id":17151,"name":"chenying","email":"chenyingko@gmail.com","username":"chenying"},"change_message_id":"4c235a818467a5278943a7314ce27337120dd2f7","unresolved":false,"context_lines":[{"line_number":55,"context_line":"                    {"},{"line_number":56,"context_line":"                      \"id\": \"99777fdd-8a5b-45ab-ba2c-52420008103f\","},{"line_number":57,"context_line":"                      \"type\": \"OS::Glance::Image\","},{"line_number":58,"context_line":"                      \"name\": \"cirros-0.3.4-x86_64-uec\""},{"line_number":59,"context_line":"                    }"},{"line_number":60,"context_line":"                  ]"},{"line_number":61,"context_line":"                }"}],"source_content_type":"text/x-rst","patch_set":1,"id":"fa6399be_a2950941","line":58,"in_reply_to":"fa6399be_e25541c6","updated":"2016-10-20 02:33:04.000000000","message":"Yes I will update this patch.","commit_id":"2aab6190f5f09297a98d531cade1010b191cbe8c"},{"author":{"_account_id":2023,"name":"Saggi Mizrahi","email":"ficoos+osreview@gmail.com","username":"ficoos"},"change_message_id":"7e10f359aa2e39633ed983a623f8667cf759acaf","unresolved":false,"context_lines":[{"line_number":90,"context_line":""},{"line_number":91,"context_line":"Protectable Plugins can return the extra_info of resource Instances."},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"The extra_info field in resource database table is only for presentation to a user/tenant."},{"line_number":94,"context_line":"The values in extra_info field can not be used and modified in karbor protection service."},{"line_number":95,"context_line":"Add a new field extra_info to resources database table;"},{"line_number":96,"context_line":" resources"},{"line_number":97,"context_line":"+-------------------------+--------------+------+-----+---------+-------+"},{"line_number":98,"context_line":"| Field                   | Type         | Null | Key | Default | Extra |"},{"line_number":99,"context_line":"+-------------------------+--------------+------+-----+---------+-------+"}],"source_content_type":"text/x-rst","patch_set":3,"id":"5a74a57a_fa434f11","line":96,"range":{"start_line":93,"start_character":0,"end_line":96,"end_character":10},"updated":"2016-12-01 02:21:28.000000000","message":"Why is this information cached in our DB. It is owned by different services.","commit_id":"2871ed3fb061a2c24c0a3d91f48843987e477f65"},{"author":{"_account_id":17151,"name":"chenying","email":"chenyingko@gmail.com","username":"chenying"},"change_message_id":"df60ea41dc7c496a525b6b78b42abac331be68bf","unresolved":false,"context_lines":[{"line_number":90,"context_line":""},{"line_number":91,"context_line":"Protectable Plugins can return the extra_info of resource Instances."},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"The extra_info field in resource database table is only for presentation to a user/tenant."},{"line_number":94,"context_line":"The values in extra_info field can not be used and modified in karbor protection service."},{"line_number":95,"context_line":"Add a new field extra_info to resources database table;"},{"line_number":96,"context_line":" resources"},{"line_number":97,"context_line":"+-------------------------+--------------+------+-----+---------+-------+"},{"line_number":98,"context_line":"| Field                   | Type         | Null | Key | Default | Extra |"},{"line_number":99,"context_line":"+-------------------------+--------------+------+-----+---------+-------+"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3a71b18c_dc2813e5","line":96,"range":{"start_line":93,"start_character":0,"end_line":96,"end_character":10},"in_reply_to":"3a71b18c_680af222","updated":"2016-12-05 11:29:47.000000000","message":"Yes. The extra-info of resources in database is not updated. This infomation is only for user to recognize the resources which is the one he want to protect. I think it doesn\u0027t matter.","commit_id":"2871ed3fb061a2c24c0a3d91f48843987e477f65"},{"author":{"_account_id":2023,"name":"Saggi Mizrahi","email":"ficoos+osreview@gmail.com","username":"ficoos"},"change_message_id":"5169113530f37a1abbaa29212724eeff1a5a255f","unresolved":false,"context_lines":[{"line_number":90,"context_line":""},{"line_number":91,"context_line":"Protectable Plugins can return the extra_info of resource Instances."},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"The extra_info field in resource database table is only for presentation to a user/tenant."},{"line_number":94,"context_line":"The values in extra_info field can not be used and modified in karbor protection service."},{"line_number":95,"context_line":"Add a new field extra_info to resources database table;"},{"line_number":96,"context_line":" resources"},{"line_number":97,"context_line":"+-------------------------+--------------+------+-----+---------+-------+"},{"line_number":98,"context_line":"| Field                   | Type         | Null | Key | Default | Extra |"},{"line_number":99,"context_line":"+-------------------------+--------------+------+-----+---------+-------+"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3a71b18c_680af222","line":96,"range":{"start_line":93,"start_character":0,"end_line":96,"end_character":10},"in_reply_to":"3a71b18c_88d8a71f","updated":"2016-12-04 13:06:14.000000000","message":"This still means this is a cache since any information in the DB is not updated when the appropriate resource is updated.","commit_id":"2871ed3fb061a2c24c0a3d91f48843987e477f65"},{"author":{"_account_id":17151,"name":"chenying","email":"chenyingko@gmail.com","username":"chenying"},"change_message_id":"48ea4aa6f85ab514feedf593aa34893d1bcab7d9","unresolved":false,"context_lines":[{"line_number":90,"context_line":""},{"line_number":91,"context_line":"Protectable Plugins can return the extra_info of resource Instances."},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"The extra_info field in resource database table is only for presentation to a user/tenant."},{"line_number":94,"context_line":"The values in extra_info field can not be used and modified in karbor protection service."},{"line_number":95,"context_line":"Add a new field extra_info to resources database table;"},{"line_number":96,"context_line":" resources"},{"line_number":97,"context_line":"+-------------------------+--------------+------+-----+---------+-------+"},{"line_number":98,"context_line":"| Field                   | Type         | Null | Key | Default | Extra |"},{"line_number":99,"context_line":"+-------------------------+--------------+------+-----+---------+-------+"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3a71b18c_88d8a71f","line":96,"range":{"start_line":93,"start_character":0,"end_line":96,"end_character":10},"in_reply_to":"5a74a57a_fa434f11","updated":"2016-12-01 09:09:23.000000000","message":"The extra-info of resources are saved to datatable. They are not used for data processing by karbor services. They are used for plan list API. User can see the detail/extra info of resources in the plan from the plan list API. Then the user can select the plan with right resoures which he want to protect.","commit_id":"2871ed3fb061a2c24c0a3d91f48843987e477f65"},{"author":{"_account_id":2023,"name":"Saggi Mizrahi","email":"ficoos+osreview@gmail.com","username":"ficoos"},"change_message_id":"dccb647942323048e9a87e61e08c9958c929c701","unresolved":false,"context_lines":[{"line_number":53,"context_line":"The values in extra-info filed of a resource can not be used inside the protection"},{"line_number":54,"context_line":"service of karbor and protection plugins."},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"The UI about the extra-info of protectable instances"},{"line_number":57,"context_line":"Show the extra-info in resource tree page. Add a fa-chevron-right icon before the"},{"line_number":58,"context_line":"Logo of the resource. The extra-info of this resource is collapsed by default."},{"line_number":59,"context_line":"If a user/tenant click the icon, The extra-info will be displayed under this resource."},{"line_number":60,"context_line":"Click the icon again, the extra-info will be collapsed."},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"Add a new field extra_info to the response for Protectable Instances API."},{"line_number":63,"context_line":"  /{project_id}/protectables/{protectable_type}/instances:"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3a71b18c_104d0ac4","line":60,"range":{"start_line":56,"start_character":0,"end_line":60,"end_character":55},"updated":"2016-12-05 13:06:16.000000000","message":"Are the values only allowed to be scalar fields or can they be compound fields? If the fields are compound how do you display them?\nShould the user be able to filter according to this information (see only entities from a specific AZ) or is the info just there for the user to see but not interact with.","commit_id":"a39a36c345e52aab5284d322cf6c945543e633eb"},{"author":{"_account_id":17151,"name":"chenying","email":"chenyingko@gmail.com","username":"chenying"},"change_message_id":"3ab23577458549a9d9ffecddcd7855cf2c265083","unresolved":false,"context_lines":[{"line_number":53,"context_line":"The values in extra-info filed of a resource can not be used inside the protection"},{"line_number":54,"context_line":"service of karbor and protection plugins."},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"The UI about the extra-info of protectable instances"},{"line_number":57,"context_line":"Show the extra-info in resource tree page. Add a fa-chevron-right icon before the"},{"line_number":58,"context_line":"Logo of the resource. The extra-info of this resource is collapsed by default."},{"line_number":59,"context_line":"If a user/tenant click the icon, The extra-info will be displayed under this resource."},{"line_number":60,"context_line":"Click the icon again, the extra-info will be collapsed."},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"Add a new field extra_info to the response for Protectable Instances API."},{"line_number":63,"context_line":"  /{project_id}/protectables/{protectable_type}/instances:"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3a71b18c_81760fd5","line":60,"range":{"start_line":56,"start_character":0,"end_line":60,"end_character":55},"in_reply_to":"3a71b18c_104d0ac4","updated":"2016-12-06 03:26:03.000000000","message":"I think the values could be simple string. It only used for presentation to user. Now the directly filter can not supportted in the protectable plugins. Because that the data queried form protectable plugins are not saved in the local database of karbor. If user want to filter resources, The parameter field of protectable API can be used to pass filter value. And this parameter filter function need be implemented in the plugins.","commit_id":"a39a36c345e52aab5284d322cf6c945543e633eb"}]}