)]}'
{"karbor/common/config.py":[{"author":{"_account_id":18266,"name":"zengchen","email":"chenzeng2@huawei.com","username":"zengchen"},"change_message_id":"03755edadfb20848a5475d2f9a5fdeaf4526c98a","unresolved":false,"context_lines":[{"line_number":32,"context_line":"core_opts \u003d ["},{"line_number":33,"context_line":"    cfg.StrOpt(\u0027api_paste_config\u0027,"},{"line_number":34,"context_line":"               default\u003d\"api-paste.ini\","},{"line_number":35,"context_line":"               help\u003d_(\u0027File name for the paste.deploy config for karbor-api\u0027)),"},{"line_number":36,"context_line":"    cfg.StrOpt(\u0027state_path\u0027,"},{"line_number":37,"context_line":"               default\u003d\u0027/var/lib/karbor\u0027,"},{"line_number":38,"context_line":"               deprecated_name\u003d\u0027pybasedir\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a77a97e_ed9569e4","line":35,"updated":"2016-11-16 02:09:34.000000000","message":"I think there are many other configs having same error. Will you  amend them all?","commit_id":"f734433e662017a1aef17842de70c678321b0983"}],"karbor/common/karbor_keystone_plugin.py":[{"author":{"_account_id":18266,"name":"zengchen","email":"chenzeng2@huawei.com","username":"zengchen"},"change_message_id":"03755edadfb20848a5475d2f9a5fdeaf4526c98a","unresolved":false,"context_lines":[{"line_number":19,"context_line":"from karbor import exception"},{"line_number":20,"context_line":"from karbor.i18n import _, _LW"},{"line_number":21,"context_line":"from karbor import utils"},{"line_number":22,"context_line":"from oslo_config import cfg"},{"line_number":23,"context_line":"from oslo_log import log as logging"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"7a77a97e_ed880925","line":23,"range":{"start_line":22,"start_character":0,"end_line":23,"end_character":35},"updated":"2016-11-16 02:09:34.000000000","message":"Why? oslo_config is the third library which should not be written  here with \u0027karbor\u0027.","commit_id":"f734433e662017a1aef17842de70c678321b0983"},{"author":{"_account_id":18266,"name":"zengchen","email":"chenzeng2@huawei.com","username":"zengchen"},"change_message_id":"03755edadfb20848a5475d2f9a5fdeaf4526c98a","unresolved":false,"context_lines":[{"line_number":72,"context_line":"            self._auth_uri \u003d utils.get_auth_uri()"},{"line_number":73,"context_line":"        except Exception:"},{"line_number":74,"context_line":"            msg \u003d _(\u0027get keystone auth url failed\u0027)"},{"line_number":75,"context_line":"            raise exception.AuthorizationFailure(obj\u003dmsg)"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    def get_service_endpoint(self, service_name, service_type,"},{"line_number":78,"context_line":"                             region_id, interface\u003d\u0027public\u0027):"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a77a97e_addc5113","line":75,"range":{"start_line":75,"start_character":18,"end_line":75,"end_character":57},"updated":"2016-11-16 02:09:34.000000000","message":"I think original code is right. Because \u0027msg\u0027 is the parameter of  exception.AuthorizationFailure.message instead of overriding it.\n\nclass AuthorizationFailure(NotAuthorized):\n    message \u003d _(\"Authorization for %(obj)s is failed \")\n\n\u0027msg\u0027 will replace \u0027obj\u0027.","commit_id":"f734433e662017a1aef17842de70c678321b0983"},{"author":{"_account_id":18266,"name":"zengchen","email":"chenzeng2@huawei.com","username":"zengchen"},"change_message_id":"03755edadfb20848a5475d2f9a5fdeaf4526c98a","unresolved":false,"context_lines":[{"line_number":92,"context_line":""},{"line_number":93,"context_line":"        except Exception:"},{"line_number":94,"context_line":"            msg \u003d _((\u0027get service(%s) endpoint failed\u0027) % service_name)"},{"line_number":95,"context_line":"            raise exception.AuthorizationFailure(obj\u003dmsg)"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    def create_trust_to_karbor(self, context):"},{"line_number":98,"context_line":"        if not context.auth_token_info:"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a77a97e_4d02dd70","line":95,"updated":"2016-11-16 02:09:34.000000000","message":"ditto","commit_id":"f734433e662017a1aef17842de70c678321b0983"},{"author":{"_account_id":18266,"name":"zengchen","email":"chenzeng2@huawei.com","username":"zengchen"},"change_message_id":"03755edadfb20848a5475d2f9a5fdeaf4526c98a","unresolved":false,"context_lines":[{"line_number":98,"context_line":"        if not context.auth_token_info:"},{"line_number":99,"context_line":"            msg \u003d _((\"user\u003d%s, project\u003d%s\") % (context.user_id,"},{"line_number":100,"context_line":"                                               context.project_id))"},{"line_number":101,"context_line":"            raise exception.AuthorizationFailure(obj\u003dmsg)"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"        auth_ref \u003d access.create(body\u003dcontext.auth_token_info,"},{"line_number":104,"context_line":"                                 auth_token\u003dcontext.auth_token)"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a77a97e_8df4f587","line":101,"updated":"2016-11-16 02:09:34.000000000","message":"ditto","commit_id":"f734433e662017a1aef17842de70c678321b0983"},{"author":{"_account_id":18266,"name":"zengchen","email":"chenzeng2@huawei.com","username":"zengchen"},"change_message_id":"03755edadfb20848a5475d2f9a5fdeaf4526c98a","unresolved":false,"context_lines":[{"line_number":139,"context_line":""},{"line_number":140,"context_line":"        except Exception:"},{"line_number":141,"context_line":"            msg \u003d _((\"get service\u0027s user(%s) endpoint failed\") % user_name)"},{"line_number":142,"context_line":"            raise exception.AuthorizationFailure(obj\u003dmsg)"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"    def _get_karbor_auth_plugin(self, trust_id\u003dNone):"},{"line_number":145,"context_line":"        auth_plugin \u003d loading.load_auth_from_conf_options("}],"source_content_type":"text/x-python","patch_set":6,"id":"7a77a97e_cdeeedb3","line":142,"updated":"2016-11-16 02:09:34.000000000","message":"ditto","commit_id":"f734433e662017a1aef17842de70c678321b0983"}],"karbor/services/protection/bank_plugin.py":[{"author":{"_account_id":2023,"name":"Saggi Mizrahi","email":"ficoos+osreview@gmail.com","username":"ficoos"},"change_message_id":"cf4c22c22b1dcbcef0a9709d06e1e8d8ab8dbb13","unresolved":false,"context_lines":[{"line_number":209,"context_line":"                    limit,"},{"line_number":210,"context_line":"                    marker,"},{"line_number":211,"context_line":"                    sort_dir"},{"line_number":212,"context_line":"        )"},{"line_number":213,"context_line":"        ]"},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"    def delete_object(self, key):"},{"line_number":216,"context_line":"        self._validate_writable()"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a629dbe_4c51c80d","line":213,"range":{"start_line":212,"start_character":0,"end_line":213,"end_character":9},"updated":"2016-11-09 13:34:56.000000000","message":"I think the old indentation is the correct way to indent these.","commit_id":"248a1dfe02493655e5f7595d147d5b33ede30438"}]}