)]}'
{"karbor/common/config.py":[{"author":{"_account_id":20883,"name":"Yuval Brik","email":"yuval@brik.org.il","username":"yuvalbr"},"change_message_id":"3a8eeed92436d3f202b8199d34c6977b394fe29f","unresolved":false,"context_lines":[{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    cfg.StrOpt(\u0027interface\u0027,"},{"line_number":94,"context_line":"               default\u003d\u0027public\u0027,"},{"line_number":95,"context_line":"               help\u003d\u0027The network interface of the endpoint. Valid \u0027"},{"line_number":96,"context_line":"                    \u0027values are: public, admin, internal.\u0027),"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    cfg.StrOpt(\u0027ca_cert_file\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"ba5201f7_40319e59","line":95,"range":{"start_line":95,"start_character":21,"end_line":95,"end_character":58},"updated":"2017-01-11 14:59:23.000000000","message":"Might be confusing.\nDoes that mean that only public interface is registered in keystone?\nIs it the interface to use by clients? Only Karbor client or other clients as well?\n\nAlso, it is not a \u0027network interface\u0027 (such as eth0)","commit_id":"37317cdb2e12bcf53bc93b6835c4454651546120"},{"author":{"_account_id":18266,"name":"zengchen","email":"chenzeng2@huawei.com","username":"zengchen"},"change_message_id":"fb1d92963e7e5282fd5ca1baa4ae585bf235de0f","unresolved":false,"context_lines":[{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    cfg.StrOpt(\u0027interface\u0027,"},{"line_number":94,"context_line":"               default\u003d\u0027public\u0027,"},{"line_number":95,"context_line":"               help\u003d\u0027The network interface of the endpoint. Valid \u0027"},{"line_number":96,"context_line":"                    \u0027values are: public, admin, internal.\u0027),"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    cfg.StrOpt(\u0027ca_cert_file\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a3c09a3_0aac37ec","line":95,"range":{"start_line":95,"start_character":21,"end_line":95,"end_character":58},"in_reply_to":"ba5201f7_40319e59","updated":"2017-01-16 09:37:11.000000000","message":"Sorry to make you confused. This config item is used to choose which kind of interface to use in the corresponding client. There are 3 optional values which are \u0027public\u0027, \u0027internal\u0027 and \u0027admin\u0027.","commit_id":"37317cdb2e12bcf53bc93b6835c4454651546120"}],"karbor/services/protection/clients/cinder.py":[{"author":{"_account_id":20883,"name":"Yuval Brik","email":"yuval@brik.org.il","username":"yuvalbr"},"change_message_id":"3a8eeed92436d3f202b8199d34c6977b394fe29f","unresolved":false,"context_lines":[{"line_number":40,"context_line":"]"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"CONFIG_GROUP \u003d \u0027%s_client\u0027 % SERVICE"},{"line_number":43,"context_line":"cfg.CONF.register_opts(config.service_client_opts, group\u003dCONFIG_GROUP)"},{"line_number":44,"context_line":"cfg.CONF.register_opts(cinder_client_opts, group\u003dCONFIG_GROUP)"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"CINDERCLIENT_VERSION \u003d \u00273\u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"ba5201f7_8370f0a5","line":43,"range":{"start_line":43,"start_character":0,"end_line":43,"end_character":70},"updated":"2017-01-11 14:59:23.000000000","message":"you register service_client_opts, but almost all of them are not used.\nHow about registering only ConfigOpts we actually can use?\nSame goes to all other clients.","commit_id":"37317cdb2e12bcf53bc93b6835c4454651546120"},{"author":{"_account_id":18266,"name":"zengchen","email":"chenzeng2@huawei.com","username":"zengchen"},"change_message_id":"fb1d92963e7e5282fd5ca1baa4ae585bf235de0f","unresolved":false,"context_lines":[{"line_number":40,"context_line":"]"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"CONFIG_GROUP \u003d \u0027%s_client\u0027 % SERVICE"},{"line_number":43,"context_line":"cfg.CONF.register_opts(config.service_client_opts, group\u003dCONFIG_GROUP)"},{"line_number":44,"context_line":"cfg.CONF.register_opts(cinder_client_opts, group\u003dCONFIG_GROUP)"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"CINDERCLIENT_VERSION \u003d \u00273\u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a3c09a3_ca45cf17","line":43,"range":{"start_line":43,"start_character":0,"end_line":43,"end_character":70},"in_reply_to":"ba5201f7_8370f0a5","updated":"2017-01-16 09:37:11.000000000","message":"It will use same client options at last as I done in the patch https://review.openstack.org/#/c/408400","commit_id":"37317cdb2e12bcf53bc93b6835c4454651546120"}],"karbor/services/protection/clients/utils.py":[{"author":{"_account_id":20883,"name":"Yuval Brik","email":"yuval@brik.org.il","username":"yuvalbr"},"change_message_id":"3a8eeed92436d3f202b8199d34c6977b394fe29f","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"from karbor import exception"},{"line_number":14,"context_line":"from karbor.i18n import _"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"def _parse_service_catalog_info(config, context):"},{"line_number":18,"context_line":"    try:"}],"source_content_type":"text/x-python","patch_set":7,"id":"ba5201f7_23890427","line":15,"updated":"2017-01-11 14:59:23.000000000","message":"Have you used `git mv` on this file, or have you deleted it and recreated in the new position?\nCan\u0027t see the diff versus the old utils.py","commit_id":"37317cdb2e12bcf53bc93b6835c4454651546120"},{"author":{"_account_id":18266,"name":"zengchen","email":"chenzeng2@huawei.com","username":"zengchen"},"change_message_id":"fb1d92963e7e5282fd5ca1baa4ae585bf235de0f","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"from karbor import exception"},{"line_number":14,"context_line":"from karbor.i18n import _"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"def _parse_service_catalog_info(config, context):"},{"line_number":18,"context_line":"    try:"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a3c09a3_4aee3fed","line":15,"in_reply_to":"ba5201f7_23890427","updated":"2017-01-16 09:37:11.000000000","message":"Sorry. I will try to update it.","commit_id":"37317cdb2e12bcf53bc93b6835c4454651546120"},{"author":{"_account_id":17151,"name":"chenying","email":"chenyingko@gmail.com","username":"chenying"},"change_message_id":"7fd36835898c9dffb7d5feeb1ede9e68f25e48c6","unresolved":false,"context_lines":[{"line_number":70,"context_line":"    try:"},{"line_number":71,"context_line":"        keystone_plugin \u003d kwargs.get(\u0027keystone_plugin\u0027)"},{"line_number":72,"context_line":"        url \u003d keystone_plugin.get_service_endpoint("},{"line_number":73,"context_line":"            client_config.service_name, client_config.service_type,"},{"line_number":74,"context_line":"            client_config.region_id, client_config.interface)"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"        url \u003d url.replace(\"$\", \"%\")"}],"source_content_type":"text/x-python","patch_set":14,"id":"5a3905b3_abe5b7dc","line":73,"range":{"start_line":73,"start_character":12,"end_line":73,"end_character":66},"updated":"2017-01-22 06:53:46.000000000","message":"The default vaule of service_name and service_type fileds in service_client_opts is None. When they are None, we can get the default value of service_name and service_type from the \u0027SERVICE\u0027_catalog_info field of \u0027SERVICE\u0027_client_opts.","commit_id":"28ddfe19d44a041e1e94adc418d94cae059dc85f"}]}