)]}'
{"karbor/services/protection/clients/cinder.py":[{"author":{"_account_id":20883,"name":"Yuval Brik","email":"yuval@brik.org.il","username":"yuvalbr"},"change_message_id":"8e2bacface5882465f0a35b4b91b2e2316c67233","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    return client"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"def set_conf():"},{"line_number":48,"context_line":"    conf \u003d cfg.CONF"},{"line_number":49,"context_line":"    conf.register_opts(config.service_client_opts, group\u003dCONFIG_GROUP)"},{"line_number":50,"context_line":"    conf.set_default(\u0027service_name\u0027, \u0027cinderv3\u0027, CONFIG_GROUP)"},{"line_number":51,"context_line":"    conf.set_default(\u0027service_type\u0027, \u0027volumev3\u0027, CONFIG_GROUP)"},{"line_number":52,"context_line":"    conf.set_default(\u0027version\u0027, \u00273\u0027, CONFIG_GROUP)"},{"line_number":53,"context_line":"    conf.set_default(\u0027catalog_info\u0027, \u0027volumev3:cinderv3:publicURL\u0027,"},{"line_number":54,"context_line":"                     CONFIG_GROUP)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"set_conf()"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa31d9ce_30bb1ee7","line":54,"range":{"start_line":47,"start_character":0,"end_line":54,"end_character":34},"updated":"2017-02-13 15:42:59.000000000","message":"why is this applied on CONF and not the on the conf that \u0027create()\u0027 gets in the parameters?","commit_id":"28ab4c15b10193f6ef74a099653316c3ea2bf0ab"},{"author":{"_account_id":17151,"name":"chenying","email":"chenyingko@gmail.com","username":"chenying"},"change_message_id":"5e47f311d08ad89e7a32b16af49f715baf53778f","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    return client"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"def set_conf():"},{"line_number":48,"context_line":"    conf \u003d cfg.CONF"},{"line_number":49,"context_line":"    conf.register_opts(config.service_client_opts, group\u003dCONFIG_GROUP)"},{"line_number":50,"context_line":"    conf.set_default(\u0027service_name\u0027, \u0027cinderv3\u0027, CONFIG_GROUP)"},{"line_number":51,"context_line":"    conf.set_default(\u0027service_type\u0027, \u0027volumev3\u0027, CONFIG_GROUP)"},{"line_number":52,"context_line":"    conf.set_default(\u0027version\u0027, \u00273\u0027, CONFIG_GROUP)"},{"line_number":53,"context_line":"    conf.set_default(\u0027catalog_info\u0027, \u0027volumev3:cinderv3:publicURL\u0027,"},{"line_number":54,"context_line":"                     CONFIG_GROUP)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"set_conf()"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa31d9ce_5c396fa3","line":54,"range":{"start_line":47,"start_character":0,"end_line":54,"end_character":34},"in_reply_to":"fa31d9ce_30bb1ee7","updated":"2017-02-14 07:54:06.000000000","message":"I will fix it.","commit_id":"28ab4c15b10193f6ef74a099653316c3ea2bf0ab"}],"karbor/tests/unit/plugins/test_image_protectable_plugin.py":[{"author":{"_account_id":20883,"name":"Yuval Brik","email":"yuval@brik.org.il","username":"yuvalbr"},"change_message_id":"3a9770163ad85226b2d4ac3fcc63a7116f1577f2","unresolved":false,"context_lines":[{"line_number":55,"context_line":"                                       auth_token\u003d\u0027efgh\u0027,"},{"line_number":56,"context_line":"                                       service_catalog\u003dservice_catalog)"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        clients.nova.set_conf(CONF)"},{"line_number":59,"context_line":"        clients.glance.set_conf(CONF)"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    @mock.patch(\u0027karbor.services.protection.client_factory.ClientFactory.\u0027"},{"line_number":62,"context_line":"                \u0027_generate_session\u0027)"}],"source_content_type":"text/x-python","patch_set":11,"id":"fa31d9ce_d3fd136f","line":59,"range":{"start_line":58,"start_character":0,"end_line":59,"end_character":37},"updated":"2017-02-15 11:39:34.000000000","message":"why is this necessary?","commit_id":"0f0aedd074a8208c5e8070660a5f9965c3773472"},{"author":{"_account_id":17151,"name":"chenying","email":"chenyingko@gmail.com","username":"chenying"},"change_message_id":"a885a316facc46094dcdba48f843212a50773fc1","unresolved":false,"context_lines":[{"line_number":55,"context_line":"                                       auth_token\u003d\u0027efgh\u0027,"},{"line_number":56,"context_line":"                                       service_catalog\u003dservice_catalog)"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        clients.nova.set_conf(CONF)"},{"line_number":59,"context_line":"        clients.glance.set_conf(CONF)"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    @mock.patch(\u0027karbor.services.protection.client_factory.ClientFactory.\u0027"},{"line_number":62,"context_line":"                \u0027_generate_session\u0027)"}],"source_content_type":"text/x-python","patch_set":11,"id":"fa31d9ce_aade59da","line":59,"range":{"start_line":58,"start_character":0,"end_line":59,"end_character":37},"in_reply_to":"fa31d9ce_d3fd136f","updated":"2017-02-15 12:43:13.000000000","message":"conf.register_opts(config.service_client_opts, group\u003dCONFIG_GROUP)\n\nThe service_client_opts in CONFIG_GROUP is registered in the set_conf methold of client firstly.","commit_id":"0f0aedd074a8208c5e8070660a5f9965c3773472"},{"author":{"_account_id":17151,"name":"chenying","email":"chenyingko@gmail.com","username":"chenying"},"change_message_id":"bab5a05aafbd04cb8f1ed8f055966ed56cc0711f","unresolved":false,"context_lines":[{"line_number":61,"context_line":"    @mock.patch(\u0027karbor.services.protection.client_factory.ClientFactory.\u0027"},{"line_number":62,"context_line":"                \u0027_generate_session\u0027)"},{"line_number":63,"context_line":"    def test_create_client_by_endpoint(self, mock_generate_session):"},{"line_number":64,"context_line":"        CONF.set_default(\u0027endpoint\u0027, \u0027http://127.0.0.1:9292\u0027,"},{"line_number":65,"context_line":"                         \u0027glance_client\u0027)"},{"line_number":66,"context_line":"        CONF.set_default(\u0027endpoint\u0027, \u0027http://127.0.0.1:8774/v2.1\u0027,"},{"line_number":67,"context_line":"                         \u0027nova_client\u0027)"},{"line_number":68,"context_line":"        plugin \u003d ImageProtectablePlugin(self._context)"},{"line_number":69,"context_line":"        mock_generate_session.return_value \u003d keystone_session.Session("},{"line_number":70,"context_line":"            auth\u003dNone)"}],"source_content_type":"text/x-python","patch_set":11,"id":"fa31d9ce_a5fccab8","line":67,"range":{"start_line":64,"start_character":0,"end_line":67,"end_character":39},"updated":"2017-02-15 12:55:55.000000000","message":"If the set_default of nova_client conf is called here, so the glance_client group must be registered first.","commit_id":"0f0aedd074a8208c5e8070660a5f9965c3773472"}]}