)]}'
{"karbor/services/operationengine/karbor_client.py":[{"author":{"_account_id":20883,"name":"Yuval Brik","email":"yuval@brik.org.il","username":"yuvalbr"},"change_message_id":"275fe7721ca4f72b4ba144026ef18e135224aa44","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        url \u003d kc_plugin.get_service_endpoint("},{"line_number":33,"context_line":"            sc_cfg.service_name, sc_cfg.service_type, sc_cfg.region_id)"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"        return url.replace(\"$\", \"%\")"},{"line_number":36,"context_line":"    except Exception:"},{"line_number":37,"context_line":"        raise"},{"line_number":38,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1a6eadb0_d1e6b543","line":35,"range":{"start_line":35,"start_character":0,"end_line":35,"end_character":36},"updated":"2016-12-19 08:51:59.000000000","message":"why not just change $ to % in the urls?","commit_id":"0e8a55818765cdca570850e762919acbea946fb3"},{"author":{"_account_id":20883,"name":"Yuval Brik","email":"yuval@brik.org.il","username":"yuvalbr"},"change_message_id":"ecb632ba6b929ddac295e289d507c7622d2d8a09","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        url \u003d kc_plugin.get_service_endpoint("},{"line_number":33,"context_line":"            sc_cfg.service_name, sc_cfg.service_type, sc_cfg.region_id)"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"        return url.replace(\"$\", \"%\")"},{"line_number":36,"context_line":"    except Exception:"},{"line_number":37,"context_line":"        raise"},{"line_number":38,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1a6eadb0_c7ac378f","line":35,"range":{"start_line":35,"start_character":0,"end_line":35,"end_character":36},"in_reply_to":"1a6eadb0_51e625e9","updated":"2016-12-19 09:53:59.000000000","message":"can we split this and the formatting using % into a different patch? have this patch only rename tenant_id -\u003e project_id\nWhy use % formatting instead of replace? What if someone somehow have another $ in the url?","commit_id":"0e8a55818765cdca570850e762919acbea946fb3"},{"author":{"_account_id":18266,"name":"zengchen","email":"chenzeng2@huawei.com","username":"zengchen"},"change_message_id":"fe8b88e49e83fcbbb9a44e266db3481ee72b0edf","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        url \u003d kc_plugin.get_service_endpoint("},{"line_number":33,"context_line":"            sc_cfg.service_name, sc_cfg.service_type, sc_cfg.region_id)"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"        return url.replace(\"$\", \"%\")"},{"line_number":36,"context_line":"    except Exception:"},{"line_number":37,"context_line":"        raise"},{"line_number":38,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1a6eadb0_588374cc","line":35,"range":{"start_line":35,"start_character":0,"end_line":35,"end_character":36},"in_reply_to":"1a6eadb0_c7ac378f","updated":"2016-12-20 06:54:25.000000000","message":"Like other services such as Cinder, Nova, their endpoints looks like that which use $ instead of %. I think it is some kind of rule. If someday Karbor\u0027s endpoint allow the single $, then the unit test will find the conflict.","commit_id":"0e8a55818765cdca570850e762919acbea946fb3"},{"author":{"_account_id":18266,"name":"zengchen","email":"chenzeng2@huawei.com","username":"zengchen"},"change_message_id":"a90721098db34dbede91c5f217351cda55eb4873","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        url \u003d kc_plugin.get_service_endpoint("},{"line_number":33,"context_line":"            sc_cfg.service_name, sc_cfg.service_type, sc_cfg.region_id)"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"        return url.replace(\"$\", \"%\")"},{"line_number":36,"context_line":"    except Exception:"},{"line_number":37,"context_line":"        raise"},{"line_number":38,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1a6eadb0_244d8572","line":35,"range":{"start_line":35,"start_character":0,"end_line":35,"end_character":36},"in_reply_to":"1a6eadb0_c7ac378f","updated":"2016-12-21 01:53:39.000000000","message":"see: https://github.com/openstack/keystone/blob/master/keystone/common/utils.py#L633\n\nhttps://github.com/openstack/keystone/blob/master/keystone/catalog/backends/templated.py#L68","commit_id":"0e8a55818765cdca570850e762919acbea946fb3"},{"author":{"_account_id":18266,"name":"zengchen","email":"chenzeng2@huawei.com","username":"zengchen"},"change_message_id":"a6e9a572d858e2a51f096a8604d86c56f60a9d4e","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        url \u003d kc_plugin.get_service_endpoint("},{"line_number":33,"context_line":"            sc_cfg.service_name, sc_cfg.service_type, sc_cfg.region_id)"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"        return url.replace(\"$\", \"%\")"},{"line_number":36,"context_line":"    except Exception:"},{"line_number":37,"context_line":"        raise"},{"line_number":38,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1a6eadb0_51e625e9","line":35,"range":{"start_line":35,"start_character":0,"end_line":35,"end_character":36},"in_reply_to":"1a6eadb0_d1e6b543","updated":"2016-12-19 09:00:24.000000000","message":"Because the endpoints of Karbor are like this.\nhttp://10.229.45.150:8799/v1/$(tenant_id)s. It just only needs replace \u0027$\u0027.","commit_id":"0e8a55818765cdca570850e762919acbea946fb3"}]}