)]}'
{"karbor/services/protection/protection_plugins/network/neutron_protection_plugin.py":[{"author":{"_account_id":19346,"name":"yinwei","email":"yinweiishere@icloud.com","username":"yinwei"},"change_message_id":"bab8c2a385e5e0d9870ac360cddc44da0a17ec1a","unresolved":false,"context_lines":[{"line_number":293,"context_line":"            properties[\"name\"] \u003d sub_data[\"name\"]"},{"line_number":294,"context_line":"            properties[\"ip_version\"] \u003d sub_data[\"ip_version\"]"},{"line_number":295,"context_line":"            properties[\"name\"] \u003d sub_data[\"name\"]"},{"line_number":296,"context_line":"            properties[\"network_id\"] \u003d sub_data[\"network_id\"]"},{"line_number":297,"context_line":"            properties[\"tenant_id\"] \u003d sub_data[\"tenant_id\"]"},{"line_number":298,"context_line":""},{"line_number":299,"context_line":"            for key, value in properties.items():"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa31d9ce_d1073d7f","line":296,"updated":"2017-02-13 09:02:06.000000000","message":"here won\u0027t work since during restoration, network has been rebuilt and thus its network id will be changed as well.\nHere you should refer to resource network, otherwise heat will take subnet and network without dependency.","commit_id":"9cf79aa1469e94516369f361db4edcd1c380b57f"},{"author":{"_account_id":16206,"name":"chenhuayi","email":"chenhuayi@huawei.com","username":"chenhuayi2"},"change_message_id":"7099c4968f54112b965f19f1ed7b93c5d2c3a1cd","unresolved":false,"context_lines":[{"line_number":293,"context_line":"            properties[\"name\"] \u003d sub_data[\"name\"]"},{"line_number":294,"context_line":"            properties[\"ip_version\"] \u003d sub_data[\"ip_version\"]"},{"line_number":295,"context_line":"            properties[\"name\"] \u003d sub_data[\"name\"]"},{"line_number":296,"context_line":"            properties[\"network_id\"] \u003d sub_data[\"network_id\"]"},{"line_number":297,"context_line":"            properties[\"tenant_id\"] \u003d sub_data[\"tenant_id\"]"},{"line_number":298,"context_line":""},{"line_number":299,"context_line":"            for key, value in properties.items():"}],"source_content_type":"text/x-python","patch_set":1,"id":"da36d5c6_9d8558d0","line":296,"in_reply_to":"fa31d9ce_d1073d7f","updated":"2017-02-25 04:02:30.000000000","message":"Done. heat use \"get_resource\".","commit_id":"9cf79aa1469e94516369f361db4edcd1c380b57f"},{"author":{"_account_id":19346,"name":"yinwei","email":"yinweiishere@icloud.com","username":"yinwei"},"change_message_id":"bab8c2a385e5e0d9870ac360cddc44da0a17ec1a","unresolved":false,"context_lines":[{"line_number":404,"context_line":"                nets_meta \u003d resource_definition[\"network_metadata\"]"},{"line_number":405,"context_line":"                nets_heatresource \u003d self.get_nets_heatresource(nets_meta)"},{"line_number":406,"context_line":"                for net_heatresource in nets_heatresource:"},{"line_number":407,"context_line":"                    heat_template.put_resource(resource_id, net_heatresource)"},{"line_number":408,"context_line":""},{"line_number":409,"context_line":"            # Config Subnet"},{"line_number":410,"context_line":"            if \"subnet_metadata\" in resource_definition:"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa31d9ce_b182c950","line":407,"updated":"2017-02-13 09:02:06.000000000","message":"Trivial:\nwhy double loops in get heat resource and put resource? seems not efficient.  If this is the restore framework defect, we should enhance the framework, say binding a resource set and for each functor to put_resource().","commit_id":"9cf79aa1469e94516369f361db4edcd1c380b57f"},{"author":{"_account_id":16206,"name":"chenhuayi","email":"chenhuayi@huawei.com","username":"chenhuayi2"},"change_message_id":"7099c4968f54112b965f19f1ed7b93c5d2c3a1cd","unresolved":false,"context_lines":[{"line_number":404,"context_line":"                nets_meta \u003d resource_definition[\"network_metadata\"]"},{"line_number":405,"context_line":"                nets_heatresource \u003d self.get_nets_heatresource(nets_meta)"},{"line_number":406,"context_line":"                for net_heatresource in nets_heatresource:"},{"line_number":407,"context_line":"                    heat_template.put_resource(resource_id, net_heatresource)"},{"line_number":408,"context_line":""},{"line_number":409,"context_line":"            # Config Subnet"},{"line_number":410,"context_line":"            if \"subnet_metadata\" in resource_definition:"}],"source_content_type":"text/x-python","patch_set":1,"id":"da36d5c6_1dc32858","line":407,"in_reply_to":"fa31d9ce_b182c950","updated":"2017-02-25 04:02:30.000000000","message":"Done. Have enhanced the framework.","commit_id":"9cf79aa1469e94516369f361db4edcd1c380b57f"}]}