)]}'
{"karbor/services/protection/protection_plugins/eisoo/oracle/oracle_protection_plugin.py":[{"author":{"_account_id":17151,"name":"chenying","email":"chenyingko@gmail.com","username":"chenying"},"change_message_id":"64a062747c2df17068a6854c09d5d9a52b9571a6","unresolved":false,"context_lines":[{"line_number":95,"context_line":"        self._interval \u003d poll_interval"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    def _get_backup_type(self, backup_mode):"},{"line_number":98,"context_line":"        if backup_mode \u003d\u003d \"full\":"},{"line_number":99,"context_line":"            backup_type \u003d 1"},{"line_number":100,"context_line":"        elif backup_mode \u003d\u003d \"incremental\":"},{"line_number":101,"context_line":"            backup_type \u003d 2"},{"line_number":102,"context_line":"        elif backup_mode \u003d\u003d \"log\":"},{"line_number":103,"context_line":"            backup_type \u003d 4"},{"line_number":104,"context_line":"        else:"},{"line_number":105,"context_line":"            backup_type \u003d 1"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"        return backup_type"},{"line_number":108,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a30ddce_fb2d7bfe","line":105,"range":{"start_line":98,"start_character":0,"end_line":105,"end_character":27},"updated":"2017-03-13 03:38:01.000000000","message":"It is better that the value of these backup types can be defined as constants in this module like the \u0027ORACLE_JOB_TYPE\u0027.","commit_id":"610a7f9df3cfb2c396850e7c90fc218886870ff9"},{"author":{"_account_id":25561,"name":"zhu.tuozhi","email":"zhutuozhi@gmail.com","username":"zhu.tuozhi"},"change_message_id":"df55cd8371ba750c24f8cb98162efd8cec76d76e","unresolved":false,"context_lines":[{"line_number":95,"context_line":"        self._interval \u003d poll_interval"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    def _get_backup_type(self, backup_mode):"},{"line_number":98,"context_line":"        if backup_mode \u003d\u003d \"full\":"},{"line_number":99,"context_line":"            backup_type \u003d 1"},{"line_number":100,"context_line":"        elif backup_mode \u003d\u003d \"incremental\":"},{"line_number":101,"context_line":"            backup_type \u003d 2"},{"line_number":102,"context_line":"        elif backup_mode \u003d\u003d \"log\":"},{"line_number":103,"context_line":"            backup_type \u003d 4"},{"line_number":104,"context_line":"        else:"},{"line_number":105,"context_line":"            backup_type \u003d 1"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"        return backup_type"},{"line_number":108,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ffe62b97_86f13c98","line":105,"range":{"start_line":98,"start_character":0,"end_line":105,"end_character":27},"in_reply_to":"9a30ddce_fb2d7bfe","updated":"2017-03-28 07:13:09.000000000","message":"todo","commit_id":"610a7f9df3cfb2c396850e7c90fc218886870ff9"},{"author":{"_account_id":17151,"name":"chenying","email":"chenyingko@gmail.com","username":"chenying"},"change_message_id":"64a062747c2df17068a6854c09d5d9a52b9571a6","unresolved":false,"context_lines":[{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    def _create_backup(self, cntxt, checkpoint, resource,"},{"line_number":118,"context_line":"                       user_name, password, backup_mode, max_copies):"},{"line_number":119,"context_line":"        # resource \u003d resource_node.value"},{"line_number":120,"context_line":"        oracle_id \u003d resource.id"},{"line_number":121,"context_line":"        oracle_name \u003d resource.name"},{"line_number":122,"context_line":"        client_mac \u003d get_client_mac(oracle_id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a30ddce_1b316f5a","line":119,"range":{"start_line":119,"start_character":8,"end_line":119,"end_character":40},"updated":"2017-03-13 03:38:01.000000000","message":"It could be deleted.","commit_id":"610a7f9df3cfb2c396850e7c90fc218886870ff9"},{"author":{"_account_id":25561,"name":"zhu.tuozhi","email":"zhutuozhi@gmail.com","username":"zhu.tuozhi"},"change_message_id":"df55cd8371ba750c24f8cb98162efd8cec76d76e","unresolved":false,"context_lines":[{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    def _create_backup(self, cntxt, checkpoint, resource,"},{"line_number":118,"context_line":"                       user_name, password, backup_mode, max_copies):"},{"line_number":119,"context_line":"        # resource \u003d resource_node.value"},{"line_number":120,"context_line":"        oracle_id \u003d resource.id"},{"line_number":121,"context_line":"        oracle_name \u003d resource.name"},{"line_number":122,"context_line":"        client_mac \u003d get_client_mac(oracle_id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ffe62b97_06e52cdc","line":119,"range":{"start_line":119,"start_character":8,"end_line":119,"end_character":40},"in_reply_to":"9a30ddce_1b316f5a","updated":"2017-03-28 07:13:09.000000000","message":"todo","commit_id":"610a7f9df3cfb2c396850e7c90fc218886870ff9"},{"author":{"_account_id":17151,"name":"chenying","email":"chenyingko@gmail.com","username":"chenying"},"change_message_id":"64a062747c2df17068a6854c09d5d9a52b9571a6","unresolved":false,"context_lines":[{"line_number":127,"context_line":"        arguments \u003d \"\""},{"line_number":128,"context_line":"        job_adv_property \u003d {}"},{"line_number":129,"context_line":"        if max_copies is not None:"},{"line_number":130,"context_line":"            job_adv_property[\u0027max_copies\u0027] \u003d max_copies"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"        eisoo_client \u003d ClientFactory.create_client(\"eisoo\", cntxt)"},{"line_number":133,"context_line":"        bank_section \u003d checkpoint.get_resource_bank_section(oracle_id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a30ddce_bb4863cd","line":130,"range":{"start_line":130,"start_character":12,"end_line":130,"end_character":55},"updated":"2017-03-13 03:38:01.000000000","message":"If the the parameter max_copies is None, do we need define the default value of max_copies for job property?","commit_id":"610a7f9df3cfb2c396850e7c90fc218886870ff9"},{"author":{"_account_id":25561,"name":"zhu.tuozhi","email":"zhutuozhi@gmail.com","username":"zhu.tuozhi"},"change_message_id":"df55cd8371ba750c24f8cb98162efd8cec76d76e","unresolved":false,"context_lines":[{"line_number":127,"context_line":"        arguments \u003d \"\""},{"line_number":128,"context_line":"        job_adv_property \u003d {}"},{"line_number":129,"context_line":"        if max_copies is not None:"},{"line_number":130,"context_line":"            job_adv_property[\u0027max_copies\u0027] \u003d max_copies"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"        eisoo_client \u003d ClientFactory.create_client(\"eisoo\", cntxt)"},{"line_number":133,"context_line":"        bank_section \u003d checkpoint.get_resource_bank_section(oracle_id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ffe62b97_80a92425","line":130,"range":{"start_line":130,"start_character":12,"end_line":130,"end_character":55},"in_reply_to":"9a30ddce_bb4863cd","updated":"2017-03-28 07:13:09.000000000","message":"job  advPropertys can be empty","commit_id":"610a7f9df3cfb2c396850e7c90fc218886870ff9"},{"author":{"_account_id":17151,"name":"chenying","email":"chenyingko@gmail.com","username":"chenying"},"change_message_id":"64a062747c2df17068a6854c09d5d9a52b9571a6","unresolved":false,"context_lines":[{"line_number":172,"context_line":"                failure_statuses\u003d{eisoo.FAILED},"},{"line_number":173,"context_line":"                ignore_statuses\u003d{eisoo.RUNNING},"},{"line_number":174,"context_line":"            )"},{"line_number":175,"context_line":"            if not is_success:"},{"line_number":176,"context_line":"                raise Exception"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"        except Exception as e:"},{"line_number":179,"context_line":"            LOG.error(_LE(\"create oracle backup failed, oracle_id: %s.\"),"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a30ddce_5b6f67fb","line":176,"range":{"start_line":175,"start_character":30,"end_line":176,"end_character":31},"updated":"2017-03-13 03:38:01.000000000","message":"If the status of backup is failed, can we get the failed reason form the backup object, so the error messages of this backup can be set to the Exception directly.","commit_id":"610a7f9df3cfb2c396850e7c90fc218886870ff9"},{"author":{"_account_id":25561,"name":"zhu.tuozhi","email":"zhutuozhi@gmail.com","username":"zhu.tuozhi"},"change_message_id":"df55cd8371ba750c24f8cb98162efd8cec76d76e","unresolved":false,"context_lines":[{"line_number":172,"context_line":"                failure_statuses\u003d{eisoo.FAILED},"},{"line_number":173,"context_line":"                ignore_statuses\u003d{eisoo.RUNNING},"},{"line_number":174,"context_line":"            )"},{"line_number":175,"context_line":"            if not is_success:"},{"line_number":176,"context_line":"                raise Exception"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"        except Exception as e:"},{"line_number":179,"context_line":"            LOG.error(_LE(\"create oracle backup failed, oracle_id: %s.\"),"}],"source_content_type":"text/x-python","patch_set":2,"id":"ffe62b97_60f86048","line":176,"range":{"start_line":175,"start_character":30,"end_line":176,"end_character":31},"in_reply_to":"9a30ddce_5b6f67fb","updated":"2017-03-28 07:13:09.000000000","message":"we cannot get the failed reason ,the failed reason return by Exception","commit_id":"610a7f9df3cfb2c396850e7c90fc218886870ff9"},{"author":{"_account_id":17151,"name":"chenying","email":"chenyingko@gmail.com","username":"chenying"},"change_message_id":"64a062747c2df17068a6854c09d5d9a52b9571a6","unresolved":false,"context_lines":[{"line_number":225,"context_line":"                ignore_statuses\u003d{eisoo.RUNNING},"},{"line_number":226,"context_line":"            )"},{"line_number":227,"context_line":"            if not is_success:"},{"line_number":228,"context_line":"                raise Exception"},{"line_number":229,"context_line":""},{"line_number":230,"context_line":"        except Exception as e:"},{"line_number":231,"context_line":"            LOG.error(_LE(\"restore oracle backup failed, oracle_id: %s.\"),"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a30ddce_db7b57bc","line":228,"range":{"start_line":228,"start_character":16,"end_line":228,"end_character":31},"updated":"2017-03-13 03:38:01.000000000","message":"ditto","commit_id":"610a7f9df3cfb2c396850e7c90fc218886870ff9"},{"author":{"_account_id":25561,"name":"zhu.tuozhi","email":"zhutuozhi@gmail.com","username":"zhu.tuozhi"},"change_message_id":"df55cd8371ba750c24f8cb98162efd8cec76d76e","unresolved":false,"context_lines":[{"line_number":225,"context_line":"                ignore_statuses\u003d{eisoo.RUNNING},"},{"line_number":226,"context_line":"            )"},{"line_number":227,"context_line":"            if not is_success:"},{"line_number":228,"context_line":"                raise Exception"},{"line_number":229,"context_line":""},{"line_number":230,"context_line":"        except Exception as e:"},{"line_number":231,"context_line":"            LOG.error(_LE(\"restore oracle backup failed, oracle_id: %s.\"),"}],"source_content_type":"text/x-python","patch_set":2,"id":"ffe62b97_a6ca004b","line":228,"range":{"start_line":228,"start_character":16,"end_line":228,"end_character":31},"in_reply_to":"9a30ddce_db7b57bc","updated":"2017-03-28 07:13:09.000000000","message":"we cannot get the failed reason ,the failed reason return by Exception","commit_id":"610a7f9df3cfb2c396850e7c90fc218886870ff9"}]}