)]}'
{"karbor/services/protection/clients/manila.py":[{"author":{"_account_id":20883,"name":"Yuval Brik","email":"yuval@brik.org.il","username":"yuvalbr"},"change_message_id":"47b4585b068b1eefdc0a0948ed307525a6768e80","unresolved":false,"context_lines":[{"line_number":58,"context_line":"                        append_project_fmt\u003d\u0027%(url)s/%(project)s\u0027, **kwargs)"},{"line_number":59,"context_line":"    LOG.debug(\u0027Creating manila client with url %s.\u0027, url)"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    session \u003d kwargs.get(\u0027session\u0027)"},{"line_number":62,"context_line":"    if session is None:"},{"line_number":63,"context_line":"        LOG.error(\u0027Creating manila client failed with url %s.\u0027, url)"},{"line_number":64,"context_line":"        raise exception.InvalidParameterValue("},{"line_number":65,"context_line":"            err\u003d\"The parameter session is None.\")"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    return mc.Client(MANILACLIENT_VERSION, session\u003dkwargs.get(\u0027session\u0027),"},{"line_number":68,"context_line":"                     endpoint_override\u003durl)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ffe62b97_17fec336","line":68,"range":{"start_line":61,"start_character":0,"end_line":68,"end_character":43},"updated":"2017-03-26 07:58:56.000000000","message":"Can\u0027t we create client without session?\nOther clients handle that","commit_id":"550eaf2e035a9ca2861e244e2a7eee68a8f8b174"},{"author":{"_account_id":20883,"name":"Yuval Brik","email":"yuval@brik.org.il","username":"yuvalbr"},"change_message_id":"57785234b0b837bac8bdbceeef523b16ae2e0445","unresolved":false,"context_lines":[{"line_number":58,"context_line":"                        append_project_fmt\u003d\u0027%(url)s/%(project)s\u0027, **kwargs)"},{"line_number":59,"context_line":"    LOG.debug(\u0027Creating manila client with url %s.\u0027, url)"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    session \u003d kwargs.get(\u0027session\u0027)"},{"line_number":62,"context_line":"    if session is None:"},{"line_number":63,"context_line":"        LOG.error(\u0027Creating manila client failed with url %s.\u0027, url)"},{"line_number":64,"context_line":"        raise exception.InvalidParameterValue("},{"line_number":65,"context_line":"            err\u003d\"The parameter session is None.\")"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    return mc.Client(MANILACLIENT_VERSION, session\u003dkwargs.get(\u0027session\u0027),"},{"line_number":68,"context_line":"                     endpoint_override\u003durl)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ffe62b97_7e2b9881","line":68,"range":{"start_line":61,"start_character":0,"end_line":68,"end_character":43},"in_reply_to":"ffe62b97_11048849","updated":"2017-03-27 08:34:30.000000000","message":"From what I see, most use SessionClient instead of HttpClient, but you can still pass url parameter or auth info, and the python client will create session for you.","commit_id":"550eaf2e035a9ca2861e244e2a7eee68a8f8b174"},{"author":{"_account_id":17151,"name":"chenying","email":"chenyingko@gmail.com","username":"chenying"},"change_message_id":"578037488010c30ab44ffacb85f31edb155bdfd3","unresolved":false,"context_lines":[{"line_number":58,"context_line":"                        append_project_fmt\u003d\u0027%(url)s/%(project)s\u0027, **kwargs)"},{"line_number":59,"context_line":"    LOG.debug(\u0027Creating manila client with url %s.\u0027, url)"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    session \u003d kwargs.get(\u0027session\u0027)"},{"line_number":62,"context_line":"    if session is None:"},{"line_number":63,"context_line":"        LOG.error(\u0027Creating manila client failed with url %s.\u0027, url)"},{"line_number":64,"context_line":"        raise exception.InvalidParameterValue("},{"line_number":65,"context_line":"            err\u003d\"The parameter session is None.\")"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    return mc.Client(MANILACLIENT_VERSION, session\u003dkwargs.get(\u0027session\u0027),"},{"line_number":68,"context_line":"                     endpoint_override\u003durl)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ffe62b97_11048849","line":68,"range":{"start_line":61,"start_character":0,"end_line":68,"end_character":43},"in_reply_to":"ffe62b97_17fec336","updated":"2017-03-27 02:38:51.000000000","message":"Creating client with httpclient in nova has been removed in ocata. More and more project will use session as the only way to initialize a client. So I am thinking about that whether we should support using httpclient to create a client now.What\u0027s your oppion about it?","commit_id":"550eaf2e035a9ca2861e244e2a7eee68a8f8b174"},{"author":{"_account_id":18266,"name":"zengchen","email":"chenzeng2@huawei.com","username":"zengchen"},"change_message_id":"fa67181b8abe58bc690acad43d05528fa80d305b","unresolved":false,"context_lines":[{"line_number":20,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"SERVICE \u003d \"manila\""},{"line_number":23,"context_line":"manila_client_opts \u003d ["},{"line_number":24,"context_line":"    cfg.StrOpt(SERVICE + \u0027_endpoint\u0027,"},{"line_number":25,"context_line":"               help\u003d\u0027URL of the manila endpoint.\u0027),"},{"line_number":26,"context_line":"    cfg.StrOpt(SERVICE + \u0027_catalog_info\u0027,"},{"line_number":27,"context_line":"               default\u003d\u0027sharev2:manilav2:publicURL\u0027,"},{"line_number":28,"context_line":"               help\u003d\u0027Info to match when looking for manila in the service \u0027"},{"line_number":29,"context_line":"               \u0027catalog. Format is: separated values of the form: \u0027"},{"line_number":30,"context_line":"               \u0027\u003cservice_type\u003e:\u003cservice_name\u003e:\u003cendpoint_type\u003e - \u0027"},{"line_number":31,"context_line":"               \u0027Only used if manila_endpoint is unset\u0027),"},{"line_number":32,"context_line":"    cfg.StrOpt(SERVICE + \u0027_ca_cert_file\u0027,"},{"line_number":33,"context_line":"               default\u003dNone,"},{"line_number":34,"context_line":"               help\u003d\u0027Location of the CA certificate file \u0027"},{"line_number":35,"context_line":"                    \u0027to use for client requests in SSL connections.\u0027),"},{"line_number":36,"context_line":"    cfg.BoolOpt(SERVICE + \u0027_auth_insecure\u0027,"},{"line_number":37,"context_line":"                default\u003dFalse,"},{"line_number":38,"context_line":"                help\u003d\u0027Bypass verification of server certificate when \u0027"},{"line_number":39,"context_line":"                     \u0027making SSL connection to manila.\u0027),"},{"line_number":40,"context_line":"]"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"CONFIG_GROUP \u003d \u0027%s_client\u0027 % SERVICE"},{"line_number":43,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":2,"id":"ffe62b97_5e895872","line":40,"range":{"start_line":23,"start_character":0,"end_line":40,"end_character":1},"updated":"2017-03-30 03:48:42.000000000","message":"Shall we talk about using uniform configuration in next meeting. I think it is not a good way to write so many duplicate codes.","commit_id":"22830b3738f721fcf2f37d822ff29dcbbba76f6b"}],"karbor/tests/unit/clients/test_manila_client.py":[{"author":{"_account_id":20883,"name":"Yuval Brik","email":"yuval@brik.org.il","username":"yuvalbr"},"change_message_id":"47b4585b068b1eefdc0a0948ed307525a6768e80","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    @mock.patch(\u0027karbor.services.protection.clients.utils.get_url\u0027)"},{"line_number":41,"context_line":"    @mock.patch(\u0027manilaclient.client.Client\u0027)"},{"line_number":42,"context_line":"    def test_create_client(self, create, get_url):"},{"line_number":43,"context_line":"        get_url.return_value \u003d self._public_url"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"        client_version \u003d manila.MANILACLIENT_VERSION"}],"source_content_type":"text/x-python","patch_set":1,"id":"ffe62b97_f7f8ff49","line":42,"range":{"start_line":42,"start_character":0,"end_line":42,"end_character":50},"updated":"2017-03-26 07:58:56.000000000","message":"add test to create with and without session","commit_id":"550eaf2e035a9ca2861e244e2a7eee68a8f8b174"},{"author":{"_account_id":17151,"name":"chenying","email":"chenyingko@gmail.com","username":"chenying"},"change_message_id":"578037488010c30ab44ffacb85f31edb155bdfd3","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    @mock.patch(\u0027karbor.services.protection.clients.utils.get_url\u0027)"},{"line_number":41,"context_line":"    @mock.patch(\u0027manilaclient.client.Client\u0027)"},{"line_number":42,"context_line":"    def test_create_client(self, create, get_url):"},{"line_number":43,"context_line":"        get_url.return_value \u003d self._public_url"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"        client_version \u003d manila.MANILACLIENT_VERSION"}],"source_content_type":"text/x-python","patch_set":1,"id":"ffe62b97_b1f83c49","line":42,"range":{"start_line":42,"start_character":0,"end_line":42,"end_character":50},"in_reply_to":"ffe62b97_f7f8ff49","updated":"2017-03-27 02:38:51.000000000","message":"ditto","commit_id":"550eaf2e035a9ca2861e244e2a7eee68a8f8b174"}]}