)]}'
{"etc/providers.d/noop.conf":[{"author":{"_account_id":17151,"name":"chenying","email":"chenyingko@gmail.com","username":"chenying"},"change_message_id":"6ff3772b515827f0a520a5b31c850f6e9730a1c8","unresolved":false,"context_lines":[{"line_number":6,"context_line":"plugin\u003dkarbor-noop-protection-plugin"},{"line_number":7,"context_line":"bank\u003dkarbor-swift-bank-plugin"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"enabled\u003dFalse"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"[swift_client]"},{"line_number":12,"context_line":"swift_auth_url\u003dhttp://127.0.0.1/identity"}],"source_content_type":"text/plain","patch_set":2,"id":"1f1a1f67_7c8676bb","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":13},"updated":"2017-07-19 06:35:26.000000000","message":"The enabled attribute of this provider should be True. There are some fullstack tests using this provider.","commit_id":"df133f860a955dcbae5a40aa2e76ae890223266a"},{"author":{"_account_id":21224,"name":"jiaopengju","email":"jiaopengju_yewu@cmss.chinamobile.com","username":"jiaopengju"},"change_message_id":"b355ab5a48ed9aed761024b6679da9c62c880617","unresolved":false,"context_lines":[{"line_number":6,"context_line":"plugin\u003dkarbor-noop-protection-plugin"},{"line_number":7,"context_line":"bank\u003dkarbor-swift-bank-plugin"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"enabled\u003dFalse"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"[swift_client]"},{"line_number":12,"context_line":"swift_auth_url\u003dhttp://127.0.0.1/identity"}],"source_content_type":"text/plain","patch_set":2,"id":"1f1a1f67_4fc899a4","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":13},"in_reply_to":"1f1a1f67_7c8676bb","updated":"2017-07-19 09:32:46.000000000","message":"Done","commit_id":"df133f860a955dcbae5a40aa2e76ae890223266a"}],"etc/providers.d/openstack-fs-bank.conf":[{"author":{"_account_id":17151,"name":"chenying","email":"chenyingko@gmail.com","username":"chenying"},"change_message_id":"6ff3772b515827f0a520a5b31c850f6e9730a1c8","unresolved":false,"context_lines":[{"line_number":8,"context_line":"plugin\u003dkarbor-server-protection-plugin"},{"line_number":9,"context_line":"bank\u003dkarbor-fs-bank-plugin"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"enabled\u003dFalse"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"[file_system_bank_plugin]"},{"line_number":14,"context_line":"file_system_bank_path\u003d/opt/stack/karbor_fs_bank"}],"source_content_type":"text/plain","patch_set":2,"id":"1f1a1f67_1cc1c2e5","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":13},"updated":"2017-07-19 06:35:26.000000000","message":"The enabled attribute of this provider should be True. There are some fullstack tests using this provider.","commit_id":"df133f860a955dcbae5a40aa2e76ae890223266a"},{"author":{"_account_id":21224,"name":"jiaopengju","email":"jiaopengju_yewu@cmss.chinamobile.com","username":"jiaopengju"},"change_message_id":"b355ab5a48ed9aed761024b6679da9c62c880617","unresolved":false,"context_lines":[{"line_number":8,"context_line":"plugin\u003dkarbor-server-protection-plugin"},{"line_number":9,"context_line":"bank\u003dkarbor-fs-bank-plugin"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"enabled\u003dFalse"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"[file_system_bank_plugin]"},{"line_number":14,"context_line":"file_system_bank_path\u003d/opt/stack/karbor_fs_bank"}],"source_content_type":"text/plain","patch_set":2,"id":"1f1a1f67_2fc31d8b","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":13},"in_reply_to":"1f1a1f67_1cc1c2e5","updated":"2017-07-19 09:32:46.000000000","message":"Done","commit_id":"df133f860a955dcbae5a40aa2e76ae890223266a"}],"etc/providers.d/openstack-infra-volume-snapshot.conf":[{"author":{"_account_id":17151,"name":"chenying","email":"chenyingko@gmail.com","username":"chenying"},"change_message_id":"6ff3772b515827f0a520a5b31c850f6e9730a1c8","unresolved":false,"context_lines":[{"line_number":6,"context_line":"plugin\u003dkarbor-volume-snapshot-plugin"},{"line_number":7,"context_line":"bank\u003dkarbor-swift-bank-plugin"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"enabled\u003dFalse"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"[swift_client]"},{"line_number":12,"context_line":"swift_auth_url\u003dhttp://127.0.0.1/identity"}],"source_content_type":"text/plain","patch_set":2,"id":"1f1a1f67_bcb9ae79","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":13},"updated":"2017-07-19 06:35:26.000000000","message":"The enabled attribute of this provider should be True. There are some fullstack tests using this provider.","commit_id":"df133f860a955dcbae5a40aa2e76ae890223266a"},{"author":{"_account_id":21224,"name":"jiaopengju","email":"jiaopengju_yewu@cmss.chinamobile.com","username":"jiaopengju"},"change_message_id":"b355ab5a48ed9aed761024b6679da9c62c880617","unresolved":false,"context_lines":[{"line_number":6,"context_line":"plugin\u003dkarbor-volume-snapshot-plugin"},{"line_number":7,"context_line":"bank\u003dkarbor-swift-bank-plugin"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"enabled\u003dFalse"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"[swift_client]"},{"line_number":12,"context_line":"swift_auth_url\u003dhttp://127.0.0.1/identity"}],"source_content_type":"text/plain","patch_set":2,"id":"1f1a1f67_0fbe21fe","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":13},"in_reply_to":"1f1a1f67_bcb9ae79","updated":"2017-07-19 09:32:46.000000000","message":"Done","commit_id":"df133f860a955dcbae5a40aa2e76ae890223266a"}],"karbor/services/protection/protectable_registry.py":[{"author":{"_account_id":17151,"name":"chenying","email":"chenyingko@gmail.com","username":"chenying"},"change_message_id":"6ff3772b515827f0a520a5b31c850f6e9730a1c8","unresolved":false,"context_lines":[{"line_number":39,"context_line":"            invoke_on_load\u003dTrue,"},{"line_number":40,"context_line":"            on_load_failure_callback\u003d_record_extension_exception)"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"        for e in mgr:"},{"line_number":43,"context_line":"            self.register_plugin(e.obj)"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    def register_plugin(self, plugin):"},{"line_number":46,"context_line":"        self._plugin_map[plugin.get_resource_type()] \u003d plugin"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f1a1f67_dfa33cff","line":43,"range":{"start_line":42,"start_character":0,"end_line":43,"end_character":39},"updated":"2017-07-19 06:35:26.000000000","message":"Does it ignore the failure protectables plugins?","commit_id":"df133f860a955dcbae5a40aa2e76ae890223266a"},{"author":{"_account_id":21224,"name":"jiaopengju","email":"jiaopengju_yewu@cmss.chinamobile.com","username":"jiaopengju"},"change_message_id":"b355ab5a48ed9aed761024b6679da9c62c880617","unresolved":false,"context_lines":[{"line_number":39,"context_line":"            invoke_on_load\u003dTrue,"},{"line_number":40,"context_line":"            on_load_failure_callback\u003d_record_extension_exception)"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"        for e in mgr:"},{"line_number":43,"context_line":"            self.register_plugin(e.obj)"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    def register_plugin(self, plugin):"},{"line_number":46,"context_line":"        self._plugin_map[plugin.get_resource_type()] \u003d plugin"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f1a1f67_df821c00","line":43,"range":{"start_line":42,"start_character":0,"end_line":43,"end_character":39},"in_reply_to":"1f1a1f67_dfa33cff","updated":"2017-07-19 09:32:46.000000000","message":"In my test, it will only throw exception when fetching dependent resources. So it is not related to the issue.","commit_id":"df133f860a955dcbae5a40aa2e76ae890223266a"},{"author":{"_account_id":17151,"name":"chenying","email":"chenyingko@gmail.com","username":"chenying"},"change_message_id":"6ff3772b515827f0a520a5b31c850f6e9730a1c8","unresolved":false,"context_lines":[{"line_number":101,"context_line":"                    protectable_resources \u003d \\"},{"line_number":102,"context_line":"                        protectable.get_dependent_resources("},{"line_number":103,"context_line":"                            context, resource)"},{"line_number":104,"context_line":"                except ListProtectableResourceFailed as e:"},{"line_number":105,"context_line":"                    LOG.error(\"List resources failed, so skip it. \""},{"line_number":106,"context_line":"                              \"Error: {0}\".format(e))"},{"line_number":107,"context_line":"                    protectable_resources \u003d []"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f1a1f67_9fb1444a","line":104,"range":{"start_line":104,"start_character":0,"end_line":104,"end_character":58},"updated":"2017-07-19 06:35:26.000000000","message":"Why not add a ListProtectableResourceFailed exception here? Is there failure protectables plugin in the self._plugin_map?","commit_id":"df133f860a955dcbae5a40aa2e76ae890223266a"},{"author":{"_account_id":21224,"name":"jiaopengju","email":"jiaopengju_yewu@cmss.chinamobile.com","username":"jiaopengju"},"change_message_id":"b355ab5a48ed9aed761024b6679da9c62c880617","unresolved":false,"context_lines":[{"line_number":101,"context_line":"                    protectable_resources \u003d \\"},{"line_number":102,"context_line":"                        protectable.get_dependent_resources("},{"line_number":103,"context_line":"                            context, resource)"},{"line_number":104,"context_line":"                except ListProtectableResourceFailed as e:"},{"line_number":105,"context_line":"                    LOG.error(\"List resources failed, so skip it. \""},{"line_number":106,"context_line":"                              \"Error: {0}\".format(e))"},{"line_number":107,"context_line":"                    protectable_resources \u003d []"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f1a1f67_8f0d91e9","line":104,"range":{"start_line":104,"start_character":0,"end_line":104,"end_character":58},"in_reply_to":"1f1a1f67_9fb1444a","updated":"2017-07-19 09:32:46.000000000","message":"self._plugin_map only hold the protectables, do not consider if it is enabled.","commit_id":"df133f860a955dcbae5a40aa2e76ae890223266a"}]}