)]}'
{"karbor/services/protection/protection_plugins/volume/volume_snapshot_plugin.py":[{"author":{"_account_id":21224,"name":"jiaopengju","email":"jiaopengju_yewu@cmss.chinamobile.com","username":"jiaopengju"},"change_message_id":"cf5bd39138b2559b85cb24e0c5b64a14576a64a9","unresolved":false,"context_lines":[{"line_number":193,"context_line":"                failure_statuses\u003dVOLUME_FAILURE_STATUSES,"},{"line_number":194,"context_line":"                ignore_statuses\u003dVOLUME_IGNORE_STATUSES,"},{"line_number":195,"context_line":"            )"},{"line_number":196,"context_line":"            volume \u003d cinder_client.volumes.get(volume.id)"},{"line_number":197,"context_line":"            if is_success is not True:"},{"line_number":198,"context_line":"                LOG.error(\u0027The status of volume is invalid. status:%s\u0027,"},{"line_number":199,"context_line":"                          volume.status)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f436f4f_f03d47c4","line":196,"range":{"start_line":196,"start_character":12,"end_line":196,"end_character":57},"updated":"2017-08-14 06:01:51.000000000","message":"IMO, move this to get_volume_status may be better.\nget_volume_status has got the volume status, but do not update the variable info outside the function. so maybe we do not need to get volume info once more.","commit_id":"4df11604cba48fb75c376369aecfaefc58fdb82b"},{"author":{"_account_id":20883,"name":"Yuval Brik","email":"yuval@brik.org.il","username":"yuvalbr"},"change_message_id":"915fd1811a52f860b005d28fd0db7b371445eb7b","unresolved":false,"context_lines":[{"line_number":193,"context_line":"                failure_statuses\u003dVOLUME_FAILURE_STATUSES,"},{"line_number":194,"context_line":"                ignore_statuses\u003dVOLUME_IGNORE_STATUSES,"},{"line_number":195,"context_line":"            )"},{"line_number":196,"context_line":"            volume \u003d cinder_client.volumes.get(volume.id)"},{"line_number":197,"context_line":"            if is_success is not True:"},{"line_number":198,"context_line":"                LOG.error(\u0027The status of volume is invalid. status:%s\u0027,"},{"line_number":199,"context_line":"                          volume.status)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f436f4f_90a6fb52","line":196,"range":{"start_line":196,"start_character":12,"end_line":196,"end_character":57},"in_reply_to":"9f436f4f_f03d47c4","updated":"2017-08-14 06:47:10.000000000","message":"I think one more call to cinder is ok. \u0027get_volume_status\u0027 is just returning a value, not updating a variable.","commit_id":"4df11604cba48fb75c376369aecfaefc58fdb82b"}]}