)]}'
{"karbor/services/protection/clients/freezer.py":[{"author":{"_account_id":17151,"name":"chenying","email":"chenyingko@gmail.com","username":"chenying"},"change_message_id":"0750907a40a76af9e6dc9cae0da403e4196f279c","unresolved":false,"context_lines":[{"line_number":22,"context_line":"SERVICE \u003d \"freezer\""},{"line_number":23,"context_line":"freezer_client_opts \u003d ["},{"line_number":24,"context_line":"    cfg.StrOpt(SERVICE + \u0027_endpoint\u0027,"},{"line_number":25,"context_line":"               help\u003d\u0027URL of the cinder endpoint.\u0027),"},{"line_number":26,"context_line":"    cfg.StrOpt(SERVICE + \u0027_catalog_info\u0027,"},{"line_number":27,"context_line":"               default\u003d\u0027backup:freezer:publicURL\u0027,"},{"line_number":28,"context_line":"               help\u003d\u0027Info to match when looking for freezer in the service \u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"7f287b81_04bf58aa","line":25,"range":{"start_line":25,"start_character":32,"end_line":25,"end_character":38},"updated":"2017-09-08 08:47:29.000000000","message":"S/cinder/freezer","commit_id":"bd94903211870b6b5b673090ea77667c7edb964b"},{"author":{"_account_id":21224,"name":"jiaopengju","email":"jiaopengju_yewu@cmss.chinamobile.com","username":"jiaopengju"},"change_message_id":"1ab824c817f3381fda8c8dcd7e9eb025754d31e9","unresolved":false,"context_lines":[{"line_number":22,"context_line":"SERVICE \u003d \"freezer\""},{"line_number":23,"context_line":"freezer_client_opts \u003d ["},{"line_number":24,"context_line":"    cfg.StrOpt(SERVICE + \u0027_endpoint\u0027,"},{"line_number":25,"context_line":"               help\u003d\u0027URL of the cinder endpoint.\u0027),"},{"line_number":26,"context_line":"    cfg.StrOpt(SERVICE + \u0027_catalog_info\u0027,"},{"line_number":27,"context_line":"               default\u003d\u0027backup:freezer:publicURL\u0027,"},{"line_number":28,"context_line":"               help\u003d\u0027Info to match when looking for freezer in the service \u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"7f287b81_45ac3aec","line":25,"range":{"start_line":25,"start_character":32,"end_line":25,"end_character":38},"in_reply_to":"7f287b81_04bf58aa","updated":"2017-09-08 08:54:03.000000000","message":"done","commit_id":"bd94903211870b6b5b673090ea77667c7edb964b"}],"karbor/services/protection/protection_plugins/volume/volume_freezer_plugin.py":[{"author":{"_account_id":17151,"name":"chenying","email":"chenyingko@gmail.com","username":"chenying"},"change_message_id":"0750907a40a76af9e6dc9cae0da403e4196f279c","unresolved":false,"context_lines":[{"line_number":96,"context_line":"            \u0027container\u0027: self.storage_path"},{"line_number":97,"context_line":"        }"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"        if self.storage_type \u003d\u003d \u0027s3\u0027:"},{"line_number":100,"context_line":"            storage[\u0027endpoint\u0027] \u003d self.config.get(\u0027endpoint\u0027, None)"},{"line_number":101,"context_line":"            storage[\u0027access_key\u0027] \u003d self.config.get(\u0027access_key\u0027, None)"},{"line_number":102,"context_line":"            storage[\u0027secret_key\u0027] \u003d self.config.get(\u0027secret_key\u0027, None)"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"        if self.storage_type \u003d\u003d \u0027ssh\u0027:"},{"line_number":105,"context_line":"            storage[\u0027ssh_key\u0027] \u003d self.config.get(\u0027ssh_key\u0027, None)"},{"line_number":106,"context_line":"            storage[\u0027ssh_port\u0027] \u003d self.config.get(\u0027ssh_port\u0027, None)"},{"line_number":107,"context_line":"            storage[\u0027ssh_username\u0027] \u003d self.config.get(\u0027ssh_username\u0027, None)"},{"line_number":108,"context_line":"            storage[\u0027ssh_host\u0027] \u003d self.config.get(\u0027ssh_host\u0027, None)"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"        return storage"},{"line_number":111,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"7f287b81_c40b908b","line":108,"range":{"start_line":99,"start_character":0,"end_line":108,"end_character":67},"updated":"2017-09-08 08:47:29.000000000","message":"Can you consider adding the storage type swift?","commit_id":"bd94903211870b6b5b673090ea77667c7edb964b"},{"author":{"_account_id":21224,"name":"jiaopengju","email":"jiaopengju_yewu@cmss.chinamobile.com","username":"jiaopengju"},"change_message_id":"e2cda193ca1caaa2d7b0e753fc7892bdd2d914e6","unresolved":false,"context_lines":[{"line_number":96,"context_line":"            \u0027container\u0027: self.storage_path"},{"line_number":97,"context_line":"        }"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"        if self.storage_type \u003d\u003d \u0027s3\u0027:"},{"line_number":100,"context_line":"            storage[\u0027endpoint\u0027] \u003d self.config.get(\u0027endpoint\u0027, None)"},{"line_number":101,"context_line":"            storage[\u0027access_key\u0027] \u003d self.config.get(\u0027access_key\u0027, None)"},{"line_number":102,"context_line":"            storage[\u0027secret_key\u0027] \u003d self.config.get(\u0027secret_key\u0027, None)"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"        if self.storage_type \u003d\u003d \u0027ssh\u0027:"},{"line_number":105,"context_line":"            storage[\u0027ssh_key\u0027] \u003d self.config.get(\u0027ssh_key\u0027, None)"},{"line_number":106,"context_line":"            storage[\u0027ssh_port\u0027] \u003d self.config.get(\u0027ssh_port\u0027, None)"},{"line_number":107,"context_line":"            storage[\u0027ssh_username\u0027] \u003d self.config.get(\u0027ssh_username\u0027, None)"},{"line_number":108,"context_line":"            storage[\u0027ssh_host\u0027] \u003d self.config.get(\u0027ssh_host\u0027, None)"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"        return storage"},{"line_number":111,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"7f287b81_058bd267","line":108,"range":{"start_line":99,"start_character":0,"end_line":108,"end_character":67},"in_reply_to":"7f287b81_656a96b3","updated":"2017-09-08 08:56:10.000000000","message":"freezer only support using swift storage this way. Can not use swift with specify endpoint url, name and password.","commit_id":"bd94903211870b6b5b673090ea77667c7edb964b"},{"author":{"_account_id":21224,"name":"jiaopengju","email":"jiaopengju_yewu@cmss.chinamobile.com","username":"jiaopengju"},"change_message_id":"1ab824c817f3381fda8c8dcd7e9eb025754d31e9","unresolved":false,"context_lines":[{"line_number":96,"context_line":"            \u0027container\u0027: self.storage_path"},{"line_number":97,"context_line":"        }"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"        if self.storage_type \u003d\u003d \u0027s3\u0027:"},{"line_number":100,"context_line":"            storage[\u0027endpoint\u0027] \u003d self.config.get(\u0027endpoint\u0027, None)"},{"line_number":101,"context_line":"            storage[\u0027access_key\u0027] \u003d self.config.get(\u0027access_key\u0027, None)"},{"line_number":102,"context_line":"            storage[\u0027secret_key\u0027] \u003d self.config.get(\u0027secret_key\u0027, None)"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"        if self.storage_type \u003d\u003d \u0027ssh\u0027:"},{"line_number":105,"context_line":"            storage[\u0027ssh_key\u0027] \u003d self.config.get(\u0027ssh_key\u0027, None)"},{"line_number":106,"context_line":"            storage[\u0027ssh_port\u0027] \u003d self.config.get(\u0027ssh_port\u0027, None)"},{"line_number":107,"context_line":"            storage[\u0027ssh_username\u0027] \u003d self.config.get(\u0027ssh_username\u0027, None)"},{"line_number":108,"context_line":"            storage[\u0027ssh_host\u0027] \u003d self.config.get(\u0027ssh_host\u0027, None)"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"        return storage"},{"line_number":111,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"7f287b81_656a96b3","line":108,"range":{"start_line":99,"start_character":0,"end_line":108,"end_character":67},"in_reply_to":"7f287b81_c40b908b","updated":"2017-09-08 08:54:03.000000000","message":"the default storage type is swift. I have added it in line 95. With swift type, no other parameters need to be added except container name.","commit_id":"bd94903211870b6b5b673090ea77667c7edb964b"},{"author":{"_account_id":17151,"name":"chenying","email":"chenyingko@gmail.com","username":"chenying"},"change_message_id":"0750907a40a76af9e6dc9cae0da403e4196f279c","unresolved":false,"context_lines":[{"line_number":178,"context_line":""},{"line_number":179,"context_line":"    @staticmethod"},{"line_number":180,"context_line":"    def _build_action(backup_name, storage, resource, action_type):"},{"line_number":181,"context_line":"        backup_name \u003d backup_name.replace(\u0027 \u0027, \u0027_\u0027) \\"},{"line_number":182,"context_line":"            if backup_name else resource.id"},{"line_number":183,"context_line":"        action \u003d {"},{"line_number":184,"context_line":"            \u0027backup_name\u0027: backup_name,"},{"line_number":185,"context_line":"            \u0027action\u0027: action_type,"}],"source_content_type":"text/x-python","patch_set":5,"id":"7f287b81_aa53ad15","line":182,"range":{"start_line":181,"start_character":0,"end_line":182,"end_character":43},"updated":"2017-09-08 08:47:29.000000000","message":"backup_name \u003d parameters.get(\u0027backup_name\u0027, \u0027backup{0}\u0027.format(resource_id))\nThe \u0027backup_name\u0027 here may not be None. Only using resource.id as the backup name seems not good.","commit_id":"bd94903211870b6b5b673090ea77667c7edb964b"},{"author":{"_account_id":21224,"name":"jiaopengju","email":"jiaopengju_yewu@cmss.chinamobile.com","username":"jiaopengju"},"change_message_id":"896f611f7b27cf64728b6f4f4ba72058b2d7b633","unresolved":false,"context_lines":[{"line_number":178,"context_line":""},{"line_number":179,"context_line":"    @staticmethod"},{"line_number":180,"context_line":"    def _build_action(backup_name, storage, resource, action_type):"},{"line_number":181,"context_line":"        backup_name \u003d backup_name.replace(\u0027 \u0027, \u0027_\u0027) \\"},{"line_number":182,"context_line":"            if backup_name else resource.id"},{"line_number":183,"context_line":"        action \u003d {"},{"line_number":184,"context_line":"            \u0027backup_name\u0027: backup_name,"},{"line_number":185,"context_line":"            \u0027action\u0027: action_type,"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f2577a7_b0fe2003","line":182,"range":{"start_line":181,"start_character":0,"end_line":182,"end_character":43},"in_reply_to":"7f287b81_aa53ad15","updated":"2017-09-10 09:20:49.000000000","message":"\u0027backup\u0027 + resource.id as backup name.","commit_id":"bd94903211870b6b5b673090ea77667c7edb964b"},{"author":{"_account_id":21224,"name":"jiaopengju","email":"jiaopengju_yewu@cmss.chinamobile.com","username":"jiaopengju"},"change_message_id":"1ab824c817f3381fda8c8dcd7e9eb025754d31e9","unresolved":false,"context_lines":[{"line_number":178,"context_line":""},{"line_number":179,"context_line":"    @staticmethod"},{"line_number":180,"context_line":"    def _build_action(backup_name, storage, resource, action_type):"},{"line_number":181,"context_line":"        backup_name \u003d backup_name.replace(\u0027 \u0027, \u0027_\u0027) \\"},{"line_number":182,"context_line":"            if backup_name else resource.id"},{"line_number":183,"context_line":"        action \u003d {"},{"line_number":184,"context_line":"            \u0027backup_name\u0027: backup_name,"},{"line_number":185,"context_line":"            \u0027action\u0027: action_type,"}],"source_content_type":"text/x-python","patch_set":5,"id":"7f287b81_a5a19ef9","line":182,"range":{"start_line":181,"start_character":0,"end_line":182,"end_character":43},"in_reply_to":"7f287b81_aa53ad15","updated":"2017-09-08 08:54:03.000000000","message":"Done","commit_id":"bd94903211870b6b5b673090ea77667c7edb964b"}]}