)]}'
{"id":"openstack%2Fkarbor~659259","triplet_id":"openstack%2Fkarbor~master~I9755949343b73702fd00f5407b5d01b82c4a0963","project":"openstack/karbor","branch":"master","topic":"bug/1829163","hashtags":[],"change_id":"I9755949343b73702fd00f5407b5d01b82c4a0963","subject":"Fix creating plan with invalid provider and no parameters","status":"MERGED","created":"2019-05-15 10:00:23.000000000","updated":"2019-06-05 01:36:31.000000000","submitted":"2019-06-05 01:36:31.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"659259-1559698591446-edb3e276","meta_rev_id":"6229270c1e419f24b7f2c401e5a5863f9fb8754a","_number":659259,"virtual_id_number":659259,"owner":{"_account_id":21224,"name":"jiaopengju","email":"jiaopengju_yewu@cmss.chinamobile.com","username":"jiaopengju"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":21224,"name":"jiaopengju","email":"jiaopengju_yewu@cmss.chinamobile.com","username":"jiaopengju"},{"value":0,"_account_id":29272,"name":"liushuai","email":"liushuai@cmss.chinamobile.com","username":"liushuai"},{"value":2,"date":"2019-06-05 01:36:31.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":21224,"name":"jiaopengju","email":"jiaopengju_yewu@cmss.chinamobile.com","username":"jiaopengju"},"all":[{"value":2,"date":"2019-06-04 06:55:42.000000000","_account_id":21224,"name":"jiaopengju","email":"jiaopengju_yewu@cmss.chinamobile.com","username":"jiaopengju"},{"value":2,"date":"2019-06-05 01:13:02.000000000","_account_id":29272,"name":"liushuai","email":"liushuai@cmss.chinamobile.com","username":"liushuai"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":29272,"name":"liushuai","email":"liushuai@cmss.chinamobile.com","username":"liushuai"},"all":[{"value":0,"_account_id":21224,"name":"jiaopengju","email":"jiaopengju_yewu@cmss.chinamobile.com","username":"jiaopengju"},{"value":1,"date":"2019-06-05 01:13:02.000000000","_account_id":29272,"name":"liushuai","email":"liushuai@cmss.chinamobile.com","username":"liushuai"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":21224,"name":"jiaopengju","email":"jiaopengju_yewu@cmss.chinamobile.com","username":"jiaopengju"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":29272,"name":"liushuai","email":"liushuai@cmss.chinamobile.com","username":"liushuai"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-06-05 01:13:02.000000000","updated_by":{"_account_id":29272,"name":"liushuai","email":"liushuai@cmss.chinamobile.com","username":"liushuai"},"reviewer":{"_account_id":29272,"name":"liushuai","email":"liushuai@cmss.chinamobile.com","username":"liushuai"},"state":"REVIEWER"},{"updated":"2019-06-05 01:36:31.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"1d0e0ae19c4d76cc979c062d713d5b28557f472d","author":{"_account_id":21224,"name":"jiaopengju","email":"jiaopengju_yewu@cmss.chinamobile.com","username":"jiaopengju"},"date":"2019-05-15 10:00:23.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"9f3fbe04b95fdf38c61f3be1b33f916d36939989","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-15 10:58:09.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-tox-cover http://logs.openstack.org/59/659259/1/check/openstack-tox-cover/bc08eb4/ : FAILURE in 7m 26s\n- openstack-tox-lower-constraints http://logs.openstack.org/59/659259/1/check/openstack-tox-lower-constraints/1f4d0f5/ : FAILURE in 5m 21s\n- openstack-tox-pep8 http://logs.openstack.org/59/659259/1/check/openstack-tox-pep8/915ad66/ : SUCCESS in 5m 08s\n- openstack-tox-py27 http://logs.openstack.org/59/659259/1/check/openstack-tox-py27/cd0036d/ : FAILURE in 7m 17s\n- openstack-tox-py35 http://logs.openstack.org/59/659259/1/check/openstack-tox-py35/ff020d1/ : FAILURE in 5m 40s\n- openstack-tox-py36 http://logs.openstack.org/59/659259/1/check/openstack-tox-py36/b5714f7/ : FAILURE in 5m 32s\n- openstack-tox-docs http://logs.openstack.org/59/659259/1/check/openstack-tox-docs/60d362c/html/ : SUCCESS in 6m 07s\n- karbor-dsvm-fullstack http://logs.openstack.org/59/659259/1/check/karbor-dsvm-fullstack/938834f/ : SUCCESS in 55m 54s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"916cb02050ddd17372478d23535066037ebbc0b3","author":{"_account_id":21224,"name":"jiaopengju","email":"jiaopengju_yewu@cmss.chinamobile.com","username":"jiaopengju"},"date":"2019-05-15 11:48:05.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"0a653a421fc9b5d4da1503b93b8af1de9a054726","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-15 12:54:40.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover http://logs.openstack.org/59/659259/2/check/openstack-tox-cover/b6f8c35/cover/ : SUCCESS in 5m 24s\n- openstack-tox-lower-constraints http://logs.openstack.org/59/659259/2/check/openstack-tox-lower-constraints/be03dea/ : SUCCESS in 5m 25s\n- openstack-tox-pep8 http://logs.openstack.org/59/659259/2/check/openstack-tox-pep8/f984750/ : SUCCESS in 4m 45s\n- openstack-tox-py27 http://logs.openstack.org/59/659259/2/check/openstack-tox-py27/da0bf00/ : SUCCESS in 5m 08s\n- openstack-tox-py35 http://logs.openstack.org/59/659259/2/check/openstack-tox-py35/e225e82/ : SUCCESS in 5m 27s\n- openstack-tox-py36 http://logs.openstack.org/59/659259/2/check/openstack-tox-py36/beafe42/ : SUCCESS in 5m 07s\n- openstack-tox-docs http://logs.openstack.org/59/659259/2/check/openstack-tox-docs/8b692c3/html/ : SUCCESS in 5m 13s\n- karbor-dsvm-fullstack http://logs.openstack.org/59/659259/2/check/karbor-dsvm-fullstack/e86238e/ : SUCCESS in 1h 00m 22s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"c427d5566e17a6b7df2c782727a7302996358d74","author":{"_account_id":21224,"name":"jiaopengju","email":"jiaopengju_yewu@cmss.chinamobile.com","username":"jiaopengju"},"date":"2019-06-04 06:55:42.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"2475c6cc9f2d2146602bd6c12788f0eac8aeb37a","author":{"_account_id":29272,"name":"liushuai","email":"liushuai@cmss.chinamobile.com","username":"liushuai"},"date":"2019-06-05 01:13:02.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"bf67e47353a0e88841479e57313496ad08108c28","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-05 01:13:14.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"4acad82b267ff05525a1394ab425a0bbc878d0ea","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-05 01:36:31.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2},{"id":"2e315699a0730325b1d31fd414e61c8f4dfccf64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-05 01:36:31.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-lower-constraints http://logs.openstack.org/59/659259/2/gate/openstack-tox-lower-constraints/ceea343/ : SUCCESS in 5m 48s\n- openstack-tox-pep8 http://logs.openstack.org/59/659259/2/gate/openstack-tox-pep8/71816ac/ : SUCCESS in 5m 09s\n- openstack-tox-py27 http://logs.openstack.org/59/659259/2/gate/openstack-tox-py27/f8f4c3e/ : SUCCESS in 5m 18s\n- openstack-tox-py35 http://logs.openstack.org/59/659259/2/gate/openstack-tox-py35/d9b9e81/ : SUCCESS in 5m 23s\n- openstack-tox-py36 http://logs.openstack.org/59/659259/2/gate/openstack-tox-py36/357833d/ : SUCCESS in 5m 20s\n- openstack-tox-docs http://logs.openstack.org/59/659259/2/gate/openstack-tox-docs/67dd7ef/html/ : SUCCESS in 6m 36s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"9206e58333ce3c0c69b63dafbe8ed10e90cdea5d","revisions":{"21f1d0b21aeb9c5c83b555e4a754917b5f1fa883":{"kind":"REWORK","_number":1,"created":"2019-05-15 10:00:23.000000000","uploader":{"_account_id":21224,"name":"jiaopengju","email":"jiaopengju_yewu@cmss.chinamobile.com","username":"jiaopengju"},"ref":"refs/changes/59/659259/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/karbor","ref":"refs/changes/59/659259/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/karbor refs/changes/59/659259/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/karbor refs/changes/59/659259/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/karbor refs/changes/59/659259/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/karbor refs/changes/59/659259/1"}}},"commit":{"parents":[{"commit":"39bdc2a89166d7b4e8b5cff2e154cc358491bcfd","subject":"Merge \"Add unit test for plan api\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/karbor/commit/39bdc2a89166d7b4e8b5cff2e154cc358491bcfd"}]}],"author":{"name":"jiaopengju","email":"jiaopengju@cmss.chinamobile.com","date":"2019-05-15 09:31:30.000000000","tz":480},"committer":{"name":"jiaopengju","email":"jiaopengju@cmss.chinamobile.com","date":"2019-05-15 09:31:30.000000000","tz":480},"subject":"Fix creating plan with invalid provider and no parameters","message":"Fix creating plan with invalid provider and no parameters\n\nWhen we create a plan with using invalid provider, it return\nsuccess if we do not specify parameters. This patch will fix\nit.\nCloses-Bug: #1829163\n\nChange-Id: I9755949343b73702fd00f5407b5d01b82c4a0963\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/karbor/commit/21f1d0b21aeb9c5c83b555e4a754917b5f1fa883"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/karbor/commit/21f1d0b21aeb9c5c83b555e4a754917b5f1fa883"}]},"branch":"refs/heads/master"},"9206e58333ce3c0c69b63dafbe8ed10e90cdea5d":{"kind":"REWORK","_number":2,"created":"2019-05-15 11:48:05.000000000","uploader":{"_account_id":21224,"name":"jiaopengju","email":"jiaopengju_yewu@cmss.chinamobile.com","username":"jiaopengju"},"ref":"refs/changes/59/659259/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/karbor","ref":"refs/changes/59/659259/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/karbor refs/changes/59/659259/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/karbor refs/changes/59/659259/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/karbor refs/changes/59/659259/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/karbor refs/changes/59/659259/2"}}},"commit":{"parents":[{"commit":"39bdc2a89166d7b4e8b5cff2e154cc358491bcfd","subject":"Merge \"Add unit test for plan api\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/karbor/commit/39bdc2a89166d7b4e8b5cff2e154cc358491bcfd"}]}],"author":{"name":"jiaopengju","email":"jiaopengju@cmss.chinamobile.com","date":"2019-05-15 09:31:30.000000000","tz":480},"committer":{"name":"jiaopengju","email":"jiaopengju@cmss.chinamobile.com","date":"2019-05-15 11:47:54.000000000","tz":480},"subject":"Fix creating plan with invalid provider and no parameters","message":"Fix creating plan with invalid provider and no parameters\n\nWhen we create a plan with using invalid provider, it return\nsuccess if we do not specify parameters. This patch will fix\nit.\nCloses-Bug: #1829163\n\nChange-Id: I9755949343b73702fd00f5407b5d01b82c4a0963\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/karbor/commit/9206e58333ce3c0c69b63dafbe8ed10e90cdea5d"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/karbor/commit/9206e58333ce3c0c69b63dafbe8ed10e90cdea5d"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
