)]}'
{"id":"openstack%2Fkarbor~668627","triplet_id":"openstack%2Fkarbor~master~I51470731ed78ddb1e197222187c432372e2f21ee","project":"openstack/karbor","branch":"master","topic":"668627","hashtags":[],"change_id":"I51470731ed78ddb1e197222187c432372e2f21ee","subject":"Remove redundant try/except statements in quotas.py","status":"MERGED","created":"2019-07-02 07:51:08.000000000","updated":"2019-07-15 06:04:02.000000000","submitted":"2019-07-15 06:04:02.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"668627-1563170642554-fd40a304","meta_rev_id":"0b2072830f4b5e386117f5674f2ce800aeb22792","_number":668627,"virtual_id_number":668627,"owner":{"_account_id":29579,"name":"helei","email":"604103249@qq.com","username":"helei"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":21224,"name":"jiaopengju","email":"jiaopengju_yewu@cmss.chinamobile.com","username":"jiaopengju"},{"value":0,"_account_id":29272,"name":"liushuai","email":"liushuai@cmss.chinamobile.com","username":"liushuai"},{"value":0,"_account_id":24328,"name":"jiaopengju","username":"JiaoPengju","inactive":true},{"value":2,"date":"2019-07-15 06:04:02.000000000","post_submit":true,"permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":21224,"name":"jiaopengju","email":"jiaopengju_yewu@cmss.chinamobile.com","username":"jiaopengju"},"all":[{"value":2,"date":"2019-07-15 03:29:37.000000000","_account_id":21224,"name":"jiaopengju","email":"jiaopengju_yewu@cmss.chinamobile.com","username":"jiaopengju"},{"value":2,"date":"2019-07-15 05:53:33.000000000","_account_id":29272,"name":"liushuai","email":"liushuai@cmss.chinamobile.com","username":"liushuai"},{"value":0,"_account_id":24328,"name":"jiaopengju","username":"JiaoPengju","inactive":true},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":29272,"name":"liushuai","email":"liushuai@cmss.chinamobile.com","username":"liushuai"},"all":[{"value":0,"_account_id":21224,"name":"jiaopengju","email":"jiaopengju_yewu@cmss.chinamobile.com","username":"jiaopengju"},{"value":1,"date":"2019-07-15 05:53:16.000000000","_account_id":29272,"name":"liushuai","email":"liushuai@cmss.chinamobile.com","username":"liushuai"},{"value":0,"_account_id":24328,"name":"jiaopengju","username":"JiaoPengju","inactive":true},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":21224,"name":"jiaopengju","email":"jiaopengju_yewu@cmss.chinamobile.com","username":"jiaopengju"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":24328,"name":"jiaopengju","username":"JiaoPengju","inactive":true},{"_account_id":29272,"name":"liushuai","email":"liushuai@cmss.chinamobile.com","username":"liushuai"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-07-03 02:14:14.000000000","updated_by":{"_account_id":24328,"name":"jiaopengju","username":"JiaoPengju","inactive":true},"reviewer":{"_account_id":24328,"name":"jiaopengju","username":"JiaoPengju","inactive":true},"state":"REVIEWER"},{"updated":"2019-07-15 03:29:37.000000000","updated_by":{"_account_id":21224,"name":"jiaopengju","email":"jiaopengju_yewu@cmss.chinamobile.com","username":"jiaopengju"},"reviewer":{"_account_id":21224,"name":"jiaopengju","email":"jiaopengju_yewu@cmss.chinamobile.com","username":"jiaopengju"},"state":"REVIEWER"},{"updated":"2019-07-15 05:53:16.000000000","updated_by":{"_account_id":29272,"name":"liushuai","email":"liushuai@cmss.chinamobile.com","username":"liushuai"},"reviewer":{"_account_id":29272,"name":"liushuai","email":"liushuai@cmss.chinamobile.com","username":"liushuai"},"state":"REVIEWER"},{"updated":"2019-07-15 06:04:02.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"c523d7c9b503aaf8938c686883e5873275473e05","author":{"_account_id":29579,"name":"helei","email":"604103249@qq.com","username":"helei"},"date":"2019-07-02 07:51:08.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"59f1dd86539bdd1fc19b61af83d223affb9712e9","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-02 09:03:17.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover http://logs.openstack.org/27/668627/1/check/openstack-tox-cover/26df7d4/cover/ : SUCCESS in 4m 38s\n- openstack-tox-lower-constraints http://logs.openstack.org/27/668627/1/check/openstack-tox-lower-constraints/46cea4c/ : SUCCESS in 3m 58s\n- openstack-tox-pep8 http://logs.openstack.org/27/668627/1/check/openstack-tox-pep8/b3f61cc/ : SUCCESS in 3m 24s\n- openstack-tox-py27 http://logs.openstack.org/27/668627/1/check/openstack-tox-py27/2ec64b2/ : SUCCESS in 4m 11s\n- openstack-tox-py35 http://logs.openstack.org/27/668627/1/check/openstack-tox-py35/054adab/ : SUCCESS in 10m 25s\n- openstack-tox-py36 http://logs.openstack.org/27/668627/1/check/openstack-tox-py36/3108bfe/ : SUCCESS in 7m 08s\n- openstack-tox-docs http://logs.openstack.org/27/668627/1/check/openstack-tox-docs/cb329e5/html/ : SUCCESS in 4m 58s\n- karbor-dsvm-fullstack http://logs.openstack.org/27/668627/1/check/karbor-dsvm-fullstack/48d4531/ : SUCCESS in 1h 09m 45s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"6025d9cbefba0b67e40e77d08e29dfaf1e868283","author":{"_account_id":29579,"name":"helei","email":"604103249@qq.com","username":"helei"},"date":"2019-07-02 09:19:21.000000000","message":"Uploaded patch set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"58b1bb497c18fd1a53df2449be6d0e188bed67b4","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-02 10:34:20.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover http://logs.openstack.org/27/668627/2/check/openstack-tox-cover/c6144ee/cover/ : SUCCESS in 4m 17s\n- openstack-tox-lower-constraints http://logs.openstack.org/27/668627/2/check/openstack-tox-lower-constraints/9fd1949/ : SUCCESS in 4m 21s\n- openstack-tox-pep8 http://logs.openstack.org/27/668627/2/check/openstack-tox-pep8/5e4edf2/ : SUCCESS in 3m 37s\n- openstack-tox-py27 http://logs.openstack.org/27/668627/2/check/openstack-tox-py27/0bfa8a6/ : SUCCESS in 3m 40s\n- openstack-tox-py35 http://logs.openstack.org/27/668627/2/check/openstack-tox-py35/dbfdd68/ : SUCCESS in 4m 12s\n- openstack-tox-py36 http://logs.openstack.org/27/668627/2/check/openstack-tox-py36/3e38d8a/ : SUCCESS in 4m 20s\n- openstack-tox-docs http://logs.openstack.org/27/668627/2/check/openstack-tox-docs/ec74563/html/ : SUCCESS in 4m 07s\n- karbor-dsvm-fullstack http://logs.openstack.org/27/668627/2/check/karbor-dsvm-fullstack/1154a8c/ : SUCCESS in 57m 37s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"a1b56360978c59fe6601653d3d8adc689647a582","author":{"_account_id":21224,"name":"jiaopengju","email":"jiaopengju_yewu@cmss.chinamobile.com","username":"jiaopengju"},"date":"2019-07-03 09:19:49.000000000","message":"Patch Set 2:\n\ncode is ok.\nplease report this bug on the storyboard, and add unit tests to cover this case.","accounts_in_message":[],"_revision_number":2},{"id":"ad728141136e4c77076f98d1fe59a60c88d89bf2","author":{"_account_id":21224,"name":"jiaopengju","email":"jiaopengju_yewu@cmss.chinamobile.com","username":"jiaopengju"},"date":"2019-07-03 09:20:35.000000000","message":"Patch Set 2: Code-Review-1","accounts_in_message":[],"_revision_number":2},{"id":"20bb7f2f997b91db33ecde318a24571272a5ff64","author":{"_account_id":29579,"name":"helei","email":"604103249@qq.com","username":"helei"},"date":"2019-07-03 10:20:53.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"6dba2bd93c70584a89d971b1d8ce8958c8c00664","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-03 11:25:00.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover http://logs.openstack.org/27/668627/3/check/openstack-tox-cover/2438f43/cover/ : SUCCESS in 6m 22s\n- openstack-tox-lower-constraints http://logs.openstack.org/27/668627/3/check/openstack-tox-lower-constraints/bc1e353/ : SUCCESS in 5m 45s\n- openstack-tox-pep8 http://logs.openstack.org/27/668627/3/check/openstack-tox-pep8/d996729/ : SUCCESS in 4m 01s\n- openstack-tox-py27 http://logs.openstack.org/27/668627/3/check/openstack-tox-py27/c76166f/ : SUCCESS in 4m 25s\n- openstack-tox-py35 http://logs.openstack.org/27/668627/3/check/openstack-tox-py35/bfcdd70/ : SUCCESS in 4m 22s\n- openstack-tox-py36 http://logs.openstack.org/27/668627/3/check/openstack-tox-py36/5ef62ec/ : SUCCESS in 5m 23s\n- openstack-tox-docs http://logs.openstack.org/27/668627/3/check/openstack-tox-docs/e1bc215/html/ : SUCCESS in 4m 02s\n- karbor-dsvm-fullstack http://logs.openstack.org/27/668627/3/check/karbor-dsvm-fullstack/34ca074/ : SUCCESS in 1h 00m 34s (non-voting)","accounts_in_message":[],"_revision_number":3},{"id":"203c50ae87f1ed24c00e1eb7c560d73fcf2d86b5","author":{"_account_id":21224,"name":"jiaopengju","email":"jiaopengju_yewu@cmss.chinamobile.com","username":"jiaopengju"},"date":"2019-07-15 03:29:37.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"f792d57bde7b9669e292715b4f84f468b39bad29","author":{"_account_id":29272,"name":"liushuai","email":"liushuai@cmss.chinamobile.com","username":"liushuai"},"date":"2019-07-15 05:53:16.000000000","message":"Patch Set 3: Workflow+1","accounts_in_message":[],"_revision_number":3},{"id":"7f7bdab6c8de19a9a5398b762d0aa4b64122e19a","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-15 05:53:28.000000000","message":"Patch Set 3: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":3},{"id":"7351e33e60ca2e8c85c0843c4ca3e289c6ced846","author":{"_account_id":29272,"name":"liushuai","email":"liushuai@cmss.chinamobile.com","username":"liushuai"},"date":"2019-07-15 05:53:33.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"2ecc370f1d15a641a13e205b0a9cf20ff397a9ef","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-15 06:04:02.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":3},{"id":"bb32d4921b2d18d86b0ecebd00ef058cc253a32c","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-15 06:04:02.000000000","message":"Patch Set 3: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-lower-constraints http://logs.openstack.org/27/668627/3/gate/openstack-tox-lower-constraints/3d6dfe7/ : SUCCESS in 4m 24s\n- openstack-tox-pep8 http://logs.openstack.org/27/668627/3/gate/openstack-tox-pep8/079604b/ : SUCCESS in 3m 26s\n- openstack-tox-py27 http://logs.openstack.org/27/668627/3/gate/openstack-tox-py27/133bb44/ : SUCCESS in 3m 37s\n- openstack-tox-py35 http://logs.openstack.org/27/668627/3/gate/openstack-tox-py35/a704c76/ : SUCCESS in 4m 17s\n- openstack-tox-py36 http://logs.openstack.org/27/668627/3/gate/openstack-tox-py36/46503a1/ : SUCCESS in 3m 30s\n- openstack-tox-docs http://logs.openstack.org/27/668627/3/gate/openstack-tox-docs/8cf8e6b/html/ : SUCCESS in 3m 59s","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"662766d64df4a31cf81024fd64044b6f0aae7ed4","revisions":{"a088342065964911b8c15bd87600af8c83520a37":{"kind":"REWORK","_number":1,"created":"2019-07-02 07:51:08.000000000","uploader":{"_account_id":29579,"name":"helei","email":"604103249@qq.com","username":"helei"},"ref":"refs/changes/27/668627/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/karbor","ref":"refs/changes/27/668627/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/karbor refs/changes/27/668627/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/karbor refs/changes/27/668627/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/karbor refs/changes/27/668627/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/karbor refs/changes/27/668627/1"}}},"commit":{"parents":[{"commit":"8632a6cfcda741c2a057a26911fea2736a53628b","subject":"Update using storyboard in README","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/karbor/commit/8632a6cfcda741c2a057a26911fea2736a53628b"}]}],"author":{"name":"helei","email":"helei@cmss.chinamobile.com","date":"2019-07-02 07:48:56.000000000","tz":-240},"committer":{"name":"helei","email":"helei@cmss.chinamobile.com","date":"2019-07-02 07:48:56.000000000","tz":-240},"subject":"Remove redundant try/except statements that are never executed","message":"Remove redundant try/except statements that are never executed\n\nIf a non-admin user performs an update/delete operation that requires\nadmin privileges, the permissions are verified and processed in\ncontext.can(...), and subsequent authentication in try/except will never\nbe executed.\n\nChange-Id: I51470731ed78ddb1e197222187c432372e2f21ee\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/karbor/commit/a088342065964911b8c15bd87600af8c83520a37"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/karbor/commit/a088342065964911b8c15bd87600af8c83520a37"}]},"branch":"refs/heads/master"},"0a18b29e210d61dd03e648f797caa86f324b928e":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2019-07-02 09:19:21.000000000","uploader":{"_account_id":29579,"name":"helei","email":"604103249@qq.com","username":"helei"},"ref":"refs/changes/27/668627/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/karbor","ref":"refs/changes/27/668627/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/karbor refs/changes/27/668627/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/karbor refs/changes/27/668627/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/karbor refs/changes/27/668627/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/karbor refs/changes/27/668627/2"}}},"commit":{"parents":[{"commit":"8632a6cfcda741c2a057a26911fea2736a53628b","subject":"Update using storyboard in README","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/karbor/commit/8632a6cfcda741c2a057a26911fea2736a53628b"}]}],"author":{"name":"helei","email":"helei@cmss.chinamobile.com","date":"2019-07-02 07:48:56.000000000","tz":-240},"committer":{"name":"helei","email":"helei@cmss.chinamobile.com","date":"2019-07-02 09:16:33.000000000","tz":-240},"subject":"Remove redundant try/except statements in quotas.py","message":"Remove redundant try/except statements in quotas.py\n\nIf a non-admin user performs an update/delete operation that requires\nadmin privileges, the permissions are verified and processed in\ncontext.can(...), and subsequent authentication in try/except will never\nbe executed.\n\nChange-Id: I51470731ed78ddb1e197222187c432372e2f21ee\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/karbor/commit/0a18b29e210d61dd03e648f797caa86f324b928e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/karbor/commit/0a18b29e210d61dd03e648f797caa86f324b928e"}]},"branch":"refs/heads/master"},"662766d64df4a31cf81024fd64044b6f0aae7ed4":{"kind":"REWORK","_number":3,"created":"2019-07-03 10:20:53.000000000","uploader":{"_account_id":29579,"name":"helei","email":"604103249@qq.com","username":"helei"},"ref":"refs/changes/27/668627/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/karbor","ref":"refs/changes/27/668627/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/karbor refs/changes/27/668627/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/karbor refs/changes/27/668627/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/karbor refs/changes/27/668627/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/karbor refs/changes/27/668627/3"}}},"commit":{"parents":[{"commit":"8632a6cfcda741c2a057a26911fea2736a53628b","subject":"Update using storyboard in README","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/karbor/commit/8632a6cfcda741c2a057a26911fea2736a53628b"}]}],"author":{"name":"helei","email":"helei@cmss.chinamobile.com","date":"2019-07-02 07:48:56.000000000","tz":-240},"committer":{"name":"helei","email":"helei@cmss.chinamobile.com","date":"2019-07-03 10:20:32.000000000","tz":-240},"subject":"Remove redundant try/except statements in quotas.py","message":"Remove redundant try/except statements in quotas.py\n\nIf a non-admin user performs an update/delete operation that requires\nadmin privileges, the permissions are verified and processed in\ncontext.can(...), and subsequent authentication in try/except will never\nbe executed.\n\nChange-Id: I51470731ed78ddb1e197222187c432372e2f21ee\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/karbor/commit/662766d64df4a31cf81024fd64044b6f0aae7ed4"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/karbor/commit/662766d64df4a31cf81024fd64044b6f0aae7ed4"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}