)]}'
{"id":"openstack%2Fkarbor~685591","triplet_id":"openstack%2Fkarbor~master~I70c5ae7d3ea79ef5868a222509e583d510d8607c","project":"openstack/karbor","branch":"master","hashtags":[],"change_id":"I70c5ae7d3ea79ef5868a222509e583d510d8607c","subject":"Do not use \u0027self\u0027 in classmethod","status":"MERGED","created":"2019-09-29 08:23:43.000000000","updated":"2019-10-18 02:04:10.000000000","submitted":"2019-10-18 02:02:48.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"685591-1571364168614-283fd268","meta_rev_id":"96c68fb73376d7cfa7d5ca0479895855bc80e944","_number":685591,"virtual_id_number":685591,"owner":{"_account_id":29729,"name":"wangyu","email":"wangyu_yewu@cmss.chinamobile.com","username":"wangyu"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":29272,"name":"liushuai","email":"liushuai@cmss.chinamobile.com","username":"liushuai"},{"value":0,"_account_id":21224,"name":"jiaopengju","email":"jiaopengju_yewu@cmss.chinamobile.com","username":"jiaopengju"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2019-10-18 02:02:48.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":21224,"name":"jiaopengju","email":"jiaopengju_yewu@cmss.chinamobile.com","username":"jiaopengju"},"all":[{"value":0,"_account_id":29272,"name":"liushuai","email":"liushuai@cmss.chinamobile.com","username":"liushuai"},{"value":2,"date":"2019-10-08 12:35:31.000000000","_account_id":21224,"name":"jiaopengju","email":"jiaopengju_yewu@cmss.chinamobile.com","username":"jiaopengju"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":21224,"name":"jiaopengju","email":"jiaopengju_yewu@cmss.chinamobile.com","username":"jiaopengju"},"all":[{"value":0,"date":"2019-09-30 07:29:52.000000000","_account_id":29272,"name":"liushuai","email":"liushuai@cmss.chinamobile.com","username":"liushuai"},{"value":1,"date":"2019-10-18 01:53:30.000000000","_account_id":21224,"name":"jiaopengju","email":"jiaopengju_yewu@cmss.chinamobile.com","username":"jiaopengju"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":21224,"name":"jiaopengju","email":"jiaopengju_yewu@cmss.chinamobile.com","username":"jiaopengju"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":29272,"name":"liushuai","email":"liushuai@cmss.chinamobile.com","username":"liushuai"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-09-30 07:29:52.000000000","updated_by":{"_account_id":29272,"name":"liushuai","email":"liushuai@cmss.chinamobile.com","username":"liushuai"},"reviewer":{"_account_id":29272,"name":"liushuai","email":"liushuai@cmss.chinamobile.com","username":"liushuai"},"state":"REVIEWER"},{"updated":"2019-10-18 01:53:30.000000000","updated_by":{"_account_id":21224,"name":"jiaopengju","email":"jiaopengju_yewu@cmss.chinamobile.com","username":"jiaopengju"},"reviewer":{"_account_id":21224,"name":"jiaopengju","email":"jiaopengju_yewu@cmss.chinamobile.com","username":"jiaopengju"},"state":"REVIEWER"},{"updated":"2019-10-18 02:02:48.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"07ed421a413371f5b7374287deeba77abdaa4f57","author":{"_account_id":29729,"name":"wangyu","email":"wangyu_yewu@cmss.chinamobile.com","username":"wangyu"},"date":"2019-09-29 08:23:43.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"00c5c01c4c729d3e3f9c4150b5bba5216a6a3c96","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-29 09:19:44.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/5a7d47bf91384dd3a7b93991a60cda47 : SUCCESS in 5m 42s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/31e5307101e245a99aa8f3019367fdcb : SUCCESS in 4m 42s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/1640131ad955472c882a39b0925acb4e : SUCCESS in 4m 06s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/546468a45a5c44e0ace57ba64fd799fb : SUCCESS in 4m 58s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/851a8cab82284bc2903c6e1087c7be36 : SUCCESS in 5m 03s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/c067f91c4743434fb874c25422b595e5 : SUCCESS in 5m 20s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/2b136bd2759c4c828d3a65706258c186 : SUCCESS in 6m 33s\n- karbor-dsvm-fullstack https://zuul.opendev.org/t/openstack/build/a7b36c3425f54fcaa55540ea27f09462 : SUCCESS in 55m 11s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"8a9b2d89452a3d2449695a16aa133ee1c334d947","author":{"_account_id":21224,"name":"jiaopengju","email":"jiaopengju_yewu@cmss.chinamobile.com","username":"jiaopengju"},"date":"2019-10-08 12:35:31.000000000","message":"Patch Set 1: Code-Review+2\n\nlooks good","accounts_in_message":[],"_revision_number":1},{"id":"54d9fc9efdcdc9eeb2dc7a7e084a9c17fb96d658","author":{"_account_id":21224,"name":"jiaopengju","email":"jiaopengju_yewu@cmss.chinamobile.com","username":"jiaopengju"},"date":"2019-10-18 01:53:30.000000000","message":"Patch Set 1: Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"6bc1bc766608559e11da064c60212cfb1763c29f","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-10-18 01:53:42.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"01230a1f876168975950e1f2cea9aa12d828fd5d","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-10-18 02:02:48.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/d4a6e50315ec4a02b320b7583e66fffe : SUCCESS in 5m 35s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/068a0c37f6a6485e87bcb70e30c77c23 : SUCCESS in 3m 53s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/beb1f0b9aee8497ebbba86a6f93498e3 : SUCCESS in 3m 45s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/671e1067012c4d1cab03387ae7a34e8e : SUCCESS in 4m 18s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/a0fe79f59a644c8f93ddd9eadb86dfa2 : SUCCESS in 5m 16s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/862c03bba0a647678422801c1eb91859 : SUCCESS in 5m 10s","accounts_in_message":[],"_revision_number":1},{"id":"6ca0f12ec7a287623b1d1c9efd9abac38ef081dc","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-10-18 02:02:48.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"96c68fb73376d7cfa7d5ca0479895855bc80e944","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-10-18 02:04:10.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/de5f98499eb94d28a4fe58a2f862c3cd : SUCCESS in 1m 06s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"798ba058ae13b78c870bd52326a5dba1d3c9ac39","revisions":{"798ba058ae13b78c870bd52326a5dba1d3c9ac39":{"kind":"REWORK","_number":1,"created":"2019-09-29 08:23:43.000000000","uploader":{"_account_id":29729,"name":"wangyu","email":"wangyu_yewu@cmss.chinamobile.com","username":"wangyu"},"ref":"refs/changes/91/685591/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/karbor","ref":"refs/changes/91/685591/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/karbor refs/changes/91/685591/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/karbor refs/changes/91/685591/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/karbor refs/changes/91/685591/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/karbor refs/changes/91/685591/1"}}},"commit":{"parents":[{"commit":"8d3c3b52598bd5a1f5c416155e2daf8bab73dc5c","subject":"Merge \"Replace use of log.warn with log.warning\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/karbor/commit/8d3c3b52598bd5a1f5c416155e2daf8bab73dc5c"}]}],"author":{"name":"wangyu","email":"wangyu@cmss.chinamobile.com","date":"2019-09-29 08:21:10.000000000","tz":480},"committer":{"name":"wangyu","email":"wangyu@cmss.chinamobile.com","date":"2019-09-29 08:21:10.000000000","tz":480},"subject":"Do not use \u0027self\u0027 in classmethod","message":"Do not use \u0027self\u0027 in classmethod\n\n\u0027cls\u0027 should be used in classmethd, instead of \u0027self\u0027.\nThis patch corrects this in the following places:\n    - karbor/services/protection/checkpoint.py\n    - karbor/services/protection/protection_plugins/network/neutron_protection_plugin.py\n\nChange-Id: I70c5ae7d3ea79ef5868a222509e583d510d8607c\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/karbor/commit/798ba058ae13b78c870bd52326a5dba1d3c9ac39"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/karbor/commit/798ba058ae13b78c870bd52326a5dba1d3c9ac39"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}