)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"32f9238737f2d091f725645091344c86e31fa98f","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"2ea0ad38_df9bb0e2","updated":"2026-09-18 12:41:38.000000000","message":"Wouldn\u0027t it be easier and more performant to write that in Python?","commit_id":"ba526549e9b06d6247c1fc84d7aa87e9248c7ee0"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"69d582b9b5d2d6d5baec6f4efec44b4547f2d659","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"352e7568_9f148ad0","in_reply_to":"2ea0ad38_df9bb0e2","updated":"2026-10-02 13:48:35.000000000","message":"Fair point, although since this has already been written, I\u0027m happy to merge as is. We can improve in a follow up.","commit_id":"ba526549e9b06d6247c1fc84d7aa87e9248c7ee0"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"570002ff828405852676753ed90b0ade9bbc7636","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"bf0c61de_e79c3cb1","in_reply_to":"352e7568_9f148ad0","updated":"2026-10-26 15:35:21.000000000","message":"Done","commit_id":"ba526549e9b06d6247c1fc84d7aa87e9248c7ee0"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"bc436ee5b7cc4c685d2d8549fed9613165429a9c","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"b7043552_459b46d6","updated":"2026-10-29 15:21:55.000000000","message":"Mostly looks good. Lets check the actual installed version and add some docs on the features.","commit_id":"4966806b0011ae5e6a440695b52f2641bc3c63b4"},{"author":{"_account_id":34940,"name":"Rafal Lewandowski","display_name":"Rafal Lewandowski","email":"rafal@stackhpc.com","username":"rav"},"change_message_id":"140580de69300a363b72d98e26b28e0996ab73a6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"287a3f78_a32b3709","in_reply_to":"b7043552_459b46d6","updated":"2026-10-30 15:25:55.000000000","message":"Done","commit_id":"4966806b0011ae5e6a440695b52f2641bc3c63b4"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"321a3d3971e947a50752c4a8c91083ef91e28ce3","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"a23300e0_1e16ae96","updated":"2026-11-03 12:31:46.000000000","message":"One last comment, but otherwise this looks good. The output mixes short and long commit ids:\n\n    Kolla Ansible is not running the expected version.\n    \n    Expected:         version-check-tag\n    Checkout tag:     version-check-tag-1-g913eae3\n    Checkout commit:  913eae321eeb69a0f51cb83e6c00271a36b56d87\n    Installed commit: 297e16e\n \n    Run: kayobe control host upgrade\n\nCould we make the installed commit use the long form?","commit_id":"707f264580d3f3933844fa187efe173a1b2b6351"},{"author":{"_account_id":34940,"name":"Rafal Lewandowski","display_name":"Rafal Lewandowski","email":"rafal@stackhpc.com","username":"rav"},"change_message_id":"4ff011bbe6ee0d901f332d49405ce3bca55ef018","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"b025e17f_627a87fa","in_reply_to":"353ed2fc_9137c343","updated":"2026-11-04 11:51:40.000000000","message":"Done","commit_id":"707f264580d3f3933844fa187efe173a1b2b6351"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"a76d12986713c243dad8fd0ae185df02a7436e05","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"353ed2fc_9137c343","in_reply_to":"a23300e0_1e16ae96","updated":"2026-11-03 12:37:51.000000000","message":"Another example when pinning to commit shas:\n\n    Kolla Ansible is not running the expected version.\n    \n    Expected:         5bf5eb8b257bcd2544f4634a2079e335af7b0912\n    Checkout tag:     15cdea7\n    Checkout commit:  15cdea7f12e8299ca6c184c791c21c31f60fe25d\n    Installed commit: 5bf5eb8b257bcd2544f4634a2079e335af7b0912\n\n    Run: kayobe control host upgrade","commit_id":"707f264580d3f3933844fa187efe173a1b2b6351"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"32b0791fa42ebff3abc9a48ccd264aefae32e1d8","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":6,"id":"47152e77_864ee75a","updated":"2026-11-14 20:14:49.000000000","message":"I\u0027m not sure if this feature should be enabled by default.","commit_id":"157db2ae7198d4175c14364b627c93c2acc138fe"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"f3fefcadf1e60965afbcee9accb81a45d44e3828","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"6224b68f_c683ad92","updated":"2026-11-13 11:30:08.000000000","message":"LGTM","commit_id":"157db2ae7198d4175c14364b627c93c2acc138fe"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"2394ecacf76da070cccfcd903099c9be1c3a3243","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":6,"id":"2b839580_eab2dabd","updated":"2026-11-17 19:11:21.000000000","message":"What if the Kayobe code is new, but Kolla-Ansible is old and there is no need for an update?","commit_id":"157db2ae7198d4175c14364b627c93c2acc138fe"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"3e2a2e95ae4e89fae8eea3762cc3d171094d44a7","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":6,"id":"66964e9e_8f1ace93","in_reply_to":"47152e77_864ee75a","updated":"2026-11-17 09:54:00.000000000","message":"Why not? Does this break how you use Kayobe?","commit_id":"157db2ae7198d4175c14364b627c93c2acc138fe"}],"ansible/roles/kolla-ansible/defaults/main.yml":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"4bd8b449a3c775f4f467630aa5facf9e3b7819d1","unresolved":true,"context_lines":[{"line_number":21,"context_line":"# Extra requirements to install inside the kolla-ansible virtualenv."},{"line_number":22,"context_line":"kolla_ansible_venv_extra_requirements: []"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"# Check if the installed kolla-ansible version is the expected version."},{"line_number":25,"context_line":"kolla_ansible_version_check_enabled: true"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"# Pip requirement specifier for the ansible package. NOTE: This limits the"},{"line_number":28,"context_line":"# version of ansible used by kolla-ansible to avoid new releases from breaking"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"35720274_5b624b89","line":25,"range":{"start_line":24,"start_character":0,"end_line":25,"end_character":41},"updated":"2026-10-08 07:38:08.000000000","message":"This could be added to ansible/inventory/group_vars/all/kolla as well.","commit_id":"ba526549e9b06d6247c1fc84d7aa87e9248c7ee0"},{"author":{"_account_id":34940,"name":"Rafal Lewandowski","display_name":"Rafal Lewandowski","email":"rafal@stackhpc.com","username":"rav"},"change_message_id":"c376b24ca2d96a155002b12bed9ce0785e803d77","unresolved":false,"context_lines":[{"line_number":21,"context_line":"# Extra requirements to install inside the kolla-ansible virtualenv."},{"line_number":22,"context_line":"kolla_ansible_venv_extra_requirements: []"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"# Check if the installed kolla-ansible version is the expected version."},{"line_number":25,"context_line":"kolla_ansible_version_check_enabled: true"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"# Pip requirement specifier for the ansible package. NOTE: This limits the"},{"line_number":28,"context_line":"# version of ansible used by kolla-ansible to avoid new releases from breaking"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"69049a04_807eb2f0","line":25,"range":{"start_line":24,"start_character":0,"end_line":25,"end_character":41},"in_reply_to":"35720274_5b624b89","updated":"2026-10-20 18:43:55.000000000","message":"Done","commit_id":"ba526549e9b06d6247c1fc84d7aa87e9248c7ee0"}],"ansible/roles/kolla-ansible/tasks/check-version.yml":[{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"bc436ee5b7cc4c685d2d8549fed9613165429a9c","unresolved":true,"context_lines":[{"line_number":21,"context_line":"      changed_when: false"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    - name: Resolve expected Kolla-Ansible version to a commit"},{"line_number":24,"context_line":"      vars:"},{"line_number":25,"context_line":"        expected_ref: \"{{ kolla_ansible_source_version }}^{commit}\""},{"line_number":26,"context_line":"      ansible.builtin.command:"},{"line_number":27,"context_line":"        cmd: git rev-parse --verify --quiet \"{{ expected_ref }}\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"8bc8d3a2_0f4594b8","line":24,"updated":"2026-10-29 15:21:55.000000000","message":"Can we check the version actually installed in the venv e.g:\n\n    - name: Get installed Kolla-Ansible commit\n      ansible.builtin.command:\n        argv:\n          - \"{{ kolla_ansible_venv }}/bin/python\"\n          - -c\n          - |\n            import importlib.metadata, json\n            try:\n                dist \u003d importlib.metadata.distribution(\u0027kolla-ansible\u0027)\n                print(json.loads(dist.read_text(\u0027pbr.json\u0027))[\u0027git_version\u0027])\n            except Exception:\n                pass\n      register: kolla_ansible_installed_commit\n      changed_when: false\n      failed_when: false","commit_id":"4966806b0011ae5e6a440695b52f2641bc3c63b4"},{"author":{"_account_id":34940,"name":"Rafal Lewandowski","display_name":"Rafal Lewandowski","email":"rafal@stackhpc.com","username":"rav"},"change_message_id":"140580de69300a363b72d98e26b28e0996ab73a6","unresolved":false,"context_lines":[{"line_number":21,"context_line":"      changed_when: false"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    - name: Resolve expected Kolla-Ansible version to a commit"},{"line_number":24,"context_line":"      vars:"},{"line_number":25,"context_line":"        expected_ref: \"{{ kolla_ansible_source_version }}^{commit}\""},{"line_number":26,"context_line":"      ansible.builtin.command:"},{"line_number":27,"context_line":"        cmd: git rev-parse --verify --quiet \"{{ expected_ref }}\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"bef549de_39ae27aa","line":24,"in_reply_to":"8bc8d3a2_0f4594b8","updated":"2026-10-30 15:25:55.000000000","message":"Thanks for the suggestion, implemented.","commit_id":"4966806b0011ae5e6a440695b52f2641bc3c63b4"}],"ansible/roles/kolla-ansible/tasks/check_version.yml":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"4bd8b449a3c775f4f467630aa5facf9e3b7819d1","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Check Kolla Ansible version"},{"line_number":3,"context_line":"  when: kolla_ansible_version_check_enabled | bool"},{"line_number":4,"context_line":"  check_mode: false"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"2491755d_7eb93467","line":1,"updated":"2026-10-08 07:38:08.000000000","message":"Please add missing newline at end of file.","commit_id":"ba526549e9b06d6247c1fc84d7aa87e9248c7ee0"},{"author":{"_account_id":34940,"name":"Rafal Lewandowski","display_name":"Rafal Lewandowski","email":"rafal@stackhpc.com","username":"rav"},"change_message_id":"c376b24ca2d96a155002b12bed9ce0785e803d77","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Check Kolla Ansible version"},{"line_number":3,"context_line":"  when: kolla_ansible_version_check_enabled | bool"},{"line_number":4,"context_line":"  check_mode: false"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"de181aeb_add80fc1","line":1,"in_reply_to":"2491755d_7eb93467","updated":"2026-10-20 18:43:55.000000000","message":"Done","commit_id":"ba526549e9b06d6247c1fc84d7aa87e9248c7ee0"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"238d1b443250f18916dafbb745795c9804144b45","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Check Kolla Ansible version"},{"line_number":3,"context_line":"  when: kolla_ansible_version_check_enabled | bool"},{"line_number":4,"context_line":"  check_mode: false"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"f11e29ec_bcecf9fd","line":1,"updated":"2026-10-21 16:23:30.000000000","message":"file name uses underscore and most roles use a dash, lets go with dash. Pip is the one exception.","commit_id":"049cb610dbca19f916f6d50ac7d7650f538e766b"},{"author":{"_account_id":34940,"name":"Rafal Lewandowski","display_name":"Rafal Lewandowski","email":"rafal@stackhpc.com","username":"rav"},"change_message_id":"91385cfbe4ba8d12353cee38b9f07ccb589230b6","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Check Kolla Ansible version"},{"line_number":3,"context_line":"  when: kolla_ansible_version_check_enabled | bool"},{"line_number":4,"context_line":"  check_mode: false"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"a5963993_5a96f2e9","line":1,"in_reply_to":"f11e29ec_bcecf9fd","updated":"2026-10-26 08:01:41.000000000","message":"Done","commit_id":"049cb610dbca19f916f6d50ac7d7650f538e766b"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"238d1b443250f18916dafbb745795c9804144b45","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Check Kolla Ansible version"},{"line_number":3,"context_line":"  when: kolla_ansible_version_check_enabled | bool"},{"line_number":4,"context_line":"  check_mode: false"},{"line_number":5,"context_line":"  block:"},{"line_number":6,"context_line":"    - name: Get current Kolla-Ansible tag"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"d0809c91_c487a113","line":3,"updated":"2026-10-21 16:23:30.000000000","message":"Also guard on `kolla_ansible_ctl_install_type` being source?","commit_id":"049cb610dbca19f916f6d50ac7d7650f538e766b"},{"author":{"_account_id":34940,"name":"Rafal Lewandowski","display_name":"Rafal Lewandowski","email":"rafal@stackhpc.com","username":"rav"},"change_message_id":"91385cfbe4ba8d12353cee38b9f07ccb589230b6","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Check Kolla Ansible version"},{"line_number":3,"context_line":"  when: kolla_ansible_version_check_enabled | bool"},{"line_number":4,"context_line":"  check_mode: false"},{"line_number":5,"context_line":"  block:"},{"line_number":6,"context_line":"    - name: Get current Kolla-Ansible tag"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"ef9c05f0_917ded2a","line":3,"in_reply_to":"d0809c91_c487a113","updated":"2026-10-26 08:01:41.000000000","message":"Done","commit_id":"049cb610dbca19f916f6d50ac7d7650f538e766b"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"238d1b443250f18916dafbb745795c9804144b45","unresolved":true,"context_lines":[{"line_number":28,"context_line":"    - name: Check installed Kolla-Ansible version is the expected version"},{"line_number":29,"context_line":"      ansible.builtin.assert:"},{"line_number":30,"context_line":"        that: \u003e"},{"line_number":31,"context_line":"          kolla_ansible_source_version in kolla_ansible_current_tag.stdout or"},{"line_number":32,"context_line":"          kolla_ansible_source_version in kolla_ansible_current_branch.stdout or"},{"line_number":33,"context_line":"          kolla_ansible_source_version in kolla_ansible_current_commit.stdout"},{"line_number":34,"context_line":"        fail_msg: |"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"5feee885_f1b3d9d2","line":31,"updated":"2026-10-21 16:23:30.000000000","message":"Can we harden this version checking:\n- expected version 20.1.1 should not match checkout version 20.1.10\n- 20.1.0 should not match `20.1.0-3-gda704fa` (3 commits on top of local checkout)","commit_id":"049cb610dbca19f916f6d50ac7d7650f538e766b"},{"author":{"_account_id":34940,"name":"Rafal Lewandowski","display_name":"Rafal Lewandowski","email":"rafal@stackhpc.com","username":"rav"},"change_message_id":"91385cfbe4ba8d12353cee38b9f07ccb589230b6","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    - name: Check installed Kolla-Ansible version is the expected version"},{"line_number":29,"context_line":"      ansible.builtin.assert:"},{"line_number":30,"context_line":"        that: \u003e"},{"line_number":31,"context_line":"          kolla_ansible_source_version in kolla_ansible_current_tag.stdout or"},{"line_number":32,"context_line":"          kolla_ansible_source_version in kolla_ansible_current_branch.stdout or"},{"line_number":33,"context_line":"          kolla_ansible_source_version in kolla_ansible_current_commit.stdout"},{"line_number":34,"context_line":"        fail_msg: |"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"a6e03d85_5c8a3cad","line":31,"in_reply_to":"5feee885_f1b3d9d2","updated":"2026-10-26 08:01:41.000000000","message":"Done","commit_id":"049cb610dbca19f916f6d50ac7d7650f538e766b"}],"releasenotes/notes/add-kolla-ansible-version-check-4bb3582ea31435ec.yaml":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"4bd8b449a3c775f4f467630aa5facf9e3b7819d1","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds a new boolean variable, ``kolla_ansible_version_check_enabled``"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"990fd734_090ce77f","line":1,"updated":"2026-10-08 07:38:08.000000000","message":"Please add missing newline at end of file.","commit_id":"ba526549e9b06d6247c1fc84d7aa87e9248c7ee0"},{"author":{"_account_id":34940,"name":"Rafal Lewandowski","display_name":"Rafal Lewandowski","email":"rafal@stackhpc.com","username":"rav"},"change_message_id":"c376b24ca2d96a155002b12bed9ce0785e803d77","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds a new boolean variable, ``kolla_ansible_version_check_enabled``"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"5c081cb7_328321e8","line":1,"in_reply_to":"990fd734_090ce77f","updated":"2026-10-20 18:43:55.000000000","message":"Done","commit_id":"ba526549e9b06d6247c1fc84d7aa87e9248c7ee0"}]}
