)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"9ae39e39c1d7ee4901e0476ea89c4dde198699af","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5ef03b26_22d8803b","updated":"2026-10-21 19:39:47.000000000","message":"It should be `kayobe overcloud firmware dell update` since only Dell supported, otherwise need to be more generic and have places to extend the support for other brands.","commit_id":"b0fa283a6119ade1821dfc95a59f480fe350983c"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"db61e204532a0a0580e271f678f33da1db5e0e7c","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"687adac8_476eef99","in_reply_to":"5ef03b26_22d8803b","updated":"2026-10-22 14:55:22.000000000","message":"There is already room for extending to other brands, they\u0027d just need a block of tasks added to ``ansible/overcloud-firmware-update.yml``. The tasks would then be ran conditionally based on ``bmc_type``, same as with the idrac tasks running against ``overcloud_with_bmcs_of_type_idrac``. \n\nI don\u0027t think we should rename the command, but I agree this should be clearer. I\u0027ve suggests updating the names of the task block to reflect which BMCs they target","commit_id":"b0fa283a6119ade1821dfc95a59f480fe350983c"}],"ansible/overcloud-firmware-update.yml":[{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"db61e204532a0a0580e271f678f33da1db5e0e7c","unresolved":true,"context_lines":[{"line_number":20,"context_line":"        key: \"overcloud_with_bmcs_of_type_{{ bmc_type | default(\u0027unknown\u0027) }}\""},{"line_number":21,"context_line":"      changed_when: false"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"- name: Update overcloud node firmware"},{"line_number":24,"context_line":"  hosts: overcloud_with_bmcs_of_type_idrac"},{"line_number":25,"context_line":"  gather_facts: no"},{"line_number":26,"context_line":"  max_fail_percentage: \u003e-"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"a0a863f2_b91690f4","line":23,"updated":"2026-10-22 14:55:22.000000000","message":"```suggestion\n- name: Update overcloud node firmware - iDRAC\n```","commit_id":"b0fa283a6119ade1821dfc95a59f480fe350983c"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"db61e204532a0a0580e271f678f33da1db5e0e7c","unresolved":true,"context_lines":[{"line_number":31,"context_line":"  # updating all nodes at once."},{"line_number":32,"context_line":"  serial: \"{{ firmware_update_serial | default(\u0027100%\u0027) }}\""},{"line_number":33,"context_line":"  tags:"},{"line_number":34,"context_line":"    - firmware-update"},{"line_number":35,"context_line":"  vars:"},{"line_number":36,"context_line":"    seed_host: \"{{ groups[\u0027seed\u0027][0] }}\""},{"line_number":37,"context_line":"  pre_tasks:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"d84af00c_392ff5f8","line":34,"updated":"2026-10-22 14:55:22.000000000","message":"```suggestion\n    - firmware-update\n    - firmware-update-idrac\n```\ncould be useful to have tags per bmc type","commit_id":"b0fa283a6119ade1821dfc95a59f480fe350983c"}]}