)]}'
{"ansible/baremetal-compute-rename.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"8e5c1257c5b7225bca7ada19cd84ffb8b00997fd","unresolved":false,"context_lines":[{"line_number":23,"context_line":"  hosts: baremetal-compute"},{"line_number":24,"context_line":"  gather_facts: False"},{"line_number":25,"context_line":"  connection: \"{{ groups[\u0027controllers\u0027][0] }}\""},{"line_number":26,"context_line":"  pre_tasks:"},{"line_number":27,"context_line":"    - name: Get list of nodes"},{"line_number":28,"context_line":"      command: openstack baremetal node list -f json --fields uuid name driver_info"},{"line_number":29,"context_line":"      register: nodes"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5f7c97a3_36a19247","line":26,"updated":"2018-06-08 12:00:49.000000000","message":"nit: no need to separate pre tasks here - that is only required to make tasks execute before a role.","commit_id":"a2dc950ec9a295c54a9d3b331196d95285d59938"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"8e5c1257c5b7225bca7ada19cd84ffb8b00997fd","unresolved":false,"context_lines":[{"line_number":31,"context_line":"      connection: local"},{"line_number":32,"context_line":"      run_once: true"},{"line_number":33,"context_line":"  vars:"},{"line_number":34,"context_line":"    ipmi_address: \"{{ hostvars[inventory_hostname].ipmi_address }}\""},{"line_number":35,"context_line":"    node: \"{{ (nodes.stdout | from_json) | selectattr(\u0027Driver Info.ipmi_address\u0027, \u0027equalto\u0027, ipmi_address) | first }}\""},{"line_number":36,"context_line":"  tasks:"},{"line_number":37,"context_line":"    - name: Rename baremetal compute nodes"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5f7c97a3_029d19ba","line":34,"updated":"2018-06-08 12:00:49.000000000","message":"This would fail for any nodes without an ipmi_address variable configured. Perhaps we should add a task that uses the fail module to provide a more user friendly failure message in that case?","commit_id":"a2dc950ec9a295c54a9d3b331196d95285d59938"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"8e5c1257c5b7225bca7ada19cd84ffb8b00997fd","unresolved":false,"context_lines":[{"line_number":32,"context_line":"      run_once: true"},{"line_number":33,"context_line":"  vars:"},{"line_number":34,"context_line":"    ipmi_address: \"{{ hostvars[inventory_hostname].ipmi_address }}\""},{"line_number":35,"context_line":"    node: \"{{ (nodes.stdout | from_json) | selectattr(\u0027Driver Info.ipmi_address\u0027, \u0027equalto\u0027, ipmi_address) | first }}\""},{"line_number":36,"context_line":"  tasks:"},{"line_number":37,"context_line":"    - name: Rename baremetal compute nodes"},{"line_number":38,"context_line":"      command: openstack baremetal node set --name \"{{ inventory_hostname }}\" \"{{ node[\u0027UUID\u0027] }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5f7c97a3_f6d47abd","line":35,"updated":"2018-06-08 12:00:49.000000000","message":"nit: placing the vars here suggests they are evaluated after pre-tasks. It works because ansible evaluates variables lazily.","commit_id":"a2dc950ec9a295c54a9d3b331196d95285d59938"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"54f30d456e45b3eed55bda02bbde93bf616bd7c8","unresolved":false,"context_lines":[{"line_number":30,"context_line":"        msg: \u003e"},{"line_number":31,"context_line":"          The host variable, ipmi_address is not defined for {{ inventory_hostname }}. This variable is required"},{"line_number":32,"context_line":"          to run this playbook."},{"line_number":33,"context_line":"      when: ipmi_address \u003d\u003d \"\""},{"line_number":34,"context_line":"    - name: Get list of nodes"},{"line_number":35,"context_line":"      command: \u003e"},{"line_number":36,"context_line":"        {{ venv }}/bin/openstack baremetal node list -f json --fields uuid name driver_info"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"5f7c97a3_010c80ea","line":33,"updated":"2018-06-18 10:58:05.000000000","message":"ipmi_address is not defined or not ipmi_address","commit_id":"4ef59f04d61b1e2513d772fc3489420bad5f162f"}],"doc/source/administration.rst":[{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"6fe7c5c5b7a34cdb402d5e4798e117bcd49df6c2","unresolved":false,"context_lines":[{"line_number":173,"context_line":"------"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"Once nodes have been discovered, it is helpful to associate them with a name"},{"line_number":176,"context_line":"to make them easier to work with. If you would like the nodes to named"},{"line_number":177,"context_line":"according to their inventory host names, you can run the following command:"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"    (kayobe) $ kayobe baremetal compute rename"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5f7c97a3_56b76ed9","line":176,"range":{"start_line":176,"start_character":62,"end_line":176,"end_character":64},"updated":"2018-06-07 14:48:18.000000000","message":"nit: to be","commit_id":"a2dc950ec9a295c54a9d3b331196d95285d59938"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"8e5c1257c5b7225bca7ada19cd84ffb8b00997fd","unresolved":false,"context_lines":[{"line_number":178,"context_line":""},{"line_number":179,"context_line":"    (kayobe) $ kayobe baremetal compute rename"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"This command will use the IPMI address defined in the inventory to map the"},{"line_number":182,"context_line":"inventory host name to the correct node."},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"Running Kayobe Playbooks on Demand"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5f7c97a3_82a849d9","line":181,"updated":"2018-06-08 12:00:49.000000000","message":"Let\u0027s mention the variable name here, ipmi_address.","commit_id":"a2dc950ec9a295c54a9d3b331196d95285d59938"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"54f30d456e45b3eed55bda02bbde93bf616bd7c8","unresolved":false,"context_lines":[{"line_number":179,"context_line":"    (kayobe) $ kayobe baremetal compute rename"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"This command will use the ``ipmi_address`` host variable from the inventory"},{"line_number":182,"context_line":"to map the inventory host name to the correct node.`"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"Running Kayobe Playbooks on Demand"},{"line_number":185,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":4,"id":"5f7c97a3_21117c05","line":182,"updated":"2018-06-18 10:58:05.000000000","message":"stray backtick?","commit_id":"4ef59f04d61b1e2513d772fc3489420bad5f162f"}],"kayobe/tests/unit/cli/test_commands.py":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"8e5c1257c5b7225bca7ada19cd84ffb8b00997fd","unresolved":false,"context_lines":[{"line_number":766,"context_line":"                ],"},{"line_number":767,"context_line":"            ),"},{"line_number":768,"context_line":"        ]"},{"line_number":769,"context_line":"        self.assertEqual(expected_calls, mock_run.call_args_list)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_168256c9","line":769,"updated":"2018-06-08 12:00:49.000000000","message":"Well done for adding a test :)","commit_id":"a2dc950ec9a295c54a9d3b331196d95285d59938"}]}
